Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Update web app regenerate alias UI (#2287)

Leendert de Borst6c4f621501e8
diff --git a/apps/server/AliasVault.Client/Main/Pages/Items/AddEdit.razor b/apps/server/AliasVault.Client/Main/Pages/Items/AddEdit.razor
index 63bdcfa47..6eb1d1c3c 100644
--- a/apps/server/AliasVault.Client/Main/Pages/Items/AddEdit.razor
+++ b/apps/server/AliasVault.Client/Main/Pages/Items/AddEdit.razor
@@ -262,27 +262,16 @@ else
{
<div class="col-span-1 md:col-span-1 lg:col-span-2">
<div class="p-4 mb-4 bg-white border border-gray-200 rounded-lg shadow-sm 2xl:col-span-2 dark:border-gray-700 sm:p-6 dark:bg-gray-800">
- <h3 class="mb-4 text-xl font-semibold dark:text-white">@Localizer["AliasSectionHeader"]</h3>
- <div class="mb-4">
- <Button OnClick="HandleGenerateOrClearAlias" Color="@(HasAliasValues() ? "secondary" : "primary")" AdditionalClasses="@GetToggleButtonClasses()">
- <svg class='w-5 h-5 inline-block' viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="1.5" strokeLinecap="round" strokeLinejoin="round">
- @if (HasAliasValues())
- {
- <path d="M18 6L6 18M6 6l12 12"/>
- }
- else
- {
- <rect x="3" y="3" width="18" height="18" rx="2" ry="2"/>
- <circle cx="8" cy="8" r="1"/>
- <circle cx="16" cy="8" r="1"/>
- <circle cx="12" cy="12" r="1"/>
- <circle cx="8" cy="16" r="1"/>
- <circle cx="16" cy="16" r="1"/>
- }
+ <h3 class="mb-4 text-xl font-semibold dark:text-white flex items-center justify-between gap-2">
+ <span>@Localizer["AliasSectionHeader"]</span>
+ <button type="button" id="generate-random-alias" @onclick="GenerateRandomAlias" @onclick:preventDefault="true"
+ class="p-1.5 text-gray-400 hover:text-primary-500 transition-colors focus:outline-none" title="@SharedLocalizer["Generate"]">
+ <svg class="w-4 h-4" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
+ <path d="M23 4v6h-6"/>
+ <path d="M20.49 15a9 9 0 1 1-2.12-9.36L23 10"/>
</svg>
- @(HasAliasValues() ? Localizer["ClearAliasFieldsButton"] : Localizer["GenerateRandomAliasButton"])
- </Button>
- </div>
+ </button>
+ </h3>
<div class="grid gap-6">
<div class="col-span-6 sm:col-span-3">
<EditFormRow Id="first-name" Label="@Localizer["FirstNameLabel"]" @bind-Value="Obj.GetField(FieldKey.AliasFirstName)!.Value"></EditFormRow>
@@ -1044,28 +1033,6 @@ else
StateHasChanged();
}
- private async Task HandleGenerateOrClearAlias()
- {
- if (HasAliasValues())
- {
- ClearAliasFields();
- }
- else
- {
- await GenerateRandomAlias();
- }
- }
-
- private void ClearAliasFields()
- {
- Obj.SetFieldValue(FieldKey.AliasFirstName, string.Empty);
- Obj.SetFieldValue(FieldKey.AliasLastName, string.Empty);
- Obj.SetFieldValue(FieldKey.AliasGender, string.Empty);
- Obj.SetFieldValue(FieldKey.AliasBirthdate, string.Empty);
-
- StateHasChanged();
- }
-
private bool HasAliasValues()
{
return !string.IsNullOrWhiteSpace(Obj.GetFieldValue(FieldKey.AliasFirstName)) ||
@@ -1074,16 +1041,6 @@ else
!string.IsNullOrWhiteSpace(Obj.GetFieldValue(FieldKey.AliasBirthdate));
}
- private string GetToggleButtonClasses()
- {
- var baseClasses = "flex items-center justify-center gap-1";
- if (HasAliasValues())
- {
- return $"{baseClasses} bg-gray-500 hover:bg-gray-600 text-white";
- }
- return baseClasses;
- }
-
private async Task GenerateRandomAlias()
{
string currentUsername = Obj.GetFieldValue(FieldKey.LoginUsername);
diff --git a/apps/server/AliasVault.Client/Resources/Pages/Main/Items/AddEdit.en.resx b/apps/server/AliasVault.Client/Resources/Pages/Main/Items/AddEdit.en.resx
index f208a5d74..e3fce9bc5 100644
--- a/apps/server/AliasVault.Client/Resources/Pages/Main/Items/AddEdit.en.resx
+++ b/apps/server/AliasVault.Client/Resources/Pages/Main/Items/AddEdit.en.resx
@@ -127,14 +127,6 @@
</data>
<!-- Button text -->
- <data name="GenerateRandomAliasButton">
- <value>Generate Random Alias</value>
- <comment>Button text for generating a random alias</comment>
- </data>
- <data name="ClearAliasFieldsButton">
- <value>Clear Alias Fields</value>
- <comment>Button text for clearing alias fields</comment>
- </data>
<data name="SaveItemButton">
<value>Save Item</value>
<comment>Button text for saving an item</comment>
diff --git a/apps/server/AliasVault.Client/wwwroot/css/tailwind.css b/apps/server/AliasVault.Client/wwwroot/css/tailwind.css
index dd1a99648..b12f47037 100644
--- a/apps/server/AliasVault.Client/wwwroot/css/tailwind.css
+++ b/apps/server/AliasVault.Client/wwwroot/css/tailwind.css
@@ -787,11 +787,6 @@ video {
margin-right: -0.5rem;
}
-.-my-1 {
- margin-top: -0.25rem;
- margin-bottom: -0.25rem;
-}
-
.mx-2 {
margin-left: 0.5rem;
margin-right: 0.5rem;
@@ -2987,11 +2982,6 @@ video {
background-color: rgb(249 250 251 / var(--tw-bg-opacity));
}
-.hover\:bg-gray-600:hover {
- --tw-bg-opacity: 1;
- background-color: rgb(75 85 99 / var(--tw-bg-opacity));
-}
-
.hover\:bg-gray-800:hover {
--tw-bg-opacity: 1;
background-color: rgb(31 41 55 / var(--tw-bg-opacity));
@@ -3032,11 +3022,6 @@ video {
background-color: rgb(251 203 116 / var(--tw-bg-opacity));
}
-.hover\:bg-primary-300:hover {
- --tw-bg-opacity: 1;
- background-color: rgb(248 185 99 / var(--tw-bg-opacity));
-}
-
.hover\:bg-primary-500:hover {
--tw-bg-opacity: 1;
background-color: rgb(244 149 65 / var(--tw-bg-opacity));
@@ -3980,10 +3965,6 @@ video {
background-color: rgb(123 74 30 / 0.3);
}
-.dark\:hover\:bg-primary-900\/40:hover:is(.dark *) {
- background-color: rgb(123 74 30 / 0.4);
-}
-
.dark\:hover\:bg-primary-900\/50:hover:is(.dark *) {
background-color: rgb(123 74 30 / 0.5);
}
diff --git a/apps/server/Tests/AliasVault.E2ETests/Common/ClientPlaywrightTest.cs b/apps/server/Tests/AliasVault.E2ETests/Common/ClientPlaywrightTest.cs
index 3a2e02703..8be8c7fae 100644
--- a/apps/server/Tests/AliasVault.E2ETests/Common/ClientPlaywrightTest.cs
+++ b/apps/server/Tests/AliasVault.E2ETests/Common/ClientPlaywrightTest.cs
@@ -229,10 +229,6 @@ public abstract class ClientPlaywrightTest : PlaywrightTest
await NavigateUsingBlazorRouter("items/create");
await WaitForUrlAsync("items/create", "Add Item");
- // Check if a button with text "Generate Random Alias" appears
- var generateButton = Page.Locator("text=Generate Random Alias");
- Assert.That(generateButton, Is.Not.Null, "Generate button not found.");
-
// Check if email field is specified with a private email domain (alias).
// In that case we need to:
// 1. Click "+ Email" button to add the email field (for Login type items)
diff --git a/apps/server/Tests/AliasVault.E2ETests/Tests/Client/Shard1/CredentialTests.cs b/apps/server/Tests/AliasVault.E2ETests/Tests/Client/Shard1/CredentialTests.cs
index cf4139cd1..13e8bb016 100644
--- a/apps/server/Tests/AliasVault.E2ETests/Tests/Client/Shard1/CredentialTests.cs
+++ b/apps/server/Tests/AliasVault.E2ETests/Tests/Client/Shard1/CredentialTests.cs
@@ -139,7 +139,7 @@ public class CredentialTests : ClientPlaywrightTest
// First, switch item type to "Alias" by clicking the type selector dropdown
// The default type is "Login", we need to change it to "Alias" to see the identity fields
- var typeSelector = Page.Locator("text=Creating Login").First;
+ var typeSelector = Page.Locator("button[aria-label='Item Type']").First;
await typeSelector.ClickAsync();
await Task.Delay(100);
@@ -163,22 +163,9 @@ public class CredentialTests : ClientPlaywrightTest
var username = await Page.InputValueAsync("#username");
Assert.That(username, Is.Not.Null.And.Not.Empty, "Username not generated before alias is generated.");
- // 2. Then generate a new identity using the "Generate Random Alias" button.
- // Note: When switching to Alias type, an alias is auto-generated, so we may need to clear first
- var generateButton = Page.Locator("text=Generate Random Alias");
- if (await generateButton.CountAsync() == 0)
- {
- // If alias was auto-generated, there's a "Clear Alias Fields" button instead - click it first
- var clearButton = Page.Locator("text=Clear Alias Fields");
- if (await clearButton.CountAsync() > 0)
- {
- await clearButton.First.ClickAsync();
- await Task.Delay(100);
- }
- }
-
- generateButton = Page.Locator("text=Generate Random Alias");
- Assert.That(await generateButton.CountAsync(), Is.GreaterThan(0), "Generate Random Alias button not found.");
+ // 2. Then generate a new identity using the regenerate button in the alias section.
+ var generateButton = Page.Locator("button[id='generate-random-alias']");
+ Assert.That(await generateButton.CountAsync(), Is.GreaterThan(0), "Generate random alias button not found.");
await generateButton.First.ClickAsync();
// Wait for the identity fields to be filled.