Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Tweak browser extension dev build flag (#2469)

Leendert de Borst7d9deb33ca67
diff --git a/apps/browser-extension/scripts/run-e2e.mjs b/apps/browser-extension/scripts/run-e2e.mjs
index 9a24500ad..552f6a2d1 100755
--- a/apps/browser-extension/scripts/run-e2e.mjs
+++ b/apps/browser-extension/scripts/run-e2e.mjs
@@ -78,6 +78,7 @@ console.log(`[e2e] Using API URL: ${apiUrl}`);
const childEnv = {
...env,
ALIASVAULT_API_URL: apiUrl,
+ WXT_E2E_BUILD: "true",
};
// Test numbers become one title filter (--grep), so selections combine as "or". Any other argument goes to Playwright as-is.
diff --git a/apps/browser-extension/src/entrypoints/content.ts b/apps/browser-extension/src/entrypoints/content.ts
index cc4e151a3..9b9672dfb 100644
--- a/apps/browser-extension/src/entrypoints/content.ts
+++ b/apps/browser-extension/src/entrypoints/content.ts
@@ -166,6 +166,9 @@ async function isDomainBlocked(domain: string): Promise<boolean> {
}
}
+/** Shadow root mode for inline UIs: open only in E2E builds (WXT_E2E_BUILD) so the test harness can inspect them. */
+const SHADOW_ROOT_MODE = import.meta.env.WXT_E2E_BUILD === 'true' ? 'open' : 'closed';
+
/**
* Check if the login already exists in the vault.
* @param domain - The domain of the login.
@@ -239,7 +242,7 @@ async function checkAndRestoreSavePromptEarly(ctx: Parameters<typeof createShado
name: 'aliasvault-save-prompt',
position: 'inline',
anchor: 'body',
- mode: await storage.getItem(StorageKeys.E2E_TEST_MODE) === true ? 'open' : 'closed',
+ mode: SHADOW_ROOT_MODE,
/**
* Mount handler for early save prompt restore.
*/
@@ -488,7 +491,7 @@ export default defineContentScript({
name: 'aliasvault-ui',
position: 'inline',
anchor: 'body',
- mode: await storage.getItem(StorageKeys.E2E_TEST_MODE) === true ? 'open' : 'closed',
+ mode: SHADOW_ROOT_MODE,
/**
* Handle mount.
*/
diff --git a/apps/browser-extension/src/utils/constants/storageKeys.ts b/apps/browser-extension/src/utils/constants/storageKeys.ts
index 947c20700..e83584ff8 100644
--- a/apps/browser-extension/src/utils/constants/storageKeys.ts
+++ b/apps/browser-extension/src/utils/constants/storageKeys.ts
@@ -42,8 +42,6 @@ export const StorageKeys = {
THEME: 'local:theme',
/** Selected UI language. */
LANGUAGE: 'local:language',
- /** True when the extension runs under the E2E test harness (opens shadow roots). */
- E2E_TEST_MODE: 'local:e2eTestMode',
/*
* -- Local preferences (cleared as a group by LocalPreferencesService.clearAll) --
diff --git a/apps/browser-extension/tests/e2e/60-credential-matcher.spec.ts b/apps/browser-extension/tests/e2e/60-credential-matcher.spec.ts
index b97dc338d..10bb25e61 100644
--- a/apps/browser-extension/tests/e2e/60-credential-matcher.spec.ts
+++ b/apps/browser-extension/tests/e2e/60-credential-matcher.spec.ts
@@ -82,9 +82,6 @@ test.describe.serial('60. Credential Matcher Integration', () => {
client = await TestClient.create();
await client.login(apiUrl, testUser.username, testUser.password);
- // Enable E2E test mode for open shadow DOM
- await client.enableE2ETestMode();
-
// Create credentials with specific URLs for testing
// Credential 1: For example.com domain
await client
diff --git a/apps/browser-extension/tests/e2e/61-save-login-prompt.spec.ts b/apps/browser-extension/tests/e2e/61-save-login-prompt.spec.ts
index b6f2230d5..441cd27d1 100644
--- a/apps/browser-extension/tests/e2e/61-save-login-prompt.spec.ts
+++ b/apps/browser-extension/tests/e2e/61-save-login-prompt.spec.ts
@@ -240,9 +240,6 @@ test.describe.serial('61. Save Login Prompt', () => {
client = await TestClient.create();
await client.login(apiUrl, testUser.username, testUser.password);
- // Enable E2E test mode for open shadow DOM
- await client.enableE2ETestMode();
-
// Enable the login save feature
await enableLoginSaveFeature(client);
diff --git a/apps/browser-extension/tests/fixtures/TestClient.ts b/apps/browser-extension/tests/fixtures/TestClient.ts
index 16d981369..64fa1db46 100644
--- a/apps/browser-extension/tests/fixtures/TestClient.ts
+++ b/apps/browser-extension/tests/fixtures/TestClient.ts
@@ -396,35 +396,6 @@ export class TestClient {
return this;
}
- /**
- * Enable E2E test mode which sets the shadow DOM to 'open' mode for testability.
- * This must be called before navigating to pages where you want to inspect the autofill popup.
- */
- async enableE2ETestMode(): Promise<this> {
- await this.popup.evaluate(() => {
- return new Promise<void>((resolve) => {
- chrome.storage.local.set({ e2eTestMode: true }, () => {
- resolve();
- });
- });
- });
- return this;
- }
-
- /**
- * Disable E2E test mode.
- */
- async disableE2ETestMode(): Promise<this> {
- await this.popup.evaluate(() => {
- return new Promise<void>((resolve) => {
- chrome.storage.local.remove('e2eTestMode', () => {
- resolve();
- });
- });
- });
- return this;
- }
-
/**
* Enable offline mode by setting an invalid API URL.
*/