Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Web app tweaks (#2439)

Leendert de Borst7f9b27f2f7ac
diff --git a/apps/web/src/components/attachments/AttachmentUploader.tsx b/apps/web/src/components/attachments/AttachmentUploader.tsx
index ff93fadfe..7d97f9841 100644
--- a/apps/web/src/components/attachments/AttachmentUploader.tsx
+++ b/apps/web/src/components/attachments/AttachmentUploader.tsx
@@ -33,6 +33,9 @@ const AttachmentUploader: React.FC<AttachmentUploaderProps> = ({ attachments, on
if (file.size > MAX_FILE_SIZE) {
throw new Error(t('importExport.serviceCard.importErrorFileTooLarge', { size: MAX_FILE_SIZE / 1024 / 1024 }));
}
+ if (file.size === 0) {
+ throw new Error(t('attachmentUploader.fileEmpty', { filename: file.name }));
+ }
const now = new Date().toISOString();
const attachment: Attachment = { Id: crypto.randomUUID(), Filename: file.name, Blob: new Uint8Array(await file.arrayBuffer()), ItemId: '', CreatedAt: now, UpdatedAt: now };
current = [...current, attachment];
diff --git a/apps/web/src/components/email/EmailModal.tsx b/apps/web/src/components/email/EmailModal.tsx
index 9f30c9e7f..64097d2fe 100644
--- a/apps/web/src/components/email/EmailModal.tsx
+++ b/apps/web/src/components/email/EmailModal.tsx
@@ -98,14 +98,12 @@ const EmailModal: React.FC<EmailModalProps> = ({ email, onClose, onEmailDeleted,
notifications.addErrorMessage(`${t('emails.modal.emailDeleteFailed')}: ${await response.text()}`, true);
return;
}
- onEmailDeleted(email.id);
- notifications.addSuccessMessage(t('emails.modal.emailDeletedSuccess'), true);
- onClose();
} else {
await webApi.delete(`Email/${email.id}`);
- onEmailDeleted(email.id);
- notifications.addSuccessMessage(t('emails.modal.emailDeletedSuccess'), true);
}
+ onEmailDeleted(email.id);
+ notifications.addSuccessMessage(t('emails.modal.emailDeletedSuccess'), true);
+ onClose();
} catch (error) {
notifications.addErrorMessage(`${t('emails.modal.emailDeleteFailed')}: ${error instanceof Error ? error.message : String(error)}`, true);
}
diff --git a/apps/web/src/components/layout/DbLockButton.tsx b/apps/web/src/components/layout/DbLockButton.tsx
index f737bbc43..a2a104ce6 100644
--- a/apps/web/src/components/layout/DbLockButton.tsx
+++ b/apps/web/src/components/layout/DbLockButton.tsx
@@ -1,8 +1,9 @@
-import React from 'react';
+import React, { useCallback } from 'react';
import { useTranslation } from 'react-i18next';
import { useNavigate } from 'react-router-dom';
import { useDb } from '@/context/DbContext';
+import { useKeyboardShortcut } from '@/hooks/useKeyboardShortcut';
import { vaultStore } from '@/vault/VaultStore';
/**
@@ -16,11 +17,13 @@ const DbLockButton: React.FC = () => {
/**
* Lock the vault and redirect to the unlock page.
*/
- const onLockClick = async (): Promise<void> => {
+ const onLockClick = useCallback(async (): Promise<void> => {
await vaultStore.lockVault();
dbContext.clearDatabase();
navigate('/unlock/true');
- };
+ }, [dbContext, navigate]);
+ const lockFromShortcut = useCallback((): void => void onLockClick(), [onLockClick]);
+ useKeyboardShortcut('gl', lockFromShortcut);
return (
<div className="ms-2 items-center hidden lg:flex">
diff --git a/apps/web/src/components/layout/TopMenu.tsx b/apps/web/src/components/layout/TopMenu.tsx
index 49c865f46..0b462cf39 100644
--- a/apps/web/src/components/layout/TopMenu.tsx
+++ b/apps/web/src/components/layout/TopMenu.tsx
@@ -2,7 +2,7 @@ import { familySharingText } from '@aliasvault/client/sharing/FamilySharingView'
import { CapabilityKeys } from '@aliasvault/models/webapi';
import React, { useCallback, useEffect, useRef, useState } from 'react';
import { useTranslation } from 'react-i18next';
-import { NavLink, useLocation } from 'react-router-dom';
+import { NavLink, useLocation, useNavigate } from 'react-router-dom';
import CreateNewIdentityWidget from '@/components/layout/CreateNewIdentityWidget';
import DbLockButton from '@/components/layout/DbLockButton';
@@ -12,6 +12,7 @@ import { useAuth } from '@/context/AuthContext';
import { useCapabilities } from '@/context/CapabilityContext';
import { useTheme } from '@/context/ThemeContext';
import { useClickOutside } from '@/hooks/useClickOutside';
+import { useKeyboardShortcut } from '@/hooks/useKeyboardShortcut';
/**
* Class of a menu link, highlighting the active route.
@@ -29,6 +30,7 @@ const DROPDOWN_LINK = 'block py-2 px-4 text-sm hover:bg-gray-100 dark:hover:bg-g
const TopMenu: React.FC = () => {
const { t } = useTranslation();
const location = useLocation();
+ const navigate = useNavigate();
const { username } = useAuth();
const { isDarkMode, toggleTheme } = useTheme();
const hasCapability = useCapabilities();
@@ -42,6 +44,9 @@ const TopMenu: React.FC = () => {
const closeMenu = useCallback((): void => setIsMobileMenuOpen(false), []);
useClickOutside([menuRef, toggleRef], closeMenu, isMobileMenuOpen);
+ const goHome = useCallback((): void => void navigate('/'), [navigate]);
+ useKeyboardShortcut('gh', goHome);
+
useEffect(() => {
setIsMobileMenuOpen(false);
}, [location.pathname]);
diff --git a/apps/web/src/context/AuthContext.tsx b/apps/web/src/context/AuthContext.tsx
index b11eb24e6..296dd6fdb 100644
--- a/apps/web/src/context/AuthContext.tsx
+++ b/apps/web/src/context/AuthContext.tsx
@@ -7,6 +7,7 @@ import { useDb } from '@/context/DbContext';
import { useWebApi } from '@/context/WebApiContext';
import { removeLocalPreference } from '@/utils/LocalPreferences';
import { LocalPreferenceKeys, StorageKeys } from '@/utils/StorageKeys';
+import { WebAuthnService } from '@/utils/WebAuthnService';
import { vaultStore } from '@/vault/VaultStore';
/**
@@ -85,8 +86,8 @@ export const AuthProvider: React.FC<{ children: React.ReactNode }> = ({ children
}, [clearDatabase]);
/**
- * Revoke the tokens and clear the tokens, session keys and vault. A forced logout (401, token revocation, password
- * change) keeps the username so the login page can prefill it.
+ * Revoke the tokens and clear the tokens, session keys, passkey unlock and vault. A forced logout (401, token
+ * revocation, password change) keeps the username so the login page can prefill it.
*/
const logout = useCallback(async (options: LogoutOptions = {}): Promise<void> => {
if (isLoggingOutRef.current) {
@@ -95,6 +96,7 @@ export const AuthProvider: React.FC<{ children: React.ReactNode }> = ({ children
try {
isLoggingOutRef.current = true;
+ WebAuthnService.disable();
try {
await webApi.revokeTokens();
} catch (error) {
diff --git a/apps/web/src/pages/auth/Login.tsx b/apps/web/src/pages/auth/Login.tsx
index 2076bb277..df774bced 100644
--- a/apps/web/src/pages/auth/Login.tsx
+++ b/apps/web/src/pages/auth/Login.tsx
@@ -49,7 +49,7 @@ const Login: React.FC = () => {
const [step, setStep] = useState<LoginStep>('credentials');
const [username, setUsername] = useState('');
const [password, setPassword] = useState('');
- const [rememberMe, setRememberMe] = useState(false);
+ const [rememberMe, setRememberMe] = useState(true);
const [twoFactorCode, setTwoFactorCode] = useState('');
const [rememberMachine, setRememberMachine] = useState(false);
const [recoveryCode, setRecoveryCode] = useState('');
diff --git a/apps/web/src/pages/auth/Logout.tsx b/apps/web/src/pages/auth/Logout.tsx
index 8e0b527d7..b1cf3f0dd 100644
--- a/apps/web/src/pages/auth/Logout.tsx
+++ b/apps/web/src/pages/auth/Logout.tsx
@@ -7,7 +7,6 @@ import { useAuth } from '@/context/AuthContext';
import { useNotifications } from '@/context/NotificationContext';
import { usePageTitle } from '@/hooks/usePageTitle';
import { delay } from '@/utils/Delay';
-import { WebAuthnService } from '@/utils/WebAuthnService';
/**
* Logs the user out and returns to the start page.
@@ -30,7 +29,6 @@ const Logout: React.FC = () => {
* Revoke the tokens and redirect to the start page.
*/
const run = async (): Promise<void> => {
- WebAuthnService.disable();
await auth.logout({ userInitiated: true });
notifications.clearMessages();
await delay(500);
diff --git a/core/i18n/locales/en.json b/core/i18n/locales/en.json
index 8deb5f425..300f1c53f 100644
--- a/core/i18n/locales/en.json
+++ b/core/i18n/locales/en.json
@@ -69,6 +69,7 @@
},
"attachmentUploader": {
"deleteSuccess": "Attachment deleted successfully.",
+ "fileEmpty": "{{filename}} is empty.",
"firefoxExpandRequired": "To upload files, use the expanded window.",
"openExpandedWindow": "Open Expanded Window",
"uploadError": "Error uploading file: {{error}}",