Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Fix password unlock error disappearing too quickly on Android (#1824)

Leendert de Borst8fc3708173e0
diff --git a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/passwordunlock/PasswordUnlockActivity.kt b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/passwordunlock/PasswordUnlockActivity.kt
index 687b4e358..77cc063e7 100644
--- a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/passwordunlock/PasswordUnlockActivity.kt
+++ b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/passwordunlock/PasswordUnlockActivity.kt
@@ -148,8 +148,8 @@ class PasswordUnlockActivity : AppCompatActivity() {
// Not used
}
override fun afterTextChanged(s: Editable?) {
- // Only hide error if user is typing (not when we programmatically clear for error display)
- if (!isShowingError) {
+ // Hide error when user starts typing a new password
+ if (!isShowingError && !s.isNullOrEmpty()) {
hideError()
}
unlockButton.isEnabled = !s.isNullOrEmpty() && !isProcessing
@@ -278,9 +278,11 @@ class PasswordUnlockActivity : AppCompatActivity() {
}
private fun showError(message: String) {
- errorTextView.text = message
+ errorContainer.animate().cancel()
isShowingError = true
+ errorTextView.text = message
+
// Animate error in with slide from top
errorContainer.visibility = View.VISIBLE
errorContainer.alpha = 0f
@@ -290,6 +292,7 @@ class PasswordUnlockActivity : AppCompatActivity() {
.translationY(0f)
.setDuration(300)
.setInterpolator(AccelerateDecelerateInterpolator())
+ .setListener(null) // Clear any previous listeners
.start()
// Shake password field to indicate error
@@ -298,18 +301,15 @@ class PasswordUnlockActivity : AppCompatActivity() {
shake.start()
passwordEditText.text?.clear()
-
- // Reset flag after clearing is done
- passwordEditText.post {
+ passwordEditText.postDelayed({
isShowingError = false
- }
+ }, 100)
passwordEditText.requestFocus()
}
private fun hideError() {
- if (errorContainer.visibility == View.VISIBLE) {
- isShowingError = false
+ if (errorContainer.visibility == View.VISIBLE && !isShowingError) {
errorContainer.animate()
.alpha(0f)
.translationY(-20f)