Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Add attachments credential filter to all clients (#1309)

Leendert de Borst9641514b3b57
diff --git a/apps/browser-extension/src/entrypoints/popup/components/Credentials/CredentialCard.tsx b/apps/browser-extension/src/entrypoints/popup/components/Credentials/CredentialCard.tsx
index 2d0400c66..76a2545ef 100644
--- a/apps/browser-extension/src/entrypoints/popup/components/Credentials/CredentialCard.tsx
+++ b/apps/browser-extension/src/entrypoints/popup/components/Credentials/CredentialCard.tsx
@@ -86,6 +86,20 @@ const CredentialCard: React.FC<CredentialCardProps> = ({ credential }) => {
<path d="M21 2l-2 2m-7.61 7.61a5.5 5.5 0 1 1-7.778 7.778 5.5 5.5 0 0 1 7.777-7.777zm0 0L15.5 7.5m0 0l3 3L22 7l-3-3m-3.5 3.5L19 4" />
</svg>
)}
+ {credential.HasAttachment && (
+ <svg
+ className="w-3.5 h-3.5 text-gray-500 dark:text-gray-400"
+ viewBox="0 0 24 24"
+ fill="none"
+ stroke="currentColor"
+ strokeWidth="2"
+ strokeLinecap="round"
+ strokeLinejoin="round"
+ aria-label="Has attachments"
+ >
+ <path d="M21.44 11.05l-9.19 9.19a6 6 0 0 1-8.49-8.49l9.19-9.19a4 4 0 0 1 5.66 5.66l-9.2 9.19a2 2 0 0 1-2.83-2.83l8.49-8.48" />
+ </svg>
+ )}
</div>
<p className="text-sm text-gray-600 dark:text-gray-400">{getDisplayText(credential)}</p>
</div>
diff --git a/apps/browser-extension/src/entrypoints/popup/pages/credentials/CredentialsList.tsx b/apps/browser-extension/src/entrypoints/popup/pages/credentials/CredentialsList.tsx
index 63c43aeed..25ca1bb4c 100644
--- a/apps/browser-extension/src/entrypoints/popup/pages/credentials/CredentialsList.tsx
+++ b/apps/browser-extension/src/entrypoints/popup/pages/credentials/CredentialsList.tsx
@@ -18,7 +18,7 @@ import type { Credential } from '@/utils/dist/shared/models/vault';
import { useMinDurationLoading } from '@/hooks/useMinDurationLoading';
-type FilterType = 'all' | 'passkeys' | 'aliases' | 'userpass';
+type FilterType = 'all' | 'passkeys' | 'aliases' | 'userpass' | 'attachments';
const FILTER_STORAGE_KEY = 'credentials-filter';
const FILTER_EXPIRY_MS = 5 * 60 * 1000; // 5 minutes
@@ -189,6 +189,8 @@ const CredentialsList: React.FC = () => {
return t('credentials.filters.aliases');
case 'userpass':
return t('credentials.filters.userpass');
+ case 'attachments':
+ return t('credentials.filters.attachments');
default:
return t('credentials.title');
}
@@ -223,6 +225,8 @@ const CredentialsList: React.FC = () => {
(credential.Password && credential.Password.trim())
);
passesTypeFilter = hasUsernameOrPassword && !credential.HasPasskey && !hasAliasFields;
+ } else if (filterType === 'attachments') {
+ passesTypeFilter = credential.HasAttachment === true;
}
if (!passesTypeFilter) {
@@ -354,6 +358,19 @@ const CredentialsList: React.FC = () => {
>
{t('credentials.filters.userpass')}
</button>
+ <button
+ onClick={() => {
+ const newFilter = 'attachments';
+ setFilterType(newFilter);
+ storeFilter(newFilter);
+ setShowFilterMenu(false);
+ }}
+ className={`w-full text-left px-4 py-2 text-sm hover:bg-gray-100 dark:hover:bg-gray-700 ${
+ filterType === 'attachments' ? 'bg-orange-50 dark:bg-orange-900/20 text-orange-600 dark:text-orange-400' : 'text-gray-700 dark:text-gray-300'
+ }`}
+ >
+ {t('credentials.filters.attachments')}
+ </button>
</div>
</div>
</>
@@ -391,7 +408,9 @@ const CredentialsList: React.FC = () => {
<p>
{filterType === 'passkeys'
? t('credentials.noPasskeysFound')
- : t('credentials.noMatchingCredentials')
+ : filterType === 'attachments'
+ ? t('credentials.noAttachmentsFound')
+ : t('credentials.noMatchingCredentials')
}
</p>
</div>
diff --git a/apps/browser-extension/src/i18n/locales/en.json b/apps/browser-extension/src/i18n/locales/en.json
index c2401e7c2..03156b22a 100644
--- a/apps/browser-extension/src/i18n/locales/en.json
+++ b/apps/browser-extension/src/i18n/locales/en.json
@@ -200,6 +200,7 @@
"welcomeTitle": "Welcome to AliasVault!",
"welcomeDescription": "To use the AliasVault browser extension: navigate to a website and use the AliasVault autofill popup to create a new credential.",
"noPasskeysFound": "No passkeys have been created yet. Passkeys are created by visiting a website that offers passkeys as an authentication method.",
+ "noAttachmentsFound": "No credentials with attachments found",
"noMatchingCredentials": "No matching credentials found",
"createdAt": "Created",
"updatedAt": "Last updated",
@@ -220,7 +221,8 @@
"all": "(All) Credentials",
"passkeys": "Passkeys",
"aliases": "Aliases",
- "userpass": "Passwords"
+ "userpass": "Passwords",
+ "attachments": "Attachments"
},
"randomAlias": "Random Alias",
"manual": "Manual",
diff --git a/apps/browser-extension/src/utils/SqliteClient.ts b/apps/browser-extension/src/utils/SqliteClient.ts
index 2432dee45..cc8a93bb5 100644
--- a/apps/browser-extension/src/utils/SqliteClient.ts
+++ b/apps/browser-extension/src/utils/SqliteClient.ts
@@ -292,7 +292,14 @@ export class SqliteClient {
WHERE pk.CredentialId = c.Id AND pk.IsDeleted = 0
) THEN 1
ELSE 0
- END as HasPasskey
+ END as HasPasskey,
+ CASE
+ WHEN EXISTS (
+ SELECT 1 FROM Attachments att
+ WHERE att.CredentialId = c.Id AND att.IsDeleted = 0
+ ) THEN 1
+ ELSE 0
+ END as HasAttachment
FROM Credentials c
LEFT JOIN Services s ON c.ServiceId = s.Id
LEFT JOIN Aliases a ON c.AliasId = a.Id
@@ -312,6 +319,7 @@ export class SqliteClient {
Logo: row.Logo,
Notes: row.Notes,
HasPasskey: row.HasPasskey === 1,
+ HasAttachment: row.HasAttachment === 1,
Alias: {
FirstName: row.FirstName,
LastName: row.LastName,
diff --git a/apps/browser-extension/src/utils/dist/shared/models/vault/index.d.ts b/apps/browser-extension/src/utils/dist/shared/models/vault/index.d.ts
index a44df8a3b..17fbf2f77 100644
--- a/apps/browser-extension/src/utils/dist/shared/models/vault/index.d.ts
+++ b/apps/browser-extension/src/utils/dist/shared/models/vault/index.d.ts
@@ -70,6 +70,8 @@ type Credential = {
PasskeyRpId?: string;
/** The display name of the associated passkey */
PasskeyDisplayName?: string;
+ /** Indicates if this credential has one or more attachments */
+ HasAttachment?: boolean;
};
/**
* Alias SQLite database type.
diff --git a/apps/mobile-app/app/(tabs)/credentials/index.tsx b/apps/mobile-app/app/(tabs)/credentials/index.tsx
index 3b566698e..9bc18576d 100644
--- a/apps/mobile-app/app/(tabs)/credentials/index.tsx
+++ b/apps/mobile-app/app/(tabs)/credentials/index.tsx
@@ -17,7 +17,7 @@ import { useMinDurationLoading } from '@/hooks/useMinDurationLoading';
import { useVaultMutate } from '@/hooks/useVaultMutate';
import { useVaultSync } from '@/hooks/useVaultSync';
-type FilterType = 'all' | 'passkeys' | 'aliases' | 'userpass';
+type FilterType = 'all' | 'passkeys' | 'aliases' | 'userpass' | 'attachments';
import Logo from '@/assets/images/logo.svg';
import { CredentialCard } from '@/components/credentials/CredentialCard';
@@ -224,6 +224,8 @@ export default function CredentialsScreen() : React.ReactNode {
return t('credentials.filters.aliases');
case 'userpass':
return t('credentials.filters.userpass');
+ case 'attachments':
+ return t('credentials.filters.attachments');
default:
return t('credentials.title');
}
@@ -258,6 +260,8 @@ export default function CredentialsScreen() : React.ReactNode {
(credential.Password && credential.Password.trim())
);
passesTypeFilter = hasUsernameOrPassword && !credential.HasPasskey && !hasAliasFields;
+ } else if (filterType === 'attachments') {
+ passesTypeFilter = credential.HasAttachment === true;
}
if (!passesTypeFilter) {
@@ -603,6 +607,23 @@ export default function CredentialsScreen() : React.ReactNode {
{t('credentials.filters.userpass')}
</ThemedText>
</TouchableOpacity>
+ <TouchableOpacity
+ style={[
+ styles.filterMenuItem,
+ filterType === 'attachments' && styles.filterMenuItemActive
+ ]}
+ onPress={() => {
+ setFilterType('attachments');
+ setShowFilterMenu(false);
+ }}
+ >
+ <ThemedText style={[
+ styles.filterMenuItemText,
+ filterType === 'attachments' && styles.filterMenuItemTextActive
+ ]}>
+ {t('credentials.filters.attachments')}
+ </ThemedText>
+ </TouchableOpacity>
</ThemedView>
)}
<ThemedView style={styles.searchContainer}>
@@ -657,7 +678,9 @@ export default function CredentialsScreen() : React.ReactNode {
? t('credentials.noMatchingCredentials')
: filterType === 'passkeys'
? t('credentials.noPasskeysFound')
- : t('credentials.noCredentialsFound')
+ : filterType === 'attachments'
+ ? t('credentials.noAttachmentsFound')
+ : t('credentials.noCredentialsFound')
}
</Text>
) : null
diff --git a/apps/mobile-app/components/credentials/CredentialCard.tsx b/apps/mobile-app/components/credentials/CredentialCard.tsx
index 8b1e55b84..5b8a61453 100644
--- a/apps/mobile-app/components/credentials/CredentialCard.tsx
+++ b/apps/mobile-app/components/credentials/CredentialCard.tsx
@@ -289,6 +289,14 @@ export function CredentialCard({ credential, onCredentialDelete }: CredentialCar
style={styles.passkeyIcon}
/>
)}
+ {credential.HasAttachment && (
+ <MaterialIcons
+ name="attach-file"
+ size={14}
+ color={colors.textMuted}
+ style={styles.passkeyIcon}
+ />
+ )}
</View>
<Text style={styles.credentialText}>
{getCredentialDisplayText(credential)}
diff --git a/apps/mobile-app/i18n/locales/en.json b/apps/mobile-app/i18n/locales/en.json
index 34cec0357..c117b05da 100644
--- a/apps/mobile-app/i18n/locales/en.json
+++ b/apps/mobile-app/i18n/locales/en.json
@@ -126,6 +126,7 @@
"noMatchingCredentials": "No matching credentials found",
"noCredentialsFound": "No credentials found. Create one to get started. Tip: you can also login to the AliasVault web app to import credentials from other password managers.",
"noPasskeysFound": "No passkeys have been created yet. Passkeys are created by visiting a website that offers passkeys as an authentication method.",
+ "noAttachmentsFound": "No credentials with attachments found",
"recentEmails": "Recent emails",
"loadingEmails": "Loading emails...",
"noEmailsYet": "No emails received yet.",
@@ -155,7 +156,8 @@
"all": "(All) Credentials",
"passkeys": "Passkeys",
"aliases": "Aliases",
- "userpass": "Passwords"
+ "userpass": "Passwords",
+ "attachments": "Attachments"
},
"twoFactorAuth": "Two-factor authentication",
"totpCode": "TOTP Code",
diff --git a/apps/mobile-app/utils/SqliteClient.tsx b/apps/mobile-app/utils/SqliteClient.tsx
index f1de4691b..975b7e725 100644
--- a/apps/mobile-app/utils/SqliteClient.tsx
+++ b/apps/mobile-app/utils/SqliteClient.tsx
@@ -316,7 +316,14 @@ class SqliteClient {
ELSE 0
END as HasPasskey,
(SELECT pk.RpId FROM Passkeys pk WHERE pk.CredentialId = c.Id AND pk.IsDeleted = 0 LIMIT 1) as PasskeyRpId,
- (SELECT pk.DisplayName FROM Passkeys pk WHERE pk.CredentialId = c.Id AND pk.IsDeleted = 0 LIMIT 1) as PasskeyDisplayName
+ (SELECT pk.DisplayName FROM Passkeys pk WHERE pk.CredentialId = c.Id AND pk.IsDeleted = 0 LIMIT 1) as PasskeyDisplayName,
+ CASE
+ WHEN EXISTS (
+ SELECT 1 FROM Attachments att
+ WHERE att.CredentialId = c.Id AND att.IsDeleted = 0
+ ) THEN 1
+ ELSE 0
+ END as HasAttachment
FROM Credentials c
LEFT JOIN Services s ON c.ServiceId = s.Id
LEFT JOIN Aliases a ON c.AliasId = a.Id
@@ -338,6 +345,7 @@ class SqliteClient {
HasPasskey: row.HasPasskey === 1,
PasskeyRpId: row.PasskeyRpId,
PasskeyDisplayName: row.PasskeyDisplayName,
+ HasAttachment: row.HasAttachment === 1,
Alias: {
FirstName: row.FirstName,
LastName: row.LastName,
diff --git a/apps/mobile-app/utils/dist/shared/models/vault/index.d.ts b/apps/mobile-app/utils/dist/shared/models/vault/index.d.ts
index a44df8a3b..17fbf2f77 100644
--- a/apps/mobile-app/utils/dist/shared/models/vault/index.d.ts
+++ b/apps/mobile-app/utils/dist/shared/models/vault/index.d.ts
@@ -70,6 +70,8 @@ type Credential = {
PasskeyRpId?: string;
/** The display name of the associated passkey */
PasskeyDisplayName?: string;
+ /** Indicates if this credential has one or more attachments */
+ HasAttachment?: boolean;
};
/**
* Alias SQLite database type.
diff --git a/apps/server/AliasVault.Client/Main/Components/Credentials/CredentialCard.razor b/apps/server/AliasVault.Client/Main/Components/Credentials/CredentialCard.razor
index 1435a4f70..be9e6799a 100644
--- a/apps/server/AliasVault.Client/Main/Components/Credentials/CredentialCard.razor
+++ b/apps/server/AliasVault.Client/Main/Components/Credentials/CredentialCard.razor
@@ -12,6 +12,12 @@
<path d="M21 2l-2 2m-7.61 7.61a5.5 5.5 0 1 1-7.778 7.778 5.5 5.5 0 0 1 7.777-7.777zm0 0L15.5 7.5m0 0l3 3L22 7l-3-3m-3.5 3.5L19 4" />
</svg>
}
+ @if (Obj.HasAttachment)
+ {
+ <svg class="w-3.5 h-3.5 text-gray-500 dark:text-gray-400 flex-shrink-0" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" aria-label="Has attachments">
+ <path d="M21.44 11.05l-9.19 9.19a6 6 0 0 1-8.49-8.49l9.19-9.19a4 4 0 0 1 5.66 5.66l-9.2 9.19a2 2 0 0 1-2.83-2.83l8.49-8.48" />
+ </svg>
+ }
</div>
<div class="text-gray-500 dark:text-gray-400 break-words w-full text-sm">@GetDisplayText()</div>
</div>
diff --git a/apps/server/AliasVault.Client/Main/Models/CredentialFilterType.cs b/apps/server/AliasVault.Client/Main/Models/CredentialFilterType.cs
index 0e1b3bfc0..5db96002f 100644
--- a/apps/server/AliasVault.Client/Main/Models/CredentialFilterType.cs
+++ b/apps/server/AliasVault.Client/Main/Models/CredentialFilterType.cs
@@ -31,4 +31,9 @@ public enum CredentialFilterType
/// Show only credentials with username/password (no aliases, no passkeys).
/// </summary>
Userpass,
+
+ /// <summary>
+ /// Show only credentials with attachments.
+ /// </summary>
+ Attachments,
}
diff --git a/apps/server/AliasVault.Client/Main/Models/CredentialListEntry.cs b/apps/server/AliasVault.Client/Main/Models/CredentialListEntry.cs
index e3a6a77b5..a2ed62da7 100644
--- a/apps/server/AliasVault.Client/Main/Models/CredentialListEntry.cs
+++ b/apps/server/AliasVault.Client/Main/Models/CredentialListEntry.cs
@@ -56,4 +56,9 @@ public sealed class CredentialListEntry
/// Gets or sets a value indicating whether this credential has a username or password.
/// </summary>
public bool HasUsernameOrPassword { get; set; }
+
+ /// <summary>
+ /// Gets or sets a value indicating whether this credential has one or more attachments.
+ /// </summary>
+ public bool HasAttachment { get; set; }
}
diff --git a/apps/server/AliasVault.Client/Main/Pages/Credentials/Home.razor b/apps/server/AliasVault.Client/Main/Pages/Credentials/Home.razor
index 753f8cacf..c31a12026 100644
--- a/apps/server/AliasVault.Client/Main/Pages/Credentials/Home.razor
+++ b/apps/server/AliasVault.Client/Main/Pages/Credentials/Home.razor
@@ -40,6 +40,9 @@
<button @onclick="() => SetFilter(CredentialFilterType.Userpass)" class="w-full text-left px-4 py-2 text-sm hover:bg-gray-100 dark:hover:bg-gray-600 @(FilterType == CredentialFilterType.Userpass ? "bg-orange-50 dark:bg-orange-900/20 text-orange-600 dark:text-orange-400" : "text-gray-700 dark:text-gray-300")">
@Localizer["FilterUserpassOption"]
</button>
+ <button @onclick="() => SetFilter(CredentialFilterType.Attachments)" class="w-full text-left px-4 py-2 text-sm hover:bg-gray-100 dark:hover:bg-gray-600 @(FilterType == CredentialFilterType.Attachments ? "bg-orange-50 dark:bg-orange-900/20 text-orange-600 dark:text-orange-400" : "text-gray-700 dark:text-gray-300")">
+ @Localizer["FilterAttachmentsOption"]
+ </button>
</div>
</div>
</ClickOutsideHandler>
@@ -133,6 +136,10 @@ else
{
<p>@Localizer["NoPasskeysFound"]</p>
}
+ else if (FilterType == CredentialFilterType.Attachments)
+ {
+ <p>@Localizer["NoAttachmentsFound"]</p>
+ }
else
{
<p>@Localizer["NoCredentialsFound"]</p>
@@ -207,6 +214,7 @@ else
CredentialFilterType.Passkeys => Credentials.Where(x => x.HasPasskey),
CredentialFilterType.Aliases => Credentials.Where(x => x.HasAlias),
CredentialFilterType.Userpass => Credentials.Where(x => x.HasUsernameOrPassword && !x.HasPasskey && !x.HasAlias),
+ CredentialFilterType.Attachments => Credentials.Where(x => x.HasAttachment),
_ => Credentials, // All
};
@@ -230,6 +238,7 @@ else
CredentialFilterType.Passkeys => Localizer["FilterPasskeysOption"],
CredentialFilterType.Aliases => Localizer["FilterAliasesOption"],
CredentialFilterType.Userpass => Localizer["FilterUserpassOption"],
+ CredentialFilterType.Attachments => Localizer["FilterAttachmentsOption"],
_ => Localizer["PageTitle"],
};
}
diff --git a/apps/server/AliasVault.Client/Resources/Pages/Main/Credentials/Home.en.resx b/apps/server/AliasVault.Client/Resources/Pages/Main/Credentials/Home.en.resx
index 24f330400..ea6d95690 100644
--- a/apps/server/AliasVault.Client/Resources/Pages/Main/Credentials/Home.en.resx
+++ b/apps/server/AliasVault.Client/Resources/Pages/Main/Credentials/Home.en.resx
@@ -160,12 +160,20 @@
<value>Passwords</value>
<comment>Filter option to show only username/passwords</comment>
</data>
+ <data name="FilterAttachmentsOption" xml:space="preserve">
+ <value>Attachments</value>
+ <comment>Filter option to show only credentials with attachments</comment>
+ </data>
<!-- Filtered Empty States -->
<data name="NoPasskeysFound" xml:space="preserve">
<value>No passkeys have been created yet. Passkeys are added through the browser extension or mobile apps when visiting a website that supports passkeys and offers passkey authentication.</value>
<comment>Empty state message when no passkeys are found</comment>
</data>
+ <data name="NoAttachmentsFound" xml:space="preserve">
+ <value>No credentials with attachments found.</value>
+ <comment>Empty state message when no credentials with attachments are found</comment>
+ </data>
<data name="NoCredentialsFound" xml:space="preserve">
<value>No credentials match the selected filter.</value>
<comment>Empty state message when no credentials match the filter</comment>
diff --git a/apps/server/AliasVault.Client/Services/CredentialService.cs b/apps/server/AliasVault.Client/Services/CredentialService.cs
index d6196b6d6..bfe59ce01 100644
--- a/apps/server/AliasVault.Client/Services/CredentialService.cs
+++ b/apps/server/AliasVault.Client/Services/CredentialService.cs
@@ -327,6 +327,7 @@ public sealed class CredentialService(HttpClient httpClient, DbService dbService
.Include(x => x.Service)
.Include(x => x.Passkeys.Where(p => !p.IsDeleted))
.Include(x => x.Passwords.Where(p => !p.IsDeleted))
+ .Include(x => x.Attachments.Where(a => !a.IsDeleted))
.AsSplitQuery()
.Where(x => !x.IsDeleted)
.ToListAsync();
@@ -348,6 +349,7 @@ public sealed class CredentialService(HttpClient httpClient, DbService dbService
x.Alias.BirthDate.Year > 1,
HasUsernameOrPassword = !string.IsNullOrWhiteSpace(x.Username) ||
(x.Passwords != null && x.Passwords.Any(p => !string.IsNullOrWhiteSpace(p.Value))),
+ HasAttachment = x.Attachments != null && x.Attachments.Any(),
}).ToList();
}
diff --git a/shared/models/src/vault/Credential.ts b/shared/models/src/vault/Credential.ts
index 987dd8af3..e461ee51f 100644
--- a/shared/models/src/vault/Credential.ts
+++ b/shared/models/src/vault/Credential.ts
@@ -16,6 +16,8 @@ export type Credential = {
PasskeyRpId?: string;
/** The display name of the associated passkey */
PasskeyDisplayName?: string;
+ /** Indicates if this credential has one or more attachments */
+ HasAttachment?: boolean;
}
/**