Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.
Update tests (#773)
Leendert de Borst9be1aec43f01
diff --git a/apps/server/AliasVault.Client/Auth/Models/RegisterFormModel.cs b/apps/server/AliasVault.Client/Auth/Models/RegisterFormModel.csindex 51e1afed1..7481bfe38 100644--- a/apps/server/AliasVault.Client/Auth/Models/RegisterFormModel.cs+++ b/apps/server/AliasVault.Client/Auth/Models/RegisterFormModel.cs@@ -27,7 +27,7 @@ public class RegisterFormModel/// Gets or sets the password./// </summary>[Required(ErrorMessageResourceType = typeof(ValidationMessages), ErrorMessageResourceName = nameof(ValidationMessages.PasswordRequired))]- [MinimumPasswordLength(PasswordStrengthConstants.MinimumGoodPasswordLength, ErrorMessageResourceType = typeof(ValidationMessages), ErrorMessageResourceName = nameof(ValidationMessages.PasswordMinLengthGeneric))]+ [MinimumPasswordLength(PasswordStrengthConstants.MinimumGoodPasswordLength, 8, ErrorMessageResourceType = typeof(ValidationMessages), ErrorMessageResourceName = nameof(ValidationMessages.PasswordMinLengthGeneric))]public string Password { get; set; } = null!;/// <summary>diff --git a/apps/server/Shared/AliasVault.Shared/Models/Validation/MinimumPasswordLengthAttribute.cs b/apps/server/Shared/AliasVault.Shared/Models/Validation/MinimumPasswordLengthAttribute.csindex f2e9d5ec7..5797f6103 100644--- a/apps/server/Shared/AliasVault.Shared/Models/Validation/MinimumPasswordLengthAttribute.cs+++ b/apps/server/Shared/AliasVault.Shared/Models/Validation/MinimumPasswordLengthAttribute.cs@@ -22,6 +22,18 @@ public class MinimumPasswordLengthAttribute : ValidationAttributepublic MinimumPasswordLengthAttribute(int minimumLength){MinimumLength = minimumLength;+ DevelopmentMinimumLength = null;+ }++ /// <summary>+ /// Initializes a new instance of the <see cref="MinimumPasswordLengthAttribute"/> class with different lengths for development and production.+ /// </summary>+ /// <param name="minimumLength">The minimum required password length for production.</param>+ /// <param name="developmentMinimumLength">The minimum required password length for development.</param>+ public MinimumPasswordLengthAttribute(int minimumLength, int developmentMinimumLength)+ {+ MinimumLength = minimumLength;+ DevelopmentMinimumLength = developmentMinimumLength;}/// <summary>@@ -29,6 +41,11 @@ public class MinimumPasswordLengthAttribute : ValidationAttribute/// </summary>public int MinimumLength { get; }+ /// <summary>+ /// Gets the minimum required password length for development environment (optional).+ /// </summary>+ public int? DevelopmentMinimumLength { get; }+/// <inheritdoc />public override bool IsValid(object? value){@@ -37,7 +54,7 @@ public class MinimumPasswordLengthAttribute : ValidationAttributereturn false;}- return password.Length >= MinimumLength;+ return password.Length >= GetEffectiveMinimumLength();}/// <inheritdoc />@@ -48,11 +65,26 @@ public class MinimumPasswordLengthAttribute : ValidationAttributereturn ValidationResult.Success;}+ var effectiveMinLength = GetEffectiveMinimumLength();+// Format the error message with the minimum password lengthvar errorMessage = string.Format(ErrorMessage ?? "Password must be at least {0} characters long.",- MinimumLength);+ effectiveMinLength);return new ValidationResult(errorMessage);}++ /// <summary>+ /// Gets the effective minimum length based on the current environment.+ /// </summary>+ /// <returns>The minimum length to use for validation.</returns>+ private int GetEffectiveMinimumLength()+ {+#if DEBUG+ return DevelopmentMinimumLength ?? MinimumLength;+#else+ return MinimumLength;+#endif+ }}