Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Fix useVaultSync loop on API error (#1459)

Leendert de Borst9f7e0b759d32
diff --git a/apps/browser-extension/src/entrypoints/popup/hooks/useVaultSync.ts b/apps/browser-extension/src/entrypoints/popup/hooks/useVaultSync.ts
index 2c203d6db..c9a904495 100644
--- a/apps/browser-extension/src/entrypoints/popup/hooks/useVaultSync.ts
+++ b/apps/browser-extension/src/entrypoints/popup/hooks/useVaultSync.ts
@@ -191,7 +191,13 @@ export const useVaultSync = (): { syncVault: (options?: VaultSyncOptions) => Pro
// Server returned Outdated - another device uploaded. Re-sync.
return syncVault(options);
} else {
+ /*
+ * Upload failed (e.g. server returned 500). Report error to prevent
+ * the caller from re-checking isDirty and looping immediately.
+ */
console.error('Failed to upload merged vault:', uploadResponse.error);
+ onError?.(uploadResponse.error ?? t('common.errors.unknownError'));
+ return false;
}
// Store metadata and load merged vault into memory
@@ -279,7 +285,13 @@ export const useVaultSync = (): { syncVault: (options?: VaultSyncOptions) => Pro
*/
return syncVault(options);
} else {
+ /*
+ * Upload failed (e.g. server returned 500). Report error to prevent
+ * the caller from re-checking isDirty and looping immediately.
+ */
console.error('Failed to upload pending vault:', uploadResponse.error);
+ onError?.(uploadResponse.error ?? t('common.errors.unknownError'));
+ return false;
}
onSuccess?.(false);