Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.
Add public user registration disabled checks to API endpoints and web client (#1546)
Leendert de Borstb19b370b9d70
diff --git a/apps/server/AliasVault.Api/Controllers/AuthController.cs b/apps/server/AliasVault.Api/Controllers/AuthController.csindex 4a660acdb..e92327487 100644--- a/apps/server/AliasVault.Api/Controllers/AuthController.cs+++ b/apps/server/AliasVault.Api/Controllers/AuthController.cs@@ -513,6 +513,13 @@ public class AuthController(IAliasServerDbContextFactory dbContextFactory, UserM[AllowAnonymous]public async Task<IActionResult> ValidateUsername([FromBody] ValidateUsernameRequest model){+ // Check if public registration is disabled in the configuration.+ // This prevents username enumeration when registration is disabled.+ if (!config.PublicRegistrationEnabled)+ {+ return BadRequest(ApiErrorCodeHelper.CreateErrorResponse(ApiErrorCode.PUBLIC_REGISTRATION_DISABLED, 400));+ }+if (string.IsNullOrWhiteSpace(model.Username)){return BadRequest(ApiErrorCodeHelper.CreateErrorResponse(ApiErrorCode.USERNAME_REQUIRED, 400));diff --git a/apps/server/AliasVault.Client/Auth/Pages/Register.razor b/apps/server/AliasVault.Client/Auth/Pages/Register.razorindex 32effaa37..22204d47b 100644--- a/apps/server/AliasVault.Client/Auth/Pages/Register.razor+++ b/apps/server/AliasVault.Client/Auth/Pages/Register.razor@@ -2,6 +2,7 @@@inherits AliasVault.Client.Auth.Pages.Base.LoginBase@attribute [AllowAnonymous]@layout Auth.Layout.MainLayout+@inject Config Config@using AliasVault.Client.Auth.Models@using AliasVault.Client.Auth.Components@using Microsoft.Extensions.Localization@@ -54,6 +55,18 @@private IStringLocalizer Localizer => LocalizerFactory.Create("Components.Auth.Register", "AliasVault.Client");+ /// <inheritdoc />+ protected override void OnInitialized()+ {+ base.OnInitialized();++ // Redirect to login page if public registration is disabled+ if (!Config.PublicRegistrationEnabled)+ {+ NavigationManager.NavigateTo("/user/login");+ }+ }+private async Task HandleRegister(){_loadingIndicator.Show(Localizer["CreatingAccountMessage"]);diff --git a/apps/server/AliasVault.Client/Auth/Pages/Setup/Setup.razor b/apps/server/AliasVault.Client/Auth/Pages/Setup/Setup.razorindex 45fc1aaea..3efb24e49 100644--- a/apps/server/AliasVault.Client/Auth/Pages/Setup/Setup.razor+++ b/apps/server/AliasVault.Client/Auth/Pages/Setup/Setup.razor@@ -4,6 +4,7 @@@using Microsoft.Extensions.Localization@inherits AliasVault.Client.Auth.Pages.Base.LoginBase@layout Auth.Layout.EmptyLayout+@inject Config Config@attribute [AllowAnonymous]<div class="min-h-screen bg-gray-100 dark:bg-gray-900 flex flex-col lg:items-center lg:justify-center">@@ -87,6 +88,18 @@private SetupStep _currentStep = SetupStep.TermsAndConditions;private readonly SetupData _setupData = new();+ /// <inheritdoc />+ protected override void OnInitialized()+ {+ base.OnInitialized();++ // Redirect to login page if public registration is disabled+ if (!Config.PublicRegistrationEnabled)+ {+ NavigationManager.NavigateTo("/user/login");+ }+ }+/// <summary>/// Determines if the "Continue" button is enabled based on the current step and setup data./// </summary>