Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Add shared page content component with min-height to prevent dropdown clipping (#2090)

Leendert de Borstca1a8e7a58d7
diff --git a/apps/server/AliasVault.Client/Main/Pages/Emails/Home.razor b/apps/server/AliasVault.Client/Main/Pages/Emails/Home.razor
index 89747aaf7..b19a3291a 100644
--- a/apps/server/AliasVault.Client/Main/Pages/Emails/Home.razor
+++ b/apps/server/AliasVault.Client/Main/Pages/Emails/Home.razor
@@ -36,6 +36,7 @@
</CustomActions>
</PageHeader>
+<PageContent>
@if (IsLoading)
{
<div class="px-4">
@@ -179,6 +180,7 @@ else
</div>
</div>
}
+</PageContent>
@code {
private IStringLocalizer Localizer => LocalizerFactory.Create("Pages.Main.Emails.Home", "AliasVault.Client");
diff --git a/apps/server/AliasVault.Client/Main/Pages/Items/AddEdit.razor b/apps/server/AliasVault.Client/Main/Pages/Items/AddEdit.razor
index 2e379bbb7..72f6d734f 100644
--- a/apps/server/AliasVault.Client/Main/Pages/Items/AddEdit.razor
+++ b/apps/server/AliasVault.Client/Main/Pages/Items/AddEdit.razor
@@ -28,6 +28,7 @@
}
else
{
+ <PageContent>
<EditForm @ref="EditFormRef" Model="Obj" OnValidSubmit="SaveAlias">
<DataAnnotationsValidator />
<div class="grid grid-cols-1 px-4 pt-6 md:grid-cols-2 lg:grid-cols-3 md:gap-4 dark:bg-gray-900">
@@ -400,6 +401,7 @@ else
<ConfirmButton OnClick="TriggerFormSubmit">@Localizer["SaveItemButton"]</ConfirmButton>
<CancelButton OnClick="Cancel">@SharedLocalizer["Cancel"]</CancelButton>
</StickyActionBar>
+ </PageContent>
}
@code {
diff --git a/apps/server/AliasVault.Client/Main/Pages/Items/Home.razor b/apps/server/AliasVault.Client/Main/Pages/Items/Home.razor
index 4c3f580ce..cb2678a66 100644
--- a/apps/server/AliasVault.Client/Main/Pages/Items/Home.razor
+++ b/apps/server/AliasVault.Client/Main/Pages/Items/Home.razor
@@ -91,7 +91,7 @@
}
else
{
- <div class="px-4 mb-4 min-h-[350px]">
+ <PageContent Class="px-4 mb-4">
@* Active filter indicator - show persistently when a filter is active *@
@if (FilterType != ItemFilterType.All)
{
@@ -218,7 +218,7 @@ else
}
</div>
}
- </div>
+ </PageContent>
}
@* Create Folder Modal *@
diff --git a/apps/server/AliasVault.Client/Main/Pages/Items/RecentlyDeleted.razor b/apps/server/AliasVault.Client/Main/Pages/Items/RecentlyDeleted.razor
index 0c595e49d..655aa0bde 100644
--- a/apps/server/AliasVault.Client/Main/Pages/Items/RecentlyDeleted.razor
+++ b/apps/server/AliasVault.Client/Main/Pages/Items/RecentlyDeleted.razor
@@ -38,7 +38,7 @@
}
else
{
- <div class="mx-4 min-h-[350px]">
+ <PageContent Class="mx-4">
@if (Items.Count == 0)
{
<div class="p-4 mb-4 bg-white border border-gray-200 rounded-lg shadow-sm dark:border-gray-700 dark:bg-gray-800">
@@ -100,7 +100,7 @@ else
</ul>
</div>
}
- </div>
+ </PageContent>
}
@* Confirm Delete Modal *@
diff --git a/apps/server/AliasVault.Client/Main/Pages/Items/View.razor b/apps/server/AliasVault.Client/Main/Pages/Items/View.razor
index 73ec79021..47b6a362c 100644
--- a/apps/server/AliasVault.Client/Main/Pages/Items/View.razor
+++ b/apps/server/AliasVault.Client/Main/Pages/Items/View.razor
@@ -34,6 +34,7 @@ else
</CustomActions>
</PageHeader>
+ <PageContent>
<div class="grid grid-cols-1 px-4 md:grid-cols-2 lg:grid-cols-3 lg:gap-4 dark:bg-gray-900">
@* Left column *@
<div class="col-span-1 md:col-span-2 lg:col-span-1">
@@ -253,6 +254,7 @@ else
}
</div>
</div>
+ </PageContent>
<FormModal
IsOpen="ShowDeleteModal"
diff --git a/apps/server/AliasVault.Client/Main/Pages/Settings/Apps.razor b/apps/server/AliasVault.Client/Main/Pages/Settings/Apps.razor
index 2519a1b07..f8f33bd57 100644
--- a/apps/server/AliasVault.Client/Main/Pages/Settings/Apps.razor
+++ b/apps/server/AliasVault.Client/Main/Pages/Settings/Apps.razor
@@ -14,6 +14,7 @@
Description="@Localizer["PageDescription"]">
</PageHeader>
+<PageContent>
<div class="p-4 mb-4 mx-4 bg-white border border-gray-200 rounded-lg shadow-sm dark:border-gray-700 sm:p-6 dark:bg-gray-800">
<div class="mb-6">
<h3 class="text-lg font-medium text-gray-900 dark:text-white mb-2">@Localizer["BrowserExtensionsTitle"]</h3>
@@ -85,6 +86,7 @@
}
</div>
</div>
+</PageContent>
@code {
private IStringLocalizer Localizer => LocalizerFactory.Create("Pages.Main.Settings.Apps", "AliasVault.Client");
diff --git a/apps/server/AliasVault.Client/Main/Pages/Settings/General.razor b/apps/server/AliasVault.Client/Main/Pages/Settings/General.razor
index 0062457ba..897bed872 100644
--- a/apps/server/AliasVault.Client/Main/Pages/Settings/General.razor
+++ b/apps/server/AliasVault.Client/Main/Pages/Settings/General.razor
@@ -13,6 +13,7 @@
Description="@Localizer["PageDescription"]">
</PageHeader>
+<PageContent>
<div class="p-4 mb-4 mx-4 bg-white border border-gray-200 rounded-lg shadow-sm dark:border-gray-700 sm:p-6 dark:bg-gray-800">
<h3 class="mb-4 text-lg font-medium text-gray-900 dark:text-white">@Localizer["AppLanguageTitle"]</h3>
@@ -139,6 +140,7 @@
<DefaultPasswordSettings />
</div>
+</PageContent>
@code {
private IStringLocalizer Localizer => LocalizerFactory.Create("Pages.Main.Settings.General", "AliasVault.Client");
diff --git a/apps/server/AliasVault.Client/Main/Pages/Settings/ImportExport/ImportExport.razor b/apps/server/AliasVault.Client/Main/Pages/Settings/ImportExport/ImportExport.razor
index 0b35fa698..5a999b521 100644
--- a/apps/server/AliasVault.Client/Main/Pages/Settings/ImportExport/ImportExport.razor
+++ b/apps/server/AliasVault.Client/Main/Pages/Settings/ImportExport/ImportExport.razor
@@ -22,6 +22,7 @@
Description="@Localizer["PageDescription"]">
</PageHeader>
+<PageContent>
<div class="p-4 mx-4 mb-4 bg-white border border-gray-200 rounded-lg shadow-sm 2xl:col-span-2 dark:border-gray-700 sm:p-6 dark:bg-gray-800">
<h3 class="mb-4 text-xl font-semibold dark:text-white">@Localizer["ImportSectionTitle"]</h3>
<div class="mb-4 text-sm text-gray-500 dark:text-gray-400">
@@ -111,6 +112,7 @@
</div>
<ResetVaultSection />
+</PageContent>
<PasswordConfirmationModal
IsOpen="@_showPasswordConfirmation"
diff --git a/apps/server/AliasVault.Client/Main/Pages/Settings/Security/Security.razor b/apps/server/AliasVault.Client/Main/Pages/Settings/Security/Security.razor
index cdd10e7e2..10ece930e 100644
--- a/apps/server/AliasVault.Client/Main/Pages/Settings/Security/Security.razor
+++ b/apps/server/AliasVault.Client/Main/Pages/Settings/Security/Security.razor
@@ -14,12 +14,14 @@
</CustomActions>
</PageHeader>
-<PasswordChangeSection OnStatusChanged="LoadData" />
-<TwoFactorAuthenticationSection @ref="TwoFactorSection" OnStatusChanged="LoadData" />
-<QuickVaultUnlockSection @ref="QuickVaultUnlockSection" OnStatusChanged="LoadData" />
-<ActiveSessionsSection @ref="SessionsSection" OnSessionsChanged="LoadData" />
-<RecentAuthLogsSection @ref="RecentAuthLogsSection" OnSessionsChanged="LoadData" />
-<DeleteAccountSection />
+<PageContent>
+ <PasswordChangeSection OnStatusChanged="LoadData" />
+ <TwoFactorAuthenticationSection @ref="TwoFactorSection" OnStatusChanged="LoadData" />
+ <QuickVaultUnlockSection @ref="QuickVaultUnlockSection" OnStatusChanged="LoadData" />
+ <ActiveSessionsSection @ref="SessionsSection" OnSessionsChanged="LoadData" />
+ <RecentAuthLogsSection @ref="RecentAuthLogsSection" OnSessionsChanged="LoadData" />
+ <DeleteAccountSection />
+</PageContent>
@code {
private IStringLocalizer Localizer => LocalizerFactory.Create("Pages.Main.Settings.Security.Security", "AliasVault.Client");
diff --git a/apps/server/AliasVault.Client/Main/Pages/Settings/StorageInsights.razor b/apps/server/AliasVault.Client/Main/Pages/Settings/StorageInsights.razor
index a2d3bf647..ad08a65e0 100644
--- a/apps/server/AliasVault.Client/Main/Pages/Settings/StorageInsights.razor
+++ b/apps/server/AliasVault.Client/Main/Pages/Settings/StorageInsights.razor
@@ -16,6 +16,7 @@
Description="@Localizer["PageDescription"]">
</PageHeader>
+<PageContent>
@if (IsLoading)
{
<div class="p-4 mb-4 mx-4 bg-white border border-gray-200 rounded-lg shadow-sm dark:border-gray-700 sm:p-6 dark:bg-gray-800">
@@ -159,6 +160,7 @@ else
</div>
</div>
}
+</PageContent>
@code {
// Approximate per-row SQLite overhead in bytes. SQLite uses 4 KiB pages by default;
diff --git a/apps/server/AliasVault.Client/Main/Pages/Test/Test1.razor b/apps/server/AliasVault.Client/Main/Pages/Test/Test1.razor
index 8a3736b99..c1d14630f 100644
--- a/apps/server/AliasVault.Client/Main/Pages/Test/Test1.razor
+++ b/apps/server/AliasVault.Client/Main/Pages/Test/Test1.razor
@@ -10,14 +10,16 @@
Description="Test webapi call 1">
</PageHeader>
-@if (IsLoading)
-{
- <LoadingIndicator />
-}
-else
-{
- <p>Test 1 OK.</p>
-}
+<PageContent Class="px-4">
+ @if (IsLoading)
+ {
+ <LoadingIndicator />
+ }
+ else
+ {
+ <p>Test 1 OK.</p>
+ }
+</PageContent>
@code {
private bool IsLoading { get; set; } = true;
diff --git a/apps/server/AliasVault.Client/Main/Pages/Test/Test2.razor b/apps/server/AliasVault.Client/Main/Pages/Test/Test2.razor
index d8453fd63..6520b767b 100644
--- a/apps/server/AliasVault.Client/Main/Pages/Test/Test2.razor
+++ b/apps/server/AliasVault.Client/Main/Pages/Test/Test2.razor
@@ -10,14 +10,16 @@
Description="Test webapi call 2">
</PageHeader>
-@if (IsLoading)
-{
- <LoadingIndicator />
-}
-else
-{
- <p>Test 2 OK.</p>
-}
+<PageContent Class="px-4">
+ @if (IsLoading)
+ {
+ <LoadingIndicator />
+ }
+ else
+ {
+ <p>Test 2 OK.</p>
+ }
+</PageContent>
@code {
private bool IsLoading { get; set; } = true;
diff --git a/apps/server/Shared/AliasVault.RazorComponents/Layout/PageContent.razor b/apps/server/Shared/AliasVault.RazorComponents/Layout/PageContent.razor
new file mode 100644
index 000000000..33c198e57
--- /dev/null
+++ b/apps/server/Shared/AliasVault.RazorComponents/Layout/PageContent.razor
@@ -0,0 +1,19 @@
+<div class="min-h-[350px] @Class">
+ @ChildContent
+</div>
+
+@code {
+ /// <summary>
+ /// Gets or sets the content rendered inside the page body wrapper.
+ /// </summary>
+ [Parameter]
+ public RenderFragment? ChildContent { get; set; }
+
+ /// <summary>
+ /// Gets or sets additional CSS classes appended to the wrapper. Use this to apply
+ /// the page's own padding/margin (e.g. "px-4 mb-4") while the wrapper guarantees a
+ /// minimum height so header dropdowns and popovers don't get clipped on short pages.
+ /// </summary>
+ [Parameter]
+ public string Class { get; set; } = string.Empty;
+}