Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.
Make password field length slider visible in main item create/edit page (#2236)
Leendert de Borstd1243110e826
diff --git a/apps/server/AliasVault.Client/Main/Components/Forms/EditPasswordFormRow.razor b/apps/server/AliasVault.Client/Main/Components/Forms/EditPasswordFormRow.razorindex 263310269..f4642b051 100644--- a/apps/server/AliasVault.Client/Main/Components/Forms/EditPasswordFormRow.razor+++ b/apps/server/AliasVault.Client/Main/Components/Forms/EditPasswordFormRow.razor@@ -1,5 +1,8 @@+@using System.Globalization+@using Microsoft.Extensions.Localization@inject DbService DbService@inject ItemService ItemService+@inject IStringLocalizerFactory LocalizerFactory<label for="@Id" class="block mb-2 text-sm font-medium text-gray-900 dark:text-white">@Label</label><div class="flex">@@ -22,7 +25,7 @@</button>@if (ShowGenerateButtons){- <button type="button" class="px-3 text-gray-500 dark:text-white bg-gray-200 hover:bg-gray-300 focus:ring-4 focus:outline-none focus:ring-gray-300 font-medium text-sm border-l border-gray-300 dark:border-gray-700 dark:bg-gray-600 dark:hover:bg-gray-700 dark:focus:ring-gray-800" @onclick="ShowPasswordSettings">+ <button type="button" id="@($"{Id}-generator-settings")" class="px-3 text-gray-500 dark:text-white bg-gray-200 hover:bg-gray-300 focus:ring-4 focus:outline-none focus:ring-gray-300 font-medium text-sm border-l border-gray-300 dark:border-gray-700 dark:bg-gray-600 dark:hover:bg-gray-700 dark:focus:ring-gray-800" @onclick="ShowPasswordSettings"><svg class="w-5 h-5" fill="none" stroke="currentColor" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M10.325 4.317c.426-1.756 2.924-1.756 3.35 0a1.724 1.724 0 002.573 1.066c1.543-.94 3.31.826 2.37 2.37a1.724 1.724 0 001.065 2.572c1.756.426 1.756 2.924 0 3.35a1.724 1.724 0 00-1.066 2.573c.94 1.543-.826 3.31-2.37 2.37a1.724 1.724 0 00-2.572 1.065c-.426 1.756-2.924 1.756-3.35 0a1.724 1.724 0 00-2.573-1.066c-1.543.94-3.31-.826-2.37-2.37a1.724 1.724 0 00-1.065-2.572c-1.756-.426-1.756-2.924 0-3.35a1.724 1.724 0 001.066-2.573c-.94-1.543.826-3.31 2.37-2.37.996.608 2.296.07 2.572-1.065z"></path><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M15 12a3 3 0 11-6 0 3 3 0 016 0z"></path>@@ -37,6 +40,36 @@</div></div>+@if (ShowGenerateButtons)+{+ @* Inline length / word-count slider, mirroring the browser extension and mobile app so the most-used+ generator control is available directly below the field without having to open the settings popup.+ Reuses the PasswordSettingsPopup resource strings so no new translations are needed. *@+ <div class="pt-2">+ <div class="flex items-center justify-between mb-1">+ <label for="@($"{Id}-inline-length")" class="text-sm font-medium text-gray-700 dark:text-gray-300">+ @(IsDiceware ? Localizer["WordCountLabel"] : string.Format(CultureInfo.CurrentCulture, Localizer["PasswordLengthLabel"], _internalPasswordSettings.Length))+ </label>+ @if (IsDiceware)+ {+ <span class="text-sm text-gray-600 dark:text-gray-400 font-mono">@_internalPasswordSettings.WordCount</span>+ }+ </div>+ @if (IsDiceware)+ {+ <input type="range" id="@($"{Id}-inline-length")" min="@MinWordCount" max="@MaxWordCount" step="1"+ class="w-full h-2 bg-gray-200 rounded-lg appearance-none cursor-pointer dark:bg-gray-700 av-range-slider"+ value="@_internalPasswordSettings.WordCount" @oninput="HandleWordCountInput">+ }+ else+ {+ <input type="range" id="@($"{Id}-inline-length")" min="@PasswordLengthSlider.SliderMin.ToString(CultureInfo.InvariantCulture)" max="@PasswordLengthSlider.SliderMax.ToString(CultureInfo.InvariantCulture)" step="0.1"+ class="w-full h-2 bg-gray-200 rounded-lg appearance-none cursor-pointer dark:bg-gray-700 av-range-slider"+ value="@_sliderValue.ToString(CultureInfo.InvariantCulture)" @oninput="HandleLengthInput">+ }+ </div>+}+@if (IsPasswordSettingsVisible){<PasswordSettingsPopup@@ -47,6 +80,14 @@}@code {+ private IStringLocalizer Localizer => LocalizerFactory.Create("Components.Main.Settings.PasswordSettingsPopup", "AliasVault.Client");++ /// <summary>+ /// Inclusive bounds for the Diceware word-count slider.+ /// </summary>+ private const int MinWordCount = AliasClientDb.Models.PasswordGeneratorDefaults.MinWordCount;+ private const int MaxWordCount = AliasClientDb.Models.PasswordGeneratorDefaults.MaxWordCount;+/// <summary>/// Id for the input field./// </summary>@@ -105,17 +146,28 @@/// </summary>private PasswordSettings _internalPasswordSettings = new();+ /// <summary>+ /// The non-linear slider position (0-100) backing the inline password-length slider.+ /// </summary>+ private double _sliderValue;+/// <summary>/// Whether the component has been initialized./// </summary>private bool _hasInitialized;+ /// <summary>+ /// Gets a value indicating whether the Diceware (passphrase) generator is currently selected.+ /// </summary>+ private bool IsDiceware => _internalPasswordSettings.Type == "diceware";+/// <inheritdoc />protected override async Task OnInitializedAsync(){await base.OnInitializedAsync();_internalShowPassword = ShowPassword;_internalPasswordSettings = DbService.Settings.PasswordSettings;+ _sliderValue = PasswordLengthSlider.LengthToSlider(_internalPasswordSettings.Length);}/// <inheritdoc />@@ -179,11 +231,47 @@private async Task HandlePasswordSettingsSaved((PasswordSettings settings, string generatedPassword) args){_internalPasswordSettings = args.settings;+ _sliderValue = PasswordLengthSlider.LengthToSlider(_internalPasswordSettings.Length);_internalShowPassword = true;Value = args.generatedPassword;await ValueChanged.InvokeAsync(Value);}+ /// <summary>+ /// Handle input from the inline password-length slider: update the length and regenerate the password.+ /// </summary>+ private async Task HandleLengthInput(ChangeEventArgs e)+ {+ if (double.TryParse(e.Value?.ToString(), NumberStyles.Float, CultureInfo.InvariantCulture, out var sliderValue))+ {+ _sliderValue = sliderValue;+ _internalPasswordSettings.Length = PasswordLengthSlider.SliderToLength(sliderValue);+ await RegenerateFromSlider();+ }+ }++ /// <summary>+ /// Handle input from the inline Diceware word-count slider: update the word count and regenerate the passphrase.+ /// </summary>+ private async Task HandleWordCountInput(ChangeEventArgs e)+ {+ if (int.TryParse(e.Value?.ToString(), NumberStyles.Integer, CultureInfo.InvariantCulture, out var wordCount))+ {+ _internalPasswordSettings.WordCount = wordCount;+ await RegenerateFromSlider();+ }+ }++ /// <summary>+ /// Regenerate the password from the current inline settings and surface it in the field.+ /// </summary>+ private async Task RegenerateFromSlider()+ {+ Value = await ItemService.GenerateRandomPasswordAsync(_internalPasswordSettings);+ _internalShowPassword = true;+ await ValueChanged.InvokeAsync(Value);+ }+/// <summary>/// Generates a new password./// </summary>diff --git a/apps/server/AliasVault.Client/Main/Components/Settings/PasswordSettingsPopup.razor b/apps/server/AliasVault.Client/Main/Components/Settings/PasswordSettingsPopup.razorindex ea85008e6..05fc017df 100644--- a/apps/server/AliasVault.Client/Main/Components/Settings/PasswordSettingsPopup.razor+++ b/apps/server/AliasVault.Client/Main/Components/Settings/PasswordSettingsPopup.razor@@ -43,7 +43,7 @@<div><label for="password-length" class="block text-sm font-medium text-gray-700 dark:text-gray-300">@string.Format(CultureInfo.CurrentCulture, Localizer["PasswordLengthLabel"], _workingSettings.Length)</label><input type="range" id="password-length" min="@PasswordLengthSlider.SliderMin.ToString(CultureInfo.InvariantCulture)" max="@PasswordLengthSlider.SliderMax.ToString(CultureInfo.InvariantCulture)" step="0.1"- class="mt-1 w-full h-2 bg-gray-200 rounded-lg appearance-none cursor-pointer dark:bg-gray-700"+ class="mt-1 w-full h-2 bg-gray-200 rounded-lg appearance-none cursor-pointer dark:bg-gray-700 av-range-slider"value="@_sliderValue.ToString(CultureInfo.InvariantCulture)" @oninput="HandleLengthInput"></div>@@ -77,7 +77,7 @@<span class="text-sm text-gray-600 dark:text-gray-400 font-mono">@_workingSettings.WordCount</span></div><input type="range" id="diceware-word-count" min="@MinWordCount" max="@MaxWordCount" step="1"- class="w-full h-2 bg-gray-200 rounded-lg appearance-none cursor-pointer dark:bg-gray-700"+ class="w-full h-2 bg-gray-200 rounded-lg appearance-none cursor-pointer dark:bg-gray-700 av-range-slider"value="@_workingSettings.WordCount" @oninput="HandleWordCountInput"></div>diff --git a/apps/server/AliasVault.Client/wwwroot/css/app.css b/apps/server/AliasVault.Client/wwwroot/css/app.cssindex eec95528b..a423998d0 100644--- a/apps/server/AliasVault.Client/wwwroot/css/app.css+++ b/apps/server/AliasVault.Client/wwwroot/css/app.css@@ -35,3 +35,24 @@.pb-safe {padding-bottom: env(safe-area-inset-bottom);}++.av-range-slider::-webkit-slider-thumb {+ -webkit-appearance: none;+ appearance: none;+ width: 16px;+ height: 16px;+ border-radius: 50%;+ background: #d68338;+ cursor: pointer;+ box-shadow: 0 2px 4px rgba(0, 0, 0, 0.2);+}++.av-range-slider::-moz-range-thumb {+ width: 16px;+ height: 16px;+ border: none;+ border-radius: 50%;+ background: #d68338;+ cursor: pointer;+ box-shadow: 0 2px 4px rgba(0, 0, 0, 0.2);+}diff --git a/apps/server/AliasVault.Client/wwwroot/css/tailwind.css b/apps/server/AliasVault.Client/wwwroot/css/tailwind.cssindex 4d58ddec3..65be67da4 100644--- a/apps/server/AliasVault.Client/wwwroot/css/tailwind.css+++ b/apps/server/AliasVault.Client/wwwroot/css/tailwind.css@@ -2361,6 +2361,10 @@ video {padding-top: 2rem;}+.pt-2 {+ padding-top: 0.5rem;+}+.text-left {text-align: left;}@@ -2680,6 +2684,11 @@ video {color: rgb(133 77 14 / var(--tw-text-opacity));}+.text-amber-500 {+ --tw-text-opacity: 1;+ color: rgb(245 158 11 / var(--tw-text-opacity));+}+.underline {text-decoration-line: underline;}diff --git a/apps/server/Tests/AliasVault.E2ETests/Tests/Client/Shard1/PasswordGeneratorSettingsTests.cs b/apps/server/Tests/AliasVault.E2ETests/Tests/Client/Shard1/PasswordGeneratorSettingsTests.csnew file mode 100644index 000000000..a723bed0d--- /dev/null+++ b/apps/server/Tests/AliasVault.E2ETests/Tests/Client/Shard1/PasswordGeneratorSettingsTests.cs@@ -0,0 +1,85 @@+//-----------------------------------------------------------------------+// <copyright file="PasswordGeneratorSettingsTests.cs" company="aliasvault">+// Copyright (c) aliasvault. All rights reserved.+// Licensed under the AGPLv3 license. See LICENSE.md file in the project root for full license information.+// </copyright>+//-----------------------------------------------------------------------++namespace AliasVault.E2ETests.Tests.Client.Shard1;++/// <summary>+/// End-to-end tests for the password generator UI (inline slider on the item edit form and the+/// advanced settings popup).+/// </summary>+[TestFixture]+[Category("ClientTests")]+[Parallelizable(ParallelScope.Self)]+public class PasswordGeneratorSettingsTests : ClientPlaywrightTest+{+ /// <summary>+ /// Tests that the inline generator slider appears directly below the password field on the item+ /// edit form, showing the character-length slider for the basic generator and the word-count slider+ /// after switching to the Diceware (passphrase) generator. This mirrors the browser extension and+ /// mobile app, where the slider is available inline without opening the settings popup.+ /// </summary>+ /// <returns>Async task.</returns>+ [Test]+ public async Task InlineLengthSliderVisibleForBothGeneratorTypes()+ {+ await NavigateUsingBlazorRouter("items/create");+ await WaitForUrlAsync("items/create", "Add Item");++ // The basic generator is the default: the inline slider must be the character-length slider (0-100).+ var inlineSlider = Page.Locator("#password-inline-length");+ await inlineSlider.WaitForAsync(new() { State = WaitForSelectorState.Visible, Timeout = TestDefaults.DefaultTimeout });+ Assert.That(await inlineSlider.IsVisibleAsync(), Is.True, "Inline password length slider not visible below the password field.");+ Assert.That(await inlineSlider.GetAttributeAsync("min"), Is.EqualTo("0"), "Inline slider is not the character-length slider in basic mode.");++ // Open the generator settings popup and switch to the Passphrase (Diceware) generator for this field only.+ await Page.Locator("#password-generator-settings").ClickAsync();+ await Page.WaitForSelectorAsync("#passwordSettingsModal", new() { State = WaitForSelectorState.Visible, Timeout = TestDefaults.DefaultTimeout });+ await Page.Locator("#passwordSettingsModal button:text-is('Passphrase')").ClickAsync();+ await Page.Locator("#passwordSettingsModal button:has-text('Use Just Once')").ClickAsync();++ // The inline slider must now be the Diceware word-count slider (3-10).+ await inlineSlider.WaitForAsync(new() { State = WaitForSelectorState.Visible, Timeout = TestDefaults.DefaultTimeout });+ Assert.That(await inlineSlider.IsVisibleAsync(), Is.True, "Inline slider not visible after switching to passphrase generator.");+ Assert.That(await inlineSlider.GetAttributeAsync("min"), Is.EqualTo("3"), "Inline slider is not the word-count slider in passphrase mode.");+ }++ /// <summary>+ /// Tests that the advanced settings popup shows the correct length slider for each generator type:+ /// the character-length slider in "Password" (basic) mode and the word-count slider in "Passphrase"+ /// (Diceware) mode.+ /// </summary>+ /// <returns>Async task.</returns>+ [Test]+ public async Task PopupLengthSliderVisibleForBothGeneratorTypes()+ {+ await NavigateUsingBlazorRouter("settings/general");+ await WaitForUrlAsync("settings/general", "Configure general");++ // Open the password generator settings popup.+ await Page.Locator("#password-generator-settings-modal").ClickAsync();+ await Page.WaitForSelectorAsync("#passwordSettingsModal", new() { State = WaitForSelectorState.Visible, Timeout = TestDefaults.DefaultTimeout });++ // The "Password" (basic) generator is selected by default: the character-length slider must be visible.+ var lengthSlider = Page.Locator("#password-length");+ await lengthSlider.WaitForAsync(new() { State = WaitForSelectorState.Visible, Timeout = TestDefaults.DefaultTimeout });+ Assert.That(await lengthSlider.IsVisibleAsync(), Is.True, "Password length slider not visible in basic password mode.");++ // Switch to the "Passphrase" (Diceware) tab.+ await Page.Locator("#passwordSettingsModal button:text-is('Passphrase')").ClickAsync();++ // In Diceware mode the word-count slider must be visible and the basic length slider must be gone.+ var wordCountSlider = Page.Locator("#diceware-word-count");+ await wordCountSlider.WaitForAsync(new() { State = WaitForSelectorState.Visible, Timeout = TestDefaults.DefaultTimeout });+ Assert.That(await wordCountSlider.IsVisibleAsync(), Is.True, "Diceware word count slider not visible in passphrase mode.");+ Assert.That(await lengthSlider.CountAsync(), Is.EqualTo(0), "Password length slider should be hidden in passphrase mode.");++ // Switch back to the "Password" (basic) tab: the character-length slider must reappear.+ await Page.Locator("#passwordSettingsModal button:text-is('Password')").ClickAsync();+ await lengthSlider.WaitForAsync(new() { State = WaitForSelectorState.Visible, Timeout = TestDefaults.DefaultTimeout });+ Assert.That(await lengthSlider.IsVisibleAsync(), Is.True, "Password length slider not visible after switching back to basic mode.");+ }+}