Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Update mobile app minimum PIN length from 4 to 6 digits (#2530)

Leendert de Borstd3aba182231f
diff --git a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/pinunlock/PinUnlockActivity.kt b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/pinunlock/PinUnlockActivity.kt
index 90e26153f..560e61378 100644
--- a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/pinunlock/PinUnlockActivity.kt
+++ b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/pinunlock/PinUnlockActivity.kt
@@ -316,7 +316,7 @@ class PinUnlockActivity : AppCompatActivity() {
private fun updatePinText() {
pinTextView.text = if (currentPin.isEmpty()) {
- "----"
+ "------"
} else {
"•".repeat(currentPin.length)
}
@@ -325,8 +325,8 @@ class PinUnlockActivity : AppCompatActivity() {
private fun updateContinueButtonState() {
val config = configuration ?: return
if (continueButton.visibility == View.VISIBLE) {
- // Enable button only if PIN is at least 4 digits
- val isEnabled = currentPin.length >= 4
+ // Enable button only if PIN is at least 6 digits
+ val isEnabled = currentPin.length >= 6
continueButton.isEnabled = isEnabled
// Animate button scale and alpha based on enabled state
@@ -405,9 +405,9 @@ class PinUnlockActivity : AppCompatActivity() {
// Validate minimum length for setup mode
if (config.mode == PinMode.SETUP &&
config.setupStep == PinSetupStep.ENTER_NEW &&
- currentPin.length < 4
+ currentPin.length < 6
) {
- return // Don't submit until at least 4 digits
+ return // Don't submit until at least 6 digits
}
CoroutineScope(Dispatchers.Main).launch {
diff --git a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/pinunlock/PinViewModel.kt b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/pinunlock/PinViewModel.kt
index dbc9383bd..49de53e2e 100644
--- a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/pinunlock/PinViewModel.kt
+++ b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/pinunlock/PinViewModel.kt
@@ -42,7 +42,7 @@ class PinViewModel(
mode = PinMode.SETUP,
title = customTitle ?: context.getString(R.string.pin_setup_title),
subtitle = customSubtitle ?: context.getString(R.string.pin_setup_description),
- pinLength = null, // Allow any length from 4-8
+ pinLength = null, // Allow any length from 6-8
setupStep = PinSetupStep.ENTER_NEW,
)
}
@@ -96,9 +96,9 @@ class PinViewModel(
return when (configuration.setupStep) {
PinSetupStep.ENTER_NEW -> {
// Validate PIN length
- if (pin.length < 4) {
+ if (pin.length < 6) {
return PinResult.Error(
- "PIN must be at least 4 digits",
+ "PIN must be at least 6 digits",
shouldClear = false,
)
}
diff --git a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/VaultPin.kt b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/VaultPin.kt
index 6c563b56f..a7b9e1717 100644
--- a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/VaultPin.kt
+++ b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/VaultPin.kt
@@ -127,7 +127,7 @@ class VaultPin(
* Encrypt the Account Key with a key derived from the PIN and keep it in secure storage.
*
* @param accountKey The Account Key to protect
- * @param pin The PIN to set (4+ digits)
+ * @param pin The PIN to set (6+ digits; older 4-digit PINs are still accepted when re-encrypted)
* @throws Exception if encryption or storage fails
*/
@Throws(Exception::class)
diff --git a/apps/mobile-app/android/app/src/main/res/layout/activity_pin_unlock.xml b/apps/mobile-app/android/app/src/main/res/layout/activity_pin_unlock.xml
index 2382b42a2..c10932238 100644
--- a/apps/mobile-app/android/app/src/main/res/layout/activity_pin_unlock.xml
+++ b/apps/mobile-app/android/app/src/main/res/layout/activity_pin_unlock.xml
@@ -81,7 +81,7 @@
android:id="@+id/pinTextView"
android:layout_width="wrap_content"
android:layout_height="44dp"
- android:text="----"
+ android:text="------"
android:textSize="38sp"
android:textStyle="bold"
android:textColor="?android:attr/textColorPrimary"
diff --git a/apps/mobile-app/ios/VaultStoreKit/VaultStore+Pin.swift b/apps/mobile-app/ios/VaultStoreKit/VaultStore+Pin.swift
index b514e8f6e..0c6955ed3 100644
--- a/apps/mobile-app/ios/VaultStoreKit/VaultStore+Pin.swift
+++ b/apps/mobile-app/ios/VaultStoreKit/VaultStore+Pin.swift
@@ -41,7 +41,7 @@ extension VaultStore {
/// The encryption key is retrieved internally and never exposed to React Native layer
///
/// - Parameters:
- /// - pin: The PIN to set (4+ digits)
+ /// - pin: The PIN to set (6+ digits; older 4-digit PINs are still accepted when re-encrypted)
/// - Throws: Error if PIN is invalid, vault not unlocked, encryption fails, or keystore unavailable
public func setupPin(_ pin: String) throws {
// Check if keystore is available (device passcode must be set)
diff --git a/apps/mobile-app/ios/VaultUI/Auth/PinSetupView.swift b/apps/mobile-app/ios/VaultUI/Auth/PinSetupView.swift
index 51b4cc63f..75cb9fca6 100644
--- a/apps/mobile-app/ios/VaultUI/Auth/PinSetupView.swift
+++ b/apps/mobile-app/ios/VaultUI/Auth/PinSetupView.swift
@@ -78,7 +78,7 @@ public struct PinSetupView: View {
.padding(.bottom, 20)
} else {
// Enter new step: show bullet points for variable length
- Text(viewModel.pin.isEmpty ? "----" : String(repeating: "•", count: viewModel.pin.count))
+ Text(viewModel.pin.isEmpty ? "------" : String(repeating: "•", count: viewModel.pin.count))
.font(.system(size: 38, weight: .semibold))
.foregroundColor(colors.text)
.kerning(6)
diff --git a/apps/mobile-app/ios/VaultUI/Auth/PinSetupViewModel.swift b/apps/mobile-app/ios/VaultUI/Auth/PinSetupViewModel.swift
index 73c831b01..ef75657ed 100644
--- a/apps/mobile-app/ios/VaultUI/Auth/PinSetupViewModel.swift
+++ b/apps/mobile-app/ios/VaultUI/Auth/PinSetupViewModel.swift
@@ -15,7 +15,7 @@ public struct PinSetupConfiguration {
public let step: Step
public let title: String
public let subtitle: String
- public let pinLength: Int? // nil = variable length (4-8 digits)
+ public let pinLength: Int? // nil = variable length (6-8 digits)
public let firstStepPin: String? // Pin from first step (used in confirm step)
public init(step: Step, title: String, subtitle: String, pinLength: Int?, firstStepPin: String? = nil) {
@@ -90,8 +90,8 @@ public class PinSetupViewModel: ObservableObject {
public func submitPin() async {
// Validate minimum length for setup mode
- if configuration.step == .enterNew && pin.count < 4 {
- return // Don't submit until at least 4 digits
+ if configuration.step == .enterNew && pin.count < 6 {
+ return // Don't submit until at least 6 digits
}
isProcessing = true
@@ -168,7 +168,7 @@ public class PinSetupViewModel: ObservableObject {
public var canSubmit: Bool {
switch configuration.step {
case .enterNew:
- return pin.count >= 4 && pin.count <= 8
+ return pin.count >= 6 && pin.count <= 8
case .confirm:
return pin.count == configuration.pinLength
}
diff --git a/apps/mobile-app/ios/VaultUI/Auth/PinUnlockView.swift b/apps/mobile-app/ios/VaultUI/Auth/PinUnlockView.swift
index 74a173971..df5cd8063 100644
--- a/apps/mobile-app/ios/VaultUI/Auth/PinUnlockView.swift
+++ b/apps/mobile-app/ios/VaultUI/Auth/PinUnlockView.swift
@@ -78,7 +78,7 @@ public struct PinUnlockView: View {
.padding(.bottom, 20)
} else {
// For variable length, show bullet points
- Text(viewModel.pin.isEmpty ? "----" : String(repeating: "•", count: viewModel.pin.count))
+ Text(viewModel.pin.isEmpty ? "------" : String(repeating: "•", count: viewModel.pin.count))
.font(.system(size: 38, weight: .semibold))
.foregroundColor(colors.text)
.kerning(6)