Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.
Update migrations to restore child manifest trigger after ItemTag table recreation (#2159)
Leendert de Borstd784498ac797
diff --git a/apps/server/Databases/AliasClientDb/Migrations/20260809201914_2.1.1-ItemChildManifestTrigger.cs b/apps/server/Databases/AliasClientDb/Migrations/20260809201914_2.1.1-ItemChildManifestTrigger.csindex 1d67f967f..01645e689 100644--- a/apps/server/Databases/AliasClientDb/Migrations/20260809201914_2.1.1-ItemChildManifestTrigger.cs+++ b/apps/server/Databases/AliasClientDb/Migrations/20260809201914_2.1.1-ItemChildManifestTrigger.cs@@ -8,16 +8,6 @@ namespace AliasClientDb.Migrations/// <inheritdoc />public partial class _211ItemChildManifestTrigger : Migration{- /// <summary>- /// The tables whose rows are owned by an item through an ItemId foreign key.- /// </summary>- private static readonly string[] ItemIdChildTables = ["FieldValues", "FieldHistories", "ItemTags", "Attachments", "Passkeys", "TotpCodes"];-- /// <summary>- /// Name of the trigger that keeps item-scoped rows stamped with their item's manifest.- /// </summary>- private const string TriggerName = "TR_Items_ResyncChildManifestIds";-/// <inheritdoc />protected override void Up(MigrationBuilder migrationBuilder){@@ -28,28 +18,13 @@ namespace AliasClientDb.Migrations* every local read until the next push heals it server-side. This trigger ensures all clients that* use this sqlite structure will automatically re-stamp when an item is moved between manifests.*/- var body = new System.Text.StringBuilder();- foreach (var table in ItemIdChildTables)- {- body.AppendLine($" UPDATE \"{table}\" SET \"ManifestId\" = NEW.\"ManifestId\" WHERE \"ItemId\" = NEW.\"Id\" AND \"ManifestId\" = OLD.\"ManifestId\";");- }-- body.AppendLine($" UPDATE \"ItemStats\" SET \"ManifestId\" = NEW.\"ManifestId\" WHERE \"Id\" = NEW.\"Id\" AND \"ManifestId\" = OLD.\"ManifestId\";");-- migrationBuilder.Sql($"""- CREATE TRIGGER IF NOT EXISTS "{TriggerName}"- AFTER UPDATE OF "ManifestId" ON "Items"- FOR EACH ROW WHEN OLD."ManifestId" <> NEW."ManifestId"- BEGIN- {body.ToString().TrimEnd()}- END;- """);+ migrationBuilder.Sql(ItemChildManifestTriggerSql.Create);}/// <inheritdoc />protected override void Down(MigrationBuilder migrationBuilder){- migrationBuilder.Sql($"DROP TRIGGER IF EXISTS \"{TriggerName}\";");+ migrationBuilder.Sql(ItemChildManifestTriggerSql.Drop);}}}diff --git a/apps/server/Databases/AliasClientDb/Migrations/20260827095516_2.1.6-ItemTagKeyedByItemAndTag.cs b/apps/server/Databases/AliasClientDb/Migrations/20260827095516_2.1.6-ItemTagKeyedByItemAndTag.csindex c28be5d84..a5600503c 100644--- a/apps/server/Databases/AliasClientDb/Migrations/20260827095516_2.1.6-ItemTagKeyedByItemAndTag.cs+++ b/apps/server/Databases/AliasClientDb/Migrations/20260827095516_2.1.6-ItemTagKeyedByItemAndTag.cs@@ -12,6 +12,9 @@ namespace AliasClientDb.Migrations/// <inheritdoc />protected override void Up(MigrationBuilder migrationBuilder){+ // Drop the ItemTags trigges in order to rebuild the table with the new primary key, afterwards in next migration we add it back.+ migrationBuilder.Sql(ItemChildManifestTriggerSql.Drop);+migrationBuilder.DropPrimaryKey(name: "PK_ItemTags",table: "ItemTags");@@ -33,6 +36,8 @@ namespace AliasClientDb.Migrations/// <inheritdoc />protected override void Down(MigrationBuilder migrationBuilder){+ migrationBuilder.Sql(ItemChildManifestTriggerSql.Drop);+migrationBuilder.DropPrimaryKey(name: "PK_ItemTags",table: "ItemTags");diff --git a/apps/server/Databases/AliasClientDb/Migrations/20260829082058_2.1.7-RestoreItemChildManifestTrigger.Designer.cs b/apps/server/Databases/AliasClientDb/Migrations/20260829082058_2.1.7-RestoreItemChildManifestTrigger.Designer.csnew file mode 100644index 000000000..2b9acfe89--- /dev/null+++ b/apps/server/Databases/AliasClientDb/Migrations/20260829082058_2.1.7-RestoreItemChildManifestTrigger.Designer.cs@@ -0,0 +1,821 @@+// <auto-generated />+using System;+using AliasClientDb;+using Microsoft.EntityFrameworkCore;+using Microsoft.EntityFrameworkCore.Infrastructure;+using Microsoft.EntityFrameworkCore.Migrations;+using Microsoft.EntityFrameworkCore.Storage.ValueConversion;++#nullable disable++namespace AliasClientDb.Migrations+{+ [DbContext(typeof(AliasClientDbContext))]+ [Migration("20260829082058_2.1.7-RestoreItemChildManifestTrigger")]+ partial class _217RestoreItemChildManifestTrigger+ {+ /// <inheritdoc />+ protected override void BuildTargetModel(ModelBuilder modelBuilder)+ {+#pragma warning disable 612, 618+ modelBuilder+ .HasAnnotation("ProductVersion", "10.0.10")+ .HasAnnotation("Proxies:ChangeTracking", false)+ .HasAnnotation("Proxies:CheckEquality", false)+ .HasAnnotation("Proxies:LazyLoading", true);++ modelBuilder.Entity("AliasClientDb.Attachment", b =>+ {+ b.Property<Guid>("ManifestId")+ .HasColumnType("TEXT");++ b.Property<Guid>("Id")+ .HasColumnType("TEXT");++ b.Property<byte[]>("Blob")+ .IsRequired()+ .HasColumnType("BLOB");++ b.Property<DateTime>("CreatedAt")+ .HasColumnType("TEXT");++ b.Property<string>("Filename")+ .IsRequired()+ .HasMaxLength(255)+ .HasColumnType("TEXT");++ b.Property<bool>("IsDeleted")+ .HasColumnType("INTEGER");++ b.Property<Guid>("ItemId")+ .HasColumnType("TEXT");++ b.Property<DateTime>("UpdatedAt")+ .HasColumnType("TEXT");++ b.HasKey("ManifestId", "Id");++ b.HasIndex("ManifestId", "ItemId");++ b.ToTable("Attachments");+ });++ modelBuilder.Entity("AliasClientDb.CodecOverflow", b =>+ {+ b.Property<Guid>("Id")+ .ValueGeneratedOnAdd()+ .HasColumnType("TEXT");++ b.Property<string>("Data")+ .IsRequired()+ .HasColumnType("TEXT");++ b.HasKey("Id");++ b.ToTable("CodecOverflows");+ });++ modelBuilder.Entity("AliasClientDb.EncryptionKey", b =>+ {+ b.Property<Guid>("ManifestId")+ .HasColumnType("TEXT");++ b.Property<Guid>("Id")+ .HasColumnType("TEXT");++ b.Property<DateTime>("CreatedAt")+ .HasColumnType("TEXT");++ b.Property<bool>("IsDeleted")+ .HasColumnType("INTEGER");++ b.Property<bool>("IsPrimary")+ .HasColumnType("INTEGER");++ b.Property<string>("PrivateKey")+ .IsRequired()+ .HasMaxLength(2000)+ .HasColumnType("TEXT");++ b.Property<string>("PublicKey")+ .IsRequired()+ .HasMaxLength(2000)+ .HasColumnType("TEXT");++ b.Property<DateTime>("UpdatedAt")+ .HasColumnType("TEXT");++ b.HasKey("ManifestId", "Id");++ b.HasIndex("ManifestId", "IsPrimary");++ b.ToTable("EncryptionKeys");+ });++ modelBuilder.Entity("AliasClientDb.FieldDefinition", b =>+ {+ b.Property<Guid>("ManifestId")+ .HasColumnType("TEXT");++ b.Property<Guid>("Id")+ .HasColumnType("TEXT");++ b.Property<string>("ApplicableToTypes")+ .HasColumnType("TEXT");++ b.Property<DateTime>("CreatedAt")+ .HasColumnType("TEXT");++ b.Property<bool>("EnableHistory")+ .HasColumnType("INTEGER");++ b.Property<string>("FieldType")+ .IsRequired()+ .HasMaxLength(50)+ .HasColumnType("TEXT");++ b.Property<bool>("IsDeleted")+ .HasColumnType("INTEGER");++ b.Property<bool>("IsHidden")+ .HasColumnType("INTEGER");++ b.Property<bool>("IsMultiValue")+ .HasColumnType("INTEGER");++ b.Property<string>("Label")+ .IsRequired()+ .HasMaxLength(255)+ .HasColumnType("TEXT");++ b.Property<DateTime>("UpdatedAt")+ .HasColumnType("TEXT");++ b.Property<int>("Weight")+ .HasColumnType("INTEGER");++ b.HasKey("ManifestId", "Id");++ b.ToTable("FieldDefinitions");+ });++ modelBuilder.Entity("AliasClientDb.FieldHistory", b =>+ {+ b.Property<Guid>("ManifestId")+ .HasColumnType("TEXT");++ b.Property<Guid>("Id")+ .HasColumnType("TEXT");++ b.Property<DateTime>("ChangedAt")+ .HasColumnType("TEXT");++ b.Property<DateTime>("CreatedAt")+ .HasColumnType("TEXT");++ b.Property<Guid?>("FieldDefinitionId")+ .HasColumnType("TEXT");++ b.Property<string>("FieldKey")+ .HasMaxLength(100)+ .HasColumnType("TEXT");++ b.Property<bool>("IsDeleted")+ .HasColumnType("INTEGER");++ b.Property<Guid>("ItemId")+ .HasColumnType("TEXT");++ b.Property<DateTime>("UpdatedAt")+ .HasColumnType("TEXT");++ b.Property<string>("ValueSnapshot")+ .IsRequired()+ .HasColumnType("TEXT");++ b.HasKey("ManifestId", "Id");++ b.HasIndex("FieldDefinitionId");++ b.HasIndex("ItemId");++ b.HasIndex("ManifestId", "FieldDefinitionId");++ b.HasIndex("ManifestId", "ItemId");++ b.ToTable("FieldHistories");+ });++ modelBuilder.Entity("AliasClientDb.FieldValue", b =>+ {+ b.Property<Guid>("ManifestId")+ .HasColumnType("TEXT");++ b.Property<Guid>("Id")+ .HasColumnType("TEXT");++ b.Property<DateTime>("CreatedAt")+ .HasColumnType("TEXT");++ b.Property<Guid?>("FieldDefinitionId")+ .HasColumnType("TEXT");++ b.Property<string>("FieldKey")+ .HasMaxLength(100)+ .HasColumnType("TEXT");++ b.Property<bool>("IsDeleted")+ .HasColumnType("INTEGER");++ b.Property<bool>("IsDisabled")+ .HasColumnType("INTEGER");++ b.Property<Guid>("ItemId")+ .HasColumnType("TEXT");++ b.Property<DateTime>("UpdatedAt")+ .HasColumnType("TEXT");++ b.Property<string>("Value")+ .HasColumnType("TEXT");++ b.Property<int>("ValueIndex")+ .HasColumnType("INTEGER");++ b.Property<int>("Weight")+ .HasColumnType("INTEGER");++ b.HasKey("ManifestId", "Id");++ b.HasIndex("FieldDefinitionId");++ b.HasIndex("FieldKey");++ b.HasIndex("ItemId");++ b.HasIndex("ItemId", "FieldKey");++ b.HasIndex("ManifestId", "FieldDefinitionId");++ b.HasIndex("ManifestId", "ItemId");++ b.HasIndex("ItemId", "FieldDefinitionId", "Weight");++ b.ToTable("FieldValues");+ });++ modelBuilder.Entity("AliasClientDb.Folder", b =>+ {+ b.Property<Guid>("ManifestId")+ .HasColumnType("TEXT");++ b.Property<Guid>("Id")+ .HasColumnType("TEXT");++ b.Property<DateTime>("CreatedAt")+ .HasColumnType("TEXT");++ b.Property<bool>("IsDeleted")+ .HasColumnType("INTEGER");++ b.Property<string>("Name")+ .IsRequired()+ .HasMaxLength(255)+ .HasColumnType("TEXT");++ b.Property<Guid?>("ParentFolderId")+ .HasColumnType("TEXT");++ b.Property<DateTime>("UpdatedAt")+ .HasColumnType("TEXT");++ b.Property<int>("Weight")+ .HasColumnType("INTEGER");++ b.HasKey("ManifestId", "Id");++ b.HasIndex("ParentFolderId");++ b.HasIndex("ManifestId", "ParentFolderId");++ b.ToTable("Folders");+ });++ modelBuilder.Entity("AliasClientDb.Item", b =>+ {+ b.Property<Guid>("ManifestId")+ .HasColumnType("TEXT");++ b.Property<Guid>("Id")+ .HasColumnType("TEXT");++ b.Property<DateTime?>("ArchivedAt")+ .HasColumnType("TEXT");++ b.Property<DateTime>("CreatedAt")+ .HasColumnType("TEXT");++ b.Property<DateTime?>("DeletedAt")+ .HasColumnType("TEXT");++ b.Property<Guid?>("FolderId")+ .HasColumnType("TEXT");++ b.Property<bool>("IsDeleted")+ .HasColumnType("INTEGER");++ b.Property<string>("ItemType")+ .IsRequired()+ .HasMaxLength(50)+ .HasColumnType("TEXT");++ b.Property<Guid?>("LogoId")+ .HasColumnType("TEXT");++ b.Property<string>("Name")+ .HasMaxLength(255)+ .HasColumnType("TEXT");++ b.Property<DateTime>("UpdatedAt")+ .HasColumnType("TEXT");++ b.HasKey("ManifestId", "Id");++ b.HasIndex("ManifestId", "FolderId");++ b.HasIndex("ManifestId", "LogoId");++ b.ToTable("Items");+ });++ modelBuilder.Entity("AliasClientDb.ItemStat", b =>+ {+ b.Property<Guid>("ManifestId")+ .HasColumnType("TEXT");++ b.Property<Guid>("Id")+ .HasColumnType("TEXT");++ b.Property<int>("AutofillCount")+ .HasColumnType("INTEGER");++ b.Property<int>("CopyCount")+ .HasColumnType("INTEGER");++ b.Property<DateTime>("CreatedAt")+ .HasColumnType("TEXT");++ b.Property<bool>("IsDeleted")+ .HasColumnType("INTEGER");++ b.Property<DateTime?>("LastAutofilledAt")+ .HasColumnType("TEXT");++ b.Property<DateTime?>("LastCopiedAt")+ .HasColumnType("TEXT");++ b.Property<DateTime?>("LastPasskeyAuthAt")+ .HasColumnType("TEXT");++ b.Property<DateTime?>("LastUsedAt")+ .HasColumnType("TEXT");++ b.Property<int>("PasskeyAuthCount")+ .HasColumnType("INTEGER");++ b.Property<DateTime>("UpdatedAt")+ .HasColumnType("TEXT");++ b.Property<int>("UseCount")+ .HasColumnType("INTEGER");++ b.HasKey("ManifestId", "Id");++ b.ToTable("ItemStats");+ });++ modelBuilder.Entity("AliasClientDb.ItemTag", b =>+ {+ b.Property<Guid>("ManifestId")+ .HasColumnType("TEXT");++ b.Property<Guid>("ItemId")+ .HasColumnType("TEXT");++ b.Property<Guid>("TagId")+ .HasColumnType("TEXT");++ b.Property<DateTime>("CreatedAt")+ .HasColumnType("TEXT");++ b.Property<bool>("IsDeleted")+ .HasColumnType("INTEGER");++ b.Property<DateTime>("UpdatedAt")+ .HasColumnType("TEXT");++ b.HasKey("ManifestId", "ItemId", "TagId");++ b.HasIndex("ItemId");++ b.HasIndex("TagId");++ b.HasIndex("ManifestId", "TagId");++ b.ToTable("ItemTags");+ });++ modelBuilder.Entity("AliasClientDb.Logo", b =>+ {+ b.Property<Guid>("ManifestId")+ .HasColumnType("TEXT");++ b.Property<Guid>("Id")+ .HasColumnType("TEXT");++ b.Property<DateTime>("CreatedAt")+ .HasColumnType("TEXT");++ b.Property<DateTime?>("FetchedAt")+ .HasColumnType("TEXT");++ b.Property<byte[]>("FileData")+ .HasColumnType("BLOB");++ b.Property<bool>("IsDeleted")+ .HasColumnType("INTEGER");++ b.Property<string>("Kind")+ .IsRequired()+ .ValueGeneratedOnAdd()+ .HasMaxLength(20)+ .HasColumnType("TEXT")+ .HasDefaultValue("favicon");++ b.Property<string>("MimeType")+ .HasMaxLength(100)+ .HasColumnType("TEXT");++ b.Property<string>("Name")+ .HasMaxLength(255)+ .HasColumnType("TEXT");++ b.Property<string>("Source")+ .IsRequired()+ .HasMaxLength(255)+ .HasColumnType("TEXT");++ b.Property<DateTime>("UpdatedAt")+ .HasColumnType("TEXT");++ b.HasKey("ManifestId", "Id");++ b.HasIndex("ManifestId", "Kind", "Source")+ .IsUnique();++ b.ToTable("Logos");+ });++ modelBuilder.Entity("AliasClientDb.Manifest", b =>+ {+ b.Property<Guid>("Id")+ .ValueGeneratedOnAdd()+ .HasColumnType("TEXT");++ b.Property<string>("Name")+ .HasColumnType("TEXT");++ b.HasKey("Id");++ b.ToTable("Manifests");+ });++ modelBuilder.Entity("AliasClientDb.Passkey", b =>+ {+ b.Property<Guid>("ManifestId")+ .HasColumnType("TEXT");++ b.Property<Guid>("Id")+ .HasColumnType("TEXT");++ b.Property<byte[]>("AdditionalData")+ .HasColumnType("BLOB");++ b.Property<DateTime>("CreatedAt")+ .HasColumnType("TEXT");++ b.Property<string>("DisplayName")+ .IsRequired()+ .HasMaxLength(255)+ .HasColumnType("TEXT");++ b.Property<bool>("IsDeleted")+ .HasColumnType("INTEGER");++ b.Property<Guid>("ItemId")+ .HasColumnType("TEXT");++ b.Property<byte[]>("PrfKey")+ .HasMaxLength(64)+ .HasColumnType("BLOB");++ b.Property<string>("PrivateKey")+ .IsRequired()+ .HasColumnType("TEXT");++ b.Property<string>("PublicKey")+ .IsRequired()+ .HasColumnType("TEXT");++ b.Property<string>("RpId")+ .IsRequired()+ .HasMaxLength(255)+ .HasColumnType("TEXT")+ .UseCollation("NOCASE");++ b.Property<DateTime>("UpdatedAt")+ .HasColumnType("TEXT");++ b.Property<byte[]>("UserHandle")+ .IsRequired()+ .HasColumnType("BLOB");++ b.HasKey("ManifestId", "Id");++ b.HasIndex("RpId");++ b.HasIndex("ManifestId", "ItemId");++ b.ToTable("Passkeys");+ });++ modelBuilder.Entity("AliasClientDb.Setting", b =>+ {+ b.Property<Guid>("ManifestId")+ .HasColumnType("TEXT");++ b.Property<string>("Key")+ .HasMaxLength(255)+ .HasColumnType("TEXT");++ b.Property<DateTime>("CreatedAt")+ .HasColumnType("TEXT");++ b.Property<bool>("IsDeleted")+ .HasColumnType("INTEGER");++ b.Property<DateTime>("UpdatedAt")+ .HasColumnType("TEXT");++ b.Property<string>("Value")+ .HasColumnType("TEXT");++ b.HasKey("ManifestId", "Key");++ b.ToTable("Settings");+ });++ modelBuilder.Entity("AliasClientDb.Tag", b =>+ {+ b.Property<Guid>("ManifestId")+ .HasColumnType("TEXT");++ b.Property<Guid>("Id")+ .HasColumnType("TEXT");++ b.Property<string>("Color")+ .HasMaxLength(50)+ .HasColumnType("TEXT");++ b.Property<DateTime>("CreatedAt")+ .HasColumnType("TEXT");++ b.Property<int>("DisplayOrder")+ .HasColumnType("INTEGER");++ b.Property<bool>("IsDeleted")+ .HasColumnType("INTEGER");++ b.Property<string>("Name")+ .IsRequired()+ .HasMaxLength(255)+ .HasColumnType("TEXT");++ b.Property<DateTime>("UpdatedAt")+ .HasColumnType("TEXT");++ b.HasKey("ManifestId", "Id");++ b.HasIndex("ManifestId", "Name");++ b.ToTable("Tags");+ });++ modelBuilder.Entity("AliasClientDb.TotpCode", b =>+ {+ b.Property<Guid>("ManifestId")+ .HasColumnType("TEXT");++ b.Property<Guid>("Id")+ .ValueGeneratedOnAdd()+ .HasColumnType("TEXT");++ b.Property<string>("Algorithm")+ .IsRequired()+ .ValueGeneratedOnAdd()+ .HasMaxLength(20)+ .HasColumnType("TEXT")+ .HasDefaultValue("SHA1");++ b.Property<DateTime>("CreatedAt")+ .HasColumnType("TEXT");++ b.Property<int>("Digits")+ .ValueGeneratedOnAdd()+ .HasColumnType("INTEGER")+ .HasDefaultValue(6);++ b.Property<bool>("IsDeleted")+ .HasColumnType("INTEGER");++ b.Property<Guid>("ItemId")+ .HasColumnType("TEXT");++ b.Property<string>("Name")+ .IsRequired()+ .HasMaxLength(255)+ .HasColumnType("TEXT");++ b.Property<int>("Period")+ .ValueGeneratedOnAdd()+ .HasColumnType("INTEGER")+ .HasDefaultValue(30);++ b.Property<string>("SecretKey")+ .IsRequired()+ .HasMaxLength(255)+ .HasColumnType("TEXT");++ b.Property<DateTime>("UpdatedAt")+ .HasColumnType("TEXT");++ b.HasKey("ManifestId", "Id");++ b.HasIndex("ManifestId", "ItemId");++ b.ToTable("TotpCodes");+ });++ modelBuilder.Entity("AliasClientDb.Attachment", b =>+ {+ b.HasOne("AliasClientDb.Item", "Item")+ .WithMany("Attachments")+ .HasForeignKey("ManifestId", "ItemId")+ .OnDelete(DeleteBehavior.Cascade)+ .IsRequired();++ b.Navigation("Item");+ });++ modelBuilder.Entity("AliasClientDb.FieldHistory", b =>+ {+ b.HasOne("AliasClientDb.FieldDefinition", "FieldDefinition")+ .WithMany("FieldHistories")+ .HasForeignKey("ManifestId", "FieldDefinitionId")+ .OnDelete(DeleteBehavior.Cascade);++ b.HasOne("AliasClientDb.Item", "Item")+ .WithMany()+ .HasForeignKey("ManifestId", "ItemId")+ .OnDelete(DeleteBehavior.Cascade)+ .IsRequired();++ b.Navigation("FieldDefinition");++ b.Navigation("Item");+ });++ modelBuilder.Entity("AliasClientDb.FieldValue", b =>+ {+ b.HasOne("AliasClientDb.FieldDefinition", "FieldDefinition")+ .WithMany("FieldValues")+ .HasForeignKey("ManifestId", "FieldDefinitionId")+ .OnDelete(DeleteBehavior.Cascade);++ b.HasOne("AliasClientDb.Item", "Item")+ .WithMany("FieldValues")+ .HasForeignKey("ManifestId", "ItemId")+ .OnDelete(DeleteBehavior.Cascade)+ .IsRequired();++ b.Navigation("FieldDefinition");++ b.Navigation("Item");+ });++ modelBuilder.Entity("AliasClientDb.Folder", b =>+ {+ b.HasOne("AliasClientDb.Folder", "ParentFolder")+ .WithMany("ChildFolders")+ .HasForeignKey("ManifestId", "ParentFolderId")+ .OnDelete(DeleteBehavior.Cascade);++ b.Navigation("ParentFolder");+ });++ modelBuilder.Entity("AliasClientDb.Item", b =>+ {+ b.HasOne("AliasClientDb.Folder", "Folder")+ .WithMany("Items")+ .HasForeignKey("ManifestId", "FolderId");++ b.HasOne("AliasClientDb.Logo", "Logo")+ .WithMany("Items")+ .HasForeignKey("ManifestId", "LogoId");++ b.Navigation("Folder");++ b.Navigation("Logo");+ });++ modelBuilder.Entity("AliasClientDb.ItemTag", b =>+ {+ b.HasOne("AliasClientDb.Item", "Item")+ .WithMany("ItemTags")+ .HasForeignKey("ManifestId", "ItemId")+ .OnDelete(DeleteBehavior.Cascade)+ .IsRequired();++ b.HasOne("AliasClientDb.Tag", "Tag")+ .WithMany("ItemTags")+ .HasForeignKey("ManifestId", "TagId")+ .OnDelete(DeleteBehavior.Cascade)+ .IsRequired();++ b.Navigation("Item");++ b.Navigation("Tag");+ });++ modelBuilder.Entity("AliasClientDb.Passkey", b =>+ {+ b.HasOne("AliasClientDb.Item", "Item")+ .WithMany("Passkeys")+ .HasForeignKey("ManifestId", "ItemId")+ .OnDelete(DeleteBehavior.Cascade)+ .IsRequired();++ b.Navigation("Item");+ });++ modelBuilder.Entity("AliasClientDb.TotpCode", b =>+ {+ b.HasOne("AliasClientDb.Item", "Item")+ .WithMany("TotpCodes")+ .HasForeignKey("ManifestId", "ItemId")+ .OnDelete(DeleteBehavior.Cascade)+ .IsRequired();++ b.Navigation("Item");+ });++ modelBuilder.Entity("AliasClientDb.FieldDefinition", b =>+ {+ b.Navigation("FieldHistories");++ b.Navigation("FieldValues");+ });++ modelBuilder.Entity("AliasClientDb.Folder", b =>+ {+ b.Navigation("ChildFolders");++ b.Navigation("Items");+ });++ modelBuilder.Entity("AliasClientDb.Item", b =>+ {+ b.Navigation("Attachments");++ b.Navigation("FieldValues");++ b.Navigation("ItemTags");++ b.Navigation("Passkeys");++ b.Navigation("TotpCodes");+ });++ modelBuilder.Entity("AliasClientDb.Logo", b =>+ {+ b.Navigation("Items");+ });++ modelBuilder.Entity("AliasClientDb.Tag", b =>+ {+ b.Navigation("ItemTags");+ });+#pragma warning restore 612, 618+ }+ }+}diff --git a/apps/server/Databases/AliasClientDb/Migrations/20260829082058_2.1.7-RestoreItemChildManifestTrigger.cs b/apps/server/Databases/AliasClientDb/Migrations/20260829082058_2.1.7-RestoreItemChildManifestTrigger.csnew file mode 100644index 000000000..1bcac85ed--- /dev/null+++ b/apps/server/Databases/AliasClientDb/Migrations/20260829082058_2.1.7-RestoreItemChildManifestTrigger.cs@@ -0,0 +1,24 @@+// <auto-generated>+using Microsoft.EntityFrameworkCore.Migrations;++#nullable disable++namespace AliasClientDb.Migrations+{+ /// <inheritdoc />+ public partial class _217RestoreItemChildManifestTrigger : Migration+ {+ /// <inheritdoc />+ protected override void Up(MigrationBuilder migrationBuilder)+ {+ // Previous migration dropped the trigger in order to rebuild the ItemTags table with the new primary key, now we restore it.+ migrationBuilder.Sql(ItemChildManifestTriggerSql.Create);+ }++ /// <inheritdoc />+ protected override void Down(MigrationBuilder migrationBuilder)+ {+ migrationBuilder.Sql(ItemChildManifestTriggerSql.Drop);+ }+ }+}diff --git a/apps/server/Databases/AliasClientDb/Migrations/ItemChildManifestTriggerSql.cs b/apps/server/Databases/AliasClientDb/Migrations/ItemChildManifestTriggerSql.csnew file mode 100644index 000000000..59ae86ead--- /dev/null+++ b/apps/server/Databases/AliasClientDb/Migrations/ItemChildManifestTriggerSql.cs@@ -0,0 +1,58 @@+//-----------------------------------------------------------------------+// <copyright file="ItemChildManifestTriggerSql.cs" company="aliasvault">+// Copyright (c) aliasvault. All rights reserved.+// Licensed under the AGPLv3 license. See LICENSE.md file in the project root for full license information.+// </copyright>+//-----------------------------------------------------------------------++namespace AliasClientDb.Migrations;++using System.Text;++/// <summary>+/// DDL of the trigger that keeps item-scoped rows stamped with their item's manifest.+/// This trigger needs to be dropped and recreated after a table is rebuilt, hence the shared code.+/// </summary>+internal static class ItemChildManifestTriggerSql+{+ /// <summary>+ /// The tables whose rows are owned by an item through an ItemId foreign key.+ /// </summary>+ private static readonly string[] ItemIdChildTables = ["FieldValues", "FieldHistories", "ItemTags", "Attachments", "Passkeys", "TotpCodes"];++ /// <summary>+ /// Gets the name of the trigger.+ /// </summary>+ public static string Name => "TR_Items_ResyncChildManifestIds";++ /// <summary>+ /// Gets the statement that drops the trigger.+ /// </summary>+ public static string Drop => $"DROP TRIGGER IF EXISTS \"{Name}\";";++ /// <summary>+ /// Gets the statement that creates the trigger.+ /// </summary>+ public static string Create+ {+ get+ {+ var body = new StringBuilder();+ foreach (var table in ItemIdChildTables)+ {+ body.AppendLine($" UPDATE \"{table}\" SET \"ManifestId\" = NEW.\"ManifestId\" WHERE \"ItemId\" = NEW.\"Id\" AND \"ManifestId\" = OLD.\"ManifestId\";");+ }++ body.AppendLine($" UPDATE \"ItemStats\" SET \"ManifestId\" = NEW.\"ManifestId\" WHERE \"Id\" = NEW.\"Id\" AND \"ManifestId\" = OLD.\"ManifestId\";");++ return $"""+ CREATE TRIGGER IF NOT EXISTS "{Name}"+ AFTER UPDATE OF "ManifestId" ON "Items"+ FOR EACH ROW WHEN OLD."ManifestId" <> NEW."ManifestId"+ BEGIN+ {body.ToString().TrimEnd()}+ END;+ """;+ }+ }+}diff --git a/apps/server/Databases/AliasClientDb/Scripts/MigrationSql/000_FullSchema.sql b/apps/server/Databases/AliasClientDb/Scripts/MigrationSql/000_FullSchema.sqlindex 8cd7dd94f..1e58493fd 100644--- a/apps/server/Databases/AliasClientDb/Scripts/MigrationSql/000_FullSchema.sql+++ b/apps/server/Databases/AliasClientDb/Scripts/MigrationSql/000_FullSchema.sql@@ -1812,6 +1812,8 @@ VALUES ('20260827095434_2.1.5-AddFieldValueValueIndex', '10.0.10');COMMIT;BEGIN TRANSACTION;+DROP TRIGGER IF EXISTS "TR_Items_ResyncChildManifestIds";+DROP INDEX "IX_ItemTags_ManifestId_ItemId_TagId";CREATE TABLE "ef_temp_ItemTags" (@@ -1855,3 +1857,22 @@ COMMIT;INSERT INTO "__EFMigrationsHistory" ("MigrationId", "ProductVersion")VALUES ('20260827095516_2.1.6-ItemTagKeyedByItemAndTag', '10.0.10');+BEGIN TRANSACTION;+CREATE TRIGGER IF NOT EXISTS "TR_Items_ResyncChildManifestIds"+AFTER UPDATE OF "ManifestId" ON "Items"+FOR EACH ROW WHEN OLD."ManifestId" <> NEW."ManifestId"+BEGIN+ UPDATE "FieldValues" SET "ManifestId" = NEW."ManifestId" WHERE "ItemId" = NEW."Id" AND "ManifestId" = OLD."ManifestId";+ UPDATE "FieldHistories" SET "ManifestId" = NEW."ManifestId" WHERE "ItemId" = NEW."Id" AND "ManifestId" = OLD."ManifestId";+ UPDATE "ItemTags" SET "ManifestId" = NEW."ManifestId" WHERE "ItemId" = NEW."Id" AND "ManifestId" = OLD."ManifestId";+ UPDATE "Attachments" SET "ManifestId" = NEW."ManifestId" WHERE "ItemId" = NEW."Id" AND "ManifestId" = OLD."ManifestId";+ UPDATE "Passkeys" SET "ManifestId" = NEW."ManifestId" WHERE "ItemId" = NEW."Id" AND "ManifestId" = OLD."ManifestId";+ UPDATE "TotpCodes" SET "ManifestId" = NEW."ManifestId" WHERE "ItemId" = NEW."Id" AND "ManifestId" = OLD."ManifestId";+ UPDATE "ItemStats" SET "ManifestId" = NEW."ManifestId" WHERE "Id" = NEW."Id" AND "ManifestId" = OLD."ManifestId";+END;++INSERT INTO "__EFMigrationsHistory" ("MigrationId", "ProductVersion")+VALUES ('20260829082058_2.1.7-RestoreItemChildManifestTrigger', '10.0.10');++COMMIT;+diff --git a/core/vault/package-lock.json b/core/vault/package-lock.jsonindex 8f389f0c9..ad586f48a 100644--- a/core/vault/package-lock.json+++ b/core/vault/package-lock.json@@ -9,10 +9,12 @@"version": "1.0.0","license": "AGPL-3.0","devDependencies": {+ "@types/sql.js": "^1.4.11","@typescript-eslint/eslint-plugin": "^8.21.0","@typescript-eslint/parser": "^8.21.0","@vitest/coverage-v8": "^4.1.8","eslint": "^9.19.0",+ "sql.js": "^1.14.2","tsup": "^8.4.0","typescript": "^5.3.3","vitest": "^4.1.8"@@ -1601,6 +1603,13 @@"dev": true,"license": "MIT"},+ "node_modules/@types/emscripten": {+ "version": "1.41.5",+ "resolved": "https://registry.npmjs.org/@types/emscripten/-/emscripten-1.41.5.tgz",+ "integrity": "sha512-cMQm7pxu6BxtHyqJ7mQZ2kXWV5SLmugybFdHCBbJ5eHzOo6VhBckEgAT3//rP5FwPHNPeEiq4SmQ5ucBwsOo4Q==",+ "dev": true,+ "license": "MIT"+ },"node_modules/@types/estree": {"version": "1.0.8","resolved": "https://registry.npmjs.org/@types/estree/-/estree-1.0.8.tgz",@@ -1615,6 +1624,27 @@"dev": true,"license": "MIT"},+ "node_modules/@types/node": {+ "version": "26.4.0",+ "resolved": "https://registry.npmjs.org/@types/node/-/node-26.4.0.tgz",+ "integrity": "sha512-faiGnoIrLH/V8cibOMEAZ8pMw6oXqSukl29ra4mN8GdaB2ZewzeaLj+INpV5N+Z1eKWzY+IzaIZH2EIR6YZRNQ==",+ "dev": true,+ "license": "MIT",+ "dependencies": {+ "undici-types": "~8.3.0"+ }+ },+ "node_modules/@types/sql.js": {+ "version": "1.4.11",+ "resolved": "https://registry.npmjs.org/@types/sql.js/-/sql.js-1.4.11.tgz",+ "integrity": "sha512-QXIx38p2ZThJaK9vP5ZdqdlRe1FG9I8SmCZOS7FHfB/2qPAjZwkL7/vlfPg6N/oWHuuOaGg/P/IRwfP2W0kWVQ==",+ "dev": true,+ "license": "MIT",+ "dependencies": {+ "@types/emscripten": "*",+ "@types/node": "*"+ }+ },"node_modules/@typescript-eslint/eslint-plugin": {"version": "8.34.1","resolved": "https://registry.npmjs.org/@typescript-eslint/eslint-plugin/-/eslint-plugin-8.34.1.tgz",@@ -4049,6 +4079,13 @@"node": ">=0.10.0"}},+ "node_modules/sql.js": {+ "version": "1.14.2",+ "resolved": "https://registry.npmjs.org/sql.js/-/sql.js-1.14.2.tgz",+ "integrity": "sha512-3ZGPovObMFrdw79zrUHbfdE/DLIsy8jdNdssmMSQuRAymedU6q84asPt0kgiqrdMYlPegDItiIMfmIXzZnYFcw==",+ "dev": true,+ "license": "MIT"+ },"node_modules/stackback": {"version": "0.0.2","resolved": "https://registry.npmjs.org/stackback/-/stackback-0.0.2.tgz",@@ -4469,6 +4506,13 @@"dev": true,"license": "MIT"},+ "node_modules/undici-types": {+ "version": "8.3.0",+ "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-8.3.0.tgz",+ "integrity": "sha512-j375ScV60dom+YkPFIfTLcOiPxkN/buHz5GobjLhixFuANaNs3C9l4GmrWqejgXWJ7BbJcFYpTEUkS1Ge8bpZQ==",+ "dev": true,+ "license": "MIT"+ },"node_modules/uri-js": {"version": "4.4.1","resolved": "https://registry.npmjs.org/uri-js/-/uri-js-4.4.1.tgz",diff --git a/core/vault/package.json b/core/vault/package.jsonindex 2ab7e0960..f4d775ef5 100644--- a/core/vault/package.json+++ b/core/vault/package.json@@ -4,27 +4,29 @@"main": "dist/index.js","types": "dist/index.d.ts","scripts": {- "build": "tsup",- "clean": "rm -rf dist",- "test": "vitest run",- "test:watch": "vitest",- "test:coverage": "vitest run --coverage",- "lint": "eslint src",- "lint:custom": "eslint",- "lint:fix": "eslint src --fix",- "generate": "node scripts/generate-vault-sql.cjs"- },+ "build": "tsup",+ "clean": "rm -rf dist",+ "test": "vitest run",+ "test:watch": "vitest",+ "test:coverage": "vitest run --coverage",+ "lint": "eslint src",+ "lint:custom": "eslint",+ "lint:fix": "eslint src --fix",+ "generate": "node scripts/generate-vault-sql.cjs"+ },"files": ["dist"],"license": "AGPL-3.0","devDependencies": {+ "@types/sql.js": "^1.4.11","@typescript-eslint/eslint-plugin": "^8.21.0","@typescript-eslint/parser": "^8.21.0",+ "@vitest/coverage-v8": "^4.1.8","eslint": "^9.19.0",+ "sql.js": "^1.14.2","tsup": "^8.4.0","typescript": "^5.3.3",- "vitest": "^4.1.8",- "@vitest/coverage-v8": "^4.1.8"+ "vitest": "^4.1.8"}}diff --git a/core/vault/src/__tests__/CompleteSchemaSql.test.ts b/core/vault/src/__tests__/CompleteSchemaSql.test.tsnew file mode 100644index 000000000..2225091ec--- /dev/null+++ b/core/vault/src/__tests__/CompleteSchemaSql.test.ts@@ -0,0 +1,47 @@+import initSqlJs from 'sql.js';+import { describe, it, expect } from 'vitest';++import { COMPLETE_SCHEMA_SQL } from '../sql/SqlConstants';++/*+ * The clients materialize every vault by applying COMPLETE_SCHEMA_SQL to an empty database, on SQLite builds+ * that are older than the one the EF tooling generates the script with (sql.js in the browser extension, the+ * system SQLite on iOS and Android). SQLite reparses every trigger in the schema while it rebuilds a table, so+ * a trigger whose body names a table that is momentarily dropped aborts the rebuild and the vault cannot be+ * opened at all. These tests run the script the way a client does.+ */+describe('COMPLETE_SCHEMA_SQL', () => {+ it('applies to an empty database', async () => {+ const SQL = await initSqlJs();+ const db = new SQL.Database();++ try {+ expect(() => db.run(COMPLETE_SCHEMA_SQL)).not.toThrow();+ } finally {+ db.close();+ }+ });++ it('leaves every table a trigger writes to in place', async () => {+ const SQL = await initSqlJs();+ const db = new SQL.Database();++ try {+ db.run(COMPLETE_SCHEMA_SQL);++ const tables = new Set((db.exec("SELECT name FROM sqlite_master WHERE type = 'table'")[0]?.values ?? []).map(row => String(row[0])));+ const triggers = (db.exec("SELECT name, sql FROM sqlite_master WHERE type = 'trigger'")[0]?.values ?? []);+ expect(triggers.length).toBeGreaterThan(0);++ for (const [name, sql] of triggers) {+ const referenced = [...String(sql).matchAll(/(?:UPDATE|INSERT INTO|DELETE FROM)\s+"([^"]+)"/g)].map(match => match[1]);+ expect(referenced.length).toBeGreaterThan(0);+ for (const table of referenced) {+ expect(tables.has(table), `trigger ${String(name)} writes to missing table ${table}`).toBe(true);+ }+ }+ } finally {+ db.close();+ }+ });+});diff --git a/core/vault/src/sql/SqlConstants.ts b/core/vault/src/sql/SqlConstants.tsindex 0aeaecfa0..c172df449 100644--- a/core/vault/src/sql/SqlConstants.ts+++ b/core/vault/src/sql/SqlConstants.ts@@ -1819,6 +1819,8 @@ VALUES ('20260827095434_2.1.5-AddFieldValueValueIndex', '10.0.10');COMMIT;BEGIN TRANSACTION;+DROP TRIGGER IF EXISTS "TR_Items_ResyncChildManifestIds";+DROP INDEX "IX_ItemTags_ManifestId_ItemId_TagId";CREATE TABLE "ef_temp_ItemTags" (@@ -1861,6 +1863,25 @@ COMMIT;INSERT INTO "__EFMigrationsHistory" ("MigrationId", "ProductVersion")VALUES ('20260827095516_2.1.6-ItemTagKeyedByItemAndTag', '10.0.10');++BEGIN TRANSACTION;+CREATE TRIGGER IF NOT EXISTS "TR_Items_ResyncChildManifestIds"+AFTER UPDATE OF "ManifestId" ON "Items"+FOR EACH ROW WHEN OLD."ManifestId" <> NEW."ManifestId"+BEGIN+ UPDATE "FieldValues" SET "ManifestId" = NEW."ManifestId" WHERE "ItemId" = NEW."Id" AND "ManifestId" = OLD."ManifestId";+ UPDATE "FieldHistories" SET "ManifestId" = NEW."ManifestId" WHERE "ItemId" = NEW."Id" AND "ManifestId" = OLD."ManifestId";+ UPDATE "ItemTags" SET "ManifestId" = NEW."ManifestId" WHERE "ItemId" = NEW."Id" AND "ManifestId" = OLD."ManifestId";+ UPDATE "Attachments" SET "ManifestId" = NEW."ManifestId" WHERE "ItemId" = NEW."Id" AND "ManifestId" = OLD."ManifestId";+ UPDATE "Passkeys" SET "ManifestId" = NEW."ManifestId" WHERE "ItemId" = NEW."Id" AND "ManifestId" = OLD."ManifestId";+ UPDATE "TotpCodes" SET "ManifestId" = NEW."ManifestId" WHERE "ItemId" = NEW."Id" AND "ManifestId" = OLD."ManifestId";+ UPDATE "ItemStats" SET "ManifestId" = NEW."ManifestId" WHERE "Id" = NEW."Id" AND "ManifestId" = OLD."ManifestId";+END;++INSERT INTO "__EFMigrationsHistory" ("MigrationId", "ProductVersion")+VALUES ('20260829082058_2.1.7-RestoreItemChildManifestTrigger', '10.0.10');++COMMIT;`;/*** Individual migration SQL scripts