Skip to content

Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.

Update browser extension word search algorithm (#1754)

Leendert de Borstd9e319b74cb0
diff --git a/apps/browser-extension/src/entrypoints/popup/pages/items/ItemsList.tsx b/apps/browser-extension/src/entrypoints/popup/pages/items/ItemsList.tsx
index e3e638588..6663ed66c 100644
--- a/apps/browser-extension/src/entrypoints/popup/pages/items/ItemsList.tsx
+++ b/apps/browser-extension/src/entrypoints/popup/pages/items/ItemsList.tsx
@@ -498,25 +498,25 @@ const ItemsList: React.FC = () => {
return true;
}
- // Search in item name and fields
- const itemName = item.Name?.toLowerCase() || '';
- if (itemName.includes(searchLower)) {
- return true;
- }
-
- // Search in field values
- const fieldMatches = item.Fields?.some(field => {
- const value = Array.isArray(field.Value)
- ? field.Value.join(' ').toLowerCase()
- : (field.Value || '').toLowerCase();
- return value.includes(searchLower) || field.Label.toLowerCase().includes(searchLower);
+ // Split search query into individual words
+ const searchWords = searchLower.split(/\s+/).filter(word => word.length > 0);
+
+ // Build searchable fields array
+ const searchableFields: string[] = [
+ item.Name?.toLowerCase() || '',
+ ];
+
+ // Add field values to searchable fields
+ item.Fields?.forEach(field => {
+ const value = Array.isArray(field.Value) ? field.Value.join(' ').toLowerCase() : (field.Value || '').toLowerCase();
+ searchableFields.push(value);
+ searchableFields.push(field.Label.toLowerCase());
});
- if (fieldMatches) {
- return true;
- }
-
- return false;
+ // Every word must appear in at least one searchable field (order doesn't matter)
+ return searchWords.every(word =>
+ searchableFields.some(field => field.includes(word))
+ );
});
/**