Privacy-first password manager with built-in email aliasing. Fully encrypted and self-hostable.
Remove username from vault exports metadata (#2471)
Leendert de Borstfab3d493b62f
diff --git a/apps/web/src/pages/settings/importexport/ImportExport.tsx b/apps/web/src/pages/settings/importexport/ImportExport.tsxindex 3c9b12af5..53503928d 100644--- a/apps/web/src/pages/settings/importexport/ImportExport.tsx+++ b/apps/web/src/pages/settings/importexport/ImportExport.tsx@@ -12,7 +12,6 @@ import Button from '@/components/shared/Button';import Card from '@/components/shared/Card';import PageContent from '@/components/shared/PageContent';import PasswordConfirmationModal from '@/components/shared/PasswordConfirmationModal';-import { useAuth } from '@/context/AuthContext';import { useConfirmModal } from '@/context/ConfirmModalContext';import { useDb } from '@/context/DbContext';import { useLoading } from '@/context/LoadingContext';@@ -37,7 +36,6 @@ const ImportExport: React.FC = () => {usePageTitle(t('settings.importExport'));const dbContext = useDb();- const { username } = useAuth();const { showConfirmation } = useConfirmModal();const { showLoading, hideLoading } = useLoading();const notifications = useNotifications();@@ -50,11 +48,11 @@ const ImportExport: React.FC = () => {const isDebugBuild = import.meta.env.DEV;/**- * The export file name: the date and the username.+ * The export file name, with the date.*/const getExportFileName = (extension: string): string => {const dateStr = new Date().toISOString().substring(0, 10);- return `aliasvault-export-${username ?? ''}-${dateStr}.${extension}`;+ return `aliasvault-export-${dateStr}.${extension}`;};/**@@ -83,7 +81,7 @@ const ImportExport: React.FC = () => {throw new Error('Vault is not available');}const data = sqliteClient.importExport.getExportData();- return AvuxExportService.exportToAvux(data.items, data.folders, data.tags, data.itemTags, data.fieldDefinitions, username ?? '');+ return AvuxExportService.exportToAvux(data.items, data.folders, data.tags, data.itemTags, data.fieldDefinitions);};/**@@ -125,7 +123,7 @@ const ImportExport: React.FC = () => {const exportVaultAvex = async (exportPassword: string): Promise<void> => {showLoading(t('importExport.exportingVaultMessage'));try {- const avexBytes = await AvexExportService.encryptToAvex(generateAvuxBytes(), exportPassword, username ?? '');+ const avexBytes = await AvexExportService.encryptToAvex(generateAvuxBytes(), exportPassword);downloadBytes(getExportFileName('avex'), avexBytes);notifications.addSuccessMessage(t('importExport.exportSuccessMessage'), true);} catch (error) {diff --git a/core/client/src/transfer/export/AvexExportService.ts b/core/client/src/transfer/export/AvexExportService.tsindex e9422e059..372eea2ff 100644--- a/core/client/src/transfer/export/AvexExportService.ts+++ b/core/client/src/transfer/export/AvexExportService.ts@@ -24,10 +24,9 @@ export class AvexExportService {* Encrypt .avux bytes to an .avex file.* @param avuxBytes - The unencrypted .avux bytes* @param exportPassword - The password to encrypt with- * @param username - The username creating the export* @returns The .avex file bytes*/- public static async encryptToAvex(avuxBytes: Uint8Array, exportPassword: string, username: string): Promise<Uint8Array> {+ public static async encryptToAvex(avuxBytes: Uint8Array, exportPassword: string): Promise<Uint8Array> {// 1. A random salt and a key derived from it with Argon2id.const salt = crypto.getRandomValues(new Uint8Array(32));const saltBase64 = bytesToBase64(salt);@@ -42,7 +41,7 @@ export class AvexExportService {version: AvexConstants.FormatVersion,kdf: { type: AVEX_KDF_TYPE, salt: saltBase64, params: { ...ARGON2_KDF_PARAMS } },encryption: { algorithm: 'AES-256-GCM', encryptedDataOffset: 0 },- metadata: { exportedAt: new Date().toISOString(), exportedBy: username, appVersion: AppInfo.VERSION },+ metadata: { exportedAt: new Date().toISOString(), appVersion: AppInfo.VERSION },};const encoder = new TextEncoder();diff --git a/core/client/src/transfer/export/AvexHeader.ts b/core/client/src/transfer/export/AvexHeader.tsindex 2a4a3846f..232f628fd 100644--- a/core/client/src/transfer/export/AvexHeader.ts+++ b/core/client/src/transfer/export/AvexHeader.ts@@ -28,7 +28,6 @@ export type AvexEncryptionParams = {*/export type AvexMetadata = {exportedAt: string;- exportedBy: string;/** The AliasVault application version that created this export. */appVersion?: string | null;};diff --git a/core/client/src/transfer/export/AvuxExportService.ts b/core/client/src/transfer/export/AvuxExportService.tsindex 40b395520..59d2987b9 100644--- a/core/client/src/transfer/export/AvuxExportService.ts+++ b/core/client/src/transfer/export/AvuxExportService.ts@@ -19,12 +19,11 @@ export class AvuxExportService {* @param tags - The tags to export* @param itemTags - The item-tag associations to export* @param fieldDefinitions - The custom field definitions to export- * @param username - The username creating the export* @returns The .avux ZIP file bytes*/- public static exportToAvux(items: ItemEntity[], folders: FolderEntity[], tags: TagEntity[], itemTags: ItemTagEntity[], fieldDefinitions: FieldDefinitionEntity[], username: string): Uint8Array {+ public static exportToAvux(items: ItemEntity[], folders: FolderEntity[], tags: TagEntity[], itemTags: ItemTagEntity[], fieldDefinitions: FieldDefinitionEntity[]): Uint8Array {const logos = AvuxExportService.itemLogos(items);- const manifest = AvuxExportService.createManifest(items, folders, tags, itemTags, fieldDefinitions, logos, username);+ const manifest = AvuxExportService.createManifest(items, folders, tags, itemTags, fieldDefinitions, logos);const attachmentMap = AvuxExportService.extractAttachments(items);const logoMap = AvuxExportService.extractLogos(logos);@@ -39,14 +38,12 @@ export class AvuxExportService {* @param itemTags - The item-tag associations* @param fieldDefinitions - The custom field definitions* @param logos - The logos- * @param username - The username creating the export* @returns The manifest*/- private static createManifest(items: ItemEntity[], folders: FolderEntity[], tags: TagEntity[], itemTags: ItemTagEntity[], fieldDefinitions: FieldDefinitionEntity[], logos: LogoEntity[], username: string): AvuxManifest {+ private static createManifest(items: ItemEntity[], folders: FolderEntity[], tags: TagEntity[], itemTags: ItemTagEntity[], fieldDefinitions: FieldDefinitionEntity[], logos: LogoEntity[]): AvuxManifest {return {version: AVUX_FORMAT_VERSION,exportedAt: new Date().toISOString(),- exportedBy: username,items: items.filter(i => !i.IsDeleted).map(AvuxExportService.mapItemToAvux),folders: folders.filter(f => !f.IsDeleted).map(AvuxExportService.mapFolderToAvux),tags: tags.filter(t => !t.IsDeleted).map(AvuxExportService.mapTagToAvux),diff --git a/core/client/src/transfer/export/AvuxManifest.ts b/core/client/src/transfer/export/AvuxManifest.tsindex ad4b5b749..66d399351 100644--- a/core/client/src/transfer/export/AvuxManifest.ts+++ b/core/client/src/transfer/export/AvuxManifest.ts@@ -163,7 +163,6 @@ export type AvuxLogo = {export type AvuxManifest = {version: string;exportedAt: string;- exportedBy: string;items: AvuxItem[];folders: AvuxFolder[];tags: AvuxTag[];diff --git a/core/client/src/transfer/export/__tests__/AvexExportService.test.ts b/core/client/src/transfer/export/__tests__/AvexExportService.test.tsindex 8a3541a3a..3c3568a36 100644--- a/core/client/src/transfer/export/__tests__/AvexExportService.test.ts+++ b/core/client/src/transfer/export/__tests__/AvexExportService.test.ts@@ -11,13 +11,13 @@ describe('AvexExportService', () => {it('decrypts what it encrypted', async () => {const avuxBytes = exportItems([createTestItem('Encrypted item', ItemTypes.Login, { [FieldKey.LoginUsername]: 'user' })]);- const avexBytes = await AvexExportService.encryptToAvex(avuxBytes, 'export-password', 'tester');+ const avexBytes = await AvexExportService.encryptToAvex(avuxBytes, 'export-password');const { header } = AvexImportService.parseAvexHeader(avexBytes);expect(header.format).toBe('avex');expect(header.version).toBe('1.0.0');expect(header.kdf.type.toLowerCase()).toBe('argon2id');expect(header.kdf.params).toEqual({ DegreeOfParallelism: 1, MemorySize: 262144, Iterations: 3 });- expect(header.metadata.exportedBy).toBe('tester');+ expect(header.metadata).not.toHaveProperty('exportedBy');const decrypted = await AvexImportService.decryptAvex(avexBytes, 'export-password');expect(Array.from(decrypted)).toEqual(Array.from(avuxBytes));diff --git a/core/client/src/transfer/export/__tests__/AvuxExportService.test.ts b/core/client/src/transfer/export/__tests__/AvuxExportService.test.tsindex 1f0f966c3..869e2bdbc 100644--- a/core/client/src/transfer/export/__tests__/AvuxExportService.test.ts+++ b/core/client/src/transfer/export/__tests__/AvuxExportService.test.ts@@ -24,7 +24,7 @@ describe('AvuxExportService', () => {const tags: TagEntity[] = [{ Id: crypto.randomUUID(), Name: 'Test Tag', Color: '#FF0000', DisplayOrder: 0, CreatedAt: new Date(), UpdatedAt: new Date(), IsDeleted: false }];const itemTags: ItemTagEntity[] = [{ ItemId: items[0].Id, TagId: tags[0].Id, IsDeleted: false }];- const avuxBytes = AvuxExportService.exportToAvux(items, folders, tags, itemTags, [], '[email protected]');+ const avuxBytes = AvuxExportService.exportToAvux(items, folders, tags, itemTags, []);expect(avuxBytes.length).toBeGreaterThan(0);diff --git a/core/client/src/transfer/export/__tests__/testHelpers.ts b/core/client/src/transfer/export/__tests__/testHelpers.tsindex 3e5545d76..615186fb0 100644--- a/core/client/src/transfer/export/__tests__/testHelpers.ts+++ b/core/client/src/transfer/export/__tests__/testHelpers.ts@@ -117,5 +117,5 @@ export function addAttachment(item: ItemEntity, filename: string, content: strin* @returns The .avux bytes*/export function exportItems(items: ItemEntity[], fieldDefinitions: FieldDefinitionEntity[] = []): Uint8Array {- return AvuxExportService.exportToAvux(items, [], [], [], fieldDefinitions, '[email protected]');+ return AvuxExportService.exportToAvux(items, [], [], [], fieldDefinitions);}diff --git a/core/client/src/transfer/import/importers/aliasvault/AvexImportService.ts b/core/client/src/transfer/import/importers/aliasvault/AvexImportService.tsindex 0f9cd3735..ba3152629 100644--- a/core/client/src/transfer/import/importers/aliasvault/AvexImportService.ts+++ b/core/client/src/transfer/import/importers/aliasvault/AvexImportService.ts@@ -95,7 +95,6 @@ export class AvexImportService {},metadata: {exportedAt: (metadata ? readString(metadata, 'exportedAt') : null) ?? '',- exportedBy: (metadata ? readString(metadata, 'exportedBy') : null) ?? '',appVersion: metadata ? readString(metadata, 'appVersion') : null,},};diff --git a/core/client/src/transfer/import/importers/aliasvault/AvuxManifestReader.ts b/core/client/src/transfer/import/importers/aliasvault/AvuxManifestReader.tsindex e413a675f..aea65e917 100644--- a/core/client/src/transfer/import/importers/aliasvault/AvuxManifestReader.ts+++ b/core/client/src/transfer/import/importers/aliasvault/AvuxManifestReader.ts@@ -15,7 +15,6 @@ export function parseAvuxManifest(root: unknown): AvuxManifest {return {version: readString(obj, 'version') ?? '1.0.0',exportedAt: readString(obj, 'exportedAt') ?? '',- exportedBy: readString(obj, 'exportedBy') ?? '',items: readObjectArray(obj, 'items', parseAvuxItem) ?? [],folders: readObjectArray(obj, 'folders', parseAvuxFolder) ?? [],tags: readObjectArray(obj, 'tags', parseAvuxTag) ?? [],