Multi-Agent Collaboration for Team and Friends
TypeScript agent-automationagent-orchestrationagent-workflowai-agentsai-collaborationai-memoryai-workforceautonomous-agentsclaude-codeclaude-code-skillscodexcoding-agentmulti-agentmultiple-agentone-person-businessone-person-companyone-person-teamopencodesolopreneur
fix(web): replace spread-based base64 encoding to prevent stack overflow on large attachments (#326)
Gener0e0c698d66b6
diff --git a/src/web/src/app/api/email/send/route.test.ts b/src/web/src/app/api/email/send/route.test.tsindex a26d601da..4c683f219 100644--- a/src/web/src/app/api/email/send/route.test.ts+++ b/src/web/src/app/api/email/send/route.test.ts@@ -440,6 +440,41 @@ describe("POST /api/email/send", () => {expect(putBody).toContain('filename="c.txt"');});+ it("handles large attachments (>64KB) without RangeError", async () => {+ mockGetAgent.mockResolvedValue({ id: "a1", emailHandle: "sender-agent", workspaceId: "ws1" });+ mockGetAgentByHandle.mockResolvedValue({ id: "a2", emailHandle: "agent-b", workspaceId: "ws1" });+ mockIsWhitelisted.mockResolvedValue(false);+ mockWorkerSelfRefFetch.mockResolvedValue(Response.json({ ok: true }));+ mockCreateEmail.mockResolvedValue({ id: "e1" });++ // Create a 100KB buffer — larger than the ~65,536 arg limit that caused the stack overflow+ const largeBuffer = new Uint8Array(100 * 1024);+ for (let i = 0; i < largeBuffer.length; i++) largeBuffer[i] = i % 256;+ mockEmailBucketGet.mockResolvedValue({+ arrayBuffer: () => Promise.resolve(largeBuffer.buffer),+ });+ mockEmailBucketPut.mockResolvedValue(undefined);++ const attachments = [+ { key: "emails/drafts/x/large.bin", filename: "large.bin", size: 100 * 1024, contentType: "application/octet-stream" },+ ];++ const req = makeReq({+ agentId: "a1",+ to: "[email protected]",+ subject: "Large attachment",+ htmlBody: "<p>Big file</p>",+ attachments,+ });++ const res = await POST(req, {} as any);+ expect(res.status).toBe(200);++ expect(mockEmailBucketGet).toHaveBeenCalledWith("emails/drafts/x/large.bin");+ const putBody = mockEmailBucketPut.mock.calls[0][1] as string;+ expect(putBody).toContain('filename="large.bin"');+ });+it("skips attachments that return null from R2 in parallel fetch", async () => {mockGetAgent.mockResolvedValue({ id: "a1", emailHandle: "sender-agent", workspaceId: "ws1" });mockGetAgentByHandle.mockResolvedValue({ id: "a2", emailHandle: "agent-b", workspaceId: "ws1" });diff --git a/src/web/src/app/api/email/send/route.ts b/src/web/src/app/api/email/send/route.tsindex 846a90dc6..6a2d5f3d6 100644--- a/src/web/src/app/api/email/send/route.ts+++ b/src/web/src/app/api/email/send/route.ts@@ -116,7 +116,10 @@ export const POST = withAuth(async (req: NextRequest, ctx) => {const obj = await cfEnv.EMAIL_BUCKET.get(att.key);if (!obj) return null;const raw = await obj.arrayBuffer();- const base64 = btoa(String.fromCharCode(...new Uint8Array(raw)));+ const bytes = new Uint8Array(raw);+ let binary = '';+ for (let i = 0; i < bytes.byteLength; i++) binary += String.fromCharCode(bytes[i]!);+ const base64 = btoa(binary);return { filename: att.filename, contentType: att.contentType, base64 };}))).filter((a): a is { filename: string; contentType: string; base64: string } => a !== null);