Skip to content

armgit / alook

Public Imported from GitHub
0

Multi-Agent Collaboration for Team and Friends

fix(web): restrict profile messages to confirmed friends (#915)

Gener0f732c3fc48d
diff --git a/src/web/src/components/community/shell/shell-frame-overlays.dom.test.ts b/src/web/src/components/community/shell/shell-frame-overlays.dom.test.ts
index 1926b5990..2017cdcf3 100644
--- a/src/web/src/components/community/shell/shell-frame-overlays.dom.test.ts
+++ b/src/web/src/components/community/shell/shell-frame-overlays.dom.test.ts
@@ -44,6 +44,7 @@ const controller = {
},
closeProfile: vi.fn(),
profileMessage: vi.fn(),
+ canMessage: true,
updateOwnStatus: vi.fn(),
openOwnerProfile: vi.fn(),
openBotAudit: vi.fn(),
@@ -98,6 +99,7 @@ describe("ShellFrameOverlays", () => {
expect("initialStatusText" in profileCard).toBe(false)
expect(profileCard.onOpenOwnerProfile).toBe(controller.openOwnerProfile)
expect(profileCard.onOpenBotAudit).toBe(controller.openBotAudit)
+ expect(profileCard.canMessage).toBe(true)
expect(hostProps.get("crop-dialog")?.maskShape).toBe("circle")
;(hostProps.get("attachment-sheet")?.onOpenChange as (open: boolean) => void)(false)
@@ -120,6 +122,13 @@ describe("ShellFrameOverlays", () => {
expect("activityStatusText" in profileCard).toBe(false)
})
+ it.each(["desktop", "mobile"] as const)("forwards a withdrawn relationship without changing the target or sender on %s", (breakpoint) => {
+ const view = render(createElement(ShellFrameOverlays, { controller, breakpoint }))
+ expect(hostProps.get("profile-card")?.canMessage).toBe(true)
+ view.rerender(createElement(ShellFrameOverlays, { controller: { ...controller, canMessage: false } as never, breakpoint }))
+ expect(hostProps.get("profile-card")).toMatchObject({ canMessage: false, data: controller.profile.data, onMessage: controller.profileMessage })
+ })
+
it("omits nullable overlays while keeping closed sheet and settings wiring", () => {
const emptyController = {
...controller,
diff --git a/src/web/src/components/community/shell/shell-frame-overlays.tsx b/src/web/src/components/community/shell/shell-frame-overlays.tsx
index 75848cfef..9fd40423f 100644
--- a/src/web/src/components/community/shell/shell-frame-overlays.tsx
+++ b/src/web/src/components/community/shell/shell-frame-overlays.tsx
@@ -36,6 +36,7 @@ export function ShellFrameOverlays({
bp={breakpoint}
onClose={controller.closeProfile}
onMessage={controller.profileMessage}
+ canMessage={controller.canMessage}
isSelf={!!profile.data.userId && profile.data.userId === currentUser.id}
onUpdateStatus={controller.updateOwnStatus}
onOpenOwnerProfile={controller.openOwnerProfile}
diff --git a/src/web/src/components/community/shell/use-shell-profile-controller.dom.test.ts b/src/web/src/components/community/shell/use-shell-profile-controller.dom.test.ts
index 9e58b6b8d..3689524a6 100644
--- a/src/web/src/components/community/shell/use-shell-profile-controller.dom.test.ts
+++ b/src/web/src/components/community/shell/use-shell-profile-controller.dom.test.ts
@@ -68,7 +68,7 @@ vi.mock("@/stores/community/message-stream", async (importOriginal) => ({ ...awa
}),
}))
vi.mock("@/hooks/community/use-friends", () => ({
- useFriends: () => ({ friends: [{ id: "remote", userId: "remote", name: "Remote", avatar: "R", sub: "seed" }] }),
+ useFriends: () => ({ data: { ids: ["remote"] }, friends: [{ id: "remote", userId: "remote", name: "Remote", avatar: "R", sub: "seed" }], pending: [], blocked: [] }),
}))
vi.mock("@/hooks/community/use-server-members", () => ({
useServerMembers: () => ({ members: [{ id: "remote", userId: "remote", name: "Remote", avatar: "R", sub: "seed" }] }),
diff --git a/src/web/src/components/community/shell/use-shell-profile-controller.relationship.dom.test.tsx b/src/web/src/components/community/shell/use-shell-profile-controller.relationship.dom.test.tsx
new file mode 100644
index 000000000..325c93022
--- /dev/null
+++ b/src/web/src/components/community/shell/use-shell-profile-controller.relationship.dom.test.tsx
@@ -0,0 +1,199 @@
+import "fake-indexeddb/auto"
+import React from "react"
+import { useQueryClient, type QueryClient } from "@tanstack/react-query"
+import { beforeEach, describe, expect, it, vi } from "vitest"
+import { act, render, waitFor } from "@/test/react-dom-harness"
+import { QueryProvider } from "@/app/c/QueryProvider"
+import { clearAllPersistedCaches } from "@/lib/query-persister"
+import { getCommunityDbRegistry } from "@/lib/community-db/collections"
+import { projectCommunityWsEventToDb } from "@/lib/community-db/sync"
+import { communityKeys } from "@/lib/query-keys"
+import { useShellProfileController } from "./use-shell-profile-controller"
+
+const mocks = vi.hoisted(() => ({ viewer: "A", api: vi.fn() }))
+vi.mock("@/lib/api/client", async (original) => ({
+ ...await original<typeof import("@/lib/api/client")>(),
+ apiFetch: mocks.api,
+}))
+vi.mock("@/lib/auth-client", () => ({
+ useSession: () => ({ data: { user: { id: mocks.viewer } }, isPending: false, error: null }),
+ currentSessionViewer: () => mocks.viewer,
+ signOutWithOrigin: vi.fn(),
+}))
+vi.mock("@/contexts/community/current-user", () => ({
+ useCurrentUser: () => ({ id: mocks.viewer, name: "Viewer", email: "[email protected]", avatar: "V", avatarVersion: 0, presence: "online" }),
+}))
+vi.mock("next/navigation", () => ({
+ useRouter: () => ({ refresh: vi.fn(), replace: vi.fn() }),
+ usePathname: () => "/c/channels/server/channel",
+ useSearchParams: () => new URLSearchParams(),
+}))
+vi.mock("@tanstack/react-query-devtools", () => ({ ReactQueryDevtools: () => null }))
+vi.mock("@/hooks/community/use-server-members", () => ({
+ useServerMembers: () => ({ members: [
+ { id: "member-peer", userId: "peer", name: "Peer", discriminator: "0001", role: "member" },
+ { id: "member-other", userId: "other", name: "Peer", discriminator: "0002", role: "member" },
+ ] }),
+}))
+
+const peer = { id: "relationship-peer", userId: "peer", name: "Peer", discriminator: "0001", avatar: "P", avatarVersion: 0, status: "offline", sub: "" }
+const empty = { friends: [], pending: [], blocked: [] }
+type Buckets = { friends: unknown[]; pending: unknown[]; blocked: unknown[] }
+function response(path: string, buckets: Buckets = { ...empty, friends: [peer] }) {
+ if (path.endsWith("/accepted")) return { friends: buckets.friends }
+ if (path.endsWith("/pending")) return { pending: buckets.pending }
+ if (path.endsWith("/blocked")) return { blocked: buckets.blocked }
+ if (path.endsWith("/profile")) return { id: path.split("/").at(-2), name: "Peer", discriminator: "0001", image: null, avatarVersion: 0, kind: "human", aboutMe: "", mutualServers: 0, statusEmoji: null, statusText: null }
+ throw new Error("Unexpected relationship fixture request: " + path)
+}
+type Held = { viewer: string; path: string; signal: AbortSignal; resolve: (value: unknown) => void }
+function holdFriends() {
+ const held: Held[] = []
+ mocks.api.mockImplementation((path: string, options: { signal: AbortSignal }) => {
+ if (!path.includes("/friends/")) return Promise.resolve(response(path))
+ return new Promise((resolve) => held.push({ viewer: mocks.viewer, path, signal: options.signal, resolve }))
+ })
+ return held
+}
+
+async function mountController() {
+ let current!: ReturnType<typeof useShellProfileController>
+ let client!: QueryClient
+ const router = { captureIntent: () => () => true, push: vi.fn(), replace: vi.fn(), prefetch: vi.fn() }
+ function Probe() {
+ client = useQueryClient()
+ current = useShellProfileController({ queryClient: client, router, cancelPendingNavigation: vi.fn(), view: "server", activeServerId: "server" })
+ return null
+ }
+ function Root({ viewer }: { viewer: string }) {
+ return <QueryProvider userId={viewer}><Probe /></QueryProvider>
+ }
+ const view = render(<Root viewer={mocks.viewer} />)
+ await waitFor(() => expect(client).toBeDefined())
+ await act(async () => { await getCommunityDbRegistry(client)!.ready; await getCommunityDbRegistry(client)!.preload() })
+ return {
+ get current() { return current },
+ get client() { return client },
+ view,
+ open(userId: string | undefined, name = "Peer") {
+ act(() => current.openProfile(name, { clientX: 1, clientY: 1 } as never, undefined, userId))
+ },
+ switchAccount(viewer: string) {
+ act(() => { mocks.viewer = viewer; view.rerender(<Root viewer={viewer} />) })
+ },
+ }
+}
+beforeEach(async () => {
+ await clearAllPersistedCaches()
+ mocks.viewer = "A"
+ mocks.api.mockReset().mockImplementation((path: string) => Promise.resolve(response(path)))
+})
+
+describe("profile message visibility from the existing relationship owner", () => {
+ it("matches accepted userId rather than friendship id or a same-name member and resets on target changes", async () => {
+ const hook = await mountController()
+ await waitFor(() => expect(hook.client.getQueryData(communityKeys.friends())).toBeDefined())
+ hook.open("peer")
+ await waitFor(() => expect(hook.current.canMessage).toBe(true))
+ hook.open("other")
+ expect(hook.current.profile?.data.userId).toBe("other")
+ expect(hook.current.canMessage).toBe(false)
+ hook.open("relationship-peer", "Missing")
+ expect(hook.current.canMessage).toBe(false)
+ hook.open("A")
+ expect(hook.current.canMessage).toBe(false)
+ hook.open(undefined, "Missing")
+ expect(hook.current.profile?.data.userId).toBeUndefined()
+ expect(hook.current.canMessage).toBe(false)
+ })
+
+ it.each([false, true])("uses the accepted self-bot source with known blocked=%s taking precedence", async (blocked) => {
+ const bot = { ...peer, id: "self-bot:bot", userId: "bot" }
+ mocks.api.mockImplementation((path: string) => Promise.resolve(response(path, { ...empty, friends: [bot], blocked: blocked ? [bot] : [] })))
+ const hook = await mountController()
+ await waitFor(() => expect(hook.client.getQueryData(communityKeys.friends())).toBeDefined())
+ hook.open("bot")
+ await waitFor(() => expect(hook.current.canMessage).toBe(!blocked))
+ })
+
+ it("keeps canonical accepted rows closed until the first query is confirmed and does not label a first failed read as friendship", async () => {
+ const held = holdFriends(), hook = await mountController()
+ await waitFor(() => expect(held).toHaveLength(3))
+ await act(async () => getCommunityDbRegistry(hook.client)!.collections.friendships.utils.writeUpsert({ id: peer.id, userId: peer.userId, kind: "accepted" }))
+ hook.open("peer")
+ expect(hook.current.canMessage).toBe(false)
+ await act(async () => { for (const request of held) request.resolve(response(request.path, empty)) })
+ await waitFor(() => expect(hook.client.getQueryData(communityKeys.friends())).toBeDefined())
+ expect(hook.current.canMessage).toBe(false)
+ hook.view.unmount()
+ mocks.api.mockImplementation((path: string) => path.includes("/friends/") ? Promise.reject(new Error("initial relationship read failed")) : Promise.resolve(response(path)))
+ const failed = await mountController()
+ failed.open("peer")
+ await waitFor(() => expect(failed.client.getQueryState(communityKeys.friends())?.status).toBe("error"), { timeout: 3000 })
+ expect(failed.client.getQueryData(communityKeys.friends())).toBeUndefined()
+ expect(failed.current.canMessage).toBe(false)
+ })
+
+ it.each(["incoming", "outgoing"] as const)("follows accepted and removed WS facts for a %s request in the same cache", async (kind) => {
+ mocks.api.mockImplementation((path: string) => Promise.resolve(response(path, { ...empty, pending: [{ ...peer, kind }] })))
+ const hook = await mountController()
+ await waitFor(() => expect(hook.client.getQueryData(communityKeys.friends())).toBeDefined())
+ hook.open("peer")
+ expect(hook.current.canMessage).toBe(false)
+ act(() => projectCommunityWsEventToDb(hook.client, { type: "community:friend.accept", friendshipId: peer.id }))
+ await waitFor(() => expect(hook.current.canMessage).toBe(true))
+ act(() => projectCommunityWsEventToDb(hook.client, { type: "community:friend.remove", friendshipId: peer.id }))
+ await waitFor(() => expect(hook.current.canMessage).toBe(false))
+ })
+
+ it.each(["error", "stale"] as const)("preserves a previous good query and accepted projection after a refresh %s", async (mode) => {
+ const hook = await mountController()
+ await waitFor(() => expect(hook.client.getQueryData(communityKeys.friends())).toBeDefined())
+ hook.open("peer")
+ await waitFor(() => expect(hook.current.canMessage).toBe(true))
+ mocks.api.mockImplementation((path: string) => !path.includes("/friends/") ? Promise.resolve(response(path)) : mode === "error" ? Promise.reject(new Error("refresh failed")) : Promise.resolve({ ...response(path), stale: true }))
+ await act(async () => { await hook.client.refetchQueries({ queryKey: communityKeys.friends(), exact: true }) })
+ expect(hook.client.getQueryState(communityKeys.friends())?.status).toBe("error")
+ expect(hook.client.getQueryData(communityKeys.friends())).toBeDefined()
+ expect(hook.current.canMessage).toBe(true)
+ })
+
+ it("does not let a late accepted snapshot restore permission after a known block", async () => {
+ const hook = await mountController()
+ await waitFor(() => expect(hook.client.getQueryData(communityKeys.friends())).toBeDefined())
+ hook.open("peer")
+ await waitFor(() => expect(hook.current.canMessage).toBe(true))
+ const held = holdFriends()
+ let refresh!: Promise<void>
+ act(() => { refresh = hook.client.refetchQueries({ queryKey: communityKeys.friends(), exact: true }) })
+ await waitFor(() => expect(held).toHaveLength(3))
+ act(() => projectCommunityWsEventToDb(hook.client, { type: "community:friend.block", userId: "peer", blockedByViewer: true }))
+ await waitFor(() => expect(hook.current.canMessage).toBe(false))
+ await act(async () => { for (const request of held) request.resolve(response(request.path)); await refresh })
+ expect(hook.current.canMessage).toBe(false)
+ expect(getCommunityDbRegistry(hook.client)!.collections.friendships.get("blocked:peer")?.kind).toBe("blocked")
+ })
+
+ it("retires account A and its late reads before account B can acquire any permission", async () => {
+ const hook = await mountController()
+ await waitFor(() => expect(hook.client.getQueryData(communityKeys.friends())).toBeDefined())
+ hook.open("peer")
+ await waitFor(() => expect(hook.current.canMessage).toBe(true))
+ const original = hook.client, held = holdFriends()
+ act(() => { void original.refetchQueries({ queryKey: communityKeys.friends(), exact: true }) })
+ await waitFor(() => expect(held.filter((request) => request.viewer === "A")).toHaveLength(3))
+ hook.switchAccount("B")
+ await waitFor(() => expect(held.filter((request) => request.viewer === "B")).toHaveLength(3))
+ expect(hook.client).not.toBe(original)
+ hook.open("peer")
+ expect(hook.current.canMessage).toBe(false)
+ const fromA = held.filter((request) => request.viewer === "A")
+ await waitFor(() => expect(fromA.every((request) => request.signal.aborted)).toBe(true))
+ await act(async () => { for (const request of fromA) request.resolve(response(request.path)) })
+ expect(hook.current.canMessage).toBe(false)
+ await act(async () => { for (const request of held.filter((request) => request.viewer === "B")) request.resolve(response(request.path, empty)) })
+ await waitFor(() => expect(hook.client.getQueryData(communityKeys.friends())).toBeDefined())
+ expect(hook.current.canMessage).toBe(false)
+ expect([...getCommunityDbRegistry(hook.client)!.collections.friendships.values()]).toHaveLength(0)
+ })
+})
diff --git a/src/web/src/components/community/shell/use-shell-profile-controller.ts b/src/web/src/components/community/shell/use-shell-profile-controller.ts
index df341b4be..de25b405e 100644
--- a/src/web/src/components/community/shell/use-shell-profile-controller.ts
+++ b/src/web/src/components/community/shell/use-shell-profile-controller.ts
@@ -82,7 +82,8 @@ export function useShellProfileController({
}
}
const currentUser = useCurrentUser()
- const { friends } = useFriends()
+ const friendsQuery = useFriends()
+ const { friends, blocked } = friendsQuery
const profileServerId = resolveProfileServerId(view, activeServerId)
const { members } = useServerMembers(profileServerId)
const createOrGetDm = useCreateOrGetDm()
@@ -117,6 +118,10 @@ export function useShellProfileController({
}
}, [finishAvatarCrop, pendingAvatarCrop])
const profileUserId = profileTarget?.data.userId
+ const canMessage = !!profileUserId && profileUserId !== currentUser.id
+ && friendsQuery.data !== undefined
+ && !blocked.some((user) => user.userId === profileUserId)
+ && friends.some((user) => user.userId === profileUserId)
const canonicalProfile = useCanonicalCommunityProfile(profileUserId)
useQuery({ queryKey: communityKeys.profile(profileUserId ?? "__none__"), enabled: !!profileUserId && profileUserId !== currentUser.id,
queryFn: userProfileQueryFn(profileUserId ?? ""), staleTime: PROFILE_STALE_TIME_MS })
@@ -373,6 +378,7 @@ export function useShellProfileController({
previewImage,
previewAttachment,
profile,
+ canMessage,
closeProfile: () => setProfile(null),
profileMessage,
updateOwnStatus,
diff --git a/src/web/src/components/community/social/profile-card.dom.test.ts b/src/web/src/components/community/social/profile-card.dom.test.ts
index dd6ba6a7f..f8cefef65 100644
--- a/src/web/src/components/community/social/profile-card.dom.test.ts
+++ b/src/web/src/components/community/social/profile-card.dom.test.ts
@@ -5,7 +5,7 @@ import { resolve } from "node:path"
import { CommunityTestProvider } from "@/test/community-owner-fixture"
import { QueryClient, QueryClientProvider } from "@tanstack/react-query"
import { afterEach, describe, it, expect, vi } from "vitest"
-import { act, render } from "@/test/react-dom-harness"
+import { act, fireEvent, render } from "@/test/react-dom-harness"
import {
displayOwnerHandle,
resolveAuditPreviewPlacement,
@@ -154,6 +154,47 @@ function findInterruptButton(container: HTMLElement) {
}
describe("ProfileCard contextual metadata", () => {
+ it.each([
+ ["desktop", "button"], ["desktop", "Enter"],
+ ["mobile", "button"], ["mobile", "Enter"],
+ ] as const)("shows messaging only with current permission and sends through the original callback on %s via %s", (bp, action) => {
+ const client = new QueryClient({ defaultOptions: { queries: { retry: false } } })
+ const onMessage = vi.fn(), onClose = vi.fn()
+ const props = { embedded: true, data: { name: "Peer", userId: "peer" }, x: 0, y: 0, bp, onMessage, onClose }
+ const card = (overrides = {}) => createElement(CommunityTestProvider, { client }, createElement(ProfileCard, { ...props, ...overrides }))
+ const view = render(card())
+ expect(view.queryByRole("textbox")).toBeNull()
+ view.rerender(card({ canMessage: true }))
+ fireEvent.change(view.getByRole("textbox"), { target: { value: " hello " } })
+ view.rerender(card({ canMessage: false }))
+ expect(view.queryByRole("textbox")).toBeNull()
+ expect(view.queryByRole("button", { name: "Send message" })).toBeNull()
+ expect(onMessage).not.toHaveBeenCalled()
+ view.rerender(card({ canMessage: true }))
+ fireEvent.keyDown(view.getByRole("textbox"), { key: "Enter", isComposing: true })
+ expect(onMessage).not.toHaveBeenCalled()
+ if (action === "button") fireEvent.click(view.getByRole("button", { name: "Send message" }))
+ else fireEvent.keyDown(view.getByRole("textbox"), { key: "Enter" })
+ expect(onMessage).toHaveBeenCalledExactlyOnceWith("peer", "hello")
+ if (bp === "mobile") expect(onClose).toHaveBeenCalledOnce()
+ else expect(onClose).not.toHaveBeenCalled()
+ expect(view.getByRole<HTMLInputElement>("textbox").value).toBe("")
+ })
+
+ it.each([
+ { isSelf: true },
+ { onMessage: undefined },
+ { data: { name: "Unknown" } },
+ ])("withholds messaging even with a true permission when the card cannot send (%j)", (overrides) => {
+ const client = new QueryClient()
+ const view = render(createElement(CommunityTestProvider, { client }, createElement(ProfileCard, {
+ embedded: true, data: { name: "Peer", userId: "peer" }, x: 0, y: 0,
+ bp: "desktop", onClose: vi.fn(), onMessage: vi.fn(), canMessage: true, ...overrides,
+ })))
+ expect(view.queryByRole("textbox")).toBeNull()
+ expect(view.queryByRole("button", { name: "Send message" })).toBeNull()
+ })
+
it("mounts the running-bots zone only for the signed-in user's profile", () => {
const self = renderProfile({}, undefined, true)
const peer = renderProfile()
diff --git a/src/web/src/components/community/social/profile-card.tsx b/src/web/src/components/community/social/profile-card.tsx
index b2d5a7809..6a14e4da3 100644
--- a/src/web/src/components/community/social/profile-card.tsx
+++ b/src/web/src/components/community/social/profile-card.tsx
@@ -74,6 +74,7 @@ type ProfileCardProps = {
bp: Breakpoint
onClose: () => void
onMessage?: (userId: string, text: string) => void
+ canMessage?: boolean
isSelf?: boolean
// Only used when `isSelf` — the inline status row opens `StatusEditor` and
// calls this on a preset pick / free-text commit / emoji override / clear.
@@ -103,7 +104,7 @@ function SelfProfileCard(props: ProfileCardProps) {
// Profile card — popover anchored at the click point on desktop, bottom sheet on mobile.
// Identity, about, status, and presence are read from the global profile map
// whenever a userId is present. Static cards use their supplied display data.
-function ProfileCardContent({ data, x, y, bp, onClose, onMessage, isSelf, onUpdateStatus, onOpenOwnerProfile, onOpenBotAudit, initialStatusEmoji, initialStatusText, activityStatusEmoji, activityStatusText, embedded, extension, hasSelfRunningBots }: ProfileCardProps & {
+function ProfileCardContent({ data, x, y, bp, onClose, onMessage, canMessage = false, isSelf, onUpdateStatus, onOpenOwnerProfile, onOpenBotAudit, initialStatusEmoji, initialStatusText, activityStatusEmoji, activityStatusText, embedded, extension, hasSelfRunningBots }: ProfileCardProps & {
hasSelfRunningBots: boolean
}) {
const registry = useOptionalCommunityDbRegistry()
@@ -159,9 +160,10 @@ function ProfileCardContent({ data, x, y, bp, onClose, onMessage, isSelf, onUpda
)
const backdropSeed = resolveProfileBackdropSeed(avatar, data.userId, name)
const close = () => setOpen(false)
+ const canSendMessage = !isSelf && canMessage && !!data.userId && !!onMessage
const send = () => {
const text = msg.trim()
- if (!text || !data.userId) return
+ if (!canSendMessage || !text || !data.userId) return
onMessage?.(data.userId, text)
setMsg("")
if (mobile) onClose()
@@ -308,7 +310,7 @@ function ProfileCardContent({ data, x, y, bp, onClose, onMessage, isSelf, onUpda
{mutual > 0 && <span>{mutual} mutual server{mutual > 1 ? "s" : ""}</span>}
</div>
)}
- {!isSelf && (
+ {canSendMessage && (
<div className="mt-4 flex h-9 items-center gap-2 rounded-md bg-secondary px-2">
<input
value={msg}
diff --git a/src/web/src/test/e2e-ui/11-profile-ui-stability.spec.ts b/src/web/src/test/e2e-ui/11-profile-ui-stability.spec.ts
index 6f6120ceb..8276b8241 100644
--- a/src/web/src/test/e2e-ui/11-profile-ui-stability.spec.ts
+++ b/src/web/src/test/e2e-ui/11-profile-ui-stability.spec.ts
@@ -1,6 +1,6 @@
import { test, expect, userId } from "./_fixtures/community-fixture"
import { tid } from "./_fixtures/testids"
-import { seedServer, seedChannel, seedJoinServer } from "./_fixtures/seed"
+import { seedServer, seedChannel, seedJoinServer, seedFriendship, seedRemoveFriendship } from "./_fixtures/seed"
// Journey 11 — profile card UI stability. Opening a member's profile shows the
// card; closing detaches it (regression ab873738 — assert detach, not the
@@ -15,19 +15,57 @@ test.describe.serial("profile card stability", () => {
await seedJoinServer("alice", "bob", serverId)
})
- test("opening a member profile shows the card; closing detaches it", async ({ asUser }) => {
- const { page } = await asUser("alice")
- await page.goto(`/c/channels/${serverId}/${channelId}`)
- await page.waitForURL(new RegExp(channelId), { timeout: 20_000 , waitUntil: "commit" })
+ for (const isFriend of [false, true]) {
+ const name = isFriend
+ ? "opening an accepted friend's profile focuses the textbox; closing detaches it"
+ : "opening a member profile shows the card; closing detaches it"
+ test(name, async ({ asUser }) => {
+ const bobId = userId("bob")
+ await seedFriendship("alice", "bob", bobId)
+ if (!isFriend) await seedRemoveFriendship("alice", bobId)
- // Open the members panel and click Bob's row → profile card.
- await page.getByRole("button", { name: /member/i }).first().click()
- await page.getByTestId(tid.memberRow(userId("bob"))).click()
- await expect(page.getByTestId(tid.profileCard)).toBeVisible({ timeout: 15_000 })
- await expect(page.getByTestId(tid.profileCard).getByRole("textbox")).toBeFocused()
+ const { page } = await asUser("alice")
+ const buckets = [
+ ["accepted", "friends", isFriend],
+ ["pending", "pending", false],
+ ["blocked", "blocked", false],
+ ] as const
+ const responseWaits = buckets.map(([bucket]) => page.waitForResponse(
+ (response) => response.request().method() === "GET"
+ && new URL(response.url()).pathname === `/api/community/friends/${bucket}`,
+ { timeout: 10_000 },
+ ))
+ const [responses] = await Promise.all([
+ Promise.all(responseWaits),
+ page.goto(`/c/channels/${serverId}/${channelId}`),
+ ])
+ for (const [index, [, field, expectedBob]] of buckets.entries()) {
+ const response = responses[index]
+ expect(response.status()).toBe(200)
+ const body = await response.json() as {
+ stale?: boolean
+ friends?: Array<{ userId: string }>
+ pending?: Array<{ userId: string }>
+ blocked?: Array<{ userId: string }>
+ }
+ expect(body.stale).not.toBe(true)
+ const peers = body[field]
+ expect(Array.isArray(peers)).toBe(true)
+ expect(peers!.some((peer) => peer.userId === bobId)).toBe(expectedBob)
+ }
+ await page.waitForURL(new RegExp(channelId), { timeout: 20_000 , waitUntil: "commit" })
- // Close by pressing Escape; the card detaches.
- await page.keyboard.press("Escape")
- await expect(page.getByTestId(tid.profileCard)).toHaveCount(0, { timeout: 15_000 })
- })
+ // Open the members panel and click Bob's row → profile card.
+ await page.getByRole("button", { name: /member/i }).first().click()
+ await page.getByTestId(tid.memberRow(userId("bob"))).click()
+ await expect(page.getByTestId(tid.profileCard)).toBeVisible({ timeout: 15_000 })
+ const textbox = page.getByTestId(tid.profileCard).getByRole("textbox")
+ if (isFriend) await expect(textbox).toBeFocused()
+ else await expect(textbox).toHaveCount(0)
+
+ // Close by pressing Escape; the card detaches.
+ await page.keyboard.press("Escape")
+ await expect(page.getByTestId(tid.profileCard)).toHaveCount(0, { timeout: 15_000 })
+ })
+ }
})