Skip to content

armgit / alook

Public Imported from GitHub
0

Multi-Agent Collaboration for Team and Friends

fix(web): broadcast runtime.status on register so onboarding shows online immediately

Gener148465ea43f5
diff --git a/src/web/src/app/(app)/studio/new/client.tsx b/src/web/src/app/(app)/studio/new/client.tsx
index fe1191775..36d4611f8 100644
--- a/src/web/src/app/(app)/studio/new/client.tsx
+++ b/src/web/src/app/(app)/studio/new/client.tsx
@@ -76,17 +76,16 @@ export function StudioOnboardingClient({
// WebSocket for runtime registration events
const handleWsMessage = useCallback((msg: WsMessage) => {
const currentWsId = workspaceIdRef.current;
- const extra = msg as WsMessage & { workspaceId?: string; payload?: { status?: string } };
if (msg.type === "runtime.registered") {
setMachineRegistered(true);
- const eventWsId = extra.workspaceId;
+ const eventWsId = msg.workspaceId;
if (eventWsId && !currentWsId) {
setWorkspaceId(eventWsId);
listRuntimes(eventWsId).then(setRuntimes).catch(() => {});
} else if (currentWsId) {
listRuntimes(currentWsId).then(setRuntimes).catch(() => {});
}
- } else if (msg.type === "runtime.status" && extra.payload?.status === "online") {
+ } else if (msg.type === "runtime.status" && msg.status === "online") {
setMachineRegistered(true);
const wsId = workspaceIdRef.current;
if (wsId) {
diff --git a/src/web/src/app/api/daemon/register/route.test.ts b/src/web/src/app/api/daemon/register/route.test.ts
index 164314403..548ce137a 100644
--- a/src/web/src/app/api/daemon/register/route.test.ts
+++ b/src/web/src/app/api/daemon/register/route.test.ts
@@ -116,7 +116,7 @@ describe("POST /api/daemon/register", () => {
expect(mockUpsertAgentRuntime).toHaveBeenCalledTimes(1);
});
- it("broadcasts runtime.registered after upserts", async () => {
+ it("broadcasts runtime.registered and runtime.status after upserts", async () => {
const POST = await loadRoute(authCtx);
mockGetMember.mockResolvedValue({ userId: "u1", workspaceId: "w1" });
@@ -126,13 +126,19 @@ describe("POST /api/daemon/register", () => {
await POST(makeReq(validBody));
- expect(mockBroadcastToUser).toHaveBeenCalledTimes(1);
+ expect(mockBroadcastToUser).toHaveBeenCalledTimes(2);
expect(mockBroadcastToUser).toHaveBeenCalledWith("u1", {
type: "runtime.registered",
daemonId: "d1",
hostname: "MyMachine",
workspaceId: "w1",
});
+ expect(mockBroadcastToUser).toHaveBeenCalledWith("u1", {
+ type: "runtime.status",
+ daemonId: "d1",
+ workspaceId: "w1",
+ status: "online",
+ });
});
it("returns 404 when membership is missing and does not broadcast", async () => {
diff --git a/src/web/src/app/api/daemon/register/route.ts b/src/web/src/app/api/daemon/register/route.ts
index 4a5059119..5e722a336 100644
--- a/src/web/src/app/api/daemon/register/route.ts
+++ b/src/web/src/app/api/daemon/register/route.ts
@@ -103,5 +103,12 @@ export const POST = withAuth(async (req: NextRequest, ctx) => {
workspaceId,
}).catch(() => {});
+ broadcastToUser(ctx.userId, {
+ type: "runtime.status",
+ daemonId,
+ workspaceId,
+ status: "online",
+ }).catch(() => {});
+
return writeJSON({ runtimes: results.map(runtimeToResponse), workspaceId });
});