Multi-Agent Collaboration for Team and Friends
TypeScript agent-automationagent-orchestrationagent-workflowai-agentsai-collaborationai-memoryai-workforceautonomous-agentsclaude-codeclaude-code-skillscodexcoding-agentmulti-agentmultiple-agentone-person-businessone-person-companyone-person-teamopencodesolopreneur
feat: add pid file for daemon
Gus1e78a1b5f4a3
diff --git a/src/cli/daemon/config.ts b/src/cli/daemon/config.tsindex 8bc3825d1..8b4d2e269 100644--- a/src/cli/daemon/config.ts+++ b/src/cli/daemon/config.ts@@ -2,6 +2,11 @@ import { hostname } from "os";import { join } from "path";import { configDir } from "../lib/config.js";+export function pidFilePath(profile?: string): string {+ const name = profile ? `daemon_${profile}.pid` : "daemon.pid";+ return join(configDir(), name);+}+function parseDuration(s: string): number {if (!s) return 0;let total = 0;diff --git a/src/cli/daemon/daemon.test.ts b/src/cli/daemon/daemon.test.tsindex 693ebcccf..109353a02 100644--- a/src/cli/daemon/daemon.test.ts+++ b/src/cli/daemon/daemon.test.ts@@ -53,6 +53,11 @@ vi.mock("../lib/config.js", () => ({})),}));+vi.mock("./pidfile.js", () => ({+ acquireDaemonPid: vi.fn(() => true),+ releaseDaemonPid: vi.fn(),+}));+vi.mock("child_process", () => ({execSync: vi.fn(),}));diff --git a/src/cli/daemon/daemon.ts b/src/cli/daemon/daemon.tsindex 0bf7fd526..7db5d6e22 100644--- a/src/cli/daemon/daemon.ts+++ b/src/cli/daemon/daemon.ts@@ -9,6 +9,7 @@ import { initEntryAsync, updateEntry, createTimelineEntry, localISOString, findRimport { loadCLIConfigForProfile } from "../lib/config.js";import { log } from "../lib/logger.js";import { cmdPrefix } from "../lib/env.js";+import { acquireDaemonPid, releaseDaemonPid } from "./pidfile.js";import { createWriteStream } from "fs";import { execSync } from "child_process";@@ -37,6 +38,10 @@ export async function startDaemon(profile?: string,serverUrl?: string,): Promise<void> {+ if (!acquireDaemonPid(profile)) {+ process.exit(1);+ }+const config = loadDaemonConfig(profile);if (serverUrl) config.serverURL = serverUrl;@@ -183,6 +188,7 @@ export async function startDaemon(// best-effort deregister}clearTimeout(timeout);+ releaseDaemonPid(profile);health.server.close();process.exit(0);};diff --git a/src/cli/daemon/pidfile.test.ts b/src/cli/daemon/pidfile.test.tsnew file mode 100644index 000000000..c52f5f817--- /dev/null+++ b/src/cli/daemon/pidfile.test.ts@@ -0,0 +1,84 @@+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";+import { mkdirSync, writeFileSync, readFileSync, unlinkSync, existsSync } from "fs";+import { join } from "path";+import { tmpdir } from "os";++// Use a temp directory for each test+let testDir: string;++vi.mock("./config.js", () => ({+ pidFilePath: (profile?: string) => {+ const name = profile ? `daemon_${profile}.pid` : "daemon.pid";+ return join(testDir, name);+ },+}));++vi.mock("../lib/logger.js", () => ({+ log: { error: vi.fn(), info: vi.fn(), warn: vi.fn(), debug: vi.fn() },+}));++import { acquireDaemonPid, releaseDaemonPid } from "./pidfile.js";++describe("pidfile", () => {+ beforeEach(() => {+ testDir = join(tmpdir(), `pidfile-test-${Date.now()}-${Math.random().toString(36).slice(2)}`);+ mkdirSync(testDir, { recursive: true });+ });++ afterEach(() => {+ // Clean up+ try {+ for (const name of ["daemon.pid", "daemon_dev.pid"]) {+ try { unlinkSync(join(testDir, name)); } catch {}+ }+ unlinkSync(testDir);+ } catch {}+ });++ it("writes PID file and returns true on fresh acquire", () => {+ const result = acquireDaemonPid();+ expect(result).toBe(true);++ const content = readFileSync(join(testDir, "daemon.pid"), "utf-8");+ expect(parseInt(content, 10)).toBe(process.pid);+ });++ it("returns false when PID file exists and process is alive", () => {+ // Write current process PID — it's alive+ writeFileSync(join(testDir, "daemon.pid"), String(process.pid));++ const result = acquireDaemonPid();+ expect(result).toBe(false);+ });++ it("overwrites stale PID file when process is not running", () => {+ // PID 999999999 is almost certainly not running+ writeFileSync(join(testDir, "daemon.pid"), "999999999");++ const result = acquireDaemonPid();+ expect(result).toBe(true);++ const content = readFileSync(join(testDir, "daemon.pid"), "utf-8");+ expect(parseInt(content, 10)).toBe(process.pid);+ });++ it("release removes PID file", () => {+ writeFileSync(join(testDir, "daemon.pid"), String(process.pid));+ expect(existsSync(join(testDir, "daemon.pid"))).toBe(true);++ releaseDaemonPid();+ expect(existsSync(join(testDir, "daemon.pid"))).toBe(false);+ });++ it("release is no-op if file does not exist", () => {+ // Should not throw+ expect(() => releaseDaemonPid()).not.toThrow();+ });++ it("uses profile-specific PID file path", () => {+ const result = acquireDaemonPid("dev");+ expect(result).toBe(true);++ expect(existsSync(join(testDir, "daemon_dev.pid"))).toBe(true);+ });+});diff --git a/src/cli/daemon/pidfile.ts b/src/cli/daemon/pidfile.tsnew file mode 100644index 000000000..9ec241f59--- /dev/null+++ b/src/cli/daemon/pidfile.ts@@ -0,0 +1,48 @@+import { readFileSync, writeFileSync, unlinkSync, mkdirSync } from "fs";+import { dirname } from "path";+import { pidFilePath } from "./config.js";+import { log } from "../lib/logger.js";++function isProcessAlive(pid: number): boolean {+ try {+ process.kill(pid, 0);+ return true;+ } catch {+ return false;+ }+}++/**+ * Write a PID file to prevent duplicate daemon starts.+ * Returns true if acquired, false if another daemon is already running.+ */+export function acquireDaemonPid(profile?: string): boolean {+ const pidPath = pidFilePath(profile);++ try {+ const content = readFileSync(pidPath, "utf-8").trim();+ const existingPid = parseInt(content, 10);+ if (!isNaN(existingPid) && isProcessAlive(existingPid)) {+ log.error(+ `Another daemon is already running (PID ${existingPid}). ` ++ `Remove ${pidPath} if this is stale.`,+ );+ return false;+ }+ } catch {+ // No existing PID file — proceed+ }++ mkdirSync(dirname(pidPath), { recursive: true, mode: 0o700 });+ writeFileSync(pidPath, String(process.pid), { mode: 0o600 });+ return true;+}++/** Remove the PID file on shutdown. */+export function releaseDaemonPid(profile?: string): void {+ try {+ unlinkSync(pidFilePath(profile));+ } catch {+ // already removed or never existed+ }+}