Skip to content

armgit / alook

Public Imported from GitHub
0

Multi-Agent Collaboration for Team and Friends

feat(web): add mobile forum tag save flow (#650)

Gener2e4f95d1b307
diff --git a/scripts/ci/e2e-shards.mjs b/scripts/ci/e2e-shards.mjs
index 6ba81474b..0dee39611 100644
--- a/scripts/ci/e2e-shards.mjs
+++ b/scripts/ci/e2e-shards.mjs
@@ -60,6 +60,7 @@ export const SPEC_SECONDS = {
"44-mobile-reaction-details.spec.ts": 70,
"45-desktop-thread-split-view.spec.ts": 60,
"50-daemon-update-notice.spec.ts": 35,
+ "51-mobile-forum-tag-editor.spec.ts": 60,
"51-share-image-assets.spec.ts": 20,
}
diff --git a/scripts/ci/e2e-shards.test.ts b/scripts/ci/e2e-shards.test.ts
index bf716ec1e..34a6bcd54 100644
--- a/scripts/ci/e2e-shards.test.ts
+++ b/scripts/ci/e2e-shards.test.ts
@@ -70,7 +70,7 @@ describe("planE2eShards", () => {
expect(first).toHaveLength(E2E_SHARD_COUNT)
expect([...assigned].sort()).toEqual(specs)
expect(new Set(assigned).size).toBe(specs.length)
- expect(totals.sort((left, right) => left - right)).toEqual([451, 454, 455, 455, 455])
+ expect(totals.sort((left, right) => left - right)).toEqual([465, 465, 465, 466, 469])
expect(Math.max(...totals) / Math.min(...totals)).toBeLessThanOrEqual(1.15)
})
diff --git a/src/web/src/components/community/channels/forum-channel-surface.test.ts b/src/web/src/components/community/channels/forum-channel-surface.test.ts
index 8e61e57bf..e8b105436 100644
--- a/src/web/src/components/community/channels/forum-channel-surface.test.ts
+++ b/src/web/src/components/community/channels/forum-channel-surface.test.ts
@@ -20,7 +20,7 @@ vi.mock("@/hooks/community/use-channel-message-feed", () => ({
vi.mock("@/hooks/community/mutations", () => ({
useCreateForumThread: () => ({ mutateAsync: mocks.createForumThread }),
useUpdatePostTags: () => ({
- mutate: mocks.updatePostTags,
+ mutateAsync: mocks.updatePostTags,
isPending: true,
variables: { threadId: "post_saving" },
}),
@@ -84,6 +84,7 @@ function surfaceProps(overrides: Record<string, unknown> = {}) {
describe("ForumChannelSurface ownership", () => {
beforeEach(() => {
mocks.createForumThread.mockResolvedValue({ threadId: "post_new" })
+ mocks.updatePostTags.mockResolvedValue({ tags: ["shipped"] })
})
afterEach(() => {
@@ -140,8 +141,10 @@ describe("ForumChannelSurface ownership", () => {
})
expect(props.onOpenPost).toHaveBeenCalledWith("post_new")
+ await act(async () => {
+ await forumProps.onEditPostTags?.(ownPost, ["shipped"])
+ })
act(() => {
- forumProps.onEditPostTags?.(ownPost, ["shipped"])
forumProps.onDeletePost?.(ownPost)
})
expect(mocks.updatePostTags).toHaveBeenCalledWith({
@@ -171,6 +174,23 @@ describe("ForumChannelSurface ownership", () => {
expect(forumProps.canDeletePost?.(otherPost)).toBe(true)
})
+ it("returns a rejected tag mutation to the editor so its draft stays retryable", async () => {
+ const error = new Error("tag update failed")
+ mocks.updatePostTags.mockRejectedValueOnce(error)
+ act(() => {
+ TestRenderer.create(React.createElement(ForumChannelSurface, surfaceProps()))
+ })
+ const forumProps = mockedForumSurface.mock.calls.at(-1)![0]
+ const post = {
+ id: "post_1",
+ authorId: "viewer_1",
+ openerMessageId: "opener_1",
+ tags: ["bug"],
+ } as Parameters<NonNullable<typeof forumProps.onEditPostTags>>[0]
+
+ await expect(forumProps.onEditPostTags?.(post, ["retry"])).rejects.toBe(error)
+ })
+
it("resets the right panel when channelId changes without relying on an outer remount", () => {
const firstProps = surfaceProps()
let renderer: TestRenderer.ReactTestRenderer
diff --git a/src/web/src/components/community/channels/forum-channel-surface.tsx b/src/web/src/components/community/channels/forum-channel-surface.tsx
index 47ef027af..36f48eb8d 100644
--- a/src/web/src/components/community/channels/forum-channel-surface.tsx
+++ b/src/web/src/components/community/channels/forum-channel-surface.tsx
@@ -114,8 +114,8 @@ export function ForumChannelSurface({
onCreatePost={createForumThread}
canEditPostTags={(post) => canManage || post.authorId === viewer.id}
savingTagsFor={updatePostTagsMut.isPending ? updatePostTagsMut.variables?.threadId ?? null : null}
- onEditPostTags={(post, tags) => {
- updatePostTagsMut.mutate(
+ onEditPostTags={async (post, tags) => {
+ await updatePostTagsMut.mutateAsync(
{
serverId,
forumChannelId: channelId,
diff --git a/src/web/src/components/community/channels/forum-surface.tsx b/src/web/src/components/community/channels/forum-surface.tsx
index d09e44b15..5f405d6e3 100644
--- a/src/web/src/components/community/channels/forum-surface.tsx
+++ b/src/web/src/components/community/channels/forum-surface.tsx
@@ -17,7 +17,7 @@ export function ForumSurface({ serverId, forumChannelId, ...props }: {
mentionCandidates?: ComposerProps["mentionCandidates"]
onOpenPost: (id: string) => void
onCreatePost?: (post: NewForumThread) => Promise<void>
- onEditPostTags?: (post: ForumThread, tags: string[]) => void
+ onEditPostTags?: (post: ForumThread, tags: string[]) => Promise<void> | void
canEditPostTags?: (post: ForumThread) => boolean
savingTagsFor?: string | null
onDeletePost?: (post: ForumThread) => void
@@ -68,7 +68,7 @@ export function ForumSurface({ serverId, forumChannelId, ...props }: {
onScrollRoot={setScrollRootEl}
onEditPostTags={(threadId, tags) => {
const post = feed.posts.find((candidate) => candidate.id === threadId)
- if (post) props.onEditPostTags?.(post, tags)
+ if (post) return props.onEditPostTags?.(post, tags)
}}
/>
}
diff --git a/src/web/src/components/community/channels/forum-view.tsx b/src/web/src/components/community/channels/forum-view.tsx
index f1638d746..5c9580c5e 100644
--- a/src/web/src/components/community/channels/forum-view.tsx
+++ b/src/web/src/components/community/channels/forum-view.tsx
@@ -200,7 +200,7 @@ export function ForumView({
// preserve composer state for retry.
onCreatePost?: (post: NewForumThread) => Promise<void>
// Save handler for a single post's tags. Absent → tag editing disabled.
- onEditPostTags?: (threadId: string, tags: string[]) => void
+ onEditPostTags?: (threadId: string, tags: string[]) => Promise<void> | void
// Whether the current user may edit a given post's tags (creator or manager).
canEditPostTags?: (post: ForumThread) => boolean
// The post id whose tag save is in flight, if any.
diff --git a/src/web/src/components/community/channels/post-tag-dialog.test.ts b/src/web/src/components/community/channels/post-tag-dialog.test.ts
index 8c77b5d61..c18c4cced 100644
--- a/src/web/src/components/community/channels/post-tag-dialog.test.ts
+++ b/src/web/src/components/community/channels/post-tag-dialog.test.ts
@@ -1,19 +1,51 @@
import { createElement, type ReactNode } from "react"
import TestRenderer, { act, type ReactTestInstance } from "react-test-renderer"
import { FORUM_ARCHIVE_TAG, MAX_FORUM_TAG_LENGTH, MAX_FORUM_TAGS_PER_POST } from "@alook/shared"
-import { describe, expect, it, vi } from "vitest"
+import { beforeEach, describe, expect, it, vi } from "vitest"
import { tid } from "@/lib/community/testids"
globalThis.IS_REACT_ACT_ENVIRONMENT = true
+const mocks = vi.hoisted(() => ({ breakpoint: "desktop" as "unknown" | "desktop" | "mobile" }))
+
+vi.mock("@/hooks/use-mobile", () => ({
+ useBreakpoint: () => mocks.breakpoint,
+}))
+
+vi.mock("@/components/ui/dialog", async () => {
+ const { createElement, Fragment } = await import("react")
+ return {
+ Dialog: ({ children, ...props }: { children: ReactNode }) =>
+ createElement("mock-dialog", props, children),
+ DialogTrigger: ({ render }: { render: ReactNode }) => createElement(Fragment, null, render),
+ DialogContent: ({ children, showCloseButton: _showCloseButton, ...props }: {
+ children: ReactNode
+ showCloseButton?: boolean
+ }) => createElement("section", props, children),
+ DialogTitle: ({ children, ...props }: { children: ReactNode }) =>
+ createElement("h2", props, children),
+ }
+})
+
vi.mock("@/components/ui/popover", async () => {
const { createElement, Fragment } = await import("react")
return {
- Popover: ({ children, onOpenChange }: { children: ReactNode; onOpenChange?: (open: boolean) => void }) =>
- createElement("mock-popover", { onOpenChange }, children),
+ Popover: ({ children, ...props }: { children: ReactNode }) =>
+ createElement("mock-popover", props, children),
PopoverTrigger: ({ render }: { render: ReactNode }) => createElement(Fragment, null, render),
PopoverContent: ({ children, ...props }: { children: ReactNode }) =>
- createElement("div", props, children),
+ createElement("section", props, children),
+ }
+})
+
+vi.mock("@/components/ui/button", async () => {
+ const { createElement } = await import("react")
+ return {
+ Button: ({ children, variant: _variant, size: _size, ...props }: {
+ children: ReactNode
+ variant?: string
+ size?: string
+ }) => createElement("button", props, children),
}
})
@@ -26,173 +58,326 @@ vi.mock("@/components/ui/input", async () => {
import { PostTagDialog } from "./post-tag-dialog"
+type Save = (tags: string[]) => Promise<void> | void
+
function renderDialog({
current = [],
allTags = [],
onSave = vi.fn(),
+ saving = false,
}: {
current?: string[]
allTags?: string[]
- onSave?: (tags: string[]) => void
+ onSave?: Save
+ saving?: boolean
} = {}) {
+ const props = { current, allTags, onSave, saving }
+ const element = () => createElement(PostTagDialog, {
+ trigger: createElement("button", { type: "button", "data-testid": "trigger" }, "Edit tags"),
+ postName: "A post",
+ ...props,
+ })
let renderer: TestRenderer.ReactTestRenderer
act(() => {
- renderer = TestRenderer.create(createElement(PostTagDialog, {
- trigger: createElement("button", { type: "button" }, "Edit tags"),
- postName: "A post",
- current,
- allTags,
- onSave,
- }))
- })
- return { renderer: renderer!, onSave }
+ renderer = TestRenderer.create(element())
+ })
+ return {
+ renderer: renderer!,
+ onSave,
+ rerender: () => act(() => renderer!.update(element())),
+ }
+}
+
+function shell(root: ReactTestInstance): ReactTestInstance {
+ return root.findByType(mocks.breakpoint === "mobile" ? "mock-dialog" : "mock-popover")
}
-function buttonText(button: ReactTestInstance): string {
- return button.children.map((child) => (
- typeof child === "string" ? child : buttonText(child)
- )).join("")
+function setOpen(root: ReactTestInstance, open: boolean): void {
+ act(() => shell(root).props.onOpenChange(open))
+}
+
+function switchBreakpoint(
+ rendered: ReturnType<typeof renderDialog>,
+ breakpoint: "desktop" | "mobile",
+): void {
+ mocks.breakpoint = breakpoint
+ rendered.rerender()
+}
+
+function byTestId(root: ReactTestInstance, testid: string): ReactTestInstance {
+ return root.findByProps({ "data-testid": testid })
}
function tagButton(root: ReactTestInstance, tag: string): ReactTestInstance {
- return root.findAllByType("button").find((button) => buttonText(button) === `#${tag}`)!
+ return byTestId(root, tid.forumTagDialogChip(tag))
}
-function setOpen(root: ReactTestInstance, open: boolean): void {
- act(() => root.findByType("mock-popover").props.onOpenChange(open))
+function input(root: ReactTestInstance): ReactTestInstance {
+ return byTestId(root, tid.forumTagDialogInput)
+}
+
+function setDraft(root: ReactTestInstance, value: string): void {
+ act(() => input(root).props.onChange({ target: { value } }))
}
-function pressEnter(input: ReactTestInstance): void {
- act(() => input.props.onKeyDown({
+function pressEnter(root: ReactTestInstance, event: Record<string, unknown> = {}): void {
+ act(() => input(root).props.onKeyDown({
key: "Enter",
preventDefault: vi.fn(),
+ ...event,
}))
}
-describe("PostTagDialog frontend limits", () => {
- it("always presets Archived and keeps it outside the ordinary tag quota", () => {
- const selected = Array.from({ length: MAX_FORUM_TAGS_PER_POST }, (_, index) => `tag-${index + 1}`)
+function deferred() {
+ let resolve!: () => void
+ let reject!: (error: Error) => void
+ const promise = new Promise<void>((resolvePromise, rejectPromise) => {
+ resolve = resolvePromise
+ reject = rejectPromise
+ })
+ return { promise, resolve, reject }
+}
+
+describe("PostTagDialog responsive session", () => {
+ beforeEach(() => {
+ mocks.breakpoint = "desktop"
+ })
+
+ it("renders no popup shell until the shared breakpoint resolves", () => {
+ mocks.breakpoint = "unknown"
+ const { renderer } = renderDialog()
+ expect(renderer.root.findAllByType("mock-dialog")).toHaveLength(0)
+ expect(renderer.root.findAllByType("mock-popover")).toHaveLength(0)
+ expect(byTestId(renderer.root, "trigger")).toBeTruthy()
+ })
+
+ it("keeps Archived outside the ordinary quota and preserves desktop close-save", () => {
+ const current = Array.from({ length: MAX_FORUM_TAGS_PER_POST }, (_, index) => `tag-${index + 1}`)
const onSave = vi.fn()
- const { renderer } = renderDialog({ current: selected, onSave })
+ const { renderer } = renderDialog({ current, allTags: [...current, "replacement"], onSave })
setOpen(renderer.root, true)
- const archived = tagButton(renderer.root, FORUM_ARCHIVE_TAG)
- expect(archived.props.disabled).toBe(false)
- expect(archived.props["data-testid"]).toBe(tid.forumTagDialogChip(FORUM_ARCHIVE_TAG))
- act(() => archived.props.onClick())
+ expect(tagButton(renderer.root, FORUM_ARCHIVE_TAG).props.disabled).toBe(false)
+ expect(tagButton(renderer.root, "replacement").props.disabled).toBe(true)
+ expect(input(renderer.root).props.disabled).toBe(true)
+ act(() => tagButton(renderer.root, FORUM_ARCHIVE_TAG).props.onClick())
setOpen(renderer.root, false)
- expect(onSave).toHaveBeenCalledWith([...selected, FORUM_ARCHIVE_TAG])
+ expect(onSave).toHaveBeenCalledOnce()
+ expect(onSave).toHaveBeenCalledWith([...current, FORUM_ARCHIVE_TAG])
+ expect(shell(renderer.root).props.open).toBe(false)
})
- it("uses the shared length limit and right-aligns the close-save hint", () => {
- const { renderer } = renderDialog()
- const input = renderer.root.findByType("input")
- const hint = renderer.root.findAllByType("p")
- .find((node) => node.children.includes("↵ to add · saves on close"))
+ it("normalizes Enter additions, rejects duplicates, and ignores IME or Shift+Enter", () => {
+ mocks.breakpoint = "mobile"
+ const onSave = vi.fn()
+ const { renderer } = renderDialog({ current: ["existing"], onSave })
+ setOpen(renderer.root, true)
- expect(input.props.maxLength).toBe(MAX_FORUM_TAG_LENGTH)
- expect(hint?.props.className).toContain("text-right")
+ setDraft(renderer.root, "existing")
+ pressEnter(renderer.root)
+ expect(input(renderer.root).props.value).toBe("")
+
+ setDraft(renderer.root, " New-Tag ")
+ pressEnter(renderer.root, { nativeEvent: { isComposing: true } })
+ expect(input(renderer.root).props.value).toBe(" New-Tag ")
+ expect(renderer.root.findAllByProps({ "data-testid": tid.forumTagDialogChip("new-tag") })).toHaveLength(0)
+
+ pressEnter(renderer.root, { shiftKey: true })
+ expect(input(renderer.root).props.value).toBe(" New-Tag ")
+ pressEnter(renderer.root)
+ expect(input(renderer.root).props.value).toBe("")
+ expect(tagButton(renderer.root, "new-tag")).toBeTruthy()
+ expect(onSave).not.toHaveBeenCalled()
})
- it("blocks a sixth chip while keeping selected chips removable", () => {
- const selected = Array.from({ length: MAX_FORUM_TAGS_PER_POST }, (_, index) => `tag-${index + 1}`)
- const replacement = "replacement"
+ it.each(["implicit", "close", "cancel"])("discards a changed mobile session via %s dismissal", (dismissal) => {
+ mocks.breakpoint = "mobile"
const onSave = vi.fn()
- const { renderer } = renderDialog({
- current: selected,
- allTags: [...selected, replacement],
- onSave,
- })
+ const { renderer } = renderDialog({ current: ["existing"], onSave })
setOpen(renderer.root, true)
+ act(() => tagButton(renderer.root, FORUM_ARCHIVE_TAG).props.onClick())
- expect(tagButton(renderer.root, replacement).props.disabled).toBe(true)
- expect(renderer.root.findByType("input").props.disabled).toBe(true)
+ if (dismissal === "implicit") setOpen(renderer.root, false)
+ else if (dismissal === "close") {
+ act(() => renderer.root.findByProps({ "aria-label": "Close" }).props.onClick())
+ } else {
+ act(() => byTestId(renderer.root, tid.forumTagDialogCancel).props.onClick())
+ }
- act(() => tagButton(renderer.root, replacement).props.onClick())
- setOpen(renderer.root, false)
expect(onSave).not.toHaveBeenCalled()
+ expect(shell(renderer.root).props.open).toBe(false)
+ setOpen(renderer.root, true)
+ expect(tagButton(renderer.root, FORUM_ARCHIVE_TAG).props["aria-label"]).toBe("Add tag archived")
+ })
+ it("closes a clean mobile session without saving", () => {
+ mocks.breakpoint = "mobile"
+ const onSave = vi.fn()
+ const { renderer } = renderDialog({ current: ["existing"], onSave })
setOpen(renderer.root, true)
- act(() => tagButton(renderer.root, selected[0]).props.onClick())
- expect(tagButton(renderer.root, replacement).props.disabled).toBe(false)
- expect(renderer.root.findByType("input").props.disabled).toBe(false)
- act(() => tagButton(renderer.root, replacement).props.onClick())
- setOpen(renderer.root, false)
+ act(() => byTestId(renderer.root, tid.forumTagDialogSave).props.onClick())
+ expect(onSave).not.toHaveBeenCalled()
+ expect(shell(renderer.root).props.open).toBe(false)
+ })
+
+ it("locks one mobile save until it succeeds", async () => {
+ mocks.breakpoint = "mobile"
+ const pending = deferred()
+ const onSave = vi.fn(() => pending.promise)
+ const { renderer } = renderDialog({ onSave })
+ setOpen(renderer.root, true)
+ act(() => tagButton(renderer.root, FORUM_ARCHIVE_TAG).props.onClick())
+
+ await act(async () => {
+ byTestId(renderer.root, tid.forumTagDialogSave).props.onClick()
+ await Promise.resolve()
+ })
+ expect(onSave).toHaveBeenCalledOnce()
+ expect(byTestId(renderer.root, tid.forumTagDialogSave).props.disabled).toBe(true)
+ expect(input(renderer.root).props.disabled).toBe(true)
+ expect(renderer.root.findByProps({ "aria-label": "Close" }).props.disabled).toBe(true)
+ act(() => byTestId(renderer.root, tid.forumTagDialogSave).props.onClick())
+ expect(onSave).toHaveBeenCalledOnce()
- expect(onSave).toHaveBeenCalledWith([...selected.slice(1), replacement])
+ await act(async () => {
+ pending.resolve()
+ await pending.promise
+ })
+ expect(shell(renderer.root).props.open).toBe(false)
})
- it("caps draft input and blocks duplicate or over-count Enter additions", () => {
- const selected = Array.from({ length: MAX_FORUM_TAGS_PER_POST }, (_, index) => `tag-${index + 1}`)
+ it("keeps selected and raw draft state after failure, then retries", async () => {
+ mocks.breakpoint = "mobile"
const onSave = vi.fn()
- const { renderer } = renderDialog({ current: selected, onSave })
+ .mockRejectedValueOnce(new Error("nope"))
+ .mockResolvedValueOnce(undefined)
+ const { renderer } = renderDialog({ onSave })
setOpen(renderer.root, true)
- let input = renderer.root.findByType("input")
+ act(() => tagButton(renderer.root, FORUM_ARCHIVE_TAG).props.onClick())
+ setDraft(renderer.root, "raw-draft")
- act(() => input.props.onChange({ target: { value: "x".repeat(MAX_FORUM_TAG_LENGTH + 8) } }))
- input = renderer.root.findByType("input")
- expect(input.props.value).toBe("x".repeat(MAX_FORUM_TAG_LENGTH))
- pressEnter(input)
- setOpen(renderer.root, false)
+ await act(async () => {
+ byTestId(renderer.root, tid.forumTagDialogSave).props.onClick()
+ await Promise.resolve()
+ await Promise.resolve()
+ })
+ expect(shell(renderer.root).props.open).toBe(true)
+ expect(input(renderer.root).props.value).toBe("raw-draft")
+ expect(tagButton(renderer.root, FORUM_ARCHIVE_TAG).props["aria-label"]).toBe("Remove tag archived")
+ expect(byTestId(renderer.root, tid.forumTagDialogSave).props.disabled).toBe(false)
+
+ await act(async () => {
+ byTestId(renderer.root, tid.forumTagDialogSave).props.onClick()
+ await Promise.resolve()
+ await Promise.resolve()
+ })
+ expect(onSave).toHaveBeenCalledTimes(2)
+ expect(shell(renderer.root).props.open).toBe(false)
+ })
+
+ it("preserves a mobile session through desktop handoff and saves only on the later desktop close", () => {
+ mocks.breakpoint = "mobile"
+ const onSave = vi.fn()
+ const rendered = renderDialog({ onSave })
+ setOpen(rendered.renderer.root, true)
+ act(() => tagButton(rendered.renderer.root, FORUM_ARCHIVE_TAG).props.onClick())
+ setDraft(rendered.renderer.root, "unfinished")
+
+ switchBreakpoint(rendered, "desktop")
+ expect(rendered.renderer.root.findByType("mock-popover").props.open).toBe(true)
+ expect(input(rendered.renderer.root).props.value).toBe("unfinished")
+ expect(tagButton(rendered.renderer.root, FORUM_ARCHIVE_TAG).props["aria-label"]).toBe("Remove tag archived")
expect(onSave).not.toHaveBeenCalled()
- const duplicateSave = vi.fn()
- const duplicate = renderDialog({ current: ["existing"], onSave: duplicateSave })
- setOpen(duplicate.renderer.root, true)
- let duplicateInput = duplicate.renderer.root.findByType("input")
- act(() => duplicateInput.props.onChange({ target: { value: "existing" } }))
- duplicateInput = duplicate.renderer.root.findByType("input")
- pressEnter(duplicateInput)
- setOpen(duplicate.renderer.root, false)
- expect(duplicateSave).not.toHaveBeenCalled()
+ setOpen(rendered.renderer.root, false)
+ expect(onSave).toHaveBeenCalledOnce()
+ expect(onSave).toHaveBeenCalledWith([FORUM_ARCHIVE_TAG])
})
- it("adds a valid normalized draft until the shared count cap", () => {
- const current = Array.from({ length: MAX_FORUM_TAGS_PER_POST - 1 }, (_, index) => `tag-${index + 1}`)
+ it("preserves a desktop session through mobile handoff and applies later mobile discard semantics", () => {
const onSave = vi.fn()
- const { renderer } = renderDialog({ current, onSave })
- setOpen(renderer.root, true)
- let input = renderer.root.findByType("input")
+ const rendered = renderDialog({ onSave })
+ setOpen(rendered.renderer.root, true)
+ act(() => tagButton(rendered.renderer.root, FORUM_ARCHIVE_TAG).props.onClick())
+ setDraft(rendered.renderer.root, "unfinished")
- act(() => input.props.onChange({ target: { value: " New-Tag " } }))
- input = renderer.root.findByType("input")
- pressEnter(input)
- expect(renderer.root.findByType("input").props.disabled).toBe(true)
- setOpen(renderer.root, false)
+ switchBreakpoint(rendered, "mobile")
+ expect(rendered.renderer.root.findByType("mock-dialog").props.open).toBe(true)
+ expect(input(rendered.renderer.root).props.value).toBe("unfinished")
+ expect(tagButton(rendered.renderer.root, FORUM_ARCHIVE_TAG).props["aria-label"]).toBe("Remove tag archived")
+ expect(onSave).not.toHaveBeenCalled()
- expect(onSave).toHaveBeenCalledWith([...current, "new-tag"])
+ setOpen(rendered.renderer.root, false)
+ expect(onSave).not.toHaveBeenCalled()
+ expect(rendered.renderer.root.findByType("mock-dialog").props.open).toBe(false)
})
- it("does not allow an over-length existing vocabulary chip to be selected", () => {
- const invalid = "x".repeat(MAX_FORUM_TAG_LENGTH + 1)
- const { renderer } = renderDialog({ allTags: [invalid] })
- setOpen(renderer.root, true)
- expect(tagButton(renderer.root, invalid).props.disabled).toBe(true)
+ it("keeps one pending save alive through a shell handoff and ignores the stale shell close", async () => {
+ mocks.breakpoint = "mobile"
+ const pending = deferred()
+ const onSave = vi.fn(() => pending.promise)
+ const rendered = renderDialog({ onSave })
+ setOpen(rendered.renderer.root, true)
+ act(() => tagButton(rendered.renderer.root, FORUM_ARCHIVE_TAG).props.onClick())
+ const staleMobileClose = rendered.renderer.root.findByType("mock-dialog").props.onOpenChange
+
+ await act(async () => {
+ byTestId(rendered.renderer.root, tid.forumTagDialogSave).props.onClick()
+ await Promise.resolve()
+ })
+ switchBreakpoint(rendered, "desktop")
+ expect(rendered.renderer.root.findByType("mock-popover").props.open).toBe(true)
+ expect(input(rendered.renderer.root).props.disabled).toBe(true)
+ act(() => staleMobileClose(false))
+ expect(rendered.renderer.root.findByType("mock-popover").props.open).toBe(true)
+ expect(onSave).toHaveBeenCalledOnce()
+
+ await act(async () => {
+ pending.resolve()
+ await pending.promise
+ })
+ expect(rendered.renderer.root.findByType("mock-popover").props.open).toBe(false)
+ expect(onSave).toHaveBeenCalledOnce()
})
- it.each([
- ["English", "w".repeat(MAX_FORUM_TAG_LENGTH)],
- ["Chinese", "标签".repeat(MAX_FORUM_TAG_LENGTH / 2)],
- ])("contains a maximum-length %s chip with an accessible truncated label and fixed remove icon", (_kind, tag) => {
+ it("caps input and contains maximum-length chip labels", () => {
+ const tag = "标签".repeat(MAX_FORUM_TAG_LENGTH / 2)
const { renderer } = renderDialog({ current: [tag], allTags: [tag] })
setOpen(renderer.root, true)
+ setDraft(renderer.root, "x".repeat(MAX_FORUM_TAG_LENGTH + 8))
+ expect(input(renderer.root).props.value).toBe("x".repeat(MAX_FORUM_TAG_LENGTH))
const button = tagButton(renderer.root, tag)
- const label = button.findByType("span")
- const removeIcon = button.findByType("svg")
-
- expect(tag).toHaveLength(MAX_FORUM_TAG_LENGTH)
expect(button.props.className).toContain("max-w-full")
- expect(button.props.className).toContain("min-w-0")
- expect(button.props["data-testid"]).toBe(tid.forumTagDialogChip(tag))
expect(button.props.title).toBe(`#${tag}`)
expect(button.props["aria-label"]).toBe(`Remove tag ${tag}`)
- expect(buttonText(button)).toBe(`#${tag}`)
- expect(label.props.className).toContain("min-w-0")
- expect(label.props.className).toContain("truncate")
- expect(buttonText(label)).toBe(`#${tag}`)
- expect(removeIcon.props.className).toContain("shrink-0")
- expect(removeIcon.props["aria-hidden"]).toBe("true")
+ expect(button.findByType("span").props.className).toContain("truncate")
+ })
+
+ it("uses compact mobile actions while preserving the desktop popover sizing", () => {
+ mocks.breakpoint = "mobile"
+ const rendered = renderDialog({ allTags: ["compact"] })
+ setOpen(rendered.renderer.root, true)
+
+ const mobileChipClass = String(tagButton(rendered.renderer.root, "compact").props.className)
+ expect(mobileChipClass).not.toContain("min-h-11")
+ expect(mobileChipClass).not.toContain("min-w-11")
+ const close = rendered.renderer.root.findByProps({ "aria-label": "Close" })
+ expect(close.props.size).toBe("icon-sm")
+ expect(String(close.props.className)).not.toContain("size-11")
+ for (const testid of [tid.forumTagDialogCancel, tid.forumTagDialogSave]) {
+ const actionClass = String(byTestId(rendered.renderer.root, testid).props.className)
+ expect(actionClass).toContain("px-4")
+ expect(actionClass).not.toContain("h-11")
+ }
+ expect(String(input(rendered.renderer.root).props.className)).toContain("h-11")
+
+ switchBreakpoint(rendered, "desktop")
+ const popover = rendered.renderer.root.findByType("section")
+ expect(popover.props.className).toBe("w-64 space-y-3 p-3")
+ expect(String(input(rendered.renderer.root).props.className)).toContain("h-8")
+ expect(String(tagButton(rendered.renderer.root, "compact").props.className))
+ .not.toContain("min-h-11")
})
})
diff --git a/src/web/src/components/community/channels/post-tag-dialog.tsx b/src/web/src/components/community/channels/post-tag-dialog.tsx
index 7a9046781..954d6a276 100644
--- a/src/web/src/components/community/channels/post-tag-dialog.tsx
+++ b/src/web/src/components/community/channels/post-tag-dialog.tsx
@@ -1,15 +1,120 @@
"use client"
-import { useEffect, useState, type ReactElement } from "react"
+import {
+ useEffect,
+ useLayoutEffect,
+ useRef,
+ useState,
+ type ReactElement,
+ type RefObject,
+} from "react"
import { X } from "lucide-react"
import { FORUM_ARCHIVE_TAG, MAX_FORUM_TAG_LENGTH, MAX_FORUM_TAGS_PER_POST } from "@alook/shared"
+import {
+ Dialog,
+ DialogContent,
+ DialogTitle,
+ DialogTrigger,
+} from "@/components/ui/dialog"
import { Popover, PopoverContent, PopoverTrigger } from "@/components/ui/popover"
+import { Button } from "@/components/ui/button"
import { Input } from "@/components/ui/input"
+import { useBreakpoint, type Breakpoint } from "@/hooks/use-mobile"
import { onEnterSubmit } from "@/lib/ime"
import { tid } from "@/lib/community/testids"
import { tagColorClassName, tagColorStyle } from "@/lib/community/tag-color"
import { cn } from "@/lib/utils"
+type ResolvedShell = Exclude<Breakpoint, "unknown">
+
+type TagEditorBodyProps = {
+ selected: string[]
+ draft: string
+ chips: string[]
+ ordinaryTagCount: number
+ busy: boolean
+ mobile: boolean
+ inputRef: RefObject<HTMLInputElement | null>
+ onDraftChange: (value: string) => void
+ onToggle: (tag: string) => void
+ onAddDraft: () => void
+}
+
+function PostTagEditorBody({
+ selected,
+ draft,
+ chips,
+ ordinaryTagCount,
+ busy,
+ mobile,
+ inputRef,
+ onDraftChange,
+ onToggle,
+ onAddDraft,
+}: TagEditorBodyProps) {
+ return (
+ <div
+ data-testid={tid.forumTagDialogBody}
+ className={cn(
+ "space-y-3",
+ mobile && "min-h-0 flex-1 overflow-y-auto thin-scrollbar px-4 py-3",
+ )}
+ >
+ {!mobile && (
+ <p className="text-[11px] font-medium tracking-[0.12em] text-muted-foreground">TAGS</p>
+ )}
+
+ <div className="flex flex-wrap items-center gap-1.5">
+ {chips.length === 0 ? (
+ <p className="text-xs text-muted-foreground">No tags yet</p>
+ ) : chips.map((tag) => {
+ const active = selected.includes(tag)
+ const additionBlocked = !active && (
+ (tag !== FORUM_ARCHIVE_TAG && ordinaryTagCount >= MAX_FORUM_TAGS_PER_POST)
+ || tag.length > MAX_FORUM_TAG_LENGTH
+ )
+ return (
+ <button
+ key={tag}
+ type="button"
+ data-testid={tid.forumTagDialogChip(tag)}
+ disabled={busy || additionBlocked}
+ aria-label={`${active ? "Remove" : "Add"} tag ${tag}`}
+ title={`#${tag}`}
+ style={tagColorStyle(tag)}
+ className={cn(
+ "inline-flex max-w-full min-w-0 items-center rounded-lg px-2 py-1 text-xs transition-opacity disabled:cursor-not-allowed disabled:opacity-40",
+ tagColorClassName,
+ active ? "opacity-100 ring-1 ring-current/20" : "opacity-55 hover:opacity-80",
+ )}
+ onClick={() => onToggle(tag)}
+ >
+ <span className="min-w-0 truncate">#{tag}</span>
+ {active && <X aria-hidden="true" className="ml-1 size-3 shrink-0" />}
+ </button>
+ )
+ })}
+ </div>
+
+ <Input
+ ref={inputRef}
+ data-testid={tid.forumTagDialogInput}
+ value={draft}
+ onChange={(event) => onDraftChange(event.target.value.slice(0, MAX_FORUM_TAG_LENGTH))}
+ onKeyDown={onEnterSubmit(onAddDraft)}
+ maxLength={MAX_FORUM_TAG_LENGTH}
+ placeholder="Add a tag…"
+ className={cn("text-sm", mobile ? "h-11" : "h-8")}
+ disabled={busy || ordinaryTagCount >= MAX_FORUM_TAGS_PER_POST}
+ />
+
+ <p className="text-right text-[11px] text-muted-foreground">
+ {busy ? "Saving…" : mobile ? "↵ to add" : "↵ to add · saves on close"}
+ </p>
+ </div>
+ )
+}
+
export function PostTagDialog({
trigger,
postName,
@@ -22,18 +127,75 @@ export function PostTagDialog({
postName: string
current: string[]
allTags: string[]
- onSave: (tags: string[]) => void
+ onSave: (tags: string[]) => Promise<void> | void
saving?: boolean
}) {
+ const breakpoint = useBreakpoint()
+ const shell: ResolvedShell | null = breakpoint === "unknown" ? null : breakpoint
+ const activeShellRef = useRef<ResolvedShell | null>(shell)
+
const [open, setOpen] = useState(false)
+ const [baseline, setBaseline] = useState<string[]>(current)
const [selected, setSelected] = useState<string[]>(current)
const [draft, setDraft] = useState("")
+ const [committing, setCommitting] = useState(false)
+ const triggerRef = useRef<HTMLButtonElement>(null)
+ const surfaceRef = useRef<HTMLDivElement>(null)
+ const inputRef = useRef<HTMLInputElement>(null)
+ const previousShellRef = useRef<ResolvedShell | null>(shell)
+ const previousOpenRef = useRef(open)
+ const busy = !!saving || committing
const ordinaryTagCount = selected.filter((tag) => tag !== FORUM_ARCHIVE_TAG).length
+ const changed = selected.length !== baseline.length
+ || selected.some((tag, index) => tag !== baseline[index])
+
+ useLayoutEffect(() => {
+ activeShellRef.current = shell
+ }, [shell])
useEffect(() => {
- if (!open) setSelected(current)
+ if (!open) {
+ setBaseline(current)
+ setSelected(current)
+ }
}, [current, open])
+ useEffect(() => {
+ const previousShell = previousShellRef.current
+ previousShellRef.current = shell
+ if (!open || !previousShell || !shell || previousShell === shell) return
+ if (!busy && inputRef.current) {
+ inputRef.current.focus()
+ return
+ }
+ surfaceRef.current?.focus()
+ }, [busy, open, shell])
+
+ useEffect(() => {
+ const wasOpen = previousOpenRef.current
+ previousOpenRef.current = open
+ if (wasOpen && !open) triggerRef.current?.focus()
+ }, [open])
+
+ const begin = () => {
+ if (open) return
+ setBaseline(current)
+ setSelected(current)
+ setDraft("")
+ setOpen(true)
+ }
+
+ const finish = () => {
+ setOpen(false)
+ setDraft("")
+ }
+
+ const discard = () => {
+ if (busy) return
+ setSelected(current)
+ finish()
+ }
+
const toggle = (tag: string) => {
setSelected((previous) => {
if (previous.includes(tag)) return previous.filter((candidate) => candidate !== tag)
@@ -62,11 +224,42 @@ export function PostTagDialog({
setDraft("")
}
- const close = () => {
- setOpen(false)
- const changed = selected.length !== current.length
- || selected.some((tag, index) => tag !== current[index])
- if (changed) onSave(selected)
+ const closeDesktop = () => {
+ if (busy) return
+ finish()
+ if (!changed) return
+ try {
+ void Promise.resolve(onSave(selected)).catch(() => undefined)
+ } catch {
+ return
+ }
+ }
+
+ const saveMobile = async () => {
+ if (busy) return
+ if (!changed) {
+ finish()
+ return
+ }
+ setCommitting(true)
+ try {
+ await onSave(selected)
+ finish()
+ } catch {
+ return
+ } finally {
+ setCommitting(false)
+ }
+ }
+
+ const onShellOpenChange = (origin: ResolvedShell, nextOpen: boolean) => {
+ if (nextOpen) {
+ begin()
+ return
+ }
+ if (activeShellRef.current !== origin || busy) return
+ if (origin === "mobile") discard()
+ else closeDesktop()
}
const chips = [
@@ -76,21 +269,86 @@ export function PostTagDialog({
.sort(),
]
+ const body = (mobile: boolean) => (
+ <PostTagEditorBody
+ selected={selected}
+ draft={draft}
+ chips={chips}
+ ordinaryTagCount={ordinaryTagCount}
+ busy={busy}
+ mobile={mobile}
+ inputRef={inputRef}
+ onDraftChange={setDraft}
+ onToggle={toggle}
+ onAddDraft={addDraft}
+ />
+ )
+
+ if (!shell) return trigger
+
+ if (shell === "mobile") {
+ return (
+ <Dialog open={open} onOpenChange={(nextOpen) => onShellOpenChange("mobile", nextOpen)}>
+ <DialogTrigger ref={triggerRef} render={trigger} />
+ <DialogContent
+ ref={surfaceRef}
+ tabIndex={-1}
+ showCloseButton={false}
+ data-testid={tid.forumTagDialog}
+ aria-label={`Edit tags for ${postName}`}
+ className="flex max-h-[calc(100dvh-2rem-env(safe-area-inset-top)-env(safe-area-inset-bottom))] w-full flex-col gap-0 p-0"
+ onClick={(event) => event.stopPropagation()}
+ >
+ <div className="flex min-w-0 shrink-0 items-center gap-2 border-b border-border/50 py-3 pr-2 pl-4">
+ <DialogTitle className="min-w-0 flex-1 truncate text-sm font-semibold">
+ Edit tags for {postName}
+ </DialogTitle>
+ <Button
+ type="button"
+ variant="ghost"
+ size="icon-sm"
+ aria-label="Close"
+ disabled={busy}
+ onClick={discard}
+ >
+ <X aria-hidden="true" />
+ </Button>
+ </div>
+
+ {body(true)}
+
+ <div className="flex shrink-0 justify-end gap-2 border-t border-border/50 p-4">
+ <Button
+ type="button"
+ variant="outline"
+ className="px-4"
+ data-testid={tid.forumTagDialogCancel}
+ disabled={busy}
+ onClick={discard}
+ >
+ Cancel
+ </Button>
+ <Button
+ type="button"
+ className="px-4"
+ data-testid={tid.forumTagDialogSave}
+ disabled={busy}
+ onClick={() => void saveMobile()}
+ >
+ {busy ? "Saving…" : "Save"}
+ </Button>
+ </div>
+ </DialogContent>
+ </Dialog>
+ )
+ }
+
return (
- <Popover
- open={open}
- onOpenChange={(nextOpen) => {
- if (nextOpen) {
- setSelected(current)
- setDraft("")
- setOpen(true)
- return
- }
- close()
- }}
- >
- <PopoverTrigger render={trigger} />
+ <Popover open={open} onOpenChange={(nextOpen) => onShellOpenChange("desktop", nextOpen)}>
+ <PopoverTrigger ref={triggerRef} render={trigger} />
<PopoverContent
+ ref={surfaceRef}
+ tabIndex={-1}
side="bottom"
align="end"
className="w-64 space-y-3 p-3"
@@ -98,53 +356,7 @@ export function PostTagDialog({
aria-label={`Edit tags for ${postName}`}
onClick={(event) => event.stopPropagation()}
>
- <p className="text-[11px] font-medium tracking-[0.12em] text-muted-foreground">TAGS</p>
-
- <div className="flex flex-wrap items-center gap-1.5">
- {chips.length === 0 ? (
- <p className="text-xs text-muted-foreground">No tags yet</p>
- ) : chips.map((tag) => {
- const active = selected.includes(tag)
- const additionBlocked = !active && (
- (tag !== FORUM_ARCHIVE_TAG && ordinaryTagCount >= MAX_FORUM_TAGS_PER_POST)
- || tag.length > MAX_FORUM_TAG_LENGTH
- )
- return (
- <button
- key={tag}
- type="button"
- data-testid={tid.forumTagDialogChip(tag)}
- disabled={saving || additionBlocked}
- aria-label={`${active ? "Remove" : "Add"} tag ${tag}`}
- title={`#${tag}`}
- style={tagColorStyle(tag)}
- className={cn(
- "inline-flex max-w-full min-w-0 items-center rounded-lg px-2 py-1 text-xs transition-opacity disabled:cursor-not-allowed disabled:opacity-40",
- tagColorClassName,
- active ? "opacity-100 ring-1 ring-current/20" : "opacity-55 hover:opacity-80",
- )}
- onClick={() => toggle(tag)}
- >
- <span className="min-w-0 truncate">#{tag}</span>
- {active && <X aria-hidden="true" className="ml-1 size-3 shrink-0" />}
- </button>
- )
- })}
- </div>
-
- <Input
- value={draft}
- onChange={(event) => setDraft(event.target.value.slice(0, MAX_FORUM_TAG_LENGTH))}
- onKeyDown={onEnterSubmit(addDraft)}
- maxLength={MAX_FORUM_TAG_LENGTH}
- placeholder="Add a tag…"
- className="h-8 text-sm"
- disabled={saving || ordinaryTagCount >= MAX_FORUM_TAGS_PER_POST}
- />
-
- <p className="text-right text-[11px] text-muted-foreground">
- {saving ? "Saving…" : "↵ to add · saves on close"}
- </p>
+ {body(false)}
</PopoverContent>
</Popover>
)
diff --git a/src/web/src/lib/community/testids.ts b/src/web/src/lib/community/testids.ts
index bb9fd4e61..8ba629bc8 100644
--- a/src/web/src/lib/community/testids.ts
+++ b/src/web/src/lib/community/testids.ts
@@ -90,6 +90,10 @@ export const tid = {
machineQuotaDetail: (machineId: string) => `community-machine-quota-detail-${machineId}`,
forumTagDialog: "community-forum-tag-dialog",
+ forumTagDialogBody: "community-forum-tag-dialog-body",
+ forumTagDialogInput: "community-forum-tag-dialog-input",
+ forumTagDialogCancel: "community-forum-tag-dialog-cancel",
+ forumTagDialogSave: "community-forum-tag-dialog-save",
forumTagDialogChip: (tag: string) => `community-forum-tag-dialog-chip-${tag}`,
imageLightbox: "community-image-lightbox",
imageLightboxThumbnail: "community-image-lightbox-thumbnail",
diff --git a/src/web/src/test/e2e-ui/14-forum-post-tags-presence.spec.ts b/src/web/src/test/e2e-ui/14-forum-post-tags-presence.spec.ts
index 7c15a1321..1396d1e89 100644
--- a/src/web/src/test/e2e-ui/14-forum-post-tags-presence.spec.ts
+++ b/src/web/src/test/e2e-ui/14-forum-post-tags-presence.spec.ts
@@ -32,6 +32,7 @@ test.describe.serial("forum post tags + participant avatars", () => {
test("creator edits a post's tags from the card; the filter bar derives the union", async ({ asUser }) => {
const { page } = await asUser("alice")
+ await page.setViewportSize({ width: 1280, height: 900 })
await page.goto(`/c/channels/${serverId}/${forumId}`)
await page.waitForURL(new RegExp(forumId), { timeout: 20_000, waitUntil: "commit" })
diff --git a/src/web/src/test/e2e-ui/17-forum-sidebar-stage-b.spec.ts b/src/web/src/test/e2e-ui/17-forum-sidebar-stage-b.spec.ts
index 6d36d5a56..6feb1cf1e 100644
--- a/src/web/src/test/e2e-ui/17-forum-sidebar-stage-b.spec.ts
+++ b/src/web/src/test/e2e-ui/17-forum-sidebar-stage-b.spec.ts
@@ -99,6 +99,7 @@ async function setForumPostArchived(
threadId: string,
currentlyArchived: boolean,
) {
+ await page.setViewportSize({ width: 1280, height: 900 })
await page.goto(`/c/channels/${serverId}/${forumId}`)
await expect(page.getByTestId(tid.forumPostList)).toBeVisible({ timeout: 20_000 })
if (currentlyArchived) {
diff --git a/src/web/src/test/e2e-ui/51-mobile-forum-tag-editor.spec.ts b/src/web/src/test/e2e-ui/51-mobile-forum-tag-editor.spec.ts
new file mode 100644
index 000000000..02e67ec90
--- /dev/null
+++ b/src/web/src/test/e2e-ui/51-mobile-forum-tag-editor.spec.ts
@@ -0,0 +1,189 @@
+import type { Page } from "@playwright/test"
+import { test, expect } from "./_fixtures/community-fixture"
+import { gotoAfterUserWsAuth } from "./_fixtures/actions"
+import { seedChannel, seedForumThread, seedServer } from "./_fixtures/seed"
+import { tid } from "./_fixtures/testids"
+
+function observeTagPuts(page: Page): string[] {
+ const writes: string[] = []
+ page.on("request", (request) => {
+ const path = new URL(request.url()).pathname
+ if (request.method() === "PUT" && path.endsWith("/tags")) writes.push(path)
+ })
+ return writes
+}
+
+async function seedForum(label: string) {
+ const serverId = await seedServer("alice", `${label} ${Date.now()}`)
+ const forumId = await seedChannel("alice", serverId, "tag-editor", "forum")
+ const threadId = await seedForumThread("alice", forumId, `Post ${Date.now()}`, "tag editor body")
+ return {
+ route: `/c/channels/${serverId}/${forumId}`,
+ threadId,
+ }
+}
+
+async function openEditor(page: Page, threadId: string) {
+ await page.getByTestId(tid.forumThreadCard(threadId)).hover()
+ const trigger = page.getByTestId(tid.forumThreadTagBtn(threadId))
+ await trigger.click()
+ await expect(page.getByTestId(tid.forumTagDialog)).toBeVisible()
+ return trigger
+}
+
+async function addDraft(page: Page, tag: string) {
+ const input = page.getByTestId(tid.forumTagDialogInput)
+ await input.fill(tag)
+ await input.press("Enter")
+ await expect(page.getByTestId(tid.forumTagDialogChip(tag))).toHaveAttribute(
+ "aria-label",
+ `Remove tag ${tag}`,
+ )
+}
+
+test.describe.serial("mobile forum tag editor", () => {
+ test("discards implicit close and commits only explicit Save", async ({ asUser }) => {
+ const { route, threadId } = await seedForum("Mobile explicit save")
+ const { page } = await asUser("alice")
+ await page.setViewportSize({ width: 390, height: 844 })
+ await gotoAfterUserWsAuth(page, route)
+ const writes = observeTagPuts(page)
+ const initialUrl = page.url()
+
+ const trigger = await openEditor(page, threadId)
+ await addDraft(page, "discarded")
+ await page.keyboard.press("Escape")
+ await expect(page.getByTestId(tid.forumTagDialog)).toHaveCount(0)
+ await expect(trigger).toBeFocused()
+ await expect(page).toHaveURL(initialUrl)
+ expect(writes).toEqual([])
+
+ await openEditor(page, threadId)
+ await expect(page.getByTestId(tid.forumTagDialogChip("discarded"))).toHaveCount(0)
+ await addDraft(page, "kept")
+ const saved = page.waitForResponse((response) => (
+ response.request().method() === "PUT"
+ && new URL(response.url()).pathname.endsWith("/tags")
+ ))
+ await page.getByTestId(tid.forumTagDialogSave).click()
+ expect((await saved).status()).toBe(200)
+ await expect(page.getByTestId(tid.forumTagDialog)).toHaveCount(0)
+ await expect(trigger).toBeFocused()
+ await expect(page.getByTestId(tid.forumTagChip("kept"))).toBeVisible()
+ expect(writes).toHaveLength(1)
+ })
+
+ test("preserves one session across both breakpoint directions without transition writes", async ({ asUser }) => {
+ const { route, threadId } = await seedForum("Responsive tag session")
+ const { page } = await asUser("alice")
+ await page.setViewportSize({ width: 639, height: 844 })
+ await gotoAfterUserWsAuth(page, route)
+ const writes = observeTagPuts(page)
+
+ const trigger = await openEditor(page, threadId)
+ await addDraft(page, "cross-mobile")
+ await page.getByTestId(tid.forumTagDialogInput).fill("unfinished")
+ await page.setViewportSize({ width: 640, height: 844 })
+ const desktopSurface = page.getByTestId(tid.forumTagDialog)
+ await expect(desktopSurface).toBeVisible()
+ await expect(page.getByTestId(tid.forumTagDialogInput)).toHaveValue("unfinished")
+ await expect(page.getByTestId(tid.forumTagDialogChip("cross-mobile"))).toHaveAttribute(
+ "aria-label",
+ "Remove tag cross-mobile",
+ )
+ await expect.poll(() => desktopSurface.evaluate((node) => node.contains(document.activeElement))).toBe(true)
+ expect(writes).toEqual([])
+
+ const desktopSave = page.waitForResponse((response) => (
+ response.request().method() === "PUT"
+ && new URL(response.url()).pathname.endsWith("/tags")
+ ))
+ await page.keyboard.press("Escape")
+ expect((await desktopSave).status()).toBe(200)
+ await expect(desktopSurface).toHaveCount(0)
+ await expect(trigger).toBeFocused()
+ await expect(
+ page.getByTestId(tid.forumThreadCard(threadId)).getByText("#cross-mobile", { exact: true }),
+ ).toBeVisible()
+ expect(writes).toHaveLength(1)
+
+ await openEditor(page, threadId)
+ const crossMobileChip = page.getByTestId(tid.forumTagDialogChip("cross-mobile"))
+ await expect(crossMobileChip).toHaveAttribute("aria-label", "Remove tag cross-mobile")
+ await crossMobileChip.click()
+ await expect(crossMobileChip).toHaveAttribute("aria-label", "Add tag cross-mobile")
+ await page.getByTestId(tid.forumTagDialogInput).fill("mobile-discard")
+ await page.setViewportSize({ width: 639, height: 844 })
+ const mobileSurface = page.getByTestId(tid.forumTagDialog)
+ await expect(mobileSurface).toBeVisible()
+ await expect(page.getByTestId(tid.forumTagDialogInput)).toHaveValue("mobile-discard")
+ await expect(page.getByTestId(tid.forumTagDialogChip("cross-mobile"))).toHaveAttribute(
+ "aria-label",
+ "Add tag cross-mobile",
+ )
+ await expect.poll(() => mobileSurface.evaluate((node) => node.contains(document.activeElement))).toBe(true)
+ expect(writes).toHaveLength(1)
+
+ await page.getByTestId(tid.forumTagDialogCancel).click()
+ await expect(mobileSurface).toHaveCount(0)
+ await expect(trigger).toBeFocused()
+ expect(writes).toHaveLength(1)
+ await openEditor(page, threadId)
+ await expect(page.getByTestId(tid.forumTagDialogChip("cross-mobile"))).toHaveAttribute(
+ "aria-label",
+ "Remove tag cross-mobile",
+ )
+ await page.keyboard.press("Escape")
+ expect(writes).toHaveLength(1)
+ })
+
+ test("retains the draft after a failed Save and retries once", async ({ asUser }) => {
+ const { route, threadId } = await seedForum("Tag save retry")
+ const { page } = await asUser("alice")
+ await page.setViewportSize({ width: 390, height: 844 })
+ await gotoAfterUserWsAuth(page, route)
+ const writes = observeTagPuts(page)
+ let rejectNext = true
+ await page.route("**/api/community/messages/*/tags", async (routeRequest) => {
+ if (rejectNext) {
+ rejectNext = false
+ await routeRequest.fulfill({
+ status: 500,
+ contentType: "application/json",
+ body: JSON.stringify({ error: "retry" }),
+ })
+ return
+ }
+ await routeRequest.continue()
+ })
+
+ const trigger = await openEditor(page, threadId)
+ await addDraft(page, "retry-tag")
+ await page.getByTestId(tid.forumTagDialogInput).fill("still-here")
+ const failed = page.waitForResponse((response) => (
+ response.request().method() === "PUT"
+ && new URL(response.url()).pathname.endsWith("/tags")
+ ))
+ await page.getByTestId(tid.forumTagDialogSave).click()
+ expect((await failed).status()).toBe(500)
+ await expect(page.getByTestId(tid.forumTagDialog)).toBeVisible()
+ await expect(page.getByTestId(tid.forumTagDialogInput)).toHaveValue("still-here")
+ await expect(page.getByTestId(tid.forumTagDialogChip("retry-tag"))).toHaveAttribute(
+ "aria-label",
+ "Remove tag retry-tag",
+ )
+ await expect(page.getByTestId(tid.forumTagDialogSave)).toBeEnabled()
+
+ const retried = page.waitForResponse((response) => (
+ response.request().method() === "PUT"
+ && new URL(response.url()).pathname.endsWith("/tags")
+ && response.status() === 200
+ ))
+ await page.getByTestId(tid.forumTagDialogSave).click()
+ expect((await retried).status()).toBe(200)
+ await expect(page.getByTestId(tid.forumTagDialog)).toHaveCount(0)
+ await expect(trigger).toBeFocused()
+ await expect(page.getByTestId(tid.forumTagChip("retry-tag"))).toBeVisible()
+ expect(writes).toHaveLength(2)
+ })
+})