Multi-Agent Collaboration for Team and Friends
TypeScript agent-automationagent-orchestrationagent-workflowai-agentsai-collaborationai-memoryai-workforceautonomous-agentsclaude-codeclaude-code-skillscodexcoding-agentmulti-agentmultiple-agentone-person-businessone-person-companyone-person-teamopencodesolopreneur
fix(web): preserve initial scroll through native row measurement
Gener30f2158e6238
diff --git a/src/web/src/hooks/community/conversation-cache-reveal.dom.test.tsx b/src/web/src/hooks/community/conversation-cache-reveal.dom.test.tsxindex 910c08299..66c04cf03 100644--- a/src/web/src/hooks/community/conversation-cache-reveal.dom.test.tsx+++ b/src/web/src/hooks/community/conversation-cache-reveal.dom.test.tsx@@ -6,16 +6,101 @@ import { conversationEntryFixture, dmConversationEntryFixture, seedConversationEimport { ingestReadStateSnapshot } from "@/lib/community-db/sync"import { communityKeys } from "@/lib/query-keys"import { MessageList } from "@/components/community/messages/message-list"+import { CommunityRouteContext } from "@/contexts/community/route-frame"import { resolveMessageReadProjection } from "@/lib/community/message-read-projection"import { useDmMessages, useMessages } from "./use-messages"-import { installMessageScrollFixture, restoreMessageScrollFixture, resize, scrollFixture } from "@/test/message-scroll-fixture"+import { installMessageScrollFixture, restoreMessageScrollFixture, resize, runFrames, scrollFixture } from "@/test/message-scroll-fixture"++type ScrollResult = ReturnType<typeof import("./use-scroll-anchor").useScrollAnchor>+const preCommand = vi.hoisted(() => ({+ latest: null as unknown,+ finishes: [] as Array<{ kind: string; entry?: object | null; reason: string; source?: string }>,+}))+vi.mock("./use-scroll-anchor", async original => {+ const actual = await original<typeof import("./use-scroll-anchor")>()+ return { ...actual, useScrollAnchor: (...args: Parameters<typeof actual.useScrollAnchor>) => {+ const result = actual.useScrollAnchor(...args)+ preCommand.latest = result+ return result+ } }+})+vi.mock("@/lib/observability/position", async original => {+ const actual = await original<typeof import("@/lib/observability/position")>()+ return { ...actual, beginPositionObservation: (...args: Parameters<typeof actual.beginPositionObservation>) => {+ const finish = actual.beginPositionObservation(...args)+ let observed = false+ return (...end: Parameters<typeof finish>) => {+ if (!observed) preCommand.finishes.push({ kind: args[0], entry: args[2], reason: end[0], source: end[1]?.position_source })+ observed = true+ return finish(...end)+ }+ } }+})const load = vi.hoisted(() => vi.fn())vi.mock("@/lib/api/client", async original => ({ ...await original<typeof import("@/lib/api/client")>(), apiFetch: load }))-beforeEach(() => { installMessageScrollFixture(); load.mockReset() })+beforeEach(() => { installMessageScrollFixture(); load.mockReset(); preCommand.latest = null; preCommand.finishes = [] })afterEach(restoreMessageScrollFixture)const kinds = ["text", "text-thread", "forum-post", "dm"] as const+it.each(["text", "dm"] as const)("keeps ordinary $0 cached entry at the qualified tail after refresh", async kind => {+ scrollFixture.width = 390+ const owner = await createCommunityQueryOwner("viewer", { defaultOptions: { queries: { retry: false, staleTime: Infinity } } })+ const packet = kind === "dm" ? dmConversationEntryFixture() : conversationEntryFixture()+ const rows = Array.from({ length: 80 }, (_, index) => ({ ...packet.messages[0], id: `m${index + 1}`, seq: index + 1,+ createdAt: new Date(Date.UTC(2026, 9, 1, 0, 0, index + 1)).toISOString() }))+ packet.messages = rows.slice(0, 35)+ packet.readState = { ...packet.readState, lastReadMessageId: "m35", lastReadSeq: 35, lastReadAt: rows[34].createdAt }+ packet.selection = { reason: "read_pointer", anchorMessageId: "m35" }+ packet.page = { olderCursor: null, newerCursor: `${rows[34].createdAt}|m35`, hasMoreOlder: false, hasMoreNewer: true, latestSeq: 80 }+ await seedConversationEntry(owner.client, packet)+ const read = { ...packet.readState, lastReadMessageId: "m80", lastReadSeq: 80, lastReadAt: rows[79].createdAt }+ ingestReadStateSnapshot(owner.registry, { revision: 5, readStates: [read] })+ owner.client.removeQueries({ queryKey: communityKeys.conversationEntries("c1") })+ let release!: (value: typeof packet) => void+ load.mockReturnValue(new Promise(resolve => { release = resolve }))+ let feed!: ReturnType<typeof useMessages>+ function Probe() {+ const channel = useMessages(kind === "dm" ? null : "c1", { serverId: "s1" })+ const dm = useDmMessages(kind === "dm" ? "c1" : null)+ feed = kind === "dm" ? dm : channel+ const projection = resolveMessageReadProjection({ messages: feed.messages, lastReadMessageId: feed.readSnapshot?.lastReadMessageId ?? null,+ viewerUserId: "viewer", anchorReconciled: feed.anchorReconciled })+ return <MessageList channel="Channel" variant={kind === "dm" ? "dm" : "channel"} messages={feed.messages}+ loading={feed.isLoading} initialLoadError={feed.initialLoadError} targetLoadError={feed.targetLoadError}+ initialScrollReady={feed.initialDisplayReady} preserveInitialPresentation={feed.preserveInitialPresentation} positionScope={feed.positionScope} positionEntry={feed.positionEntry}+ positionDataState={feed.positionDataState} targetPositionDataState={feed.targetPositionDataState} messageWindow={feed.messageWindow}+ newDividerBefore={projection.newDividerBefore} hasMore={feed.hasMoreOlder} hasMoreNewer={feed.hasMoreNewer}+ onUserTakeover={feed.onUserTakeover} onRetryInitialLoad={feed.retryInitialLoad} retryingInitialLoad={feed.retryingInitialLoad} onOpenThread={() => {}} />+ }+ const view = render(<CommunityTestProvider {...owner}><Probe /></CommunityTestProvider>)+ const phases: unknown[] = []+ try {+ resize()+ const root = view.getByTestId("community-message-scroller")+ const capture = (phase: string) => phases.push({ phase, scrollTop: root.scrollTop, scrollHeight: root.scrollHeight, clientHeight: root.clientHeight,+ distanceToEnd: root.scrollHeight - root.clientHeight - root.scrollTop, first: feed.messages[0]?.id, last: feed.messages.at(-1)?.id,+ hasMoreNewer: feed.hasMoreNewer, positionDataState: feed.positionDataState, busy: root.getAttribute("aria-busy") })+ capture("cached-display")+ expect(root).toHaveAttribute("aria-busy", "false")+ expect(root.scrollHeight - root.clientHeight - root.scrollTop).toBeLessThanOrEqual(1)+ const fresh = { ...packet, messages: rows.slice(34), readState: read, readStateRevision: 5,+ selection: { reason: "read_pointer" as const, anchorMessageId: "m80" },+ page: { olderCursor: `${rows[34].createdAt}|m35`, newerCursor: null, hasMoreOlder: true, hasMoreNewer: false, latestSeq: 80 } }+ await act(async () => { release(fresh); await vi.advanceTimersByTimeAsync(0) })+ resize()+ capture("entry-refresh")+ expect(view.getByTestId("community-message-scroller")).toBe(root)+ expect(feed.messages.at(-1)?.id).toBe("m80")+ expect(root.querySelector("[data-new-divider]")).toBeNull()+ expect(root.scrollHeight - root.clientHeight - root.scrollTop).toBeLessThanOrEqual(1)+ expect(root.querySelector('[data-msg-id="m80"]')).not.toBeNull()+ } finally {+ console.info("ordinary-cache-tail-phases", JSON.stringify({ kind, phases }))+ view.unmount(); owner.client.clear()+ }+})+it.each(kinds.flatMap(kind => [{ takeover: true, repairFailure: false }, { takeover: false, repairFailure: false }, { takeover: true, repairFailure: true },].map(mode => ({ kind, ...mode }))))(@@ -247,3 +332,151 @@ it.each(kinds)("keeps $0 display qualification separate from an unavailable canoexpect(view.result.current.feed.navigationBlocked).toBe(true)} finally { view.unmount(); owner.client.clear() }})+++it.each([+ { name: "keeps ordinary cached tail ownership through its own pre-command row measurement", external: false },+ { name: "keeps unlabelled takeover through following native row compensation", external: true },+])("$name", async ({ external }) => {+ scrollFixture.width = 390+ const owner = await createCommunityQueryOwner("viewer", { defaultOptions: { queries: { retry: false, staleTime: Infinity } } })+ const packet = dmConversationEntryFixture()+ const rows = Array.from({ length: 60 }, (_, index) => ({ ...packet.messages[0], id: "ro" + (index + 1), seq: index + 1,+ createdAt: new Date(Date.UTC(2026, 9, 1, 0, 0, index + 1)).toISOString() }))+ packet.messages = rows+ packet.channel.messageCount = 60+ packet.readState = { ...packet.readState, lastReadMessageId: "ro60", lastReadSeq: 60, lastReadAt: rows[59].createdAt }+ packet.selection = { reason: "read_pointer", anchorMessageId: "ro60" }+ packet.page = { olderCursor: null, newerCursor: null, hasMoreOlder: false, hasMoreNewer: false, latestSeq: 60 }+ await seedConversationEntry(owner.client, packet)+ load.mockResolvedValue(packet)+ const href = "/c/me/c1"+ let navigation = { entryIntent: { href }, publishedHref: href, pendingHref: null, navigationPending: false }+ let nextIntent: { href: string } | null = null+ let feed!: ReturnType<typeof useDmMessages>+ let newDivider: string | undefined+ const handovers = vi.fn(() => feed.onUserTakeover())+ function Probe() {+ feed = useDmMessages("c1")+ const projection = resolveMessageReadProjection({ messages: feed.messages, lastReadMessageId: feed.readSnapshot?.lastReadMessageId ?? null,+ viewerUserId: "viewer", anchorReconciled: feed.anchorReconciled })+ newDivider = projection.newDividerBefore+ return <MessageList channel="DM" variant="dm" messages={feed.messages} loading={feed.isLoading}+ initialLoadError={feed.initialLoadError} targetLoadError={feed.targetLoadError}+ initialScrollReady={feed.initialDisplayReady} preserveInitialPresentation={feed.preserveInitialPresentation}+ positionScope={feed.positionScope} positionEntry={feed.positionEntry}+ positionDataState={feed.positionDataState} targetPositionDataState={feed.targetPositionDataState} messageWindow={feed.messageWindow}+ initialPositionMessageId={feed.initialPositionMessageId} newDividerBefore={newDivider}+ hasMore={feed.hasMoreOlder} hasMoreNewer={feed.hasMoreNewer}+ isFetching={feed.isFetching} isFetchingOlder={feed.isFetchingOlder} isFetchingNewer={feed.isFetchingNewer}+ onUserTakeover={handovers} onRetryInitialLoad={feed.retryInitialLoad} retryingInitialLoad={feed.retryingInitialLoad} onOpenThread={() => {}} />+ }+ function Page() {+ return <CommunityTestProvider {...owner}>+ <CommunityRouteContext value={{ breakpoint: "mobile", frame: { revision: nextIntent ? 2 : 1 }, navigation } as never}>+ <Probe />+ </CommunityRouteContext>+ </CommunityTestProvider>+ }+ const view = render(<Page />)+ const phases: unknown[] = []+ const writes: unknown[] = []+ let phase = "warm"+ let inputs = 0+ const input = () => { inputs++ }+ const current = () => preCommand.latest as ScrollResult+ const geometry = () => {+ const root = view.getByTestId("community-message-scroller")+ return { at: performance.now(), scrollTop: root.scrollTop, scrollHeight: root.scrollHeight, clientHeight: root.clientHeight,+ distanceToEnd: root.scrollHeight - root.clientHeight - root.scrollTop, outcome: current().positionOutcome,+ readReady: current().readPositionReady, inputCount: inputs, first: feed.messages[0]?.id, last: feed.messages.at(-1)?.id }+ }+ try {+ resize()+ const root = view.getByTestId("community-message-scroller")+ const native = current().virtualizer+ expect(root.scrollHeight - root.clientHeight - root.scrollTop).toBeLessThanOrEqual(1)+ for (const kind of ["wheel", "keydown", "pointerdown", "touchstart"]) root.addEventListener(kind, input)+ phase = "old-user-setup"+ fireEvent.wheel(root, { deltaY: -2000 })+ act(() => root.scrollTo({ top: 2000 }))+ resize()+ expect(root.scrollTop).toBeGreaterThan(0)+ expect(root.scrollHeight - root.clientHeight - root.scrollTop).toBeGreaterThan(500)+ expect(native.isScrolling).toBe(false)+ const selected = native.getVirtualItems().findLast(row => String(row.key).startsWith("msg:") && row.end <= root.scrollTop)+ expect(selected, "Preparation invalid: no mounted above-fold row").toBeDefined()+ const wrapper = root.querySelector<HTMLElement>("[data-index='" + selected!.index + "']")+ expect(wrapper, "Preparation invalid: native row wrapper is not mounted").not.toBeNull()+ expect(wrapper!.querySelector<HTMLElement>("[data-message-row-key]")?.dataset.messageRowKey).toBe(String(selected!.key))+ const body = wrapper!.querySelector<HTMLElement>("[data-msg-id]")+ expect(body, "Preparation invalid: mounted row has no message body").not.toBeNull()+ const id = body!.dataset.msgId!+ expect(id).toBeTruthy()+ const bodyHeight = body!.getBoundingClientRect().height+ const originalScrollTo = HTMLElement.prototype.scrollTo+ vi.spyOn(HTMLElement.prototype, "scrollTo").mockImplementation(function(this: HTMLElement, ...args: [options?: ScrollToOptions] | [x: number, y: number]) {+ const before = this.scrollTop+ Reflect.apply(originalScrollTo, this, args)+ writes.push({ phase, before, requested: typeof args[0] === "number" ? args[1] : args[0]?.top, after: this.scrollTop, inputCount: inputs,+ nativeResizeStack: new Error().stack?.split("\n").filter(line => /resizeItem|applyScrollAdjustment|_scrollToOffset/.test(line)) })+ })+ const end = vi.spyOn(native, "scrollToEnd")+ const measure = vi.spyOn(native, "resizeItem")+ const inputBaseline = inputs+ handovers.mockClear()+ nextIntent = { href }+ navigation = { ...navigation, entryIntent: nextIntent }+ phase = "new-entry-before-first-frame"+ view.rerender(<Page />)+ expect(view.getByTestId("community-message-scroller")).toBe(root)+ expect(current().virtualizer).toBe(native)+ expect(native.scrollElement).toBe(root)+ expect(feed.positionEntry).toBe(nextIntent)+ expect(feed.readSnapshot?.lastReadMessageId).toBe("ro60")+ expect(feed.readSnapshot?.lastReadSeq).toBe(60)+ expect(feed.initialPositionMessageId).toBeNull()+ expect(newDivider).toBeUndefined()+ expect(feed.positionDataState).toBe("ready")+ expect(native.options.anchorTo).toBe("start")+ expect(end).not.toHaveBeenCalled()+ const origin = root.scrollTop+ phases.push({ phase, ...geometry(), pointer: feed.readSnapshot?.lastReadSeq, initialTarget: feed.initialPositionMessageId, newDivider })+ if (external) {+ phase = "external-unlabelled-negative-control"+ act(() => root.scrollTo({ top: origin + 100 }))+ phases.push({ phase, ...geometry() })+ }+ const beforeNative = root.scrollTop+ phase = "one-row-native-ro"+ scrollFixture.bodyHeights.set(id, bodyHeight + 40)+ resize(0)+ phases.push({ phase, ...geometry(), row: id, nativeResizeCalls: measure.mock.calls.map(([index, size]) => ({ index, size })),+ firstEndCalls: end.mock.calls.length, nativeOffset: native.scrollOffset })+ expect(measure.mock.calls.some(([index]) => index === selected!.index), "Preparation invalid: selected row was not measured through RO").toBe(true)+ expect(Math.abs(root.scrollTop - beforeNative), "Preparation invalid: no automatic native offset change").toBeGreaterThan(1)+ expect(inputs).toBe(inputBaseline)+ expect(end).not.toHaveBeenCalled()+ phase = "new-entry-first-frames"+ runFrames()+ phases.push({ phase, ...geometry(), firstEndCalls: end.mock.calls.length, newHandovers: handovers.mock.calls.length })+ const decisions = preCommand.finishes.filter(event => event.entry === nextIntent)+ expect(decisions.some(event => event.source === "tail"), "Preparation invalid: no actual tail decision").toBe(true)+ expect(inputs).toBe(inputBaseline)+ if (external) {+ expect(root.scrollHeight - root.clientHeight - root.scrollTop).toBeGreaterThan(500)+ expect(decisions.some(event => event.reason === "origin_changed")).toBe(true)+ expect(handovers).toHaveBeenCalledOnce()+ expect(end).not.toHaveBeenCalled()+ } else {+ expect(root.scrollHeight - root.clientHeight - root.scrollTop).toBeLessThanOrEqual(1)+ expect(decisions.some(event => event.reason === "origin_changed")).toBe(false)+ expect(handovers).not.toHaveBeenCalled()+ expect(end).toHaveBeenCalledOnce()+ }+ } finally {+ console.info("pre-command-row-measurement-facts", JSON.stringify({ phases, writes, decisions: preCommand.finishes.map(({ kind, entry, reason, source }) => ({ kind, entry: entry === nextIntent ? "new" : "old", reason, source })) }))+ view.unmount()+ owner.client.clear()+ }+})diff --git a/src/web/src/hooks/community/use-scroll-anchor.ts b/src/web/src/hooks/community/use-scroll-anchor.tsindex 842b17367..660de82a0 100644--- a/src/web/src/hooks/community/use-scroll-anchor.ts+++ b/src/web/src/hooks/community/use-scroll-anchor.ts@@ -1,7 +1,7 @@import { beginPositionObservation, type PositionDecision, type PositionReason } from "@/lib/observability/position"import { useAtom, useCreateAtom } from "@tanstack/react-store";import { useCallback, useLayoutEffect, useRef, useState } from "react"-import { measureElement, useVirtualizer, type ReactVirtualizer } from "@tanstack/react-virtual"+import { elementScroll, measureElement, useVirtualizer, type ReactVirtualizer } from "@tanstack/react-virtual"import { COMMUNITY_VIRTUALIZER_REACT_OPTIONS, type VirtualRowsLayoutSnapshot } from "./virtualizer-react-options"import { estimateRowHeight, computeBelowCount, type FlatItem } from "@/lib/community/message-list-items"import { MESSAGE_RAIL_TAIL_PADDING_END_PX } from "@/lib/community/conversation-layout"@@ -376,6 +376,20 @@ export function useScrollAnchor({&& lateNewRef.current.allowed && !lateNewRef.current.consumed && (ownerKind === "idle" || ownerKind === "initial")const getItemKey = useCallback((index: number) => items[index].key, [items])const estimateSize = useCallback((index: number) => estimateRowHeight(items[index], !!hasMoreOlder), [items, hasMoreOlder])+ const scrollToFn = useCallback<ReactVirtualizer<HTMLDivElement, Element>["options"]["scrollToFn"]>((offset, options, native) => {+ const owner = positionOwnerRef.current+ const epoch = owner.epoch+ const intent = semanticIntentRef.current+ const origin = intent?.origin+ const root = scrollRef.current+ const ownsOrigin = owner.active && contextRef.current.visible && intent && !intent.issued && intent.epoch === epoch+ && root && origin && origin.root === root && native === virtualizerRef.current && native.scrollElement === root+ && Math.abs(root.scrollTop - origin.offset) <= 1+ elementScroll(offset, options, native)+ if (ownsOrigin && root && origin && intent && !intent.issued && owner.active && owner.epoch === epoch+ && contextRef.current.visible && semanticIntentRef.current === intent && intent.origin === origin+ && scrollRef.current === root && virtualizerRef.current === native) origin.offset = root.scrollTop+ }, [])// eslint-disable-next-line react-hooks/incompatible-library -- supported TanStack Virtual imperative adapterconst virtualizer = useVirtualizer({...COMMUNITY_VIRTUALIZER_REACT_OPTIONS,@@ -384,6 +398,7 @@ export function useScrollAnchor({initialRect: { width: 0, height: 800 },count: items.length,getScrollElement: () => scrollRef.current,+ scrollToFn,estimateSize,useCachedMeasurements: !visible,measureElement: (element, entry, instance) => {