Skip to content

armgit / alook

Public Imported from GitHub
0

Multi-Agent Collaboration for Team and Friends

fix(driver): allow Windows old ACP initialization to complete

Gus381f64680e97
diff --git a/src/daemon/agent-driver/src/adapters/antigravity/acp-lane.ts b/src/daemon/agent-driver/src/adapters/antigravity/acp-lane.ts
index 16f766e74..23ed064b9 100644
--- a/src/daemon/agent-driver/src/adapters/antigravity/acp-lane.ts
+++ b/src/daemon/agent-driver/src/adapters/antigravity/acp-lane.ts
@@ -440,7 +440,8 @@ export class AntigravityAcpLane implements RuntimeLane {
}
private call(method: string, params: JsonRecord): Promise<unknown> {
- return this.request(method, params, this.options.handshakeTimeoutMs ?? HANDSHAKE_TIMEOUT_MS).promise;
+ const timeoutMs = this.options.handshakeTimeoutMs ?? (method === "initialize" && process.platform === "win32" ? 30_000 : HANDSHAKE_TIMEOUT_MS);
+ return this.request(method, params, timeoutMs).promise;
}
private request(method: string, params: JsonRecord, timeoutMs?: number): RpcRequest {
diff --git a/src/daemon/agent-driver/src/adapters/antigravity/index.test.ts b/src/daemon/agent-driver/src/adapters/antigravity/index.test.ts
index 81ec27de4..b5f3edc68 100644
--- a/src/daemon/agent-driver/src/adapters/antigravity/index.test.ts
+++ b/src/daemon/agent-driver/src/adapters/antigravity/index.test.ts
@@ -408,3 +408,63 @@ describe("Antigravity Windows cold start budget", () => {
}
});
});
+
+
+describe("Antigravity default session initialization deadlines", () => {
+ it.each(["win32", "darwin", "linux"] as const)("handles a16-second initialize on %s", async (platform) => {
+ const h = setup();
+ const platformSpy = vi.spyOn(process, "platform", "get").mockReturnValue(platform);
+ vi.useFakeTimers();
+ h.proc.stdin.removeAllListeners("data");
+ h.proc.stdin.on("data", chunk => {
+ const request = JSON.parse(String(chunk));
+ h.messages.push(request);
+ if (request.method === "initialize") setTimeout(() => h.emit({ id: request.id, result: {
+ protocolVersion: 1, agentInfo: { name: "antigravity-acp" }, agentCapabilities: { loadSession: true },
+ } }), 16_000);
+ if (request.method === "session/new") h.emit({ id: request.id, result: { sessionId: "native-session" } });
+ });
+ const lane = new AntigravityAcpLane({ spawn: h.spawn }, h.ctx);
+ try {
+ const started = lane.start({ text: "first" });
+ const checked = platform === "win32"
+ ? expect(started).resolves.toMatchObject({ ok: true })
+ : expect(started).rejects.toThrow("initialize timed out");
+ await vi.advanceTimersByTimeAsync(16_100);
+ await checked;
+ expect(h.prompts()).toHaveLength(platform === "win32" ? 1 : 0);
+ await lane.stop();
+ expect(h.proc.kill).toHaveBeenCalledTimes(1);
+ } finally { platformSpy.mockRestore(); vi.useRealTimers(); }
+ });
+
+ it.each(["initialize", "session/load"] as const)("keeps silent Windows %s bounded and fences late replies", async (method) => {
+ const h = setup();
+ const platformSpy = vi.spyOn(process, "platform", "get").mockReturnValue("win32");
+ vi.useFakeTimers();
+ h.proc.stdin.removeAllListeners("data");
+ h.proc.stdin.on("data", chunk => {
+ const request = JSON.parse(String(chunk));
+ h.messages.push(request);
+ if (method !== "initialize" && request.method === "initialize") h.emit({ id: request.id, result: {
+ protocolVersion: 1, agentInfo: { name: "antigravity-acp" }, agentCapabilities: { loadSession: true },
+ } });
+ });
+ const lane = new AntigravityAcpLane({ spawn: h.spawn }, h.ctx);
+ try {
+ let settled = false;
+ const started = lane.start({ text: "first", ...(method === "session/load" ? { sessionId: "saved" } : {}) });
+ const checked = expect(started.finally(() => { settled = true; })).rejects.toThrow(`${method} timed out`);
+ const deadline = method === "initialize" ? 30_000 : 15_000;
+ await vi.advanceTimersByTimeAsync(deadline - 1);
+ expect(settled).toBe(false);
+ await vi.advanceTimersByTimeAsync(1);
+ await checked;
+ const request = h.messages.find(request => request.method === method)!;
+ h.emit({ id: request.id, result: { sessionId: "late-session", protocolVersion: 1 } });
+ expect(h.prompts()).toHaveLength(0);
+ await lane.stop();
+ expect(h.proc.kill).toHaveBeenCalledTimes(1);
+ } finally { platformSpy.mockRestore(); vi.useRealTimers(); }
+ });
+});
diff --git a/src/daemon/agent-driver/src/internal/probe.windows.test.ts b/src/daemon/agent-driver/src/internal/probe.windows.test.ts
index 07fe0d44a..744d1fc62 100644
--- a/src/daemon/agent-driver/src/internal/probe.windows.test.ts
+++ b/src/daemon/agent-driver/src/internal/probe.windows.test.ts
@@ -46,7 +46,7 @@ function launch(binary: string, args: string[]) {
return child;
}
-function waitForLine(child: ChildProcess, matches: (line: string) => boolean): Promise<string> {
+function waitForLine(child: ChildProcess, matches: (line: string) => boolean, timeoutMs = 20_000): Promise<string> {
const lines = createInterface({ input: child.stdout! });
return new Promise((resolve, reject) => {
const timer = setTimeout(() => {
@@ -54,7 +54,7 @@ function waitForLine(child: ChildProcess, matches: (line: string) => boolean): P
console.log(JSON.stringify({ stage: "readiness-timeout", binary: trace?.binary, pid: child.pid,
alive: child.pid ? isAlive(child.pid) : false, stdout: scrubDriverErrorMessage(trace?.stdout ?? ""), stderr: scrubDriverErrorMessage(trace?.stderr ?? "") }));
finish(new Error("runtime output timed out"));
- }, 20_000);
+ }, timeoutMs);
const onExit = (code: number | null, signal: string | null) => {
const trace = diagnostics.get(child);
finish(new Error(`${trace?.binary} exited before readiness: code=${code}, signal=${signal}, stderr=${scrubDriverErrorMessage(trace?.stderr ?? "")}`));
@@ -280,7 +280,7 @@ describe.skipIf(!nativePrefix)("real npm and native providers from an isolated p
const child = launch(binary, [...args]);
const initialized = waitForLine(child, line => {
try { return JSON.parse(line).id === 1; } catch { return false; }
- });
+ }, binary === "agy_acp_server.exe" ? 30_000 : 20_000);
child.stdin!.write(JSON.stringify({ jsonrpc: "2.0", id: 1, method: "initialize", params: {
protocolVersion: 1, clientCapabilities: {}, clientInfo: { name: "alook-windows-qa", version: "1.0.0" },
} }) + "\n");