Skip to content

armgit / alook

Public Imported from GitHub
0

Multi-Agent Collaboration for Team and Friends

fix(config): restore iPad interface rotation (#1139)

Gener6c7c02f3140f
diff --git a/.github/workflows/mobile-release.yml b/.github/workflows/mobile-release.yml
index b7c7eed70..27d254e35 100644
--- a/.github/workflows/mobile-release.yml
+++ b/.github/workflows/mobile-release.yml
@@ -179,7 +179,12 @@ jobs:
assert info["CFBundleIdentifier"] == "ai.alook.ios"
assert info["WKAppBoundDomains"] == ["localhost", "alook.ai"]
assert info["UISupportedInterfaceOrientations"] == ["UIInterfaceOrientationPortrait"]
- assert info["UISupportedInterfaceOrientations~ipad"] == ["UIInterfaceOrientationPortrait"]
+ assert info["UISupportedInterfaceOrientations~ipad"] == [
+ "UIInterfaceOrientationPortrait",
+ "UIInterfaceOrientationPortraitUpsideDown",
+ "UIInterfaceOrientationLandscapeLeft",
+ "UIInterfaceOrientationLandscapeRight",
+ ]
assert info.get("UIRequiresFullScreen") is True
assert info.get("UIRequiresFullScreen~iphone") is False
assert info["CFBundleURLTypes"] == [
diff --git a/scripts/ci/tauri-startup.test.ts b/scripts/ci/tauri-startup.test.ts
index e45906be8..99421981c 100644
--- a/scripts/ci/tauri-startup.test.ts
+++ b/scripts/ci/tauri-startup.test.ts
@@ -22,7 +22,12 @@ function verifyIosArtifact(overrides: Record<string, unknown> = {}) {
UIRequiresFullScreen: true,
"UIRequiresFullScreen~iphone": false,
UISupportedInterfaceOrientations: ["UIInterfaceOrientationPortrait"],
- "UISupportedInterfaceOrientations~ipad": ["UIInterfaceOrientationPortrait"],
+ "UISupportedInterfaceOrientations~ipad": [
+ "UIInterfaceOrientationPortrait",
+ "UIInterfaceOrientationPortraitUpsideDown",
+ "UIInterfaceOrientationLandscapeLeft",
+ "UIInterfaceOrientationLandscapeRight",
+ ],
CFBundleURLTypes: [{ CFBundleURLName: "ai.alook", CFBundleURLSchemes: ["ai.alook"] }],
}
for (const [key, value] of Object.entries(overrides)) {
@@ -98,16 +103,50 @@ describe("Tauri startup release separation", () => {
}
})
- it("accepts the final IPA metadata with portrait-only phone and tablet declarations and Boolean full-screen requirement", () => {
+ it("accepts the final IPA metadata with a portrait-only phone, rotating iPad and Boolean full-screen requirements", () => {
const result = verifyIosArtifact()
expect(result.error).toBeUndefined()
expect(result.status, result.stderr).toBe(0)
})
- const invalidOrientations: [string, string, string[] | undefined][] = [
- ["phone landscape", "UISupportedInterfaceOrientations", ["UIInterfaceOrientationPortrait", "UIInterfaceOrientationLandscapeLeft"]],
- ["tablet landscape", "UISupportedInterfaceOrientations~ipad", ["UIInterfaceOrientationPortrait", "UIInterfaceOrientationLandscapeRight"]],
- ["tablet upside-down", "UISupportedInterfaceOrientations~ipad", ["UIInterfaceOrientationPortrait", "UIInterfaceOrientationPortraitUpsideDown"]],
+ it("accepts the XcodeGen orientation declarations with the final IPA validator", () => {
+ const spec = read("gen/apple/project.yml")
+ const declarations: Record<string, string[]> = {}
+ for (const key of ["UISupportedInterfaceOrientations", "UISupportedInterfaceOrientations~ipad"]) {
+ const property = spec.match(new RegExp(`^ ${key}:\\n((?: - [^\\n]+\\n)+)`, "m"))
+ expect(property, key).not.toBeNull()
+ declarations[key] = [...property![1].matchAll(/- (\S+)/g)].map(match => match[1])
+ }
+ const result = verifyIosArtifact(declarations)
+ expect(result.error).toBeUndefined()
+ expect(result.status, result.stderr).toBe(0)
+ })
+
+ const invalidOrientations: [string, string, unknown][] = [
+ ["phone landscape left", "UISupportedInterfaceOrientations", ["UIInterfaceOrientationPortrait", "UIInterfaceOrientationLandscapeLeft"]],
+ ["phone landscape right", "UISupportedInterfaceOrientations", ["UIInterfaceOrientationPortrait", "UIInterfaceOrientationLandscapeRight"]],
+ ["phone upside-down", "UISupportedInterfaceOrientations", ["UIInterfaceOrientationPortrait", "UIInterfaceOrientationPortraitUpsideDown"]],
+ ["phone without portrait", "UISupportedInterfaceOrientations", ["UIInterfaceOrientationLandscapeLeft", "UIInterfaceOrientationLandscapeRight"]],
+ ["portrait-only tablet", "UISupportedInterfaceOrientations~ipad", ["UIInterfaceOrientationPortrait"]],
+ ...[
+ "UIInterfaceOrientationPortrait",
+ "UIInterfaceOrientationPortraitUpsideDown",
+ "UIInterfaceOrientationLandscapeLeft",
+ "UIInterfaceOrientationLandscapeRight",
+ ].map((missing): [string, string, unknown] => [
+ `tablet without ${missing}`,
+ "UISupportedInterfaceOrientations~ipad",
+ [
+ "UIInterfaceOrientationPortrait",
+ "UIInterfaceOrientationPortraitUpsideDown",
+ "UIInterfaceOrientationLandscapeLeft",
+ "UIInterfaceOrientationLandscapeRight",
+ ].filter(orientation => orientation !== missing),
+ ]),
+ ["phone string", "UISupportedInterfaceOrientations", "UIInterfaceOrientationPortrait"],
+ ["tablet string", "UISupportedInterfaceOrientations~ipad", "UIInterfaceOrientationPortrait"],
+ ["empty phone", "UISupportedInterfaceOrientations", []],
+ ["empty tablet", "UISupportedInterfaceOrientations~ipad", []],
["missing phone", "UISupportedInterfaceOrientations", undefined],
["missing tablet", "UISupportedInterfaceOrientations~ipad", undefined],
]
diff --git a/src/desktop/src-tauri/gen/apple/project.yml b/src/desktop/src-tauri/gen/apple/project.yml
index 4565366a3..5241ee2d5 100644
--- a/src/desktop/src-tauri/gen/apple/project.yml
+++ b/src/desktop/src-tauri/gen/apple/project.yml
@@ -51,6 +51,9 @@ targets:
- UIInterfaceOrientationPortrait
UISupportedInterfaceOrientations~ipad:
- UIInterfaceOrientationPortrait
+ - UIInterfaceOrientationPortraitUpsideDown
+ - UIInterfaceOrientationLandscapeLeft
+ - UIInterfaceOrientationLandscapeRight
CFBundleShortVersionString: 0.1.62
CFBundleVersion: "1"
NSPhotoLibraryAddUsageDescription: Allow Alook to save shared message images to Photos.