Multi-Agent Collaboration for Team and Friends
TypeScript agent-automationagent-orchestrationagent-workflowai-agentsai-collaborationai-memoryai-workforceautonomous-agentsclaude-codeclaude-code-skillscodexcoding-agentmulti-agentmultiple-agentone-person-businessone-person-companyone-person-teamopencodesolopreneur
fix(community): baseline bot inbox unread at join time, not seq 0
Gus72b4950ff5dc
diff --git a/src/shared/src/db/queries/community/agent-inbox.ts b/src/shared/src/db/queries/community/agent-inbox.tsindex 36a13ddcd..2beee2782 100644--- a/src/shared/src/db/queries/community/agent-inbox.ts+++ b/src/shared/src/db/queries/community/agent-inbox.ts@@ -13,6 +13,8 @@ import { eq, and, or, inArray, gt, lt, ne, asc, desc, sql, isNotNull } from "driimport {communityMessage,communityChannel,+ communityChannelMember,+ communityServerMember,communityDmConversation,communityServer,communityReadState,@@ -422,6 +424,24 @@ async function listAgentAllowedChannelIds(db: Database, botUserId: string): Promreturn visibleChannelIds.filter((id) => !narrowSet.has(id) || participating.has(id));}+/**+ * The "message is at/after the bot's join baseline" guard for the channel arm,+ * expressed over the LEFT-JOINed membership rows (see `withJoinBaseline`).+ * Mirrors the human unread baseline (`inbox.ts` `lastMessageAt > joinedAt`): a+ * bot's unread must start at the moment it JOINED, not at seq 0 — otherwise a+ * bot added to a server/channel with backlog gets flooded with all history+ * (the agent predicate keys on `seq > COALESCE(lastReadSeq,0)`, and a fresh+ * member has no read-state row → baseline 0 → every message matches).+ *+ * Baseline precedence: the private-channel access row's `added_at` when present+ * (bot explicitly added to that channel), else the server-member `joined_at`+ * for the channel's server. If neither exists (shouldn't happen for an allowed+ * channel), COALESCE falls to `''` → any ISO `createdAt > ''` is true → fail+ * open to the pre-existing behavior, never wrongly suppressing. Strict `>`: a+ * message whose `createdAt` exactly equals the join timestamp is NOT unread.+ */+const channelJoinBaselineGuard = sql`${communityMessage.createdAt} > COALESCE(${communityChannelMember.addedAt}, ${communityServerMember.joinedAt}, '')`;+/*** Cross-channel unread fill for `inboxPull`, grouped by channel/DM (not* global seq order — `seq` is a per-scope counter, comparing raw values@@ -462,6 +482,21 @@ export async function listUnreadMessagesForAgent()))+ .leftJoin(communityChannel, eq(communityChannel.id, communityMessage.channelId))+ .leftJoin(+ communityChannelMember,+ and(+ eq(communityChannelMember.channelId, communityMessage.channelId),+ eq(communityChannelMember.userId, botUserId)+ )+ )+ .leftJoin(+ communityServerMember,+ and(+ eq(communityServerMember.serverId, communityChannel.serverId),+ eq(communityServerMember.userId, botUserId)+ )+ ).where(and(ne(communityMessage.authorId, botUserId),@@ -471,7 +506,8 @@ export async function listUnreadMessagesForAgent(isNotNull(communityMessage.channelId),allowedChannelIds.length > 0? inArray(communityMessage.channelId, allowedChannelIds)- : sql`1 = 0`+ : sql`1 = 0`,+ channelJoinBaselineGuard),and(isNotNull(communityMessage.dmConversationId),@@ -541,6 +577,21 @@ export async function getInboxSnapshotForAgent(db: Database, botUserId: string):)))+ .leftJoin(communityChannel, eq(communityChannel.id, communityMessage.channelId))+ .leftJoin(+ communityChannelMember,+ and(+ eq(communityChannelMember.channelId, communityMessage.channelId),+ eq(communityChannelMember.userId, botUserId)+ )+ )+ .leftJoin(+ communityServerMember,+ and(+ eq(communityServerMember.serverId, communityChannel.serverId),+ eq(communityServerMember.userId, botUserId)+ )+ ).where(and(ne(communityMessage.authorId, botUserId),@@ -550,7 +601,8 @@ export async function getInboxSnapshotForAgent(db: Database, botUserId: string):isNotNull(communityMessage.channelId),allowedChannelIds.length > 0? inArray(communityMessage.channelId, allowedChannelIds)- : sql`1 = 0`+ : sql`1 = 0`,+ channelJoinBaselineGuard),and(isNotNull(communityMessage.dmConversationId),@@ -665,6 +717,21 @@ export async function getLatestUnreadMessageForAgent()))+ .leftJoin(communityChannel, eq(communityChannel.id, communityMessage.channelId))+ .leftJoin(+ communityChannelMember,+ and(+ eq(communityChannelMember.channelId, communityMessage.channelId),+ eq(communityChannelMember.userId, botUserId)+ )+ )+ .leftJoin(+ communityServerMember,+ and(+ eq(communityServerMember.serverId, communityChannel.serverId),+ eq(communityServerMember.userId, botUserId)+ )+ ).where(and(ne(communityMessage.authorId, botUserId),@@ -674,7 +741,8 @@ export async function getLatestUnreadMessageForAgent(isNotNull(communityMessage.channelId),allowedChannelIds.length > 0? inArray(communityMessage.channelId, allowedChannelIds)- : sql`1 = 0`+ : sql`1 = 0`,+ channelJoinBaselineGuard),and(isNotNull(communityMessage.dmConversationId),diff --git a/src/shared/test/queries/community-agent-inbox.test.ts b/src/shared/test/queries/community-agent-inbox.test.tsindex 15a517160..eb3324d6c 100644--- a/src/shared/test/queries/community-agent-inbox.test.ts+++ b/src/shared/test/queries/community-agent-inbox.test.ts@@ -349,9 +349,11 @@ describe("listUnreadMessagesForAgent", () => {await agentInbox.listUnreadMessagesForAgent(db, "bot_1", { max: 50 });const chainResult = db.select.mock.results[4]!.value;- // dm + read-state — communityChannel join dropped now that- // participation is folded into `listAgentAllowedChannelIds` up front.- expect(chainResult.leftJoin).toHaveBeenCalledTimes(2);+ // dm + read-state, plus the 3 join-baseline joins (channel + channel-member+ // + server-member) that back the `createdAt > joinedAt` guard so a freshly+ // joined bot isn't flooded with pre-join history. Visibility/participation+ // is still pre-narrowed in `listAgentAllowedChannelIds` up front.+ expect(chainResult.leftJoin).toHaveBeenCalledTimes(5);expect(chainResult.leftJoin.mock.invocationCallOrder[0]).toBeLessThan(chainResult.where.mock.invocationCallOrder[0]);@@ -488,8 +490,9 @@ describe("getLatestUnreadMessageForAgent", () => {]);await agentInbox.getLatestUnreadMessageForAgent(db, "bot_1");const chainResult = db.select.mock.results[4]!.value;- // dm + read-state.- expect(chainResult.leftJoin).toHaveBeenCalledTimes(2);+ // dm + read-state + the 3 join-baseline joins (channel, channel-member,+ // server-member) backing the `createdAt > joinedAt` guard.+ expect(chainResult.leftJoin).toHaveBeenCalledTimes(5);expect(chainResult.leftJoin.mock.invocationCallOrder[0]).toBeLessThan(chainResult.where.mock.invocationCallOrder[0]);@@ -635,8 +638,9 @@ describe("getInboxSnapshotForAgent", () => {await agentInbox.getInboxSnapshotForAgent(db, "bot_1");const chainResult = db.select.mock.results[4]!.value;- // dm + read-state.- expect(chainResult.leftJoin).toHaveBeenCalledTimes(2);+ // dm + read-state + the 3 join-baseline joins (channel, channel-member,+ // server-member) backing the `createdAt > joinedAt` guard.+ expect(chainResult.leftJoin).toHaveBeenCalledTimes(5);expect(chainResult.leftJoin.mock.invocationCallOrder[0]).toBeLessThan(chainResult.where.mock.invocationCallOrder[0]);