Skip to content

armgit / alook

Public Imported from GitHub
0

Multi-Agent Collaboration for Team and Friends

fix(email-worker): handle null/empty subject from RFC 2047 encoded emails

Gener9bec2bd1a0a9
diff --git a/src/email-worker/src/index.test.ts b/src/email-worker/src/index.test.ts
index 6b3753378..ae5997c55 100644
--- a/src/email-worker/src/index.test.ts
+++ b/src/email-worker/src/index.test.ts
@@ -203,7 +203,7 @@ describe("whitelisted path", () => {
expect(body.forwarded).toBeUndefined()
})
- it("defaults subject to empty string when header is missing", async () => {
+ it("defaults subject to '(No Subject)' when header is missing", async () => {
const { env, message, wsFetch } = setup({
isWhitelisted: true,
messageOpts: { from: "[email protected]", to: "[email protected]", subject: null },
@@ -212,7 +212,7 @@ describe("whitelisted path", () => {
await handler.email(message, env)
const notifyBody = JSON.parse(wsFetch.mock.calls[0][1].body)
- expect(notifyBody.subject).toBe("")
+ expect(notifyBody.subject).toBe("(No Subject)")
})
it("does NOT call message.forward", async () => {
diff --git a/src/email-worker/src/index.ts b/src/email-worker/src/index.ts
index 677afe063..f62a40b76 100644
--- a/src/email-worker/src/index.ts
+++ b/src/email-worker/src/index.ts
@@ -351,7 +351,7 @@ export default {
const parsed = await PostalMime.parse(rawBytes)
const attachmentsMeta = extractAttachmentMeta(parsed.attachments || [])
- const subject = message.headers.get("subject") ?? ""
+ const subject = message.headers.get("subject") || "(No Subject)"
const messageId = message.headers.get("message-id") ?? ""
const inReplyTo = message.headers.get("in-reply-to") ?? ""
const references = message.headers.get("references") ?? ""
diff --git a/src/shared/src/schemas.ts b/src/shared/src/schemas.ts
index b54df714a..6720750eb 100644
--- a/src/shared/src/schemas.ts
+++ b/src/shared/src/schemas.ts
@@ -589,7 +589,7 @@ export const EmailNotifyRequestSchema = z.object({
r2Key: z.string().min(1),
from: z.string().min(1),
to: z.string().optional(),
- subject: z.string().min(1),
+ subject: z.string(),
isWhitelisted: z.boolean(),
forwarded: z.boolean().optional().default(false),
messageId: z.string().optional().default(""),