Skip to content

armgit / alook

Public Imported from GitHub
0

Multi-Agent Collaboration for Team and Friends

fix(test): add machine owner_id to e2e seed for runtime member isolation (#324)

Generaadc73e473be
diff --git a/src/web/src/test/e2e/workspace-init.test.ts b/src/web/src/test/e2e/workspace-init.test.ts
index 181a3f12f..306a89374 100644
--- a/src/web/src/test/e2e/workspace-init.test.ts
+++ b/src/web/src/test/e2e/workspace-init.test.ts
@@ -160,6 +160,10 @@ describe("workspace init flow", () => {
// Register a runtime in the new workspace (POST /api/workspaces already adds user as member)
const now = new Date().toISOString()
const rtId = `rt_e2e_${Date.now()}`
+ sqlRun(
+ `INSERT INTO machine (daemon_id, workspace_id, device_info, last_seen_at, created_at, updated_at, owner_id) VALUES (?, ?, ?, ?, ?, ?, ?)`,
+ seed.daemonId, extraWorkspaceId, "test-device", now, now, now, seed.userId,
+ )
sqlRun(
`INSERT INTO agent_runtime (id, workspace_id, daemon_id, runtime_mode, provider, status, device_info, created_at, updated_at) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)`,
rtId, extraWorkspaceId, seed.daemonId, "local", "claude", "online", "test-device", now, now,
diff --git a/src/web/src/test/e2e/workspace-invites.test.ts b/src/web/src/test/e2e/workspace-invites.test.ts
index 908def5bb..eda55fd4e 100644
--- a/src/web/src/test/e2e/workspace-invites.test.ts
+++ b/src/web/src/test/e2e/workspace-invites.test.ts
@@ -118,6 +118,14 @@ describe("workspace invite flow", () => {
seed.workspaceId,
)[0].slug
+ // Create a runtime owned by the invitee so they can pass the member-isolation check
+ const inviteeUserId = sqlQuery<{ id: string }>(`SELECT id FROM "user" WHERE email = ?`, inviteeEmail)[0].id
+ const now = new Date().toISOString()
+ const inviteeDaemonId = `daemon_invitee_${Date.now()}`
+ const inviteeRtId = `rt_invitee_${Date.now()}`
+ sqlRun(`INSERT INTO machine (daemon_id, workspace_id, device_info, last_seen_at, created_at, updated_at, owner_id) VALUES (?, ?, ?, ?, ?, ?, ?)`, inviteeDaemonId, seed.workspaceId, "test", now, now, now, inviteeUserId)
+ sqlRun(`INSERT INTO agent_runtime (id, workspace_id, daemon_id, runtime_mode, provider, status, device_info, created_at, updated_at) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)`, inviteeRtId, seed.workspaceId, inviteeDaemonId, "local", "claude", "online", "test", now, now)
+
const res = await sessionRequest(`/api/studios`, inviteeCookie, {
method: "POST",
headers: {
@@ -126,7 +134,7 @@ describe("workspace invite flow", () => {
},
body: JSON.stringify({
name: "Hijacked Studio Name",
- members: [{ name: "Rogue", role: "leader", runtime_id: seed.runtimeId }],
+ members: [{ name: "Rogue", role: "leader", runtime_id: inviteeRtId }],
}),
})
expect(res.status).toBe(201)
diff --git a/tests/utils/src/seed.ts b/tests/utils/src/seed.ts
index 3a54462a9..70027f996 100644
--- a/tests/utils/src/seed.ts
+++ b/tests/utils/src/seed.ts
@@ -41,7 +41,7 @@ export function seedTestData(): TestSeed {
sqlRun(`INSERT INTO "user" (id, name, email, emailVerified, createdAt, updatedAt) VALUES (?, ?, ?, 1, ?, ?)`, userId, 'Test User', `${userId}@test.local`, now, now)
sqlRun(`INSERT INTO workspace (id, name, slug, created_at, updated_at) VALUES (?, ?, ?, ?, ?)`, workspaceId, 'Test Workspace', slug, now, now)
sqlRun(`INSERT INTO member (id, workspace_id, user_id, role, created_at) VALUES (?, ?, ?, ?, ?)`, memberId, workspaceId, userId, 'owner', now)
- sqlRun(`INSERT INTO machine (daemon_id, workspace_id, device_info, last_seen_at, created_at, updated_at) VALUES (?, ?, ?, ?, ?, ?)`, daemonId, workspaceId, 'test-device', now, now, now)
+ sqlRun(`INSERT INTO machine (daemon_id, workspace_id, device_info, last_seen_at, created_at, updated_at, owner_id) VALUES (?, ?, ?, ?, ?, ?, ?)`, daemonId, workspaceId, 'test-device', now, now, now, userId)
sqlRun(`INSERT INTO agent_runtime (id, workspace_id, daemon_id, runtime_mode, provider, status, device_info, created_at, updated_at) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)`, runtimeId, workspaceId, daemonId, 'local', 'claude', 'online', 'test-device', now, now)
sqlRun(`INSERT INTO agent (id, workspace_id, name, runtime_id, email_handle, owner_id, created_at, updated_at) VALUES (?, ?, ?, ?, ?, ?, ?, ?)`, agentId, workspaceId, 'Test Agent', runtimeId, emailHandle, userId, now, now)
sqlRun(`INSERT INTO machine_token (id, user_id, workspace_id, token, name, status, created_at) VALUES (?, ?, ?, ?, ?, ?, ?)`, machineTokenId, userId, workspaceId, rawToken, 'test-token', 'active', now)