Skip to content

armgit / alook

Public Imported from GitHub
0

Multi-Agent Collaboration for Team and Friends

fix(web): restore mobile profile seam and running ring

Generaf0a3704483a
diff --git a/src/web/src/app/globals.css b/src/web/src/app/globals.css
index 13021bef2..b26a721cb 100644
--- a/src/web/src/app/globals.css
+++ b/src/web/src/app/globals.css
@@ -472,6 +472,7 @@ body.driver-active .community-ws-reconnect-overlay * {
--popover-foreground: oklch(0.18 0.03 230);
--primary: oklch(0.22 0.03 230);
--primary-foreground: oklch(0.985 0.005 80);
+ --running-bots-primary: oklch(0.9 0.008 80);
--composer-send-active: #34c759;
--composer-send-active-foreground: #fff;
--apple-signin: oklch(0 0 0);
diff --git a/src/web/src/components/community/shell/user-bar-extension-slot.dom.test.tsx b/src/web/src/components/community/shell/user-bar-extension-slot.dom.test.tsx
index dc422f6f8..09b5ddc62 100644
--- a/src/web/src/components/community/shell/user-bar-extension-slot.dom.test.tsx
+++ b/src/web/src/components/community/shell/user-bar-extension-slot.dom.test.tsx
@@ -34,7 +34,7 @@ const machines = [{
}]
describe("UserBarExtensionSlot", () => {
- it("keeps the mobile primary card framed and gives only the companion the shrink budget", () => {
+ it("leaves mobile profile styling to the content and gives only the companion the shrink budget", () => {
const renderer = render(createElement(UserBarExtensionSlot, {
active: "profile",
profile: createElement("div", { "data-testid": "profile-content" }, "Profile"),
@@ -49,18 +49,11 @@ describe("UserBarExtensionSlot", () => {
const slot = renderer.getByTestId(tid.userBarExtension)
const scroller = renderer.getByTestId("profile-content").parentElement?.parentElement
expect(slot.style.maxHeight).toContain("100dvh")
- expect(slot.className).toContain("bg-transparent")
- expect(slot.className).toContain("shadow-none")
- expect(slot.className).not.toContain("border-border/40")
- expect(slot.className).not.toContain("border-x")
- expect(slot.className).not.toContain("border-t")
+ expect(slot.className).not.toMatch(/bg-|shadow-|border|rounded|overflow-|clip-path|text-popover-foreground/)
expect(scroller?.className).toContain("min-h-0")
expect(scroller?.className).not.toContain("overflow-y-auto")
expect(scroller?.style.maxHeight).toContain("100dvh")
- expect(renderer.getByTestId("profile-content").parentElement?.className).toContain("shrink-0")
- expect(renderer.getByTestId("profile-content").parentElement?.className).toContain("bg-popover")
- expect(renderer.getByTestId("profile-content").parentElement?.className).toContain("rounded-xl")
- expect(renderer.getByTestId("profile-content").parentElement?.className).not.toContain("shadow-")
+ expect(renderer.getByTestId("profile-content").parentElement?.className).toBe("shrink-0")
const companionSurface = renderer.getByTestId("profile-companion").parentElement
expect(companionSurface?.className).toContain("min-h-0")
expect(companionSurface?.className).toContain("flex-col")
diff --git a/src/web/src/components/community/shell/user-bar-extension-slot.tsx b/src/web/src/components/community/shell/user-bar-extension-slot.tsx
index 9daa045bb..dcd640d10 100644
--- a/src/web/src/components/community/shell/user-bar-extension-slot.tsx
+++ b/src/web/src/components/community/shell/user-bar-extension-slot.tsx
@@ -107,10 +107,8 @@ export function UserBarExtensionSlot({
data-presentation={presentation}
tabIndex={-1}
className={cn(
- "relative min-h-0 origin-bottom overflow-hidden text-popover-foreground",
- unframedMobileProfile
- ? "bg-transparent shadow-none [clip-path:inset(-2rem_-2rem_0)]"
- : "border-border/40 bg-popover shadow-(--e2)",
+ "relative min-h-0 origin-bottom",
+ !unframedMobileProfile && "overflow-hidden border-border/40 bg-popover text-popover-foreground shadow-(--e2)",
presentation === "popup"
? "rounded-xl border"
: !unframedMobileProfile && "rounded-t-xl border-x border-t [clip-path:inset(-2rem_-2rem_0)]",
@@ -131,7 +129,7 @@ export function UserBarExtensionSlot({
style={{ maxHeight: boundedHeight }}
>
{profileCompanion && <div className="flex min-h-0 flex-col">{profileCompanion}</div>}
- <div className={cn("shrink-0", unframedMobileProfile && "overflow-hidden rounded-xl border border-border bg-popover p-2")}>{profile}</div>
+ <div className="shrink-0">{profile}</div>
</div>
)}
{active === "update" && update && (
diff --git a/src/web/src/components/community/shell/user-bar.test.ts b/src/web/src/components/community/shell/user-bar.test.ts
index 90c1d8bfa..02b6a4ad3 100644
--- a/src/web/src/components/community/shell/user-bar.test.ts
+++ b/src/web/src/components/community/shell/user-bar.test.ts
@@ -23,7 +23,11 @@ describe("UserBar", () => {
expect(running).toContain("pointer-events-none absolute -inset-px")
expect(running).toContain("focus-visible:ring-offset-4")
expect(running).toContain("focus-visible:ring-offset-muted")
- expect(running).toContain("var(--primary)")
+ expect(running).toContain("var(--running-bots-primary)")
+ expect(readFileSync(new URL("../../../app/globals.css", import.meta.url), "utf8"))
+ .toContain("--running-bots-primary: oklch(0.9 0.008 80);")
+ expect(running).not.toContain("color-mix")
+ expect(running).not.toContain("var(--primary)")
expect(running).not.toContain("var(--status-online)")
expect(idle).toContain('aria-label="Open profile"')
expect(idle).not.toContain(tid.userBarRunningBotsRing)
@@ -100,7 +104,7 @@ describe("UserBar", () => {
expect(html).not.toContain("<a")
})
- it("joins the mobile Inbox to the user bar without seam radii", () => {
+ it("joins the mobile Inbox and Profile to the user bar without seam radii", () => {
const openHtml = renderToStaticMarkup(createElement(UserBar, {
breakpoint: "mobile",
user: { id: "u1", name: "User", avatar: "U" },
@@ -135,7 +139,7 @@ describe("UserBar", () => {
},
}))
expect(profileHtml).toContain(
- 'class="flex h-12 items-center gap-3 border border-border/40 bg-muted px-4 rounded-xl"',
+ 'class="flex h-12 items-center gap-3 border border-border/40 bg-muted px-4 rounded-b-xl"',
)
})
diff --git a/src/web/src/components/community/shell/user-bar.tsx b/src/web/src/components/community/shell/user-bar.tsx
index 4105dc6bd..7bb43a79f 100644
--- a/src/web/src/components/community/shell/user-bar.tsx
+++ b/src/web/src/components/community/shell/user-bar.tsx
@@ -63,7 +63,7 @@ export function UserBar({ breakpoint, user, onOpenProfile, onEditProfile, inbox,
const mobile = breakpoint === "mobile"
const joinedMobileExtension = mobile && (
inboxOpen
- || Boolean(extension && extension.active !== "none" && extension.active !== "profile")
+ || Boolean(extension && extension.active !== "none")
)
const closeInboxForAction = () => {
if (inboxOpen) onInboxOpenChange?.(false)
@@ -222,12 +222,12 @@ function Inner({ breakpoint, user, onOpenProfile, onEditProfile, inbox, hasUnrea
<span
data-testid={tid.userBarRunningBotsGlow}
aria-hidden
- className="user-bar-running-bots-glow pointer-events-none absolute -inset-1 rounded-full opacity-40 blur-[5px] [background:conic-gradient(from_30deg,var(--link),var(--primary),var(--link))]"
+ className="user-bar-running-bots-glow pointer-events-none absolute -inset-1 rounded-full opacity-40 blur-[5px] [background:conic-gradient(from_30deg,var(--link),var(--running-bots-primary),var(--link))]"
/>
<span
data-testid={tid.userBarRunningBotsRing}
aria-hidden
- className="pointer-events-none absolute -inset-px rounded-full [background:conic-gradient(from_30deg,var(--link),var(--primary),var(--link))]"
+ className="pointer-events-none absolute -inset-px rounded-full [background:conic-gradient(from_30deg,var(--link),var(--running-bots-primary),var(--link))]"
/>
</>
)}
diff --git a/src/web/src/components/community/social/profile-card-surface.dom.test.ts b/src/web/src/components/community/social/profile-card-surface.dom.test.ts
index 5cf4051ea..36d55df5b 100644
--- a/src/web/src/components/community/social/profile-card-surface.dom.test.ts
+++ b/src/web/src/components/community/social/profile-card-surface.dom.test.ts
@@ -144,7 +144,7 @@ describe("ProfileCard surface contracts", () => {
))
const profile = renderer.getByTestId("community-profile-card")
- expect(profile.className).toBe("w-full")
+ expect(profile.className).toBe("w-full overflow-hidden rounded-t-xl border-x border-t border-border/40 bg-popover p-2")
expect(renderer.container.querySelectorAll("sheet-root")).toHaveLength(0)
expect(renderer.container.querySelectorAll("popover-root")).toHaveLength(0)
})
diff --git a/src/web/src/components/community/social/profile-card.tsx b/src/web/src/components/community/social/profile-card.tsx
index 1747878a9..67139733d 100644
--- a/src/web/src/components/community/social/profile-card.tsx
+++ b/src/web/src/components/community/social/profile-card.tsx
@@ -350,7 +350,7 @@ function ProfileCardContent({ data, x, y, bp, onClose, onMessage, isSelf, onUpda
) : null
if (extension)
- return <div data-testid={tid.profileCard} className="w-full">{card}</div>
+ return <div data-testid={tid.profileCard} className={mobile ? "w-full overflow-hidden rounded-t-xl border-x border-t border-border/40 bg-popover p-2" : "w-full"}>{card}</div>
if (embedded)
return (