Skip to content

armgit / alook

Public Imported from GitHub
0

Multi-Agent Collaboration for Team and Friends

perf: add workspace constraints to expensive subqueries

Generb576be36874b
diff --git a/src/shared/src/db/queries/inbox.ts b/src/shared/src/db/queries/inbox.ts
index 6d5c112ac..aca6f55ac 100644
--- a/src/shared/src/db/queries/inbox.ts
+++ b/src/shared/src/db/queries/inbox.ts
@@ -55,14 +55,16 @@ export async function listUnreadConversations(
)
LEFT JOIN agent a
ON a.id = c.agent_id AND a.workspace_id = c.workspace_id
- WHERE t.parent_task_id IS NULL
+ WHERE t.workspace_id = ${workspaceId}
+ AND t.parent_task_id IS NULL
AND t.trace_id IS NOT NULL
AND t.type = 'user_dm_message'
AND t.status IN ('completed', 'failed')
AND t.completed_at > COALESCE(crs.last_read_at, '1970-01-01T00:00:00.000Z')
AND t.id = (
SELECT id FROM agent_task_queue
- WHERE conversation_id = c.id
+ WHERE workspace_id = ${workspaceId}
+ AND conversation_id = c.id
AND parent_task_id IS NULL
AND trace_id IS NOT NULL
AND type = 'user_dm_message'
@@ -94,7 +96,8 @@ export async function getUnreadCount(
AND c.workspace_id = ${workspaceId}
LEFT JOIN conversation_read_state crs
ON crs.conversation_id = t.conversation_id AND crs.user_id = ${userId}
- WHERE t.parent_task_id IS NULL
+ WHERE t.workspace_id = ${workspaceId}
+ AND t.parent_task_id IS NULL
AND t.trace_id IS NOT NULL
AND t.type = 'user_dm_message'
AND t.status IN ('completed', 'failed')
diff --git a/src/shared/src/db/queries/task.ts b/src/shared/src/db/queries/task.ts
index c6c457c79..df6aa7c49 100644
--- a/src/shared/src/db/queries/task.ts
+++ b/src/shared/src/db/queries/task.ts
@@ -473,7 +473,8 @@ export async function listActiveTaskCountsByWorkspace(
ne(agentTaskQueue.type, TASK_TYPES.KILL_TASK)
)
)
- .groupBy(agentTaskQueue.agentId);
+ .groupBy(agentTaskQueue.agentId)
+ .limit(200);
}
export async function listActiveTasksByWorkspace(
@@ -754,6 +755,7 @@ export async function listTraces(
.from(helperTask)
.where(
and(
+ eq(helperTask.workspaceId, workspaceId),
eq(helperTask.traceId, agentTaskQueue.traceId),
ne(helperTask.agentId, agentTaskQueue.agentId),
ne(helperTask.type, TASK_TYPES.KILL_TASK),
@@ -773,6 +775,7 @@ export async function listTraces(
.from(traceTask)
.where(
and(
+ eq(traceTask.workspaceId, workspaceId),
eq(traceTask.traceId, agentTaskQueue.traceId),
ne(traceTask.type, TASK_TYPES.KILL_TASK),
inArray(traceTask.status, ["queued", "dispatched", "running"])
@@ -782,11 +785,11 @@ export async function listTraces(
);
} else if (opts.status === "completed") {
conditions.push(
- sql`NOT EXISTS (SELECT 1 FROM ${agentTaskQueue} tt WHERE tt.trace_id = ${agentTaskQueue.traceId} AND tt.type != ${TASK_TYPES.KILL_TASK} AND tt.status IN ('queued', 'dispatched', 'running', 'failed'))`
+ sql`NOT EXISTS (SELECT 1 FROM ${agentTaskQueue} tt WHERE tt.workspace_id = ${workspaceId} AND tt.trace_id = ${agentTaskQueue.traceId} AND tt.type != ${TASK_TYPES.KILL_TASK} AND tt.status IN ('queued', 'dispatched', 'running', 'failed'))`
);
} else if (opts.status === "failed") {
conditions.push(
- sql`NOT EXISTS (SELECT 1 FROM ${agentTaskQueue} tt WHERE tt.trace_id = ${agentTaskQueue.traceId} AND tt.type != ${TASK_TYPES.KILL_TASK} AND tt.status IN ('queued', 'dispatched', 'running'))`
+ sql`NOT EXISTS (SELECT 1 FROM ${agentTaskQueue} tt WHERE tt.workspace_id = ${workspaceId} AND tt.trace_id = ${agentTaskQueue.traceId} AND tt.type != ${TASK_TYPES.KILL_TASK} AND tt.status IN ('queued', 'dispatched', 'running'))`
);
const failedTask = alias(agentTaskQueue, "failed_task");
conditions.push(
@@ -795,6 +798,7 @@ export async function listTraces(
.from(failedTask)
.where(
and(
+ eq(failedTask.workspaceId, workspaceId),
eq(failedTask.traceId, agentTaskQueue.traceId),
ne(failedTask.type, TASK_TYPES.KILL_TASK),
eq(failedTask.status, "failed")
@@ -837,6 +841,7 @@ export async function listTraces(
.from(agentTaskQueue)
.where(
and(
+ eq(agentTaskQueue.workspaceId, workspaceId),
inArray(agentTaskQueue.traceId, traceIds),
ne(agentTaskQueue.type, TASK_TYPES.KILL_TASK),
)