Skip to content

armgit / alook

Public Imported from GitHub
0

Multi-Agent Collaboration for Team and Friends

fix(web): prevent composer resize scroll jumps (#822)

Generbc0bab59ed68
diff --git a/src/web/src/components/community/channels/text-channel-surface.dom.test.ts b/src/web/src/components/community/channels/text-channel-surface.dom.test.ts
index dbd5cb909..3d8cdafc0 100644
--- a/src/web/src/components/community/channels/text-channel-surface.dom.test.ts
+++ b/src/web/src/components/community/channels/text-channel-surface.dom.test.ts
@@ -6,6 +6,7 @@ import type { MessageChannelControllerValue } from "../messages/message-channel-
import { ChannelHeader } from "./channel-header"
import { TextChannelSurface } from "./text-channel-surface"
import { MessageContextSheet } from "../messages/message-context-sheet"
+import { ComposerOverlayShell } from "../messages/composer-overlay-shell"
import { MessageList } from "../messages/message-list"
import { useChannelMessageFeed } from "@/hooks/community/use-channel-message-feed"
import { buildAttachmentUploadFormData } from "@/hooks/community/mutations/uploads"
@@ -48,6 +49,15 @@ vi.mock("@/components/community/channels/channel-shell", () => ({
vi.mock("@/components/community/messages/composer", () => ({
Composer: vi.fn(() => null),
}))
+vi.mock("@/components/community/messages/composer-overlay-shell", () => ({
+ ComposerOverlayShell: vi.fn(({ children, onOverlapChange, ...props }: {
+ children: React.ReactNode
+ onOverlapChange: (overlap: number) => void
+ }) => React.createElement("div", {
+ ...props,
+ onClick: () => onOverlapChange(96),
+ }, children)),
+}))
vi.mock("@/components/community/messages/message-list", () => ({
MessageList: vi.fn(() => null),
}))
@@ -110,6 +120,7 @@ function feed(overrides: Record<string, unknown> = {}) {
const mockedChannelHeader = vi.mocked(ChannelHeader)
const mockedMessageContextSheet = vi.mocked(MessageContextSheet)
+const mockedComposerOverlayShell = vi.mocked(ComposerOverlayShell)
const mockedMessageList = vi.mocked(MessageList)
const mockedUseChannelMessageFeed = vi.mocked(useChannelMessageFeed)
@@ -428,4 +439,34 @@ describe("TextChannelSurface header hierarchy", () => {
}))
expect(mockedChannelHeader.mock.calls.at(-1)?.[0].onToggle).toEqual(expect.any(Function))
})
+
+ it("passes measured composer overlap to the message list", () => {
+ mockedUseChannelMessageFeed.mockReturnValue(feed())
+ const renderer = render(React.createElement(TextChannelSurface, {
+ channelId: "channel_1",
+ serverId: "server_1",
+ serverParam: "server_1",
+ channelName: "general",
+ viewer: { id: "viewer_1", name: "Viewer", avatar: "V" },
+ anchorMessageId: null,
+ notificationLevel: "default",
+ onSetNotificationLevel: vi.fn(),
+ composerMembers: [],
+ composerMentionCandidates: undefined,
+ channelRefCandidates: [],
+ memberPanelProps: { members: [] },
+ manageMembersDialog: null,
+ uiHandlers: {},
+ onOpenThread: vi.fn(),
+ onOpenProfile: vi.fn(),
+ resolveUserName: (userId: string) => userId,
+ }))
+
+ expect(mockedComposerOverlayShell).toHaveBeenCalled()
+ expect(renderer.container.querySelector('[data-slot="community-conversation-surface"]'))
+ .toHaveAttribute("data-channel-id", "channel_1")
+ expect(mockedMessageList.mock.calls.at(-1)?.[0].composerOverlap).toBe(0)
+ fireEvent.click(renderer.getByTestId("community-composer-shell"))
+ expect(mockedMessageList.mock.calls.at(-1)?.[0].composerOverlap).toBe(96)
+ })
})
diff --git a/src/web/src/components/community/channels/text-channel-surface.tsx b/src/web/src/components/community/channels/text-channel-surface.tsx
index 3f666e4fd..2ee38e693 100644
--- a/src/web/src/components/community/channels/text-channel-surface.tsx
+++ b/src/web/src/components/community/channels/text-channel-surface.tsx
@@ -8,6 +8,7 @@ import { ChannelShell } from "@/components/community/channels/channel-shell"
import { CommunityPanel } from "@/components/community/shell/community-panel"
import type { ChannelMemberPanelProps } from "@/components/community/members/channel-member-view-model"
import { Composer } from "@/components/community/messages/composer"
+import { ComposerOverlayShell } from "@/components/community/messages/composer-overlay-shell"
import { MessageContextSheet } from "@/components/community/messages/message-context-sheet"
import { MessageList } from "@/components/community/messages/message-list"
import { useAuthorMentionInsertion } from "@/components/community/messages/use-author-mention-insertion"
@@ -69,6 +70,7 @@ export function TextChannelSurface({
}) {
const breakpoint = useBreakpoint()
const [rightPanel, setRightPanel] = useState<RightPanel>(null)
+ const [composerOverlap, setComposerOverlap] = useState(0)
const mentionInsertion = useAuthorMentionInsertion({
members: composerMembers,
viewerUserId: viewer.id,
@@ -124,11 +126,16 @@ export function TextChannelSurface({
/>
)}
body={(
- <Body className="flex min-h-0 min-w-0 flex-1 flex-col">
+ <Body
+ data-slot="community-conversation-surface"
+ data-channel-id={channelId}
+ className="flex min-h-0 min-w-0 flex-1 flex-col"
+ >
<MessageList
key={channelId}
channel={channelName}
messages={feed.messages}
+ composerOverlap={composerOverlap}
loading={feed.isLoading}
pinnedIds={controller.pinnedIds}
newDividerBefore={feed.newDividerBefore}
@@ -155,10 +162,10 @@ export function TextChannelSurface({
presentVersion={feed.presentVersion}
unreadCount={feed.unreadCount}
/>
- <div
+ <ComposerOverlayShell
data-onboarding-target="channel-composer"
data-testid={tid.channelComposerShell}
- className="shrink-0"
+ onOverlapChange={setComposerOverlap}
>
<Composer
ref={mentionInsertion.composerRef}
@@ -175,7 +182,7 @@ export function TextChannelSurface({
autoFocus={breakpoint === "desktop"}
draftKey={`${serverId}/${channelId}`}
/>
- </div>
+ </ComposerOverlayShell>
</Body>
)}
panels={rightPanel && (
diff --git a/src/web/src/components/community/channels/thread-channel-surface.dom.test.ts b/src/web/src/components/community/channels/thread-channel-surface.dom.test.ts
index 3d330edcf..a0bc83569 100644
--- a/src/web/src/components/community/channels/thread-channel-surface.dom.test.ts
+++ b/src/web/src/components/community/channels/thread-channel-surface.dom.test.ts
@@ -1,10 +1,11 @@
import React from "react"
-import { act, render } from "@/test/react-dom-harness"
+import { act, fireEvent, render } from "@/test/react-dom-harness"
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"
import { ThreadChannelSurface } from "./thread-channel-surface"
import { ChannelHeader, ChannelHeaderSkeleton } from "./channel-header"
import { CommunityPanel } from "../shell/community-panel"
import { Composer } from "../messages/composer"
+import { ComposerOverlayShell } from "../messages/composer-overlay-shell"
import { MessageContextSheet } from "../messages/message-context-sheet"
import { MessageList } from "../messages/message-list"
import { ThreadOpener } from "../messages/thread-opener"
@@ -66,6 +67,15 @@ vi.mock("@/components/community/messages/composer", () => ({
Composer: vi.fn(() => null),
ComposerSkeleton: vi.fn(() => null),
}))
+vi.mock("@/components/community/messages/composer-overlay-shell", () => ({
+ ComposerOverlayShell: vi.fn(({ children, onOverlapChange, ...props }: {
+ children: React.ReactNode
+ onOverlapChange: (overlap: number) => void
+ }) => React.createElement("div", {
+ ...props,
+ onClick: () => onOverlapChange(96),
+ }, children)),
+}))
vi.mock("@/components/community/messages/message-context-sheet", () => ({
MessageContextSheet: vi.fn(() => null),
}))
@@ -132,6 +142,7 @@ const mockedChannelHeader = vi.mocked(ChannelHeader)
const mockedChannelHeaderSkeleton = vi.mocked(ChannelHeaderSkeleton)
const mockedCommunityPanel = vi.mocked(CommunityPanel)
const mockedComposer = vi.mocked(Composer)
+const mockedComposerOverlayShell = vi.mocked(ComposerOverlayShell)
const mockedMessageContextSheet = vi.mocked(MessageContextSheet)
const mockedMessageList = vi.mocked(MessageList)
const mockedUseChannelMessageFeed = vi.mocked(useChannelMessageFeed)
@@ -308,6 +319,17 @@ describe("ThreadChannelSurface ownership", () => {
expect(mocks.setReplyTo).toHaveBeenCalledWith(null)
})
+ it("passes measured composer overlap to the thread message list", () => {
+ const renderer = render(React.createElement(ThreadChannelSurface, surfaceProps()))
+
+ expect(mockedComposerOverlayShell).toHaveBeenCalled()
+ expect(renderer.container.querySelector('[data-slot="community-conversation-surface"]'))
+ .toHaveAttribute("data-channel-id", "thread_1")
+ expect(mockedMessageList.mock.calls.at(-1)?.[0].composerOverlap).toBe(0)
+ fireEvent.click(renderer.getByTestId("community-composer-shell"))
+ expect(mockedMessageList.mock.calls.at(-1)?.[0].composerOverlap).toBe(96)
+ })
+
it("gates live and preview Pin actions without removing the pinned panel control", () => {
let renderer: ReturnType<typeof render>
act(() => {
diff --git a/src/web/src/components/community/channels/thread-channel-surface.tsx b/src/web/src/components/community/channels/thread-channel-surface.tsx
index 3d007d078..5d9617f3c 100644
--- a/src/web/src/components/community/channels/thread-channel-surface.tsx
+++ b/src/web/src/components/community/channels/thread-channel-surface.tsx
@@ -10,6 +10,7 @@ import { ChannelHeader, type ChannelNotifLevel } from "@/components/community/ch
import { ChannelShell } from "@/components/community/channels/channel-shell"
import { CommunityPanel } from "@/components/community/shell/community-panel"
import { Composer } from "@/components/community/messages/composer"
+import { ComposerOverlayShell } from "@/components/community/messages/composer-overlay-shell"
import { MessageChannelController } from "@/components/community/messages/message-channel-controller"
import { MessagePaneNavigationProvider } from "@/components/community/messages/message-pane-navigation"
import { MessageContextSheet } from "@/components/community/messages/message-context-sheet"
@@ -93,6 +94,7 @@ export function ThreadChannelSurface({
const router = useRouter()
const breakpoint = useBreakpoint()
const [rightPanel, setRightPanel] = useState<RightPanel>(null)
+ const [composerOverlap, setComposerOverlap] = useState(0)
const [localName, setLocalName] = useState<string | null>(null)
const mentionInsertion = useAuthorMentionInsertion({
members: composerMembers,
@@ -224,11 +226,16 @@ export function ThreadChannelSurface({
/>
)}
body={(
- <Body className="flex min-h-0 min-w-0 flex-1 flex-col">
+ <Body
+ data-slot="community-conversation-surface"
+ data-channel-id={channelId}
+ className="flex min-h-0 min-w-0 flex-1 flex-col"
+ >
<MessageList
key={channelId}
channel={displayName}
messages={controller.feed.messages}
+ composerOverlap={composerOverlap}
loading={controller.feed.isLoading}
pinnedIds={controller.pinnedIds}
newDividerBefore={controller.feed.newDividerBefore}
@@ -256,10 +263,10 @@ export function ThreadChannelSurface({
presentVersion={controller.feed.presentVersion}
unreadCount={controller.feed.unreadCount}
/>
- <div
+ <ComposerOverlayShell
data-onboarding-target="channel-composer"
data-testid={tid.channelComposerShell}
- className="shrink-0"
+ onOverlapChange={setComposerOverlap}
>
<Composer
ref={mentionInsertion.composerRef}
@@ -276,7 +283,7 @@ export function ThreadChannelSurface({
autoFocus={breakpoint === "desktop"}
draftKey={`${serverId}/${channelId}`}
/>
- </div>
+ </ComposerOverlayShell>
</Body>
)}
panels={rightPanel && (
diff --git a/src/web/src/components/community/messages/composer-accessory-rail.dom.test.ts b/src/web/src/components/community/messages/composer-accessory-rail.dom.test.ts
index 2ad8ecbdd..0b0f300c8 100644
--- a/src/web/src/components/community/messages/composer-accessory-rail.dom.test.ts
+++ b/src/web/src/components/community/messages/composer-accessory-rail.dom.test.ts
@@ -32,6 +32,7 @@ const baseProps = {
selectedCount: 0,
onCancelSelection: vi.fn(),
onShareSelection: vi.fn(),
+ composerOverlap: 0,
}
describe("ComposerAccessoryRail", () => {
@@ -132,6 +133,7 @@ describe("ComposerAccessoryRail", () => {
expect(railClasses).toContain("bottom-2")
expect(railClasses).toContain("sm:bottom-4")
expect(railClasses).not.toContain("bottom-3")
+ expect(rail).toHaveStyle({ transform: "translateY(-0px)" })
expect(rail).toHaveAttribute("data-layout", "centered")
const scroll = renderer.getByTestId(tid.scrollToPresent)
expect(scroll).toHaveAttribute("aria-label", "Jump to present, 4 unread below")
@@ -142,6 +144,12 @@ describe("ComposerAccessoryRail", () => {
expect(baseProps.onScroll).toHaveBeenCalledOnce()
})
+ it("moves above the live composer overlap", () => {
+ const renderer = renderRail({ composerOverlap: 96 })
+ expect(renderer.getByTestId(tid.composerAccessoryRail))
+ .toHaveStyle({ transform: "translateY(-96px)" })
+ })
+
it("never reserves composer space for WebSocket state", () => {
useCommunityWsStore.getState().setConnectionStatus("reconnecting")
const empty = renderRail({ scrollCount: 0 })
diff --git a/src/web/src/components/community/messages/composer-accessory-rail.tsx b/src/web/src/components/community/messages/composer-accessory-rail.tsx
index 8263f8a04..1b45239a1 100644
--- a/src/web/src/components/community/messages/composer-accessory-rail.tsx
+++ b/src/web/src/components/community/messages/composer-accessory-rail.tsx
@@ -19,6 +19,7 @@ export function ComposerAccessoryRail({
selectedCount,
onCancelSelection,
onShareSelection,
+ composerOverlap,
}: {
typingNames: string[]
scrollCount: number
@@ -28,6 +29,7 @@ export function ComposerAccessoryRail({
selectedCount: number
onCancelSelection: () => void
onShareSelection: () => void
+ composerOverlap: number
}) {
const hasTyping = typingNames.length > 0
const hasScroll = scrollCount > 0
@@ -43,6 +45,7 @@ export function ComposerAccessoryRail({
data-selection={selectMode ? "active" : "inactive"}
data-layout={layout}
className="pointer-events-none absolute inset-x-0 bottom-2 z-20 px-2 sm:bottom-4 sm:px-4"
+ style={{ transform: `translateY(-${composerOverlap}px)` }}
>
<div
className={cn(
diff --git a/src/web/src/components/community/messages/composer-overlay-shell.dom.test.tsx b/src/web/src/components/community/messages/composer-overlay-shell.dom.test.tsx
new file mode 100644
index 000000000..c07f81d1d
--- /dev/null
+++ b/src/web/src/components/community/messages/composer-overlay-shell.dom.test.tsx
@@ -0,0 +1,71 @@
+import React from "react"
+import { act, render } from "@/test/react-dom-harness"
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"
+import { ComposerOverlayShell } from "./composer-overlay-shell"
+
+let resize: ResizeObserverCallback | null = null
+let shellHeight = 60
+let overlayHeight = 60
+let offsetHeightDescriptor: PropertyDescriptor | undefined
+
+beforeEach(() => {
+ resize = null
+ shellHeight = 60
+ overlayHeight = 60
+ offsetHeightDescriptor = Object.getOwnPropertyDescriptor(HTMLElement.prototype, "offsetHeight")
+ Object.defineProperty(HTMLElement.prototype, "offsetHeight", {
+ configurable: true,
+ get() {
+ const slot = (this as HTMLElement).dataset.slot
+ if (slot === "community-composer-shell") return shellHeight
+ if (slot === "community-composer-overlay") return overlayHeight
+ return 0
+ },
+ })
+ vi.stubGlobal("ResizeObserver", class {
+ constructor(callback: ResizeObserverCallback) { resize = callback }
+ observe() {}
+ disconnect() {}
+ unobserve() {}
+ })
+})
+
+afterEach(() => {
+ vi.unstubAllGlobals()
+ if (offsetHeightDescriptor) {
+ Object.defineProperty(HTMLElement.prototype, "offsetHeight", offsetHeightDescriptor)
+ } else {
+ delete (HTMLElement.prototype as unknown as { offsetHeight?: unknown }).offsetHeight
+ }
+})
+
+describe("ComposerOverlayShell", () => {
+ it("reserves the collapsed height and reports only upward overlap", () => {
+ const onOverlapChange = vi.fn()
+ const renderer = render(
+ <ComposerOverlayShell onOverlapChange={onOverlapChange} data-testid="shell">
+ <div>composer</div>
+ </ComposerOverlayShell>,
+ )
+
+ const shell = renderer.getByTestId("shell")
+ expect(shell).toHaveClass("relative", "shrink-0")
+ expect(shell.className).toContain("h-[calc(3.75rem+var(--app-safe-area-bottom))]")
+ expect(shell).toHaveClass("sm:h-15")
+ expect(shell.querySelector('[data-slot="community-composer-overlay"]'))
+ .toHaveClass("absolute", "inset-x-0", "bottom-0", "z-30")
+ expect(onOverlapChange).toHaveBeenLastCalledWith(0)
+
+ overlayHeight = 156
+ act(() => resize?.([], {} as ResizeObserver))
+ expect(onOverlapChange).toHaveBeenLastCalledWith(96)
+
+ overlayHeight = 84
+ act(() => resize?.([], {} as ResizeObserver))
+ expect(onOverlapChange).toHaveBeenLastCalledWith(24)
+
+ overlayHeight = 48
+ act(() => resize?.([], {} as ResizeObserver))
+ expect(onOverlapChange).toHaveBeenLastCalledWith(0)
+ })
+})
diff --git a/src/web/src/components/community/messages/composer-overlay-shell.tsx b/src/web/src/components/community/messages/composer-overlay-shell.tsx
new file mode 100644
index 000000000..18198270e
--- /dev/null
+++ b/src/web/src/components/community/messages/composer-overlay-shell.tsx
@@ -0,0 +1,56 @@
+"use client"
+
+import { useLayoutEffect, useRef, type HTMLAttributes, type ReactNode } from "react"
+
+export function ComposerOverlayShell({
+ children,
+ className,
+ onOverlapChange,
+ ...props
+}: Omit<HTMLAttributes<HTMLDivElement>, "children"> & {
+ children: ReactNode
+ onOverlapChange: (overlap: number) => void
+}) {
+ const shellRef = useRef<HTMLDivElement>(null)
+ const overlayRef = useRef<HTMLDivElement>(null)
+ const overlapRef = useRef<number | null>(null)
+
+ useLayoutEffect(() => {
+ const shell = shellRef.current
+ const overlay = overlayRef.current
+ if (!shell || !overlay) return
+
+ const measure = () => {
+ const overlap = Math.max(0, overlay.offsetHeight - shell.offsetHeight)
+ if (overlap === overlapRef.current) return
+ overlapRef.current = overlap
+ onOverlapChange(overlap)
+ }
+
+ measure()
+ if (typeof ResizeObserver === "undefined") return
+ const observer = new ResizeObserver(measure)
+ observer.observe(shell)
+ observer.observe(overlay)
+ return () => observer.disconnect()
+ }, [onOverlapChange])
+
+ return (
+ <div
+ {...props}
+ ref={shellRef}
+ data-slot="community-composer-shell"
+ className={`relative h-[calc(3.75rem+var(--app-safe-area-bottom))] shrink-0 sm:h-15${
+ className ? ` ${className}` : ""
+ }`}
+ >
+ <div
+ ref={overlayRef}
+ data-slot="community-composer-overlay"
+ className="absolute inset-x-0 bottom-0 z-30"
+ >
+ {children}
+ </div>
+ </div>
+ )
+}
diff --git a/src/web/src/components/community/messages/message-list-controller.dom.test.ts b/src/web/src/components/community/messages/message-list-controller.dom.test.ts
index 309e5c722..7e07d7bac 100644
--- a/src/web/src/components/community/messages/message-list-controller.dom.test.ts
+++ b/src/web/src/components/community/messages/message-list-controller.dom.test.ts
@@ -65,6 +65,7 @@ function props(overrides: Partial<ResolvedMessageListProps> = {}): ResolvedMessa
onOpenThread: vi.fn(),
variant: "channel",
initialScrollReady: true,
+ composerOverlap: 0,
...overrides,
}
}
@@ -564,6 +565,32 @@ describe("useMessageListController", () => {
act(() => renderer!.unmount())
})
+ it("rechecks selected-row clearance when the composer moves the rail", () => {
+ selectionRailTop = 692
+ selectedRowBottom = 684
+ let renderer: ReturnType<typeof rtlRender>
+ act(() => {
+ renderer = rtlRender(
+ React.createElement(Probe, { value: props({ composerOverlap: 0 }) })
+ )
+ })
+
+ act(() => latest.onEnterSelectId("m1"))
+ runNextFrame()
+ runNextFrame()
+ expect(scrollNode.scrollTop).toBe(0)
+
+ selectionRailTop = 596
+ act(() => {
+ renderer!.rerender(
+ React.createElement(Probe, { value: props({ composerOverlap: 96 }) })
+ )
+ })
+ runNextFrame()
+ expect(scrollNode.scrollTop).toBe(96)
+ act(() => renderer!.unmount())
+ })
+
it("closes the share dialog before exiting selection mode", () => {
const source = readWebSource(
"src/components/community/messages/message-list-controller.ts",
diff --git a/src/web/src/components/community/messages/message-list-controller.ts b/src/web/src/components/community/messages/message-list-controller.ts
index 1e1b02a40..f65753852 100644
--- a/src/web/src/components/community/messages/message-list-controller.ts
+++ b/src/web/src/components/community/messages/message-list-controller.ts
@@ -12,6 +12,7 @@ const SELECTION_RAIL_GAP_PX = 8
export function useMessageListController({
messages,
+ composerOverlap,
loading,
newDividerBefore,
scrollToMessageId,
@@ -170,7 +171,7 @@ export function useMessageListController({
}
keepSelectionClearOfRail()
return () => window.cancelAnimationFrame(frame)
- }, [selectMode, selectedIds, scrollRef])
+ }, [composerOverlap, selectMode, selectedIds, scrollRef])
useEffect(() => {
if (!onScrollRoot) return
diff --git a/src/web/src/components/community/messages/message-list-facade.contract.test.ts b/src/web/src/components/community/messages/message-list-facade.contract.test.ts
index f4dbce688..9d05a3940 100644
--- a/src/web/src/components/community/messages/message-list-facade.contract.test.ts
+++ b/src/web/src/components/community/messages/message-list-facade.contract.test.ts
@@ -14,6 +14,7 @@ vi.mock("./initial-position-aurora.module.css", () => ({
type ExpectedMessageListProps = {
channel: string
messages: Msg[]
+ composerOverlap?: number
loading?: boolean
pinnedIds?: Set<string>
newDividerBefore?: string
@@ -67,6 +68,7 @@ describe("MessageList facade contract", () => {
const text = source("src/components/community/messages/message-list.tsx")
expect(text).toContain('variant = "channel"')
expect(text).toContain("initialScrollReady = true")
+ expect(text).toContain("composerOverlap = 0")
expect(text).toContain("useMessageListController(resolvedProps)")
expect(text).toContain("return renderMessageListView(resolvedProps, controller, () => (")
expect(text).toContain("<VirtualRows")
diff --git a/src/web/src/components/community/messages/message-list-row.dom.test.ts b/src/web/src/components/community/messages/message-list-row.dom.test.ts
index 9c5d18dc3..a611d0b3a 100644
--- a/src/web/src/components/community/messages/message-list-row.dom.test.ts
+++ b/src/web/src/components/community/messages/message-list-row.dom.test.ts
@@ -46,6 +46,7 @@ const props = {
messages: [],
variant: "channel" as const,
initialScrollReady: true,
+ composerOverlap: 0,
viewerUserId: "viewer_1",
pinnedIds: new Set(["m1"]),
...callbacks,
diff --git a/src/web/src/components/community/messages/message-list-types.ts b/src/web/src/components/community/messages/message-list-types.ts
index e274b77da..028dc1c44 100644
--- a/src/web/src/components/community/messages/message-list-types.ts
+++ b/src/web/src/components/community/messages/message-list-types.ts
@@ -5,6 +5,7 @@ import type { OpenProfile } from "@/components/community/social/profile-types"
export type MessageListProps = {
channel: string
messages: Msg[]
+ composerOverlap?: number
loading?: boolean
pinnedIds?: Set<string>
newDividerBefore?: string
@@ -47,5 +48,6 @@ export type MessageListProps = {
export type ResolvedMessageListProps = MessageListProps & {
variant: "channel" | "dm"
initialScrollReady: boolean
+ composerOverlap: number
hoverCapable: boolean
}
diff --git a/src/web/src/components/community/messages/message-list-view.dom.test.ts b/src/web/src/components/community/messages/message-list-view.dom.test.ts
index 947b843d1..0176a07a7 100644
--- a/src/web/src/components/community/messages/message-list-view.dom.test.ts
+++ b/src/web/src/components/community/messages/message-list-view.dom.test.ts
@@ -49,6 +49,7 @@ function props(overrides: Partial<ResolvedMessageListProps> = {}): ResolvedMessa
onOpenThread: vi.fn(),
variant: "channel",
initialScrollReady: true,
+ composerOverlap: 0,
...overrides,
}
}
@@ -94,6 +95,7 @@ describe("renderMessageListView", () => {
typingNames: ["Alice"],
scrollCount: 3,
selectMode: false,
+ composerOverlap: 0,
}), undefined)
const scrollerBoundary = renderer.container.querySelector("[data-message-scroller-boundary]")!
expect(scrollerBoundary.querySelectorAll("accessory-rail")).toHaveLength(1)
diff --git a/src/web/src/components/community/messages/message-list-view.tsx b/src/web/src/components/community/messages/message-list-view.tsx
index 040d1c24d..0e5bf147b 100644
--- a/src/web/src/components/community/messages/message-list-view.tsx
+++ b/src/web/src/components/community/messages/message-list-view.tsx
@@ -33,6 +33,7 @@ export function renderMessageListView(
selectedCount={controller.selectedIds.size}
onCancelSelection={controller.exitSelect}
onShareSelection={() => controller.setShareOpen(true)}
+ composerOverlap={props.composerOverlap}
/>
)}
<div
diff --git a/src/web/src/components/community/messages/message-list.tsx b/src/web/src/components/community/messages/message-list.tsx
index 9bdfb2d28..463704163 100644
--- a/src/web/src/components/community/messages/message-list.tsx
+++ b/src/web/src/components/community/messages/message-list.tsx
@@ -10,11 +10,13 @@ import { VirtualRows } from "./virtual-cursor-list"
export function MessageList({
variant = "channel",
initialScrollReady = true,
+ composerOverlap = 0,
...props
}: MessageListProps) {
const hoverCapable = useHoverCapable()
const resolvedProps: ResolvedMessageListProps = {
...props,
+ composerOverlap,
variant,
initialScrollReady,
hoverCapable,
diff --git a/src/web/src/hooks/community/use-scroll-anchor.ts b/src/web/src/hooks/community/use-scroll-anchor.ts
index aca0f946a..c44204c3f 100644
--- a/src/web/src/hooks/community/use-scroll-anchor.ts
+++ b/src/web/src/hooks/community/use-scroll-anchor.ts
@@ -806,14 +806,12 @@ export function useScrollAnchor({
if (delta !== 0) el.scrollTop += delta
}, [heroHeight])
- // Composer/viewport resize compensation — the composer is a flex sibling
- // of this scroll viewport with no `shrink-0`, so when it grows/shrinks
- // (auto-grow while typing, clearing on send, opening/closing the reply
- // banner, adding/removing attachment chips) the viewport's `clientHeight`
- // changes and the bottom-pinned content (`min-h-full … justify-end`) would
- // otherwise appear to jump. A `ResizeObserver` on the viewport itself
- // catches every such resize regardless of cause without coupling to the
- // composer component. Only a viewport that was literally pinned within
+ // Viewport resize compensation — shell or mobile-keyboard changes can alter
+ // this viewport's `clientHeight`, and the bottom-pinned content
+ // (`min-h-full … justify-end`) would otherwise appear to jump. The channel
+ // composer's internal growth is isolated by its stable overlay shell and
+ // does not reach this observer. A `ResizeObserver` on the viewport itself
+ // catches every real viewport resize. Only a viewport literally pinned within
// 1px re-pins instantly (NOT the smooth `scrollToBottom` — a smooth
// animation firing on every keystroke resize is janky and fights rapid
// successive resizes). Every away position is left to the browser; in
diff --git a/src/web/src/test/e2e-ui/55-message-scroll-characterization.spec.ts b/src/web/src/test/e2e-ui/55-message-scroll-characterization.spec.ts
index fa9ca02c1..0763af200 100644
--- a/src/web/src/test/e2e-ui/55-message-scroll-characterization.spec.ts
+++ b/src/web/src/test/e2e-ui/55-message-scroll-characterization.spec.ts
@@ -5,7 +5,7 @@ import {
communityFrameEvents,
proxyCommunityWebSockets,
} from "./_fixtures/community-ws-proxy"
-import { seedChannel, seedJoinServer, seedMessage, seedServer } from "./_fixtures/seed"
+import { seedChannel, seedJoinServer, seedMessage, seedServer, seedThread } from "./_fixtures/seed"
import {
abortScrollTrace,
attachScrollTrace,
@@ -203,6 +203,39 @@ async function establishExactPinnedPrecondition(
return establishScrollDistancePrecondition(scroller, label, targetDistanceToEnd)
}
+async function establishTailMessageBelowViewportPrecondition(
+ scroller: Locator,
+ label: string,
+ tailMessageId: string,
+): Promise<void> {
+ const driveTailBelowViewport = () => scroller.evaluate((element, messageId) => {
+ const root = element as HTMLElement
+ const rootRect = root.getBoundingClientRect()
+ const tail = Array.from(root.querySelectorAll<HTMLElement>("[data-msg-id]"))
+ .find((row) => row.dataset.msgId === messageId)
+ const distanceToEnd = Math.max(0, root.scrollHeight - root.clientHeight - root.scrollTop)
+ // A fresh virtualizer may not have mounted the known tail row yet even
+ // while the viewport is still pinned. Only accept an absent row after an
+ // actual away position has been established.
+ const tailBelowViewport = tail
+ ? tail.getBoundingClientRect().top >= rootRect.bottom - 1
+ : distanceToEnd >= Math.max(1, root.clientHeight / 2)
+ if (!tailBelowViewport) {
+ root.scrollTop = Math.max(0, root.scrollTop - Math.max(400, root.clientHeight / 2))
+ root.dispatchEvent(new Event("scroll"))
+ }
+ return { tailBelowViewport, scrollTop: root.scrollTop, distanceToEnd }
+ }, tailMessageId)
+
+ await expect.poll(driveTailBelowViewport, {
+ timeout: 20_000,
+ message: `${label}: tail row must leave the viewport so the accessory rail is semantically required`,
+ }).toMatchObject({ tailBelowViewport: true })
+ await scroller.evaluate(() => new Promise<void>((resolveValue) => {
+ requestAnimationFrame(() => requestAnimationFrame(() => resolveValue()))
+ }))
+}
+
async function establishMidHistoryPrecondition(
scroller: Locator,
): Promise<{ scrollTop: number; scrollHeight: number; clientHeight: number; distanceToEnd: number }> {
@@ -258,6 +291,8 @@ type MessageViewportGeometry = {
contentPaddingBottom: number
railPosition: string | null
railRect: { top: number; bottom: number } | null
+ composerRect: { top: number; bottom: number } | null
+ surfaceChannelId: string | null
scrollerRect: { top: number; bottom: number }
}
@@ -265,6 +300,8 @@ async function readMessageViewportGeometry(scroller: Locator): Promise<MessageVi
return scroller.evaluate((element, accessoryRailTestId) => {
const root = element as HTMLElement
const rootRect = root.getBoundingClientRect()
+ const boundary = root.closest<HTMLElement>("[data-message-scroller-boundary]")
+ const surface = root.closest<HTMLElement>('[data-slot="community-conversation-surface"]')
const firstVisible = Array.from(root.querySelectorAll<HTMLElement>("[data-msg-id]"))
.find((row) => {
const rect = row.getBoundingClientRect()
@@ -272,8 +309,10 @@ async function readMessageViewportGeometry(scroller: Locator): Promise<MessageVi
}) ?? null
const firstRect = firstVisible?.getBoundingClientRect() ?? null
const content = root.querySelector<HTMLElement>("[data-message-list-content]")
- const rail = root.querySelector<HTMLElement>(`[data-testid="${accessoryRailTestId}"]`)
+ const rail = boundary?.querySelector<HTMLElement>(`[data-testid="${accessoryRailTestId}"]`)
const railRect = rail?.getBoundingClientRect() ?? null
+ const composer = surface?.querySelector<HTMLElement>('[data-slot="community-composer-overlay"]')
+ const composerRect = composer?.getBoundingClientRect() ?? null
return {
scrollTop: root.scrollTop,
scrollHeight: root.scrollHeight,
@@ -284,6 +323,8 @@ async function readMessageViewportGeometry(scroller: Locator): Promise<MessageVi
contentPaddingBottom: content ? Number.parseFloat(getComputedStyle(content).paddingBottom) : 0,
railPosition: rail ? getComputedStyle(rail).position : null,
railRect: railRect ? { top: railRect.top, bottom: railRect.bottom } : null,
+ composerRect: composerRect ? { top: composerRect.top, bottom: composerRect.bottom } : null,
+ surfaceChannelId: surface?.dataset.channelId ?? null,
scrollerRect: { top: rootRect.top, bottom: rootRect.bottom },
}
}, tid.composerAccessoryRail)
@@ -312,7 +353,7 @@ async function advanceScrollTraceFrame(scroller: Locator): Promise<void> {
}))
}
-function expectAwayAnchorPreserved(
+function expectViewportAnchorPreserved(
before: MessageViewportGeometry,
after: MessageViewportGeometry,
label: string,
@@ -334,10 +375,14 @@ function expectAwayLatchPreserved(
function expectFixedMessageGeometry(geometry: MessageViewportGeometry, label: string): void {
expect(geometry.contentPaddingBottom, `${label}: desktop tail safe area`).toBe(72)
+ expect(geometry.composerRect, `${label}: scoped composer`).not.toBeNull()
if (geometry.railRect) {
expect(geometry.railPosition, `${label}: rail position`).toBe("absolute")
expect(geometry.railRect.top, `${label}: rail top`).toBeGreaterThanOrEqual(geometry.scrollerRect.top - 1)
expect(geometry.railRect.bottom, `${label}: rail bottom`).toBeLessThanOrEqual(geometry.scrollerRect.bottom + 1)
+ expect(geometry.railRect.bottom, `${label}: rail clears composer`).toBeLessThanOrEqual(
+ geometry.composerRect!.top + 1,
+ )
}
}
@@ -775,6 +820,12 @@ test.describe.serial("message scroll characterization", () => {
test("exact-pinned composer and accessory resizes preserve geometry boundaries", async ({ asUser }, testInfo) => {
test.setTimeout(180_000)
+ const splitThreadId = await seedThread(
+ "alice",
+ composerProfile.ids.at(-1)!,
+ `scroll split ${Date.now()}`,
+ )
+ const splitProfile = await seedProfile(splitThreadId, 24, false, "alice")
const alice = await asUser("alice")
const bob = await asUser("bob")
await alice.page.setViewportSize(VIEWPORT)
@@ -808,7 +859,7 @@ test.describe.serial("message scroll characterization", () => {
).join("\n")
for (const distance of [0, 1, 2, 99, 100, 101, 300]) {
- await editable.fill("")
+ await editable.fill(composerLines(`boundary-${distance}`, 6))
const precondition = distance <= 1
? await establishExactPinnedPrecondition(
scroller,
@@ -826,33 +877,37 @@ test.describe.serial("message scroll characterization", () => {
const before = await waitForCommittedGeometry(scroller)
expectFixedMessageGeometry(before, `resize-${distance}-before`)
+ // Match the user journey that exposed the regression: grow the composer,
+ // establish the reading position, then delete the draft. Positioning the
+ // scroller before growth misses the browser's shrink-time maxScrollTop clamp.
+ await beginScrollTraceAnalysis(alice.page, `composer-shrink-${distance}`)
+ await editable.click()
+ await alice.page.keyboard.press("ControlOrMeta+A")
+ await alice.page.keyboard.press("Backspace")
+ await expect(editable).toHaveText("")
+ await expect.poll(() => scroller.evaluate((element) => element.clientHeight))
+ .toBe(before.clientHeight)
+ const shrunk = await waitForCommittedGeometry(scroller)
+ expectFixedMessageGeometry(shrunk, `resize-${distance}-shrunk`)
+ expectViewportAnchorPreserved(before, shrunk, `resize-${distance}-shrunk`)
+ if (distance <= 1) {
+ expect(shrunk.distanceToEnd, `resize-${distance}-shrunk pinned`).toBeLessThanOrEqual(1)
+ }
+ await endScrollTraceAnalysis(alice.page, `composer-shrink-${distance}`)
+ await advanceScrollTraceFrame(scroller)
+
await beginScrollTraceAnalysis(alice.page, `composer-grow-${distance}`)
await editable.fill(composerLines(`boundary-${distance}`, 6))
await expect.poll(() => scroller.evaluate((element) => element.clientHeight))
- .toBeLessThan(before.clientHeight)
+ .toBe(shrunk.clientHeight)
const grown = await waitForCommittedGeometry(scroller)
expectFixedMessageGeometry(grown, `resize-${distance}-grown`)
+ expectViewportAnchorPreserved(before, grown, `resize-${distance}-grown`)
if (distance <= 1) {
expect(grown.distanceToEnd, `resize-${distance}-grown pinned`).toBeLessThanOrEqual(1)
- } else {
- expectAwayAnchorPreserved(before, grown, `resize-${distance}-grown away`)
}
await endScrollTraceAnalysis(alice.page, `composer-grow-${distance}`)
await advanceScrollTraceFrame(scroller)
-
- await beginScrollTraceAnalysis(alice.page, `composer-shrink-${distance}`)
- await editable.fill("")
- await expect.poll(() => scroller.evaluate((element) => element.clientHeight))
- .toBeGreaterThan(grown.clientHeight)
- const shrunk = await waitForCommittedGeometry(scroller)
- expectFixedMessageGeometry(shrunk, `resize-${distance}-shrunk`)
- if (distance <= 1) {
- expect(shrunk.distanceToEnd, `resize-${distance}-shrunk pinned`).toBeLessThanOrEqual(1)
- } else {
- expectAwayAnchorPreserved(before, shrunk, `resize-${distance}-shrunk away`)
- }
- await endScrollTraceAnalysis(alice.page, `composer-shrink-${distance}`)
- await advanceScrollTraceFrame(scroller)
}
const rapidPrecondition = await establishScrollDistancePrecondition(scroller, "rapid-resize-away", 2)
@@ -867,10 +922,10 @@ test.describe.serial("message scroll characterization", () => {
const rapidShrinkOne = await waitForCommittedGeometry(scroller)
await editable.fill("")
const rapidShrinkTwo = await waitForCommittedGeometry(scroller)
- expect(rapidGrowOne.clientHeight).toBeLessThan(rapidBase.clientHeight)
- expect(rapidGrowTwo.clientHeight).toBeLessThan(rapidGrowOne.clientHeight)
- expect(rapidShrinkOne.clientHeight).toBeGreaterThan(rapidGrowTwo.clientHeight)
- expect(rapidShrinkTwo.clientHeight).toBeGreaterThan(rapidShrinkOne.clientHeight)
+ expect(rapidGrowOne.clientHeight).toBe(rapidBase.clientHeight)
+ expect(rapidGrowTwo.clientHeight).toBe(rapidBase.clientHeight)
+ expect(rapidShrinkOne.clientHeight).toBe(rapidBase.clientHeight)
+ expect(rapidShrinkTwo.clientHeight).toBe(rapidBase.clientHeight)
for (const [label, geometry] of [
["grow-one", rapidGrowOne],
["grow-two", rapidGrowTwo],
@@ -878,6 +933,7 @@ test.describe.serial("message scroll characterization", () => {
["shrink-two", rapidShrinkTwo],
] as const) {
expectAwayLatchPreserved(geometry, `rapid-${label}`)
+ expectViewportAnchorPreserved(rapidBase, geometry, `rapid-${label}`)
expectFixedMessageGeometry(geometry, `rapid-${label}`)
}
await endScrollTraceAnalysis(alice.page, "rapid-composer-resizes")
@@ -893,26 +949,34 @@ test.describe.serial("message scroll characterization", () => {
replyTargetBox!.x + replyTargetBox!.width / 2,
replyTargetBox!.y + replyTargetBox!.height / 2,
)
- const replyButton = replyTarget.getByRole("button", { name: "Reply" })
+ const replyButton = replyTarget.getByRole("button", { name: "Reply", exact: true })
await expect(replyButton).toBeVisible()
await expect(replyButton).toBeInViewport()
expect((await waitForCommittedGeometry(scroller)).distanceToEnd).toBeLessThanOrEqual(1)
await replyButton.click()
await expect(alice.page.locator('[data-slot="composer-reply-preview"]')).toBeVisible()
const replyOpen = await waitForCommittedGeometry(scroller)
- expect(replyOpen.clientHeight).toBeLessThan(replyBase.clientHeight)
+ expect(replyOpen.clientHeight).toBe(replyBase.clientHeight)
expect(replyOpen.distanceToEnd).toBeLessThanOrEqual(1)
+ expectViewportAnchorPreserved(replyBase, replyOpen, "reply-open")
expectFixedMessageGeometry(replyOpen, "reply-open")
await alice.page.getByRole("button", { name: "Cancel reply" }).click()
await expect(alice.page.locator('[data-slot="composer-reply-preview"]')).toHaveCount(0)
const replyClosed = await waitForCommittedGeometry(scroller)
expect(replyClosed.clientHeight).toBe(replyBase.clientHeight)
expect(replyClosed.distanceToEnd).toBeLessThanOrEqual(1)
+ expectViewportAnchorPreserved(replyBase, replyClosed, "reply-closed")
await endScrollTraceAnalysis(alice.page, "reply-banner-pinned")
await advanceScrollTraceFrame(scroller)
- await establishScrollDistancePrecondition(scroller, "attachment-resize-away", 300)
+ await establishTailMessageBelowViewportPrecondition(
+ scroller,
+ "attachment-resize-away",
+ composerProfile.ids.at(-1)!,
+ )
+ await expect(alice.page.getByTestId(tid.composerAccessoryRail)).toBeVisible()
const attachmentBase = await waitForCommittedGeometry(scroller)
+ expect(attachmentBase.railRect, "attachment-base-away rail").not.toBeNull()
await beginScrollTraceAnalysis(alice.page, "attachment-chip-away")
await alice.page.getByTestId(tid.composerFileInput).setInputFiles({
name: "geometry-only.txt",
@@ -921,14 +985,15 @@ test.describe.serial("message scroll characterization", () => {
})
await expect(alice.page.getByText("geometry-only.txt", { exact: true })).toBeVisible()
const attachmentOpen = await waitForCommittedGeometry(scroller)
- expect(attachmentOpen.clientHeight).toBeLessThan(attachmentBase.clientHeight)
- expectAwayAnchorPreserved(attachmentBase, attachmentOpen, "attachment-open-away")
+ expect(attachmentOpen.clientHeight).toBe(attachmentBase.clientHeight)
+ expectViewportAnchorPreserved(attachmentBase, attachmentOpen, "attachment-open-away")
expectFixedMessageGeometry(attachmentOpen, "attachment-open-away")
+ expect(attachmentOpen.railRect, "attachment-open-away rail").not.toBeNull()
await alice.page.getByRole("button", { name: "Remove file" }).click()
await expect(alice.page.getByText("geometry-only.txt", { exact: true })).toHaveCount(0)
const attachmentClosed = await waitForCommittedGeometry(scroller)
expect(attachmentClosed.clientHeight).toBe(attachmentBase.clientHeight)
- expectAwayAnchorPreserved(attachmentBase, attachmentClosed, "attachment-closed-away")
+ expectViewportAnchorPreserved(attachmentBase, attachmentClosed, "attachment-closed-away")
await endScrollTraceAnalysis(alice.page, "attachment-chip-away")
await advanceScrollTraceFrame(scroller)
@@ -939,8 +1004,9 @@ test.describe.serial("message scroll characterization", () => {
await expect(alice.page.getByTestId(tid.typingIndicator)).toBeVisible({ timeout: 20_000 })
const typingOpen = await waitForCommittedGeometry(scroller)
expect(typingOpen.clientHeight).toBe(typingBase.clientHeight)
- expectAwayAnchorPreserved(typingBase, typingOpen, "typing-rail-away")
+ expectViewportAnchorPreserved(typingBase, typingOpen, "typing-rail-away")
expectFixedMessageGeometry(typingOpen, "typing-rail-away")
+ expect(typingOpen.railRect, "typing-rail-away rail").not.toBeNull()
await bobEditable.fill("")
await endScrollTraceAnalysis(alice.page, "typing-rail-away")
await advanceScrollTraceFrame(scroller)
@@ -954,13 +1020,8 @@ test.describe.serial("message scroll characterization", () => {
const shrink = resizeSegments.get(`composer-shrink-${distance}`)
expect(grow, `missing composer-grow-${distance}`).toBeDefined()
expect(shrink, `missing composer-shrink-${distance}`).toBeDefined()
- if (distance <= 1) {
- expect(grow!.writerCount, `composer-grow-${distance} writer`).toBeGreaterThanOrEqual(1)
- expect(shrink!.writerCount, `composer-shrink-${distance} writer`).toBeGreaterThanOrEqual(1)
- } else {
- expect(grow!.writerCount, `composer-grow-${distance} writer`).toBe(0)
- expect(shrink!.writerCount, `composer-shrink-${distance} writer`).toBe(0)
- }
+ expect(grow!.writerCount, `composer-grow-${distance} writer`).toBe(0)
+ expect(shrink!.writerCount, `composer-shrink-${distance} writer`).toBe(0)
}
expect(resizeSegments.get("rapid-composer-resizes")?.writerCount).toBe(0)
expect(resizeSegments.get("attachment-chip-away")?.writerCount).toBe(0)
@@ -968,6 +1029,58 @@ test.describe.serial("message scroll characterization", () => {
expect(mutationPosts).toBe(0)
expect(proxy.frames.flatMap(communityFrameEvents).filter((event) =>
event.type === "community:message.create" && event.channelId === composerChannelId)).toHaveLength(0)
+
+ await alice.page.goto(`/c/channels/${serverId}/${splitThreadId}`, { waitUntil: "commit" })
+ const split = alice.page.getByTestId(tid.threadSplit)
+ await expect(split).toHaveAttribute("data-layout", "split", { timeout: 30_000 })
+ const parentPanel = alice.page.getByTestId(tid.threadSplitParent)
+ const threadPanel = alice.page.getByTestId(tid.threadSplitPanel)
+ const parentSurface = parentPanel.locator('[data-slot="community-conversation-surface"]')
+ const threadSurface = threadPanel.locator('[data-slot="community-conversation-surface"]')
+ await expect(parentSurface).toHaveAttribute("data-channel-id", composerChannelId)
+ await expect(threadSurface).toHaveAttribute("data-channel-id", splitThreadId)
+ await expect(parentSurface).toHaveCount(1)
+ await expect(threadSurface).toHaveCount(1)
+
+ const parentEditable = composerEditable(alice.page, parentPanel)
+ const threadEditable = composerEditable(alice.page, threadPanel)
+ await parentEditable.fill(composerLines("split-parent", 2))
+ await threadEditable.fill(composerLines("split-thread", 6))
+ const parentScroller = parentPanel.getByTestId(tid.messageScroller)
+ const threadScroller = threadPanel.getByTestId(tid.messageScroller)
+ await establishTailMessageBelowViewportPrecondition(
+ parentScroller,
+ "split-parent-away",
+ composerProfile.ids.at(-1)!,
+ )
+ await establishTailMessageBelowViewportPrecondition(
+ threadScroller,
+ "split-thread-away",
+ splitProfile.ids.at(-1)!,
+ )
+ await expect(parentPanel.getByTestId(tid.composerAccessoryRail)).toBeVisible()
+ await expect(threadPanel.getByTestId(tid.composerAccessoryRail)).toBeVisible()
+
+ const parentGeometry = await waitForCommittedGeometry(parentScroller)
+ const threadGeometry = await waitForCommittedGeometry(threadScroller)
+ const parentComposerBox = await parentSurface
+ .locator('[data-slot="community-composer-overlay"]')
+ .boundingBox()
+ const threadComposerBox = await threadSurface
+ .locator('[data-slot="community-composer-overlay"]')
+ .boundingBox()
+ expect(parentGeometry.surfaceChannelId).toBe(composerChannelId)
+ expect(threadGeometry.surfaceChannelId).toBe(splitThreadId)
+ expect(parentGeometry.railRect, "split parent rail is located from its boundary").not.toBeNull()
+ expect(threadGeometry.railRect, "split thread rail is located from its boundary").not.toBeNull()
+ expect(parentComposerBox).not.toBeNull()
+ expect(threadComposerBox).not.toBeNull()
+ expect(Math.abs(parentGeometry.composerRect!.top - parentComposerBox!.y)).toBeLessThanOrEqual(1)
+ expect(Math.abs(threadGeometry.composerRect!.top - threadComposerBox!.y)).toBeLessThanOrEqual(1)
+ expect(threadGeometry.composerRect!.top).not.toBe(parentGeometry.composerRect!.top)
+ expectFixedMessageGeometry(parentGeometry, "split-parent")
+ expectFixedMessageGeometry(threadGeometry, "split-thread")
+ expect(mutationPosts).toBe(0)
})
test.afterEach(async ({ page }) => {