Skip to content

armgit / alook

Public Imported from GitHub
0

Multi-Agent Collaboration for Team and Friends

fix(config): scope full-screen metadata by device (#1106)

Generdd0d7328dc71
diff --git a/.github/workflows/mobile-release.yml b/.github/workflows/mobile-release.yml
index 3950b5248..b7c7eed70 100644
--- a/.github/workflows/mobile-release.yml
+++ b/.github/workflows/mobile-release.yml
@@ -180,6 +180,8 @@ jobs:
assert info["WKAppBoundDomains"] == ["localhost", "alook.ai"]
assert info["UISupportedInterfaceOrientations"] == ["UIInterfaceOrientationPortrait"]
assert info["UISupportedInterfaceOrientations~ipad"] == ["UIInterfaceOrientationPortrait"]
+ assert info.get("UIRequiresFullScreen") is True
+ assert info.get("UIRequiresFullScreen~iphone") is False
assert info["CFBundleURLTypes"] == [
{"CFBundleURLName": "ai.alook", "CFBundleURLSchemes": ["ai.alook"]}
]
diff --git a/scripts/ci/tauri-startup.test.ts b/scripts/ci/tauri-startup.test.ts
index 9858462d0..e45906be8 100644
--- a/scripts/ci/tauri-startup.test.ts
+++ b/scripts/ci/tauri-startup.test.ts
@@ -12,20 +12,22 @@ const base = JSON.parse(read("tauri.conf.json"))
const release = JSON.parse(read("tauri.ios.release.conf.json"))
const development = JSON.parse(read("tauri.dev.conf.json"))
-function verifyIosArtifact(orientationKey?: string, orientations?: string[]) {
+function verifyIosArtifact(overrides: Record<string, unknown> = {}) {
const workflow = readFileSync(resolve(root, ".github/workflows/mobile-release.yml"), "utf8")
const validator = workflow.match(/^\s+python3 - "\$app_path\/Info\.plist" "\$entitlements_path" <<'PY'\n([\s\S]*?)^\s+PY$/m)
expect(validator).not.toBeNull()
const info: Record<string, unknown> = {
CFBundleIdentifier: "ai.alook.ios",
WKAppBoundDomains: ["localhost", "alook.ai"],
+ UIRequiresFullScreen: true,
+ "UIRequiresFullScreen~iphone": false,
UISupportedInterfaceOrientations: ["UIInterfaceOrientationPortrait"],
"UISupportedInterfaceOrientations~ipad": ["UIInterfaceOrientationPortrait"],
CFBundleURLTypes: [{ CFBundleURLName: "ai.alook", CFBundleURLSchemes: ["ai.alook"] }],
}
- if (orientationKey) {
- if (orientations) info[orientationKey] = orientations
- else delete info[orientationKey]
+ for (const [key, value] of Object.entries(overrides)) {
+ if (value === undefined) delete info[key]
+ else info[key] = value
}
return spawnSync("python3", ["-c", `
import json
@@ -96,7 +98,7 @@ describe("Tauri startup release separation", () => {
}
})
- it("accepts the final IPA metadata with portrait-only phone and tablet declarations", () => {
+ it("accepts the final IPA metadata with portrait-only phone and tablet declarations and Boolean full-screen requirement", () => {
const result = verifyIosArtifact()
expect(result.error).toBeUndefined()
expect(result.status, result.stderr).toBe(0)
@@ -110,12 +112,38 @@ describe("Tauri startup release separation", () => {
["missing tablet", "UISupportedInterfaceOrientations~ipad", undefined],
]
it.each(invalidOrientations)("rejects final IPA metadata with %s declarations", (_name, key, orientations) => {
- const result = verifyIosArtifact(key, orientations)
+ const result = verifyIosArtifact({ [key]: orientations })
expect(result.error).toBeUndefined()
expect(result.status).toBe(1)
expect(result.stderr).toMatch(/AssertionError|KeyError/)
})
+ const invalidFullScreen: [string, unknown][] = [
+ ["missing", undefined],
+ ["false", false],
+ ["string true", "true"],
+ ["integer one", 1],
+ ]
+ it.each(invalidFullScreen)("rejects final IPA metadata with %s full-screen requirement", (_name, value) => {
+ const result = verifyIosArtifact({ UIRequiresFullScreen: value })
+ expect(result.error).toBeUndefined()
+ expect(result.status).toBe(1)
+ expect(result.stderr).toMatch(/AssertionError/)
+ })
+
+ const invalidPhoneFullScreen: [string, unknown][] = [
+ ["missing", undefined],
+ ["true", true],
+ ["string false", "false"],
+ ["integer zero", 0],
+ ]
+ it.each(invalidPhoneFullScreen)("rejects final IPA metadata with %s iPhone full-screen override", (_name, value) => {
+ const result = verifyIosArtifact({ "UIRequiresFullScreen~iphone": value })
+ expect(result.error).toBeUndefined()
+ expect(result.status).toBe(1)
+ expect(result.stderr).toMatch(/AssertionError/)
+ })
+
it("does not require a generated plist on a fresh development checkout", () => {
expect(prepareIosDevelopmentPlist(resolve(tauriRoot, "nonexistent-test.plist"))).toBe(false)
})
diff --git a/src/desktop/src-tauri/gen/apple/project.yml b/src/desktop/src-tauri/gen/apple/project.yml
index 507b04375..ab4ab5f6d 100644
--- a/src/desktop/src-tauri/gen/apple/project.yml
+++ b/src/desktop/src-tauri/gen/apple/project.yml
@@ -41,6 +41,8 @@ targets:
properties:
ITSAppUsesNonExemptEncryption: false
LSRequiresIPhoneOS: true
+ UIRequiresFullScreen: true
+ UIRequiresFullScreen~iphone: false
UIApplicationSceneManifest:
UIApplicationSupportsMultipleScenes: false
UILaunchStoryboardName: LaunchScreen