Multi-Agent Collaboration for Team and Friends
TypeScript agent-automationagent-orchestrationagent-workflowai-agentsai-collaborationai-memoryai-workforceautonomous-agentsclaude-codeclaude-code-skillscodexcoding-agentmulti-agentmultiple-agentone-person-businessone-person-companyone-person-teamopencodesolopreneur
test(mobile): use canonical thread panel selectors (#994)
Gustavo Yee24efd8b23ff
diff --git a/src/web/src/test/e2e-ui/39-mobile-message-interactions.spec.ts b/src/web/src/test/e2e-ui/39-mobile-message-interactions.spec.tsindex 8b5cffd9b..4b1427fac 100644--- a/src/web/src/test/e2e-ui/39-mobile-message-interactions.spec.ts+++ b/src/web/src/test/e2e-ui/39-mobile-message-interactions.spec.ts@@ -569,13 +569,14 @@ test("mobile reply, avatar mention, and typing rail keep exact backend and WS idawait expect(composerEditable(bob.page, bobThread)).toBeVisible()const threadTarget = alice.page.getByTestId(tid.message(threadBobMessageId))await expect(threadTarget).toBeVisible()- const restingThreadGap = await alice.page.evaluate(({ targetId, composerId }) => {- const target = document.querySelector('[data-testid="community-thread-split-panel"]')?.querySelector(`[data-testid="${targetId}"]`)?.getBoundingClientRect()- const composer = document.querySelector('[data-testid="community-thread-split-panel"]')?.querySelector(`[data-testid="${composerId}"]`)?.getBoundingClientRect()+ const restingThreadGap = await alice.page.evaluate(({ targetId, composerId, threadPanelTestId }) => {+ const target = document.querySelector(`[data-testid="${threadPanelTestId}"]`)?.querySelector(`[data-testid="${targetId}"]`)?.getBoundingClientRect()+ const composer = document.querySelector(`[data-testid="${threadPanelTestId}"]`)?.querySelector(`[data-testid="${composerId}"]`)?.getBoundingClientRect()return target && composer ? composer.top - target.bottom : null}, {targetId: tid.message(threadBobMessageId),composerId: tid.channelComposerShell,+ threadPanelTestId: tid.threadSplitPanel,})expect(restingThreadGap).not.toBeNull()expect(restingThreadGap!).toBeGreaterThanOrEqual(39)diff --git a/src/web/src/test/e2e-ui/40-mobile-server-header-hierarchy.spec.ts b/src/web/src/test/e2e-ui/40-mobile-server-header-hierarchy.spec.tsindex acba1df50..42386daf3 100644--- a/src/web/src/test/e2e-ui/40-mobile-server-header-hierarchy.spec.ts+++ b/src/web/src/test/e2e-ui/40-mobile-server-header-hierarchy.spec.ts@@ -102,12 +102,13 @@ test.describe("mobile server header direct hierarchy", () => {page.off("response", observeStartupAttention)await page.waitForLoadState("networkidle")- await page.evaluate(({ composerTestId }) => {- const backControl = document.querySelector('[data-testid="community-thread-split-panel"]')?.querySelector('button[aria-label="Back"]')+ await page.evaluate(({ composerTestId, threadPanelTestId }) => {+ const backControl = document.querySelector(`[data-testid="${threadPanelTestId}"]`)?.querySelector('button[aria-label="Back"]')Reflect.set(window, "__headerHierarchyBanner", backControl?.closest("header[role=banner]"))- Reflect.set(window, "__headerHierarchyComposer", document.querySelector('[data-testid="community-thread-split-panel"]')?.querySelector(`[data-testid="${composerTestId}"]`))+ Reflect.set(window, "__headerHierarchyComposer", document.querySelector(`[data-testid="${threadPanelTestId}"]`)?.querySelector(`[data-testid="${composerTestId}"]`))}, {composerTestId: tid.channelComposerShell,+ threadPanelTestId: tid.threadSplitPanel,})let communityRequests = 0let newSockets = 0@@ -120,20 +121,22 @@ test.describe("mobile server header direct hierarchy", () => {await page.setViewportSize({ width: 640, height: 844 })await expect(page.getByRole("button", { name: "Back" })).toBeVisible()await expect(page.getByTestId(tid.threadSplitPanel).getByTestId(tid.channelComposerShell)).toBeVisible()- expect(await page.evaluate(({ composerTestId }) => ({- banner: Reflect.get(window, "__headerHierarchyBanner") === document.querySelector('[data-testid="community-thread-split-panel"]')?.querySelector('button[aria-label="Back"]')?.closest("header[role=banner]"),- composer: Reflect.get(window, "__headerHierarchyComposer") === document.querySelector('[data-testid="community-thread-split-panel"]')?.querySelector(`[data-testid="${composerTestId}"]`),+ expect(await page.evaluate(({ composerTestId, threadPanelTestId }) => ({+ banner: Reflect.get(window, "__headerHierarchyBanner") === document.querySelector(`[data-testid="${threadPanelTestId}"]`)?.querySelector('button[aria-label="Back"]')?.closest("header[role=banner]"),+ composer: Reflect.get(window, "__headerHierarchyComposer") === document.querySelector(`[data-testid="${threadPanelTestId}"]`)?.querySelector(`[data-testid="${composerTestId}"]`),}), {composerTestId: tid.channelComposerShell,+ threadPanelTestId: tid.threadSplitPanel,})).toEqual({ banner: true, composer: true })await page.setViewportSize({ width: 639, height: 844 })await expect(page.getByRole("button", { name: "Back" })).toBeVisible()- expect(await page.evaluate(({ composerTestId }) => ({- banner: Reflect.get(window, "__headerHierarchyBanner") === document.querySelector('[data-testid="community-thread-split-panel"]')?.querySelector('button[aria-label="Back"]')?.closest("header[role=banner]"),- composer: Reflect.get(window, "__headerHierarchyComposer") === document.querySelector('[data-testid="community-thread-split-panel"]')?.querySelector(`[data-testid="${composerTestId}"]`),+ expect(await page.evaluate(({ composerTestId, threadPanelTestId }) => ({+ banner: Reflect.get(window, "__headerHierarchyBanner") === document.querySelector(`[data-testid="${threadPanelTestId}"]`)?.querySelector('button[aria-label="Back"]')?.closest("header[role=banner]"),+ composer: Reflect.get(window, "__headerHierarchyComposer") === document.querySelector(`[data-testid="${threadPanelTestId}"]`)?.querySelector(`[data-testid="${composerTestId}"]`),}), {composerTestId: tid.channelComposerShell,+ threadPanelTestId: tid.threadSplitPanel,})).toEqual({ banner: true, composer: true })expect(new URL(page.url()).pathname).toBe(pathname)expect(communityRequests).toBe(0)