Skip to content

armgit / alook

Public Imported from GitHub
0

Multi-Agent Collaboration for Team and Friends

fix: handle drizzle-orm 0.44+ wrapped errors for unique constraint detection

Generf4754c67d478
diff --git a/src/shared/src/index.ts b/src/shared/src/index.ts
index 3e200c08e..771db3d39 100644
--- a/src/shared/src/index.ts
+++ b/src/shared/src/index.ts
@@ -114,3 +114,4 @@ export * as queries from "./db/queries-index";
export { parseEmailHandle, toAlookAddress, isValidHandle } from "./utils/email";
export { isValidToken, isValidEmail } from "./utils/validation";
export { isOnline, formatStatus } from "./utils/status";
+export { isUniqueConstraintError } from "./utils/db-errors";
diff --git a/src/shared/src/utils/db-errors.ts b/src/shared/src/utils/db-errors.ts
new file mode 100644
index 000000000..d68f01136
--- /dev/null
+++ b/src/shared/src/utils/db-errors.ts
@@ -0,0 +1,14 @@
+/**
+ * Returns true when the error represents a SQLite UNIQUE constraint violation,
+ * whether thrown directly by the driver or wrapped by DrizzleQueryError (0.44+).
+ */
+export function isUniqueConstraintError(err: unknown): boolean {
+ if (err instanceof Error) {
+ const e = err as Error & { code?: string; cause?: unknown };
+ if (e.code === "SQLITE_CONSTRAINT_UNIQUE") return true;
+ if (e.message.includes("UNIQUE")) return true;
+ // DrizzleQueryError (0.44+) wraps the driver error as .cause
+ if (e.cause) return isUniqueConstraintError(e.cause);
+ }
+ return false;
+}
diff --git a/src/web/src/app/api/workspaces/route.test.ts b/src/web/src/app/api/workspaces/route.test.ts
index 159379a47..e491e6465 100644
--- a/src/web/src/app/api/workspaces/route.test.ts
+++ b/src/web/src/app/api/workspaces/route.test.ts
@@ -9,18 +9,22 @@ const mockListWorkspaces = vi.fn();
const mockCreateWorkspace = vi.fn();
const mockCreateMember = vi.fn();
-vi.mock("@alook/shared", () => ({
- createDb: vi.fn(() => ({})),
- queries: {
- workspace: {
- listWorkspaces: (...args: unknown[]) => mockListWorkspaces(...args),
- createWorkspace: (...args: unknown[]) => mockCreateWorkspace(...args),
- },
- member: {
- createMember: (...args: unknown[]) => mockCreateMember(...args),
+vi.mock("@alook/shared", async () => {
+ const actual = await vi.importActual("@alook/shared");
+ return {
+ ...actual,
+ createDb: vi.fn(() => ({})),
+ queries: {
+ workspace: {
+ listWorkspaces: (...args: unknown[]) => mockListWorkspaces(...args),
+ createWorkspace: (...args: unknown[]) => mockCreateWorkspace(...args),
+ },
+ member: {
+ createMember: (...args: unknown[]) => mockCreateMember(...args),
+ },
},
- },
-}));
+ };
+});
vi.mock("@/lib/middleware/auth", () => ({
withAuth: vi.fn((handler: any) => async (req: any, ctx?: any) => {
@@ -125,4 +129,21 @@ describe("POST /api/workspaces", () => {
expect(res.status).toBe(409);
expect(await res.json()).toEqual({ error: "workspace slug already exists" });
});
+
+ it("returns 409 on duplicate slug wrapped with cause", async () => {
+ const cause = new Error("UNIQUE constraint failed: workspaces.slug");
+ const wrapped = new Error("Failed query: INSERT INTO ...");
+ (wrapped as any).cause = cause;
+ mockCreateWorkspace.mockRejectedValue(wrapped);
+
+ const req = new NextRequest("http://localhost/api/workspaces", {
+ method: "POST",
+ body: JSON.stringify({ name: "Dup", slug: "dup" }),
+ headers: { "Content-Type": "application/json" },
+ });
+ const res = await POST(req, {} as any);
+
+ expect(res.status).toBe(409);
+ expect(await res.json()).toEqual({ error: "workspace slug already exists" });
+ });
});
diff --git a/src/web/src/app/api/workspaces/route.ts b/src/web/src/app/api/workspaces/route.ts
index f5ff416b9..ea7249432 100644
--- a/src/web/src/app/api/workspaces/route.ts
+++ b/src/web/src/app/api/workspaces/route.ts
@@ -1,6 +1,6 @@
import { NextRequest } from "next/server";
import { getCloudflareContext } from "@opennextjs/cloudflare"
-import { createDb, queries } from "@alook/shared"
+import { createDb, queries, isUniqueConstraintError } from "@alook/shared"
import { withAuth } from "@/lib/middleware/auth";
import { writeJSON, writeError } from "@/lib/middleware/helpers";
import { workspaceToResponse } from "@/lib/api/responses";
@@ -43,9 +43,7 @@ export const POST = withAuth(async (req: NextRequest, ctx) => {
});
return writeJSON(workspaceToResponse(ws), 201);
} catch (err: unknown) {
- const e = err as Record<string, unknown>;
- // SQLite unique constraint violation code
- if (e.code === "SQLITE_CONSTRAINT_UNIQUE" || (typeof e.message === "string" && e.message.includes("UNIQUE"))) {
+ if (isUniqueConstraintError(err)) {
return writeError("workspace slug already exists", 409);
}
throw err;