Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Make clicking Compare / Disable Comparison in period picker menu close the menu (#5333)

Artur Pata05bd71a6090e
diff --git a/CHANGELOG.md b/CHANGELOG.md
index d5fc43bee0..c7a8c59dd6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,10 @@ All notable changes to this project will be documented in this file.
### Changed
+### Fixed
+
+- Make clicking Compare / Disable Comparison in period picker menu close the menu
+
## v3.0.0 - 2025-04-11
### Added
diff --git a/assets/js/dashboard/nav-menu/query-periods/query-period-menu.tsx b/assets/js/dashboard/nav-menu/query-periods/query-period-menu.tsx
index a7e9623743..9620bcb508 100644
--- a/assets/js/dashboard/nav-menu/query-periods/query-period-menu.tsx
+++ b/assets/js/dashboard/nav-menu/query-periods/query-period-menu.tsx
@@ -121,7 +121,11 @@ const QueryPeriodMenuInner = ({
const { query, expandedSegment } = useQueryContext()
const groups = useMemo(() => {
- const compareLink = getCompareLinkItem({ site, query })
+ const compareLink = getCompareLinkItem({
+ site,
+ query,
+ onEvent: closeDropdown
+ })
return getDatePeriodGroups({
site,
onEvent: closeDropdown,
diff --git a/assets/js/dashboard/query-time-periods.ts b/assets/js/dashboard/query-time-periods.ts
index ba81f45046..a20b55f568 100644
--- a/assets/js/dashboard/query-time-periods.ts
+++ b/assets/js/dashboard/query-time-periods.ts
@@ -474,16 +474,19 @@ export const getDatePeriodGroups = ({
export const getCompareLinkItem = ({
query,
- site
+ site,
+ onEvent
}: {
query: DashboardQuery
site: PlausibleSite
+ onEvent: () => void
}): LinkItem => [
[
isComparisonEnabled(query.comparison) ? 'Disable comparison' : 'Compare',
'X'
],
{
+ onEvent,
search: getSearchToToggleComparison({ site, query }),
isActive: () => false
}