Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
Ignore maps in prop values
Uku Taht0edf4765d41b
diff --git a/lib/plausible_web/controllers/api/external_controller.ex b/lib/plausible_web/controllers/api/external_controller.exindex 65cec40c77..d3f8a1bd57 100644--- a/lib/plausible_web/controllers/api/external_controller.ex+++ b/lib/plausible_web/controllers/api/external_controller.ex@@ -168,7 +168,7 @@ defmodule PlausibleWeb.Api.ExternalController dodefp validate_custom_props(props) dois_valid =Enum.all?(props, fn {_key, val} ->- !is_list(val)+ !is_list(val) && !is_map(val)end)if is_valid, do: :ok, else: :invalid_propsdiff --git a/test/plausible_web/controllers/api/external_controller_test.exs b/test/plausible_web/controllers/api/external_controller_test.exsindex a1089d02f2..659c8aecb7 100644--- a/test/plausible_web/controllers/api/external_controller_test.exs+++ b/test/plausible_web/controllers/api/external_controller_test.exs@@ -495,6 +495,24 @@ defmodule PlausibleWeb.Api.ExternalControllerTest doassert Map.get(event, :"meta.value") == []end+ test "ignores custom prop with map value", %{conn: conn} do+ params = %{+ name: "Signup",+ url: "http://gigride.live/",+ domain: "custom-prop-test-5.com",+ props: Jason.encode!(%{foo: %{bar: "baz"}})+ }++ conn = post(conn, "/api/event", params)++ assert conn.status == 202++ event = get_event("custom-prop-test-5.com")++ assert Map.get(event, :"meta.key") == []+ assert Map.get(event, :"meta.value") == []+ end+test "ignores a malformed referrer URL", %{conn: conn} doparams = %{name: "pageview",