Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Fine tune sampling logic: filter estimate multiplier and cap filter exponent (#5784)

Adrian Gruntkowski114bf325a810
diff --git a/extra/lib/plausible/stats/sampling.ex b/extra/lib/plausible/stats/sampling.ex
index f78953c585..a1172281d7 100644
--- a/extra/lib/plausible/stats/sampling.ex
+++ b/extra/lib/plausible/stats/sampling.ex
@@ -97,7 +97,9 @@ defmodule Plausible.Stats.Sampling do
estimate_by_filters(duration_adjusted_traffic, query.filters)
end
- @filter_traffic_multiplier 1 / 20.0
+ @filter_traffic_multiplier 1 / 4.0
+ @max_filters 2
+
defp estimate_by_filters(estimation, filters),
- do: estimation * @filter_traffic_multiplier ** length(filters)
+ do: estimation * @filter_traffic_multiplier ** min(length(filters), @max_filters)
end
diff --git a/test/plausible/stats/sampling_test.exs b/test/plausible/stats/sampling_test.exs
index 92fbcda19b..02faf5cf56 100644
--- a/test/plausible/stats/sampling_test.exs
+++ b/test/plausible/stats/sampling_test.exs
@@ -46,11 +46,21 @@ defmodule Plausible.Stats.SamplingTest do
assert fractional_sample_rate(@threshold * 50, query(30, filters: [])) == 0.02
assert fractional_sample_rate(@threshold * 50, query(30, filters: [@filter])) ==
- 0.40
+ 0.08
assert fractional_sample_rate(
@threshold * 50,
query(30, filters: [@filter, @filter])
+ ) == 0.32
+
+ assert fractional_sample_rate(
+ @threshold * 50,
+ query(30, filters: [@filter, @filter, @filter])
+ ) == 0.32
+
+ assert fractional_sample_rate(
+ @threshold * 10,
+ query(30, filters: [@filter, @filter])
) == :no_sampling
end
end