Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Fix dogfooding invitation event (#4023)

hq1148413afbbf2
diff --git a/lib/plausible_web/live/register_form.ex b/lib/plausible_web/live/register_form.ex
index 619504318d..8b80fc1d7c 100644
--- a/lib/plausible_web/live/register_form.ex
+++ b/lib/plausible_web/live/register_form.ex
@@ -301,17 +301,24 @@ defmodule PlausibleWeb.Live.RegisterForm do
defp add_user(socket, user) do
case Repo.insert(user) do
{:ok, _user} ->
- metrics_params =
- if socket.assigns.invitation do
- %{
- event_name: "Signup via invitation",
- params: %{u: "/register/invitation/:invitation_id"}
- }
- else
- %{event_name: "Signup", params: %{}}
- end
-
- {:noreply, push_event(socket, "send-metrics", metrics_params)}
+ on_full_build do
+ metrics_params =
+ if socket.assigns.invitation do
+ %{
+ event_name: "Signup via invitation",
+ params: %{
+ url:
+ Path.join(PlausibleWeb.Endpoint.url(), "/register/invitation/:invitation_id")
+ }
+ }
+ else
+ %{event_name: "Signup", params: %{}}
+ end
+
+ {:noreply, push_event(socket, "send-metrics", metrics_params)}
+ else
+ {:noreply, socket}
+ end
{:error, changeset} ->
{:noreply,
diff --git a/test/plausible_web/live/register_form_test.exs b/test/plausible_web/live/register_form_test.exs
index 57d3ce8a2d..586584194c 100644
--- a/test/plausible_web/live/register_form_test.exs
+++ b/test/plausible_web/live/register_form_test.exs
@@ -63,7 +63,9 @@ defmodule PlausibleWeb.Live.RegisterFormTest do
html = lv |> element("form") |> render_submit()
- assert_push_event(lv, "send-metrics", %{event_name: "Signup", params: %{}})
+ on_full_build do
+ assert_push_event(lv, "send-metrics", %{event_name: "Signup", params: %{}})
+ end
assert [
csrf_input,
@@ -159,7 +161,9 @@ defmodule PlausibleWeb.Live.RegisterFormTest do
html = lv |> element("form") |> render_submit()
- assert_push_event(lv, "send-metrics", %{event_name: "Signup via invitation", params: %{}})
+ on_full_build do
+ assert_push_event(lv, "send-metrics", %{event_name: "Signup via invitation", params: %{}})
+ end
assert [
csrf_input,