Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Fix flaky tests in `Plausible.Auth.TOTPTest` (#4362)

Adrian Gruntkowski1da1da9421b2
diff --git a/test/plausible/auth/totp_test.exs b/test/plausible/auth/totp_test.exs
index 6c1007f64c..4b2d7bf778 100644
--- a/test/plausible/auth/totp_test.exs
+++ b/test/plausible/auth/totp_test.exs
@@ -115,8 +115,10 @@ defmodule Plausible.Auth.TOTPTest do
{:ok, user, %{recovery_codes: [recovery_code | recovery_codes]}} = TOTP.enable(user, code)
:ok = TOTP.use_recovery_code(user, recovery_code)
+ new_code = NimbleTOTP.verification_code(user.totp_secret)
+
assert {:ok, updated_user, %{recovery_codes: new_recovery_codes}} =
- TOTP.enable(user, code, allow_reuse?: true)
+ TOTP.enable(user, new_code, allow_reuse?: true)
assert updated_user.id == user.id
assert updated_user.totp_enabled
@@ -326,7 +328,7 @@ defmodule Plausible.Auth.TOTPTest do
# making sure that generated OTP codes are different
assert code != new_code
- assert {:ok, user} = TOTP.validate_code(user, code, allow_reuse?: true)
+ assert {:ok, user} = TOTP.validate_code(user, new_code, allow_reuse?: true)
assert_in_delta Timex.to_unix(user.totp_last_used_at), System.os_time(:second), 2
end