Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Add constraint enforcing at most one owner membership per site (#3403)

Adrian Gruntkowski21297b666f3b
diff --git a/priv/repo/migrations/20231010074900_add_unique_index_on_site_memberships_site_id_when_owner.exs b/priv/repo/migrations/20231010074900_add_unique_index_on_site_memberships_site_id_when_owner.exs
new file mode 100644
index 0000000000..2dc5bf2a96
--- /dev/null
+++ b/priv/repo/migrations/20231010074900_add_unique_index_on_site_memberships_site_id_when_owner.exs
@@ -0,0 +1,13 @@
+defmodule Plausible.Repo.Migrations.AddUniqueIndexOnSiteMembershipsSiteIdWhenOwner do
+ use Ecto.Migration
+
+ @disable_ddl_transaction true
+ @disable_migration_lock true
+
+ def change do
+ create_if_not_exists unique_index(:site_memberships, [:site_id],
+ where: "role = 'owner'",
+ concurrently: true
+ )
+ end
+end
diff --git a/test/plausible/site/membership_test.exs b/test/plausible/site/membership_test.exs
new file mode 100644
index 0000000000..4efc94b7c1
--- /dev/null
+++ b/test/plausible/site/membership_test.exs
@@ -0,0 +1,15 @@
+defmodule Plausible.Site.MembershipTest do
+ use Plausible.DataCase
+
+ test "raises on trying to insert two owner memberships for the same site" do
+ user1 = insert(:user)
+ user2 = insert(:user)
+ site = insert(:site)
+
+ insert(:site_membership, site: site, user: user1, role: "owner")
+
+ assert_raise Ecto.ConstraintError, ~r/site_memberships_site_id_index/, fn ->
+ insert(:site_membership, site: site, user: user2, role: "owner")
+ end
+ end
+end