Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
Ignore missing subscription on update (#2930)
Uku Taht2259651b2175
diff --git a/lib/plausible/billing/billing.ex b/lib/plausible/billing/billing.exindex f10d8fcb26..00ddfe3434 100644--- a/lib/plausible/billing/billing.ex+++ b/lib/plausible/billing/billing.ex@@ -201,11 +201,14 @@ defmodule Plausible.Billing doenddefp handle_subscription_updated(params) do- Subscription- |> Repo.get_by!(paddle_subscription_id: params["subscription_id"])- |> Subscription.changeset(format_subscription(params))- |> Repo.update!()- |> after_subscription_update()+ subscription = Repo.get_by(Subscription, paddle_subscription_id: params["subscription_id"])++ if subscription do+ subscription+ |> Subscription.changeset(format_subscription(params))+ |> Repo.update!()+ |> after_subscription_update()+ endenddefp handle_subscription_cancelled(params) dodiff --git a/test/plausible/billing/billing_test.exs b/test/plausible/billing/billing_test.exsindex c44567768b..b8401a3ad2 100644--- a/test/plausible/billing/billing_test.exs+++ b/test/plausible/billing/billing_test.exs@@ -507,6 +507,26 @@ defmodule Plausible.BillingTest doassert Repo.reload!(site).locked == trueassert Repo.reload!(user).grace_period.allowance_required == 11_000end++ test "ignores if subscription cannot be found" do+ user = insert(:user)++ res =+ Billing.subscription_updated(%{+ "alert_name" => "subscription_updated",+ "subscription_id" => "666",+ "subscription_plan_id" => "new-plan-id",+ "update_url" => "update_url.com",+ "cancel_url" => "cancel_url.com",+ "passthrough" => user.id,+ "status" => "active",+ "next_bill_date" => "2019-06-01",+ "new_unit_price" => "12.00",+ "currency" => "EUR"+ })++ assert res == {:ok, nil}+ endenddescribe "subscription_cancelled" do