Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
Respond with 400 when no auth supplied to shared link request
Adam Rutkowski2275cd8e225f
diff --git a/lib/plausible_web/controllers/stats_controller.ex b/lib/plausible_web/controllers/stats_controller.exindex 18bf1acb14..5c3ddbb485 100644--- a/lib/plausible_web/controllers/stats_controller.ex+++ b/lib/plausible_web/controllers/stats_controller.ex@@ -144,6 +144,10 @@ defmodule PlausibleWeb.StatsController doendend+ def shared_link(conn, _) do+ render_error(conn, 400)+ end+def authenticate_shared_link(conn, %{"slug" => slug, "password" => password}) doshared_link =Repo.get_by(Plausible.Site.SharedLink, slug: slug)diff --git a/test/plausible_web/controllers/stats_controller_test.exs b/test/plausible_web/controllers/stats_controller_test.exsindex 416afefa7e..54a4a18458 100644--- a/test/plausible_web/controllers/stats_controller_test.exs+++ b/test/plausible_web/controllers/stats_controller_test.exs@@ -263,6 +263,11 @@ defmodule PlausibleWeb.StatsControllerTest doassert html_response(conn, 200) =~ "Site locked"refute String.contains?(html_response(conn, 200), "Back to my sites")end++ test "renders bad request when no auth parameter supplied", %{conn: conn} do+ conn = get(conn, "/share/example.com")+ assert response(conn, 400) =~ "Bad Request"+ endenddescribe "POST /share/:slug/authenticate" do