Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Fix membership role action and checks under Site Settings > People (#4910)

Adrian Gruntkowski2938936c4c89
diff --git a/lib/plausible_web/templates/site/settings_people.html.heex b/lib/plausible_web/templates/site/settings_people.html.heex
index b72d6b56f3..516e9cd6c5 100644
--- a/lib/plausible_web/templates/site/settings_people.html.heex
+++ b/lib/plausible_web/templates/site/settings_people.html.heex
@@ -127,7 +127,7 @@
:update_role_by_user,
@site.domain,
membership.user.id,
- "admin"
+ "editor"
)
}
method="put"
@@ -142,7 +142,7 @@
</p>
</div>
- <%= if membership.role == :admin do %>
+ <%= if membership.role == "admin" do %>
<span class="text-indigo-500 group-hover:text-white">
<svg
class="h-5 w-5"
@@ -182,7 +182,7 @@
</p>
</div>
- <%= if membership.role == :viewer do %>
+ <%= if membership.role == "viewer" do %>
<span class="text-indigo-500 group-hover:text-white">
<svg
class="h-5 w-5"
diff --git a/test/plausible_web/controllers/site/membership_controller_test.exs b/test/plausible_web/controllers/site/membership_controller_test.exs
index 2a0c95ac1b..e4a7df5801 100644
--- a/test/plausible_web/controllers/site/membership_controller_test.exs
+++ b/test/plausible_web/controllers/site/membership_controller_test.exs
@@ -68,7 +68,7 @@ defmodule PlausibleWeb.Site.MembershipControllerTest do
conn =
post(conn, "/sites/#{site.domain}/memberships/invite", %{
- role: "admin"
+ role: "editor"
})
assert html_response(conn, 200) =~
@@ -82,7 +82,7 @@ defmodule PlausibleWeb.Site.MembershipControllerTest do
conn =
post(conn, "/sites/#{site.domain}/memberships/invite", %{
- role: "admin"
+ role: "editor"
})
assert conn.status == 404
@@ -164,7 +164,7 @@ defmodule PlausibleWeb.Site.MembershipControllerTest do
conn =
post(conn, "/sites/#{site.domain}/memberships/invite", %{
email: second_member.email,
- role: "admin"
+ role: "editor"
})
assert html_response(conn, 200) =~