Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
Don't read/write active_visitors from GA4 (#5178)
Karl-Aksel Puulmann2f27ce02beaf
diff --git a/lib/plausible/imported/google_analytics4.ex b/lib/plausible/imported/google_analytics4.exindex cc03cda51b..ab98384792 100644--- a/lib/plausible/imported/google_analytics4.ex+++ b/lib/plausible/imported/google_analytics4.ex@@ -200,7 +200,6 @@ defmodule Plausible.Imported.GoogleAnalytics4 dohostname: row.dimensions |> Map.fetch!("hostName") |> String.replace_prefix("www.", ""),page: row.dimensions |> Map.fetch!("pagePath") |> URI.parse() |> Map.get(:path),visitors: row.metrics |> Map.fetch!("totalUsers") |> parse_number(),- active_visitors: row.metrics |> Map.fetch!("activeUsers") |> parse_number(),visits: row.metrics |> Map.fetch!("sessions") |> parse_number(),pageviews: row.metrics |> Map.fetch!("screenPageViews") |> parse_number(),# NOTE: no exits metric in GA4 API currentlydiff --git a/lib/plausible/imported/page.ex b/lib/plausible/imported/page.exindex bc4a9edba7..3b854ec104 100644--- a/lib/plausible/imported/page.ex+++ b/lib/plausible/imported/page.ex@@ -11,7 +11,6 @@ defmodule Plausible.Imported.Page dofield :page, :stringfield :visits, Ch, type: "UInt64"field :visitors, Ch, type: "UInt64"- field :active_visitors, Ch, type: "UInt64"field :pageviews, Ch, type: "UInt64"field :exits, Ch, type: "UInt64"field :total_scroll_depth, Ch, type: "UInt64"diff --git a/test/plausible/imported/google_analytics4_test.exs b/test/plausible/imported/google_analytics4_test.exsindex 11317f7fcb..fbb49ae9f6 100644--- a/test/plausible/imported/google_analytics4_test.exs+++ b/test/plausible/imported/google_analytics4_test.exs@@ -6,7 +6,6 @@ defmodule Plausible.Imported.GoogleAnalytics4Test doimport Ecto.Query, only: [from: 2]import ExUnit.CaptureLog- alias Plausible.ClickhouseRepoalias Plausible.Repoalias Plausible.Imported.GoogleAnalytics4@@ -150,9 +149,6 @@ defmodule Plausible.Imported.GoogleAnalytics4Test doassert_browsers(conn, breakdown_params)assert_os(conn, breakdown_params)assert_os_versions(conn, breakdown_params)-- # Misc- assert_active_visitors(site_import)endtest "handles empty response payload gracefully", %{user: user, site: site} do@@ -463,34 +459,6 @@ defmodule Plausible.Imported.GoogleAnalytics4Test doendend- defp assert_active_visitors(site_import) do- result =- ClickhouseRepo.query!(- "SELECT date, sum(visitors) AS all_visitors, sum(active_visitors) AS all_active_visitors " <>- "FROM imported_pages WHERE site_id = #{site_import.site_id} AND import_id = #{site_import.id} GROUP BY date"- )- |> Map.fetch!(:rows)- |> Enum.map(fn [date, all_visitors, all_active_visitors] ->- %{date: date, visitors: all_visitors, active_visitors: all_active_visitors}- end)-- assert length(result) == 31-- Enum.each(result, fn row ->- assert row.visitors > 100 and row.active_visitors > 100- assert row.active_visitors <= row.visitors- end)-- ClickhouseRepo.query!(- "SELECT time_on_page FROM imported_pages WHERE active_visitors = 0 AND " <>- "site_id = #{site_import.site_id} AND import_id = #{site_import.id}"- )- |> Map.fetch!(:rows)- |> Enum.each(fn [time_on_page] ->- assert time_on_page == 0- end)- end-defp assert_custom_events(conn, params) doparams =params