Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Filter for pageviews when no other filter is specified in base.ex

Uku Taht2f98da8f3a4a
diff --git a/lib/plausible/stats/base.ex b/lib/plausible/stats/base.ex
index da502bcf1c..bdffa2fb0c 100644
--- a/lib/plausible/stats/base.ex
+++ b/lib/plausible/stats/base.ex
@@ -56,9 +56,17 @@ defmodule Plausible.Stats.Base do
q =
case query.filters["event:name"] do
- {:is, name} -> from(e in q, where: e.name == ^name)
- {:member, list} -> from(e in q, where: e.name in ^list)
- nil -> q
+ {:is, name} ->
+ from(e in q, where: e.name == ^name)
+
+ {:member, list} ->
+ from(e in q, where: e.name in ^list)
+
+ # Logically, this isn't necessary and might even cause some confusion (request with no filters will still filter for event:name==pageviews).
+ nil ->
+ from(e in q, where: e.name == "pageview")
+
+ # When removing this, however, sampling in clickhouse goes a bit weird (dashboard with 3m pageviews will start getting sampled which is weird)
end
q =