Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Expose goal contains filter in dashboard (#4412)

Uku Taht2f9ca72fd6ef
diff --git a/CHANGELOG.md b/CHANGELOG.md
index c109658bb6..a9624680ef 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file.
## Unreleased
### Added
+- Support contains filter for goals
- UI to edit funnels
- Add a search functionality in all Details views, except for Countries, Regions, and Cities
- Icons for browsers plausible/analytics#4239
diff --git a/assets/js/dashboard/components/filter-operator-selector.js b/assets/js/dashboard/components/filter-operator-selector.js
index 5086e6abf6..1af025b0a7 100644
--- a/assets/js/dashboard/components/filter-operator-selector.js
+++ b/assets/js/dashboard/components/filter-operator-selector.js
@@ -64,7 +64,7 @@ export default function FilterOperatorSelector(props) {
{renderTypeItem(FILTER_OPERATIONS.is, true)}
{renderTypeItem(FILTER_OPERATIONS.isNot, supportsIsNot(filterName))}
{renderTypeItem(FILTER_OPERATIONS.contains, isFreeChoiceFilter(filterName))}
- {renderTypeItem(FILTER_OPERATIONS.does_not_contain, isFreeChoiceFilter(filterName))}
+ {renderTypeItem(FILTER_OPERATIONS.does_not_contain, isFreeChoiceFilter(filterName) && supportsIsNot(filterName))}
</div>
</Menu.Items>
</Transition>
diff --git a/assets/js/dashboard/util/filters.js b/assets/js/dashboard/util/filters.js
index f99e4a2243..6c5fc6f0c5 100644
--- a/assets/js/dashboard/util/filters.js
+++ b/assets/js/dashboard/util/filters.js
@@ -20,7 +20,7 @@ export const FILTER_GROUP_TO_MODAL_TYPE = Object.fromEntries(
.flatMap(([modalName, filterGroups]) => filterGroups.map((filterGroup) => [filterGroup, modalName]))
)
-export const NO_CONTAINS_OPERATOR = new Set(['goal', 'screen'].concat(FILTER_MODAL_TO_FILTER_GROUP['location']))
+export const NO_CONTAINS_OPERATOR = new Set(['screen'].concat(FILTER_MODAL_TO_FILTER_GROUP['location']))
export const EVENT_PROPS_PREFIX = "props:"