Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Temporarily disable combobox spinner (#4971)

Artur Pata3abf974a5605
diff --git a/lib/plausible_web/live/components/combo_box.ex b/lib/plausible_web/live/components/combo_box.ex
index 6b6695375d..69fec5114f 100644
--- a/lib/plausible_web/live/components/combo_box.ex
+++ b/lib/plausible_web/live/components/combo_box.ex
@@ -245,7 +245,7 @@ defmodule PlausibleWeb.Live.Components.ComboBox do
>
<a
x-ref={"dropdown-#{@ref}-option-#{@idx}"}
- x-on:click={not @creatable && "selectionInProgress = true"}
+ x-on:click={not @creatable && "selectionInProgress = false"}
phx-click={select_option(@ref, @submit_value, @display_value)}
phx-value-submit-value={@submit_value}
phx-value-display-value={@display_value}
diff --git a/test/plausible_web/live/components/combo_box_test.exs b/test/plausible_web/live/components/combo_box_test.exs
index d54872b69b..cb6f18423d 100644
--- a/test/plausible_web/live/components/combo_box_test.exs
+++ b/test/plausible_web/live/components/combo_box_test.exs
@@ -303,7 +303,7 @@ defmodule PlausibleWeb.Live.Components.ComboBoxTest do
{:ok, lv, html} = live_isolated(conn, CreatableView, session: %{})
regular_option = find(html, "li#dropdown-test-creatable-component-option-1 a")
- assert Floki.attribute(regular_option, "x-on:click") == ["selectionInProgress = true"]
+ assert Floki.attribute(regular_option, "x-on:click") == ["selectionInProgress = false"]
creatable_option =
lv