Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

add proper escaping (#6386)

Cenk Kücük3e4bf8a3c67d
diff --git a/lib/plausible_web/live/goal_settings/form.ex b/lib/plausible_web/live/goal_settings/form.ex
index d25c678e09..3d521537df 100644
--- a/lib/plausible_web/live/goal_settings/form.ex
+++ b/lib/plausible_web/live/goal_settings/form.ex
@@ -330,14 +330,14 @@ defmodule PlausibleWeb.Live.GoalSettings.Form do
}
"""
else
- """
- {
- scrollThreshold: '#{assigns.goal.scroll_threshold}',
- pagePath: '#{assigns.goal.page_path}',
- displayName: '#{assigns.goal.display_name}',
- updateDisplayName() {}
- }
- """
+ data =
+ Jason.encode!(%{
+ scrollThreshold: to_string(assigns.goal.scroll_threshold),
+ pagePath: assigns.goal.page_path,
+ displayName: assigns.goal.display_name
+ })
+
+ "{...#{data}, updateDisplayName() {}}"
end
assigns = assign(assigns, :js, js)