Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
Fix favicon HTTP response handling
Uku Taht57c758cff9e4
diff --git a/lib/plausible_web/plugs/favicon.ex b/lib/plausible_web/plugs/favicon.exindex 72fc27594a..0368cb7654 100644--- a/lib/plausible_web/plugs/favicon.ex+++ b/lib/plausible_web/plugs/favicon.ex@@ -20,19 +20,27 @@ defmodule PlausibleWeb.Favicon do["favicon", "sources", source] ->clean_source = URI.decode_www_form(source)domain = Map.get(favicon_domains, clean_source, clean_source)- res = HTTPClient.get("https://icons.duckduckgo.com/ip3/#{domain}.ico")- conn =- Enum.filter(res.headers, fn {key, _val} -> key != "Transfer-Encoding" end)- |> Enum.reduce(conn, fn {key, val}, conn ->- put_resp_header(conn, key, val)- end)+ case HTTPClient.get("https://icons.duckduckgo.com/ip3/#{domain}") do+ {:ok, res} ->+ send_response(conn, res)- send_resp(conn, 200, res.body)- |> halt+ e ->+ send_resp(conn, 503, "") |> halt+ end_ ->connendend++ defp send_response(conn, res) do+ conn =+ Enum.filter(res.headers, fn {key, _val} -> key != "Transfer-Encoding" end)+ |> Enum.reduce(conn, fn {key, val}, conn ->+ put_resp_header(conn, key, val)+ end)++ send_resp(conn, 200, res.body) |> halt+ endend