Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Fix bounce_rate metric causing 500s with comparisons (#4723)

Karl-Aksel Puulmann7794ff141742
diff --git a/lib/plausible/stats/filters/filters.ex b/lib/plausible/stats/filters/filters.ex
index 9e911ae20b..e93aac75a2 100644
--- a/lib/plausible/stats/filters/filters.ex
+++ b/lib/plausible/stats/filters/filters.ex
@@ -115,7 +115,7 @@ defmodule Plausible.Stats.Filters do
"""
def get_toplevel_filter(query, prefix) do
Enum.find(query.filters, fn [_op, dimension | _rest] ->
- String.starts_with?(dimension, prefix)
+ is_binary(dimension) and String.starts_with?(dimension, prefix)
end)
end
diff --git a/test/plausible_web/controllers/api/stats_controller/sources_test.exs b/test/plausible_web/controllers/api/stats_controller/sources_test.exs
index ddf8cb4d28..3071962eb6 100644
--- a/test/plausible_web/controllers/api/stats_controller/sources_test.exs
+++ b/test/plausible_web/controllers/api/stats_controller/sources_test.exs
@@ -606,6 +606,64 @@ defmodule PlausibleWeb.Api.StatsController.SourcesTest do
%{"name" => "Z", "visitors" => 1, "bounce_rate" => 100, "visit_duration" => 0}
]
end
+
+ test "can compare with previous period", %{conn: conn, site: site} do
+ populate_stats(site, [
+ build(:pageview,
+ referrer_source: "DuckDuckGo",
+ referrer: "duckduckgo.com",
+ timestamp: ~N[2021-01-01 00:00:00]
+ ),
+ build(:pageview,
+ referrer_source: "DuckDuckGo",
+ referrer: "duckduckgo.com",
+ timestamp: ~N[2021-01-02 00:00:00]
+ ),
+ build(:pageview,
+ referrer_source: "Google",
+ referrer: "google.com",
+ timestamp: ~N[2021-01-02 00:00:00]
+ ),
+ build(:pageview,
+ referrer_source: "Google",
+ referrer: "google.com",
+ timestamp: ~N[2021-01-02 00:00:00]
+ )
+ ])
+
+ conn =
+ get(
+ conn,
+ "/api/stats/#{site.domain}/sources?period=day&date=2021-01-02&comparison=previous_period&detailed=true"
+ )
+
+ assert json_response(conn, 200)["results"] == [
+ %{
+ "name" => "Google",
+ "visitors" => 2,
+ "bounce_rate" => 100,
+ "visit_duration" => 0,
+ "comparison" => %{
+ "visitors" => 0,
+ "bounce_rate" => 0,
+ "visit_duration" => 0,
+ "change" => %{"visitors" => 100, "bounce_rate" => nil, "visit_duration" => 0}
+ }
+ },
+ %{
+ "name" => "DuckDuckGo",
+ "visitors" => 1,
+ "bounce_rate" => 100,
+ "visit_duration" => 0,
+ "comparison" => %{
+ "visitors" => 1,
+ "bounce_rate" => 100,
+ "visit_duration" => 0,
+ "change" => %{"visitors" => 0, "bounce_rate" => 0, "visit_duration" => 0}
+ }
+ }
+ ]
+ end
end
describe "UTM parameters with hostname filter" do