Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.
TypeScript analyticsanalytics-dashboardclickhouseelixirgoogle-analyticsmarketingopen-source-analyticsphoenixplausible-analyticspostgresqlprivacyprivacy-friendlyself-hostedsimple-analyticsstatisticstailwindcssweb-analyticswebsite-analyticswebsite-statswebsite-tracking
Verification: prioritize domain mismatch over multiple snippets (#4146)
hq178c5762761c5
diff --git a/lib/plausible/verification/diagnostics.ex b/lib/plausible/verification/diagnostics.exindex 907d501ff1..dc5477af40 100644--- a/lib/plausible/verification/diagnostics.ex+++ b/lib/plausible/verification/diagnostics.ex@@ -187,6 +187,10 @@ defmodule Plausible.Verification.Diagnostics doerror(@errors.proxy_general)end+ def interpret(%__MODULE__{data_domain_mismatch?: true}, "https://" <> domain) do+ error(@errors.different_data_domain, domain: domain)+ end+def interpret(%__MODULE__{snippets_found_in_head: count_head, snippets_found_in_body: count_body},_url@@ -238,10 +242,6 @@ defmodule Plausible.Verification.Diagnostics doerror(@errors.snippet_in_body)end- def interpret(%__MODULE__{data_domain_mismatch?: true}, "https://" <> domain) do- error(@errors.different_data_domain, domain: domain)- end-def interpret(%__MODULE__{plausible_installed?: false,diff --git a/test/plausible/site/verification/checks_test.exs b/test/plausible/site/verification/checks_test.exsindex 3838b9860c..014395289b 100644--- a/test/plausible/site/verification/checks_test.exs+++ b/test/plausible/site/verification/checks_test.exs@@ -671,6 +671,27 @@ defmodule Plausible.Verification.ChecksTest doassert_receive :redirect_sentend++ @many_snippets_with_domain_mismatch """+ <html>+ <head>+ <script defer data-domain="example.org" src="https://plausible.io/js/script.js"></script>+ <script defer data-domain="example.org" src="https://plausible.io/js/script.js"></script>+ </head>+ <body>+ Hello+ </body>+ </html>+ """++ test "prioritizes data-domain mismatch over multiple snippets" do+ stub_fetch_body(200, @many_snippets_with_domain_mismatch)+ stub_installation()++ run_checks()+ |> Checks.interpret_diagnostics()+ |> assert_error(@errors.different_data_domain, domain: "example.com")+ endenddefp run_checks(extra_opts \\ []) do