Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

UI fix for multi-line pill text underline issues (#1499)

Ru Singh7da138e99e6b
diff --git a/CHANGELOG.md b/CHANGELOG.md
index c520730193..430ad695dc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,9 @@ All notable changes to this project will be documented in this file.
- Region and city-level geolocation plausible/analytics#1449
- The `u` option can now be used in the `manual` extension to specify a URL when triggering events.
+### Fixed
+- UI fix where multi-line text in pills would not be underlined properly on small screens.
+
## v1.4.1
### Fixed
diff --git a/assets/css/app.css b/assets/css/app.css
index a3ac26981a..708b842eb9 100644
--- a/assets/css/app.css
+++ b/assets/css/app.css
@@ -322,3 +322,17 @@ iframe[hidden] {
left: 0 !important;
}
}
+
+.active-prop-heading {
+ /* Properties related to text-decoration are all here in one place. TailwindCSS does support underline but that's about it. */
+ text-decoration-line: underline;
+ text-decoration-color: #4338CA; /* tailwind's indigo-700 */
+ text-decoration-thickness: 2px;
+}
+
+@media (prefers-color-scheme: dark) {
+ .active-prop-heading {
+ text-decoration-color: #6366F1; /* tailwind's indigo-500 */
+ }
+
+}
\ No newline at end of file
diff --git a/assets/js/dashboard/stats/conversions/prop-breakdown.js b/assets/js/dashboard/stats/conversions/prop-breakdown.js
index b9e03f0588..50fe54455b 100644
--- a/assets/js/dashboard/stats/conversions/prop-breakdown.js
+++ b/assets/js/dashboard/stats/conversions/prop-breakdown.js
@@ -168,7 +168,7 @@ export default class PropertyBreakdown extends React.Component {
const isActive = this.state.propKey === key
if (isActive) {
- return <li key={key} className="inline-block h-5 text-indigo-700 dark:text-indigo-500 font-bold border-b-2 border-indigo-700 dark:border-indigo-500 mr-2">{key}</li>
+ return <li key={key} className="inline-block h-5 text-indigo-700 dark:text-indigo-500 font-bold mr-2 active-prop-heading">{key}</li>
} else {
return <li key={key} className="hover:text-indigo-600 cursor-pointer mr-2" onClick={this.changePropKey.bind(this, key)}>{key}</li>
}
diff --git a/assets/js/dashboard/stats/devices/index.js b/assets/js/dashboard/stats/devices/index.js
index f7a3253af5..1e5ce88f2e 100644
--- a/assets/js/dashboard/stats/devices/index.js
+++ b/assets/js/dashboard/stats/devices/index.js
@@ -161,7 +161,7 @@ export default class Devices extends React.Component {
if (isActive) {
return (
<li
- className="inline-block h-5 font-bold text-indigo-700 border-b-2 border-indigo-700 dark:text-indigo-500 dark:border-indigo-500"
+ className="inline-block h-5 font-bold text-indigo-700 active-prop-heading dark:text-indigo-500"
>
{name}
</li>
diff --git a/assets/js/dashboard/stats/locations/index.js b/assets/js/dashboard/stats/locations/index.js
index c9b15bd6d1..762d9de081 100644
--- a/assets/js/dashboard/stats/locations/index.js
+++ b/assets/js/dashboard/stats/locations/index.js
@@ -104,7 +104,7 @@ export default class Locations extends React.Component {
if (isActive) {
return (
<li
- className="inline-block h-5 text-indigo-700 dark:text-indigo-500 font-bold border-b-2 border-indigo-700 dark:border-indigo-500"
+ className="inline-block h-5 text-indigo-700 dark:text-indigo-500 font-bold active-prop-heading"
>
{name}
</li>
diff --git a/assets/js/dashboard/stats/pages/index.js b/assets/js/dashboard/stats/pages/index.js
index fb6b45ccf0..990a4767c3 100644
--- a/assets/js/dashboard/stats/pages/index.js
+++ b/assets/js/dashboard/stats/pages/index.js
@@ -47,7 +47,7 @@ export default class Pages extends React.Component {
if (isActive) {
return (
<li
- className="inline-block h-5 text-indigo-700 dark:text-indigo-500 font-bold border-b-2 border-indigo-700 dark:border-indigo-500"
+ className="inline-block h-5 text-indigo-700 dark:text-indigo-500 font-bold active-prop-heading"
>
{name}
</li>
diff --git a/assets/js/dashboard/stats/sources/source-list.js b/assets/js/dashboard/stats/sources/source-list.js
index 3c89dbde0b..9c6f3668b6 100644
--- a/assets/js/dashboard/stats/sources/source-list.js
+++ b/assets/js/dashboard/stats/sources/source-list.js
@@ -284,7 +284,7 @@ export default class SourceList extends React.Component {
}
renderTabs() {
- const activeClass = 'inline-block h-5 text-indigo-700 dark:text-indigo-500 font-bold border-b-2 border-indigo-700 dark:border-indigo-500'
+ const activeClass = 'inline-block h-5 text-indigo-700 dark:text-indigo-500 font-bold active-prop-heading'
const defaultClass = 'hover:text-indigo-600 cursor-pointer'
return (
<ul className="flex text-xs font-medium text-gray-500 dark:text-gray-400 space-x-2">