Skip to content

Open source, privacy-first web analytics. Lightweight, cookie-free Google Analytics alternative. Self-hosted or cloud.

Fix regression in shared link settings form (#5862)

Sanne de Vries7de8526b6a7f
diff --git a/lib/plausible_web/live/components/form.ex b/lib/plausible_web/live/components/form.ex
index 314937fe6c..04d463ac22 100644
--- a/lib/plausible_web/live/components/form.ex
+++ b/lib/plausible_web/live/components/form.ex
@@ -75,7 +75,7 @@ defmodule PlausibleWeb.Live.Components.Form do
def input(%{type: "select"} = assigns) do
~H"""
<div class={@mt? && "mt-4"}>
- <.label for={@id} class="mb-1.5">{@label}</.label>
+ <.label for={@id} class={if @help_text, do: "mb-0.5", else: "mb-1.5"}>{@label}</.label>
<p :if={@help_text} class="text-gray-500 dark:text-gray-400 mb-2 text-sm">
{@help_text}
@@ -177,7 +177,11 @@ defmodule PlausibleWeb.Live.Components.Form do
~H"""
<div class={@mt? && "mt-4"}>
- <.label :if={@label != nil and @label != ""} for={@id} class="mb-1.5">
+ <.label
+ :if={@label != nil and @label != ""}
+ for={@id}
+ class={if @help_text, do: "mb-0.5", else: "mb-1.5"}
+ >
{@label}
</.label>
<p :if={@help_text} class="text-gray-500 dark:text-gray-400 mb-2 text-sm">
diff --git a/lib/plausible_web/live/shared_link_settings/form.ex b/lib/plausible_web/live/shared_link_settings/form.ex
index 40a0e2b5b7..e4ff0effc5 100644
--- a/lib/plausible_web/live/shared_link_settings/form.ex
+++ b/lib/plausible_web/live/shared_link_settings/form.ex
@@ -58,10 +58,10 @@ defmodule PlausibleWeb.Live.SharedLinkSettings.Form do
<.input
field={f[:password]}
label="Password (optional)"
+ help_text="Store the password securely, as it can't be viewed again."
type="password"
autocomplete="new-password"
/>
-
<.button type="submit" class="w-full">
Create shared link
</.button>